From: Laurent Monin <zas@norz.org>
Date: Thu, 30 Aug 2012 16:10:47 +0000 (+0200)
Subject: Clear few more warnings, unused variables mostly.
X-Git-Tag: v1.2~25
X-Git-Url: http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commitdiff_plain;h=8de6122502695be2f4247e0d258e72f1b877cc6b

Clear few more warnings, unused variables mostly.
---

diff --git a/src/collect-io.c b/src/collect-io.c
index a8d9a7f3..0c26ec40 100644
--- a/src/collect-io.c
+++ b/src/collect-io.c
@@ -784,12 +784,11 @@ static void collect_manager_process_actions(gint max)
 static gboolean collect_manager_process_entry(CollectManagerEntry *entry)
 {
 	CollectionData *cd;
-	gboolean success;
 
 	if (entry->empty) return FALSE;
 
 	cd = collection_new(entry->path);
-	success = collection_load_private(cd, entry->path, COLLECTION_LOAD_NONE);
+	(void) collection_load_private(cd, entry->path, COLLECTION_LOAD_NONE);
 
 	collection_unref(cd);
 
diff --git a/src/metadata.c b/src/metadata.c
index b91a4bb3..2e92c22f 100644
--- a/src/metadata.c
+++ b/src/metadata.c
@@ -1592,70 +1592,70 @@ static GtkTreeIter keyword_tree_default_append(GtkTreeStore *keyword_tree, GtkTr
 
 void keyword_tree_new_default(void)
 {
-	GtkTreeIter i1, i2, i3;
+	GtkTreeIter i1, i2;
 
 	if (!keyword_tree) keyword_tree_new();
 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("People"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Family"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Free time"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Children"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Sport"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Culture"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Festival"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Nature"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Animal"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Bird"), TRUE); 
- 			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Insect"), TRUE); 
- 			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Pets"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Wildlife"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Zoo"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Plant"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Tree"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Flower"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Water"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("River"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Lake"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Sea"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Landscape"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Art"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Statue"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Painting"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Historic"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Modern"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("City"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Park"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Street"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Square"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Architecture"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Buildings"), FALSE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("House"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Cathedral"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Palace"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Castle"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Bridge"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Interior"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Historic"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Modern"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Places"), FALSE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Conditions"), FALSE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Night"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Lights"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Reflections"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Sun"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Weather"), FALSE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Fog"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Rain"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Clouds"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Snow"), TRUE); 
-			i3 = keyword_tree_default_append(keyword_tree, &i2, _("Sunny weather"), TRUE); 
-	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Photo"), FALSE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Edited"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Detail"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Macro"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Portrait"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Black and White"), TRUE); 
-		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Perspective"), TRUE); 
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("People"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Family"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Free time"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Children"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Sport"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Culture"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Festival"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Nature"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Animal"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Bird"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Insect"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Pets"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Wildlife"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Zoo"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Plant"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Tree"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Flower"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Water"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("River"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Lake"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Sea"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Landscape"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Art"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Statue"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Painting"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Historic"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Modern"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("City"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Park"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Street"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Square"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Architecture"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Buildings"), FALSE);
+			keyword_tree_default_append(keyword_tree, &i2, _("House"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Cathedral"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Palace"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Castle"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Bridge"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Interior"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Historic"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Modern"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Places"), FALSE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Conditions"), FALSE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Night"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Lights"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Reflections"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Sun"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Weather"), FALSE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Fog"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Rain"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Clouds"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Snow"), TRUE);
+			keyword_tree_default_append(keyword_tree, &i2, _("Sunny weather"), TRUE);
+	i1 = keyword_tree_default_append(keyword_tree, NULL, _("Photo"), FALSE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Edited"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Detail"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Macro"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Portrait"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Black and White"), TRUE);
+		i2 = keyword_tree_default_append(keyword_tree, &i1, _("Perspective"), TRUE);
 }
 
 
diff --git a/src/pixbuf-renderer.c b/src/pixbuf-renderer.c
index 9ec84acc..addc1cf5 100644
--- a/src/pixbuf-renderer.c
+++ b/src/pixbuf-renderer.c
@@ -1691,8 +1691,6 @@ static void pr_zoom_sync(PixbufRenderer *pr, gdouble zoom,
 {
 	gdouble old_scale;
 	gint old_cx, old_cy;
-	gboolean clamped;
-	gboolean sized;
 	gboolean center_point = !!(flags & PR_ZOOM_CENTER);
 	gboolean force = !!(flags & PR_ZOOM_FORCE);
 	gboolean new = !!(flags & PR_ZOOM_NEW);
@@ -1700,7 +1698,7 @@ static void pr_zoom_sync(PixbufRenderer *pr, gdouble zoom,
 	PrZoomFlags clamp_flags = flags;
 	gdouble old_center_x = pr->norm_center_x;
 	gdouble old_center_y = pr->norm_center_y;
-	
+
 	old_scale = pr->scale;
 	if (center_point)
 		{
@@ -1719,8 +1717,8 @@ static void pr_zoom_sync(PixbufRenderer *pr, gdouble zoom,
 	if (force) clamp_flags |= PR_ZOOM_INVALIDATE;
 	if (!pr_zoom_clamp(pr, zoom, clamp_flags)) return;
 
-	clamped = pr_size_clamp(pr);
-	sized = pr_parent_window_resize(pr, pr->width, pr->height);
+	(void) pr_size_clamp(pr);
+	(void) pr_parent_window_resize(pr, pr->width, pr->height);
 
 	if (force && new)
 		{
diff --git a/src/preferences.c b/src/preferences.c
index 5cb113ab..027abe05 100644
--- a/src/preferences.c
+++ b/src/preferences.c
@@ -552,7 +552,7 @@ static void stereo_mode_menu_cb(GtkWidget *combo, gpointer data)
 }
 
 static void add_stereo_mode_menu(GtkWidget *table, gint column, gint row, const gchar *text,
-			     guint option, guint *option_c, gboolean add_fixed)
+			     gint option, gint *option_c, gboolean add_fixed)
 {
 	GtkWidget *combo;
 	gint current = 0;
diff --git a/src/renderer-tiles.c b/src/renderer-tiles.c
index eda06846..6d74becd 100644
--- a/src/renderer-tiles.c
+++ b/src/renderer-tiles.c
@@ -581,11 +581,8 @@ static void rt_overlay_draw(RendererTiles *rt, gint x, gint y, gint w, gint h,
 			    ImageTile *it)
 {
 	PixbufRenderer *pr = rt->pr;
-	GtkWidget *box;
 	GList *work;
 
-	box = GTK_WIDGET(pr);
-
 	work = rt->overlay_list;
 	while (work)
 		{
@@ -998,14 +995,13 @@ static void rt_tile_mirror_and_flip(RendererTiles *rt, GdkPixbuf **tile, gint x,
 	gint srs, drs;
 	guchar *s_pix, *d_pix;
 	guchar *sp, *dp;
-	guchar *spi, *dpi;
+	guchar *dpi;
 	gint i, j;
 	gint tw = rt->tile_width;
 	gint th = rt->tile_height;
 
 	srs = gdk_pixbuf_get_rowstride(src);
 	s_pix = gdk_pixbuf_get_pixels(src);
-	spi = s_pix + (x * COLOR_BYTES);
 
 	dest = rt_get_spare_tile(rt);
 	drs = gdk_pixbuf_get_rowstride(dest);
@@ -1119,13 +1115,10 @@ static gboolean rt_source_tile_render(RendererTiles *rt, ImageTile *it,
 				      gboolean new_data, gboolean fast)
 {
 	PixbufRenderer *pr = rt->pr;
-	GtkWidget *box;
 	GList *list;
 	GList *work;
 	gboolean draw = FALSE;
 
-	box = GTK_WIDGET(pr);
-
 	if (pr->zoom == 1.0 || pr->scale == 1.0)
 		{
 		list = pr_source_tile_compute_region(pr, it->x + x, it->y + y, w, h, TRUE);
@@ -1295,7 +1288,6 @@ static void rt_tile_render(RendererTiles *rt, ImageTile *it,
 			   gboolean new_data, gboolean fast)
 {
 	PixbufRenderer *pr = rt->pr;
-	GtkWidget *box;
 	gboolean has_alpha;
 	gboolean draw = FALSE;
 	gint orientation = rt_get_orientation(rt);
@@ -1323,8 +1315,6 @@ static void rt_tile_render(RendererTiles *rt, ImageTile *it,
 	rt_tile_prepare(rt, it);
 	has_alpha = (pr->pixbuf && gdk_pixbuf_get_has_alpha(pr->pixbuf));
 
-	box = GTK_WIDGET(pr);
-
 	/* FIXME checker colors for alpha should be configurable,
 	 * also should be drawn for blank = TRUE
 	 */
diff --git a/src/utilops.c b/src/utilops.c
index de1a6c63..6c84f9b8 100644
--- a/src/utilops.c
+++ b/src/utilops.c
@@ -773,10 +773,9 @@ static void file_util_perform_ci_dir(UtilityData *ud, gboolean internal, gboolea
 			if (fail)
 				{
 				gchar *text;
-				GenericDialog *gd;
 
 				text = g_strdup_printf("%s:\n\n%s", ud->messages.fail, ud->dir_fd->path);
-				gd = file_util_warning_dialog(ud->messages.fail, text, GTK_STOCK_DIALOG_ERROR, NULL);
+				(void) file_util_warning_dialog(ud->messages.fail, text, GTK_STOCK_DIALOG_ERROR, NULL);
 				g_free(text);
 
 				file_data_unref(fail);
@@ -793,10 +792,9 @@ static void file_util_perform_ci_dir(UtilityData *ud, gboolean internal, gboolea
 			else
 				{
 				gchar *text;
-				GenericDialog *gd;
 
 				text = g_strdup_printf("%s:\n\n%s", ud->messages.fail, ud->dir_fd->path);
-				gd = file_util_warning_dialog(ud->messages.fail, text, GTK_STOCK_DIALOG_ERROR, NULL);
+				(void) file_util_warning_dialog(ud->messages.fail, text, GTK_STOCK_DIALOG_ERROR, NULL);
 				g_free(text);
 				}
 			
diff --git a/src/view_dir.c b/src/view_dir.c
index 53e49812..1cdef938 100644
--- a/src/view_dir.c
+++ b/src/view_dir.c
@@ -604,7 +604,6 @@ static void vd_pop_menu_rename_cb(GtkWidget *widget, gpointer data)
 GtkWidget *vd_pop_menu(ViewDir *vd, FileData *fd)
 {
 	GtkWidget *menu;
-	GtkWidget *item;
 	gboolean active;
 	gboolean rename_delete_active = FALSE;
 	gboolean new_folder_active = FALSE;
@@ -674,11 +673,11 @@ GtkWidget *vd_pop_menu(ViewDir *vd, FileData *fd)
 	menu_item_add_divider(menu);
 
 
-	item = menu_item_add_radio(menu, _("View as _List"), GINT_TO_POINTER(DIRVIEW_LIST), vd->type == DIRVIEW_LIST,
-                                           G_CALLBACK(vd_pop_submenu_dir_view_as_cb), vd);
+	menu_item_add_radio(menu, _("View as _List"), GINT_TO_POINTER(DIRVIEW_LIST), vd->type == DIRVIEW_LIST,
+                        G_CALLBACK(vd_pop_submenu_dir_view_as_cb), vd);
 
-	item = menu_item_add_radio(menu, _("View as _Tree"), GINT_TO_POINTER(DIRVIEW_TREE), vd->type == DIRVIEW_TREE,
-                                           G_CALLBACK(vd_pop_submenu_dir_view_as_cb), vd);
+	menu_item_add_radio(menu, _("View as _Tree"), GINT_TO_POINTER(DIRVIEW_TREE), vd->type == DIRVIEW_TREE,
+                        G_CALLBACK(vd_pop_submenu_dir_view_as_cb), vd);
 
 	menu_item_add_divider(menu);
 
diff --git a/src/view_file_icon.c b/src/view_file_icon.c
index 8cfd4616..d4226e73 100644
--- a/src/view_file_icon.c
+++ b/src/view_file_icon.c
@@ -531,7 +531,7 @@ static void vficon_drag_data_received(GtkWidget *entry_widget, GdkDragContext *c
 		if (id && id->fd) {
 			/* Add keywords to file */
 			FileData *fd = id->fd;
-			gchar *str = gtk_selection_data_get_text(selection);
+			gchar *str = (gchar *) gtk_selection_data_get_text(selection);
 			GList *kw_list = string_to_keywords_list(str);
 			
 			metadata_append_list(fd, KEYWORD_KEY, kw_list);
diff --git a/src/view_file_list.c b/src/view_file_list.c
index 111cbcc1..12de15d9 100644
--- a/src/view_file_list.c
+++ b/src/view_file_list.c
@@ -251,7 +251,7 @@ static void vflist_drag_data_received(GtkWidget *entry_widget, GdkDragContext *c
 
 		if (fd) {
 			/* Add keywords to file */
-			gchar *str = gtk_selection_data_get_text(selection);
+			gchar *str = (gchar *) gtk_selection_data_get_text(selection);
 			GList *kw_list = string_to_keywords_list(str);
 			
 			metadata_append_list(fd, KEYWORD_KEY, kw_list);
@@ -1836,10 +1836,6 @@ static void vflist_listview_add_column_toggle(ViewFile *vf, gint n, const gchar
 {
 	GtkTreeViewColumn *column;
 	GtkCellRenderer *renderer;
-	GtkTreeStore *store;
-	gint index;
-
-	store = GTK_TREE_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview)));
 
 	renderer = gtk_cell_renderer_toggle_new();
 	column = gtk_tree_view_column_new_with_attributes(title, renderer, "active", n, NULL);
@@ -1848,7 +1844,7 @@ static void vflist_listview_add_column_toggle(ViewFile *vf, gint n, const gchar
 	g_object_set_data(G_OBJECT(column), "column_store_idx", GUINT_TO_POINTER(n));
 	g_object_set_data(G_OBJECT(renderer), "column_store_idx", GUINT_TO_POINTER(n));
 
-	index = gtk_tree_view_append_column(GTK_TREE_VIEW(vf->listview), column);
+	gtk_tree_view_append_column(GTK_TREE_VIEW(vf->listview), column);
 	gtk_tree_view_column_set_fixed_width(column, 22);
 	gtk_tree_view_column_set_visible(column, vf->marks_enabled);