From: Colin Clark Date: Mon, 26 Jul 2021 09:30:05 +0000 (+0100) Subject: Fix #911: can't rename or create directories, while file name outside the window X-Git-Tag: v1.7~87 X-Git-Url: http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commitdiff_plain;h=9da6b1e3a9b6dbea4af3e8b4ee98077c310b141f Fix #911: can't rename or create directories, while file name outside the window https://github.com/BestImageViewer/geeqie/issues/911 Using gtk_tree_view_get_bin_window() sometimes resulted in a negative x value. Use the window of the parent widget instead. --- diff --git a/src/ui_tree_edit.c b/src/ui_tree_edit.c index 38ce890d..b572c1d5 100644 --- a/src/ui_tree_edit.c +++ b/src/ui_tree_edit.c @@ -160,7 +160,7 @@ static gboolean tree_edit_by_path_idle_cb(gpointer data) w = MAX(w - sx, sw); } - gdk_window_get_origin(gtk_tree_view_get_bin_window(ted->tree), &wx, &wy); + gdk_window_get_origin(gtk_widget_get_window(gtk_widget_get_parent(GTK_WIDGET(ted->tree))), &wx, &wy); x += wx - 2; /* the -val is to 'fix' alignment of entry position */ y += wy - 2; @@ -231,7 +231,7 @@ gboolean tree_edit_by_path(GtkTreeView *tree, GtkTreePath *tpath, gint column, c ted->column = tcolumn; ted->cell = cell; - gtk_tree_view_scroll_to_cell(ted->tree, ted->path, ted->column, FALSE, 0.0, 0.0); + gtk_tree_view_scroll_to_cell(ted->tree, ted->path, ted->column, TRUE, 0.5, 0.0); /* create the window */