From: Colin Clark <colin.clark@cclark.uk>
Date: Fri, 24 Jul 2020 09:03:17 +0000 (+0100)
Subject: Fix #782: dangerous duplicate finder deletes original, leaves dangling symlink
X-Git-Tag: v1.6~32
X-Git-Url: http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commitdiff_plain;h=d6195e586128dcda176951f6874ba33b9a6f2abc

Fix #782: dangerous duplicate finder deletes original, leaves dangling symlink

https://github.com/BestImageViewer/geeqie/issues/782

Ignore symlinks to files
---

diff --git a/doc/docbook/GuideImageSearchFindingDuplicates.xml b/doc/docbook/GuideImageSearchFindingDuplicates.xml
index d84e33b9..c5d0a975 100644
--- a/doc/docbook/GuideImageSearchFindingDuplicates.xml
+++ b/doc/docbook/GuideImageSearchFindingDuplicates.xml
@@ -37,6 +37,11 @@
         </listitem>
       </varlistentry>
     </variablelist>
+    <para>
+      <note>
+        <para>Symbolic links to folders will be followed, but symbolic links to files will be ignored. Only actual files will be tested.</para>
+      </note>
+    </para>
   </section>
   <section id="Comparisonmethods">
     <title>Comparison methods</title>
diff --git a/src/dupe.c b/src/dupe.c
index cdbe6307..d64f69de 100644
--- a/src/dupe.c
+++ b/src/dupe.c
@@ -1840,7 +1840,7 @@ static void dupe_files_add(DupeWindow *dw, CollectionData *collection, CollectIn
 		}
 	else if (fd)
 		{
-		if (isfile(fd->path))
+		if (isfile(fd->path) && !g_file_test(fd->path, G_FILE_TEST_IS_SYMLINK))
 			{
 			di = dupe_item_new(fd);
 			}