From: Colin Clark <colin.clark@cclark.uk>
Date: Fri, 2 Feb 2024 14:58:16 +0000 (+0000)
Subject: clang-tidy: misc-redundant-expression
X-Git-Tag: v2.3~60
X-Git-Url: http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commitdiff_plain;h=f3625043c892f1d7cdb89518301309fc52d18afb

clang-tidy: misc-redundant-expression

- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
---

diff --git a/.clang-tidy b/.clang-tidy
index cf322294..17b7897d 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -40,7 +40,6 @@ Checks: >
   -misc-const-correctness,
   -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
-  -misc-redundant-expression,
   -misc-use-anonymous-namespace,
   -modernize-avoid-c-arrays,
   -modernize-macro-to-enum,
diff --git a/src/ui-tabcomp.cc b/src/ui-tabcomp.cc
index 0196cd5b..50b9059f 100644
--- a/src/ui-tabcomp.cc
+++ b/src/ui-tabcomp.cc
@@ -588,8 +588,7 @@ static void tab_completion_button_size_allocate(GtkWidget *button, GtkAllocation
 
 		gtk_widget_get_allocation(button, &button_allocation);
 		button_allocation.height = parent_allocation.height;
-		button_allocation.y = parent_allocation.y +
-			(parent_allocation.height - parent_allocation.height) / 2;
+		button_allocation.y = parent_allocation.y;
 		gtk_widget_size_allocate(button, &button_allocation);
 		}
 }