Fix #753: Various cleanups based on gcc warnings
[geeqie.git] / src / layout.c
index 692a2ae..87b82cc 100644 (file)
@@ -25,6 +25,7 @@
 #include "color-man.h"
 #include "filedata.h"
 #include "histogram.h"
+#include "history_list.h"
 #include "image.h"
 #include "image-overlay.h"
 #include "layout_config.h"
@@ -62,7 +63,7 @@
 #define TOOLWINDOW_DEF_HEIGHT 450
 
 #define PROGRESS_WIDTH 150
-#define ZOOM_LABEL_WIDTH 64
+#define ZOOM_LABEL_WIDTH 120
 
 #define PANE_DIVIDER_SIZE 10
 
@@ -149,6 +150,23 @@ LayoutWindow *layout_find_by_layout_id(const gchar *id)
        return NULL;
 }
 
+gchar *layout_get_unique_id()
+{
+       char id[10];
+       gint i;
+
+       i = 1;
+       while (TRUE)
+               {
+               g_snprintf(id, sizeof(id), "lw%d", i);
+               if (!layout_find_by_layout_id(id))
+                       {
+                       return g_strdup(id);
+                       }
+               i++;
+               }
+}
+
 static void layout_set_unique_id(LayoutWindow *lw)
 {
        char id[10];
@@ -233,6 +251,7 @@ static void layout_path_entry_tab_cb(const gchar *path, gpointer data)
                {
                if ((!lw->dir_fd || strcmp(lw->dir_fd->path, buf) != 0) && layout_set_path(lw, buf))
                        {
+                       gtk_widget_grab_focus(GTK_WIDGET(lw->path_entry));
                        gint pos = -1;
                        /* put the G_DIR_SEPARATOR back, if we are in tab completion for a dir and result was path change */
                        gtk_editable_insert_text(GTK_EDITABLE(lw->path_entry), G_DIR_SEPARATOR_S, -1, &pos);
@@ -260,9 +279,13 @@ static void layout_path_entry_cb(const gchar *path, gpointer data)
        gchar *buf;
 
        buf = g_strdup(path);
-       parse_out_relatives(buf);
 
-       layout_set_path(lw, buf);
+       if (!download_web_file(buf, FALSE, lw))
+               {
+               parse_out_relatives(buf);
+
+               layout_set_path(lw, buf);
+               }
 
        g_free(buf);
 }
@@ -285,30 +308,48 @@ static void layout_path_entry_tab_append_cb(const gchar *path, gpointer data, gi
        gtk_widget_set_sensitive(lw->back_button, (n > 1));
 }
 
+static gboolean path_entry_tooltip_cb(GtkWidget *widget, gpointer data)
+{
+       GList *box_child_list;
+       GtkComboBox *path_entry;
+       gchar *current_path;
+
+       box_child_list = gtk_container_get_children(GTK_CONTAINER(widget));
+       path_entry = box_child_list->data;
+       current_path = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(path_entry));
+       gtk_widget_set_tooltip_text(GTK_WIDGET(widget), current_path);
+
+       g_free(current_path);
+       g_list_free(box_child_list);
+
+       return FALSE;
+}
+
 static GtkWidget *layout_tool_setup(LayoutWindow *lw)
 {
        GtkWidget *box;
        GtkWidget *box_folders;
        GtkWidget *scd;
-       GtkWidget *menu_bar;
+       GtkWidget *menu_tool_bar;
        GtkWidget *tabcomp;
-       GtkWidget *toolbar;
 
        box = gtk_vbox_new(FALSE, 0);
 
-       menu_bar = layout_actions_menu_bar(lw);
-       gtk_box_pack_start(GTK_BOX(box), menu_bar, FALSE, FALSE, 0);
-
-       toolbar = layout_actions_toolbar(lw, TOOLBAR_MAIN);
-       gtk_box_pack_start(GTK_BOX(box), toolbar, FALSE, FALSE, 0);
-       if (lw->options.toolbar_hidden) gtk_widget_hide(toolbar);
+       menu_tool_bar = layout_actions_menu_tool_bar(lw);
+       DEBUG_NAME(menu_tool_bar);
+       gtk_widget_show(menu_tool_bar);
+       gtk_box_pack_start(GTK_BOX(lw->main_box), lw->menu_tool_bar, FALSE, FALSE, 0);
+       if (lw->options.toolbar_hidden) gtk_widget_hide(lw->toolbar[TOOLBAR_MAIN]);
 
        tabcomp = tab_completion_new_with_history(&lw->path_entry, NULL, "path_list", -1,
                                                  layout_path_entry_cb, lw);
+       DEBUG_NAME(tabcomp);
        tab_completion_add_tab_func(lw->path_entry, layout_path_entry_tab_cb, lw);
        tab_completion_add_append_func(lw->path_entry, layout_path_entry_tab_append_cb, lw);
        gtk_box_pack_start(GTK_BOX(box), tabcomp, FALSE, FALSE, 0);
        gtk_widget_show(tabcomp);
+       gtk_widget_set_has_tooltip(GTK_WIDGET(tabcomp), TRUE);
+       g_signal_connect(G_OBJECT(tabcomp), "query_tooltip", G_CALLBACK(path_entry_tooltip_cb), lw);
 
 #if GTK_CHECK_VERSION(3,20,0)
        g_signal_connect(G_OBJECT(gtk_widget_get_parent(gtk_widget_get_parent(lw->path_entry))), "changed",
@@ -319,17 +360,20 @@ static GtkWidget *layout_tool_setup(LayoutWindow *lw)
 #endif
 
        box_folders = GTK_WIDGET(gtk_hpaned_new());
+       DEBUG_NAME(box_folders);
        gtk_box_pack_start(GTK_BOX(box), box_folders, TRUE, TRUE, 0);
 
-       lw->vd = vd_new(lw->options.dir_view_type, lw->dir_fd);
-       vd_set_layout(lw->vd, lw);
+       lw->vd = vd_new(lw);
+
        vd_set_select_func(lw->vd, layout_vd_select_cb, lw);
 
        lw->dir_view = lw->vd->widget;
+       DEBUG_NAME(lw->dir_view);
        gtk_paned_add2(GTK_PANED(box_folders), lw->dir_view);
        gtk_widget_show(lw->dir_view);
 
        scd = shortcuts_new_default(lw);
+       DEBUG_NAME(scd);
        gtk_paned_add1(GTK_PANED(box_folders), scd);
        gtk_paned_set_position(GTK_PANED(box_folders), lw->options.folder_window.vdivider_pos);
 
@@ -361,6 +405,10 @@ static void layout_sort_menu_cb(GtkWidget *widget, gpointer data)
 
        type = (SortType)GPOINTER_TO_INT(data);
 
+       if (type == SORT_EXIFTIME || type == SORT_EXIFTIMEDIGITIZED || type == SORT_RATING)
+               {
+               vf_read_metadata_in_idle(lw->vf);
+               }
        layout_sort_set(lw, type, lw->sort_ascend);
 }
 
@@ -422,6 +470,7 @@ static GtkWidget *layout_sort_button(LayoutWindow *lw)
        GtkWidget *button;
 
        button = gtk_button_new_with_label(sort_type_get_text(lw->sort_method));
+       DEBUG_NAME(button);
        g_signal_connect(G_OBJECT(button), "clicked",
                         G_CALLBACK(layout_sort_button_press_cb), lw);
        gtk_button_set_relief(GTK_BUTTON(button), GTK_RELIEF_NONE);
@@ -518,6 +567,7 @@ static GtkWidget *layout_zoom_button(LayoutWindow *lw, GtkWidget *box, gint size
 
 
        frame = gtk_frame_new(NULL);
+       DEBUG_NAME(frame);
        if (size) gtk_widget_set_size_request(frame, size, -1);
        gtk_frame_set_shadow_type(GTK_FRAME(frame), GTK_SHADOW_IN);
 
@@ -545,11 +595,28 @@ static GtkWidget *layout_zoom_button(LayoutWindow *lw, GtkWidget *box, gint size
 
 void layout_status_update_progress(LayoutWindow *lw, gdouble val, const gchar *text)
 {
+       static gdouble meta = 0;
+
        if (!layout_valid(&lw)) return;
        if (!lw->info_progress_bar) return;
 
+       /* Give priority to the loading meta data message
+        */
+       if(!g_strcmp0(text, "Loading thumbs..."))
+               {
+               if (meta)
+                       {
+                       return;
+                       }
+               }
+       else
+               {
+               meta = val;
+               }
+
        gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(lw->info_progress_bar), val);
-       gtk_progress_bar_set_text(GTK_PROGRESS_BAR(lw->info_progress_bar), (text) ? text : " ");
+       gtk_progress_bar_set_text(GTK_PROGRESS_BAR(lw->info_progress_bar),
+                                                                       val ? ((text) ? text : " ") : " ");
 }
 
 void layout_status_update_info(LayoutWindow *lw, const gchar *text)
@@ -627,6 +694,9 @@ void layout_status_update_info(LayoutWindow *lw, const gchar *text)
 void layout_status_update_image(LayoutWindow *lw)
 {
        guint64 n;
+       FileData *fd;
+       gint page_total;
+       gint page_num;
 
        if (!layout_valid(&lw) || !lw->image) return;
        if (!lw->info_zoom || !lw->info_details) return; /*called from layout_style_set */
@@ -663,10 +733,19 @@ void layout_status_update_image(LayoutWindow *lw)
                else
                        {
                        gint width, height;
-
+                       fd = image_get_fd(lw->image);
+                       page_total = fd->page_total;
+                       page_num = fd->page_num + 1;
                        image_get_image_size(lw->image, &width, &height);
-                       text = g_strdup_printf(_("( %d x %d ) %s bytes"),
-                                              width, height, b);
+
+                       if (page_total > 1)
+                               {
+                               text = g_strdup_printf(_("( %d x %d ) %s bytes %s%d%s%d%s"), width, height, b, "[", page_num, "/", page_total, "]");
+                               }
+                       else
+                               {
+                               text = g_strdup_printf(_("( %d x %d ) %s bytes"), width, height, b);
+                               }
                        }
 
                g_signal_emit_by_name (lw->image->pr, "update-pixel");
@@ -693,6 +772,7 @@ static GtkWidget *layout_status_label(gchar *text, GtkWidget *box, gboolean star
        GtkWidget *frame;
 
        frame = gtk_frame_new(NULL);
+       DEBUG_NAME(frame);
        if (size) gtk_widget_set_size_request(frame, size, -1);
        gtk_frame_set_shadow_type(GTK_FRAME(frame), GTK_SHADOW_IN);
        if (start)
@@ -723,10 +803,12 @@ static void layout_status_setup(LayoutWindow *lw, GtkWidget *box, gboolean small
        if (small_format)
                {
                lw->info_box = gtk_vbox_new(FALSE, 0);
+               DEBUG_NAME(lw->info_box);
                }
        else
                {
                lw->info_box = gtk_hbox_new(FALSE, 0);
+               DEBUG_NAME(lw->info_box);
                }
        gtk_box_pack_end(GTK_BOX(box), lw->info_box, FALSE, FALSE, 0);
        gtk_widget_show(lw->info_box);
@@ -734,6 +816,7 @@ static void layout_status_setup(LayoutWindow *lw, GtkWidget *box, gboolean small
        if (small_format)
                {
                hbox = gtk_hbox_new(FALSE, 0);
+               DEBUG_NAME(hbox);
                gtk_box_pack_start(GTK_BOX(lw->info_box), hbox, FALSE, FALSE, 0);
                gtk_widget_show(hbox);
                }
@@ -742,6 +825,7 @@ static void layout_status_setup(LayoutWindow *lw, GtkWidget *box, gboolean small
                hbox = lw->info_box;
                }
        lw->info_progress_bar = gtk_progress_bar_new();
+       DEBUG_NAME(lw->info_progress_bar);
        gtk_widget_set_size_request(lw->info_progress_bar, PROGRESS_WIDTH, -1);
 #if GTK_CHECK_VERSION(3,0,0)
        gtk_progress_bar_set_text(GTK_PROGRESS_BAR(lw->info_progress_bar), "");
@@ -756,35 +840,41 @@ static void layout_status_setup(LayoutWindow *lw, GtkWidget *box, gboolean small
        gtk_widget_show(lw->info_sort);
 
        lw->info_status = layout_status_label(NULL, lw->info_box, TRUE, 0, (!small_format));
+       DEBUG_NAME(lw->info_status);
        gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_status), _("Folder contents (files selected)"));
 
        if (small_format)
                {
                hbox = gtk_hbox_new(FALSE, 0);
+               DEBUG_NAME(hbox);
                gtk_box_pack_start(GTK_BOX(lw->info_box), hbox, FALSE, FALSE, 0);
                gtk_widget_show(hbox);
                }
        lw->info_details = layout_status_label(NULL, hbox, TRUE, 0, TRUE);
-       gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_details), _("(Image dimensions) Image size"));
+       DEBUG_NAME(lw->info_details);
+       gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_details), _("(Image dimensions) Image size [page n of m]"));
        toolbar = layout_actions_toolbar(lw, TOOLBAR_STATUS);
 
        toolbar_frame = gtk_frame_new(NULL);
+       DEBUG_NAME(toolbar_frame);
        gtk_frame_set_shadow_type(GTK_FRAME(toolbar_frame), GTK_SHADOW_IN);
        gtk_container_add(GTK_CONTAINER(toolbar_frame), toolbar);
        gtk_widget_show(toolbar_frame);
        gtk_widget_show(toolbar);
        gtk_box_pack_end(GTK_BOX(hbox), toolbar_frame, FALSE, FALSE, 0);
        lw->info_zoom = layout_zoom_button(lw, hbox, ZOOM_LABEL_WIDTH, TRUE);
-       gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_zoom), _("Select zoom mode"));
+       gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_zoom), _("Select zoom and scroll mode"));
        gtk_widget_show(lw->info_zoom);
 
        if (small_format)
                {
                hbox = gtk_hbox_new(FALSE, 0);
+               DEBUG_NAME(hbox);
                gtk_box_pack_start(GTK_BOX(lw->info_box), hbox, FALSE, FALSE, 0);
                gtk_widget_show(hbox);
                }
        lw->info_pixel = layout_status_label(NULL, hbox, FALSE, 0, small_format); /* expand only in small format */
+       DEBUG_NAME(lw->info_pixel);
        gtk_widget_set_tooltip_text(GTK_WIDGET(lw->info_pixel), _("[Pixel x,y coord]: (Pixel R,G,B value)"));
        if (!lw->options.show_info_pixel) gtk_widget_hide(gtk_widget_get_parent(lw->info_pixel));
 }
@@ -820,6 +910,11 @@ static void layout_list_sync_thumb(LayoutWindow *lw)
        if (lw->vf) vf_thumb_set(lw->vf, lw->options.show_thumbnails);
 }
 
+static void layout_list_sync_file_filter(LayoutWindow *lw)
+{
+       if (lw->vf) vf_file_filter_set(lw->vf, lw->options.show_file_filter);
+}
+
 static GtkWidget *layout_list_new(LayoutWindow *lw)
 {
        lw->vf = vf_new(lw->options.file_view_type, NULL);
@@ -831,6 +926,7 @@ static GtkWidget *layout_list_new(LayoutWindow *lw)
        vf_marks_set(lw->vf, lw->options.show_marks);
 
        layout_list_sync_thumb(lw);
+       layout_list_sync_file_filter(lw);
 
        return lw->vf->widget;
 }
@@ -1064,7 +1160,11 @@ gboolean layout_set_fd(LayoutWindow *lw, FileData *fd)
                if (isfile(fd->path)) have_file = TRUE;
                }
 
-       if (lw->path_entry) tab_completion_append_to_history(lw->path_entry, lw->dir_fd->path);
+       if (lw->path_entry)
+               {
+               history_chain_append_end(lw->dir_fd->path);
+               tab_completion_append_to_history(lw->path_entry, lw->dir_fd->path);
+               }
        layout_sync_path(lw);
        layout_list_sync_sort(lw);
 
@@ -1090,6 +1190,11 @@ gboolean layout_set_fd(LayoutWindow *lw, FileData *fd)
        if (options->metadata.confirm_on_dir_change && dir_changed)
                metadata_write_queue_confirm(FALSE, NULL, NULL);
 
+       if (lw->vf && (options->read_metadata_in_idle || (lw->sort_method == SORT_EXIFTIME || lw->sort_method == SORT_EXIFTIMEDIGITIZED || lw->sort_method == SORT_RATING)))
+               {
+               vf_read_metadata_in_idle(lw->vf);
+               }
+
        return TRUE;
 }
 
@@ -1127,6 +1232,18 @@ void layout_thumb_set(LayoutWindow *lw, gboolean enable)
        layout_list_sync_thumb(lw);
 }
 
+void layout_file_filter_set(LayoutWindow *lw, gboolean enable)
+{
+       if (!layout_valid(&lw)) return;
+
+       if (lw->options.show_file_filter == enable) return;
+
+       lw->options.show_file_filter = enable;
+
+       layout_util_sync_file_filter(lw);
+       layout_list_sync_file_filter(lw);
+}
+
 void layout_marks_set(LayoutWindow *lw, gboolean enable)
 {
        if (!layout_valid(&lw)) return;
@@ -1135,7 +1252,7 @@ void layout_marks_set(LayoutWindow *lw, gboolean enable)
 
        lw->options.show_marks = enable;
 
-//     layout_util_sync_marks(lw);
+       layout_util_sync_marks(lw);
        layout_list_sync_marks(lw);
 }
 
@@ -1241,6 +1358,18 @@ void layout_views_set(LayoutWindow *lw, DirViewType dir_view_type, FileViewType
        layout_style_set(lw, -1, NULL);
 }
 
+void layout_views_set_sort(LayoutWindow *lw, SortType method, gboolean ascend)
+{
+       if (!layout_valid(&lw)) return;
+
+       if (lw->options.dir_view_list_sort.method == method && lw->options.dir_view_list_sort.ascend == ascend) return;
+
+       lw->options.dir_view_list_sort.method = method;
+       lw->options.dir_view_list_sort.ascend = ascend;
+
+       layout_style_set(lw, -1, NULL);
+}
+
 gboolean layout_views_get(LayoutWindow *lw, DirViewType *dir_view_type, FileViewType *file_view_type)
 {
        if (!layout_valid(&lw)) return FALSE;
@@ -1332,7 +1461,7 @@ gboolean layout_geometry_get_tools(LayoutWindow *lw, gint *x, gint *y, gint *w,
        *h = gdk_window_get_height(window);
        gtk_widget_get_allocation(gtk_paned_get_child1(GTK_PANED(lw->tools_pane)), &allocation);
 
-       if (GTK_IS_VPANED(lw->tools_pane))
+       if (gtk_orientable_get_orientation(GTK_ORIENTABLE(lw->tools_pane)) == GTK_ORIENTATION_VERTICAL)
                {
                *divider_pos = allocation.height;
                }
@@ -1422,6 +1551,7 @@ static void layout_tools_setup(LayoutWindow *lw, GtkWidget *tools, GtkWidget *fi
                GdkWindowHints hints;
 
                lw->tools = window_new(GTK_WINDOW_TOPLEVEL, "tools", PIXBUF_INLINE_ICON_TOOLS, NULL, _("Tools"));
+               DEBUG_NAME(lw->tools);
                g_signal_connect(G_OBJECT(lw->tools), "delete_event",
                                 G_CALLBACK(layout_tools_delete_cb), lw);
                layout_keyboard_init(lw, lw->tools);
@@ -1445,6 +1575,7 @@ static void layout_tools_setup(LayoutWindow *lw, GtkWidget *tools, GtkWidget *fi
 
                gtk_window_set_resizable(GTK_WINDOW(lw->tools), TRUE);
                gtk_container_set_border_width(GTK_CONTAINER(lw->tools), 0);
+               gtk_container_remove(GTK_CONTAINER(lw->main_box), lw->menu_tool_bar);
 
                new_window = TRUE;
                }
@@ -1458,7 +1589,9 @@ static void layout_tools_setup(LayoutWindow *lw, GtkWidget *tools, GtkWidget *fi
        layout_actions_add_window(lw, lw->tools);
 
        vbox = gtk_vbox_new(FALSE, 0);
+       DEBUG_NAME(vbox);
        gtk_container_add(GTK_CONTAINER(lw->tools), vbox);
+       gtk_box_pack_start(GTK_BOX(vbox), GTK_WIDGET(lw->menu_tool_bar), FALSE, FALSE, 0);
        gtk_widget_show(vbox);
 
        layout_status_setup(lw, vbox, TRUE);
@@ -1466,10 +1599,12 @@ static void layout_tools_setup(LayoutWindow *lw, GtkWidget *tools, GtkWidget *fi
        if (vertical)
                {
                lw->tools_pane = gtk_vpaned_new();
+               DEBUG_NAME(lw->tools_pane);
                }
        else
                {
                lw->tools_pane = gtk_hpaned_new();
+               DEBUG_NAME(lw->tools_pane);
                }
        gtk_box_pack_start(GTK_BOX(vbox), lw->tools_pane, TRUE, TRUE, 0);
        gtk_widget_show(lw->tools_pane);
@@ -1608,7 +1743,8 @@ static void layout_grid_setup(LayoutWindow *lw)
        layout_actions_setup(lw);
 
        lw->group_box = gtk_vbox_new(FALSE, 0);
-       gtk_box_pack_start(GTK_BOX(lw->main_box), lw->group_box, TRUE, TRUE, 0);
+       DEBUG_NAME(lw->group_box);
+       gtk_box_pack_end(GTK_BOX(lw->main_box), lw->group_box, TRUE, TRUE, 0);
        gtk_widget_show(lw->group_box);
 
        priority_location = layout_grid_compass(lw);
@@ -1617,16 +1753,20 @@ static void layout_grid_setup(LayoutWindow *lw)
                {
                layout_split_change(lw, lw->split_mode); /* this re-creates image frame for the new configuration */
                image_sb = lw->utility_box;
+               DEBUG_NAME(image_sb);
                }
        else
                {
                GtkWidget *image; /* image or split images together */
                image = layout_image_setup_split(lw, lw->split_mode);
                image_sb = layout_bars_prepare(lw, image);
+               DEBUG_NAME(image_sb);
                }
 
        tools = layout_tools_new(lw);
+       DEBUG_NAME(tools);
        files = layout_list_new(lw);
+       DEBUG_NAME(files);
 
 
        if (lw->options.tools_float || lw->options.tools_hidden)
@@ -1653,8 +1793,10 @@ static void layout_grid_setup(LayoutWindow *lw)
        layout_grid_compute(lw, image_sb, tools, files, &w1, &w2, &w3);
 
        v = lw->v_pane = gtk_vpaned_new();
+       DEBUG_NAME(v);
 
        h = lw->h_pane = gtk_hpaned_new();
+       DEBUG_NAME(h);
 
        if (!layout_location_vertical(priority_location))
                {
@@ -1709,7 +1851,6 @@ static void layout_grid_setup(LayoutWindow *lw)
 void layout_style_set(LayoutWindow *lw, gint style, const gchar *order)
 {
        FileData *dir_fd;
-       gint i;
 
        if (!layout_valid(&lw)) return;
 
@@ -1742,9 +1883,10 @@ void layout_style_set(LayoutWindow *lw, gint style, const gchar *order)
        /* preserve utility_box (image + sidebars), menu_bar and toolbars to be reused later in layout_grid_setup */
        /* lw->image is preserved together with lw->utility_box */
        if (lw->utility_box) gtk_container_remove(GTK_CONTAINER(gtk_widget_get_parent(lw->utility_box)), lw->utility_box);
-       if (lw->menu_bar) gtk_container_remove(GTK_CONTAINER(gtk_widget_get_parent(lw->menu_bar)), lw->menu_bar);
-       for (i = 0; i < TOOLBAR_COUNT; i++)
-               if (lw->toolbar[i]) gtk_container_remove(GTK_CONTAINER(gtk_widget_get_parent(lw->toolbar[i])), lw->toolbar[i]);
+
+       if (lw->toolbar[TOOLBAR_STATUS]) gtk_container_remove(GTK_CONTAINER(gtk_widget_get_parent(lw->toolbar[TOOLBAR_STATUS])), lw->toolbar[TOOLBAR_STATUS]);
+
+       if (lw->menu_tool_bar) gtk_container_remove(GTK_CONTAINER(gtk_widget_get_parent(lw->menu_tool_bar)), lw->menu_tool_bar);
 
        /* clear it all */
 
@@ -2007,18 +2149,30 @@ static void home_path_set_current_cb(GtkWidget *widget, gpointer data)
 static void startup_path_set_current_cb(GtkWidget *widget, gpointer data)
 {
        LayoutConfig *lc = data;
+       if (!gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)))
+               {
+               return;
+               }
        lc->options.startup_path = STARTUP_PATH_CURRENT;
 }
 
 static void startup_path_set_last_cb(GtkWidget *widget, gpointer data)
 {
        LayoutConfig *lc = data;
+       if (!gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)))
+               {
+               return;
+               }
        lc->options.startup_path = STARTUP_PATH_LAST;
 }
 
 static void startup_path_set_home_cb(GtkWidget *widget, gpointer data)
 {
        LayoutConfig *lc = data;
+       if (!gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)))
+               {
+               return;
+               }
        lc->options.startup_path = STARTUP_PATH_HOME;
 }
 
@@ -2049,6 +2203,7 @@ void layout_show_config_window(LayoutWindow *lw)
        copy_layout_options(&lc->options, &lw->options);
 
        lc->configwindow = window_new(GTK_WINDOW_TOPLEVEL, "Layout", PIXBUF_INLINE_ICON_CONFIG, NULL, _("Window options and layout"));
+       DEBUG_NAME(lc->configwindow);
        gtk_window_set_type_hint(GTK_WINDOW(lc->configwindow), GDK_WINDOW_TYPE_HINT_DIALOG);
 
        g_signal_connect(G_OBJECT(lc->configwindow), "delete_event",
@@ -2059,6 +2214,7 @@ void layout_show_config_window(LayoutWindow *lw)
        gtk_container_set_border_width(GTK_CONTAINER(lc->configwindow), PREF_PAD_BORDER);
 
        win_vbox = gtk_vbox_new(FALSE, PREF_PAD_SPACE);
+       DEBUG_NAME(win_vbox);
        gtk_container_add(GTK_CONTAINER(lc->configwindow), win_vbox);
        gtk_widget_show(win_vbox);
 
@@ -2107,8 +2263,10 @@ void layout_show_config_window(LayoutWindow *lw)
                }
 
        frame = pref_frame_new(win_vbox, TRUE, NULL, GTK_ORIENTATION_VERTICAL, PREF_PAD_GAP);
+       DEBUG_NAME(frame);
 
        vbox = gtk_vbox_new(FALSE, PREF_PAD_SPACE);
+       DEBUG_NAME(vbox);
        gtk_container_add(GTK_CONTAINER(frame), vbox);
        gtk_widget_show(vbox);
 
@@ -2118,7 +2276,7 @@ void layout_show_config_window(LayoutWindow *lw)
        pref_label_new(group, _("Home path (empty to use your home directory)"));
        hbox = pref_box_new(group, FALSE, GTK_ORIENTATION_HORIZONTAL, PREF_PAD_SPACE);
 
-       tabcomp = tab_completion_new(&lc->home_path_entry, lc->options.home_path, NULL, NULL);
+       tabcomp = tab_completion_new(&lc->home_path_entry, lc->options.home_path, NULL, NULL, NULL, NULL);
        tab_completion_add_select_button(lc->home_path_entry, NULL, TRUE);
        gtk_box_pack_start(GTK_BOX(hbox), tabcomp, TRUE, TRUE, 0);
        gtk_widget_show(tabcomp);
@@ -2129,9 +2287,6 @@ void layout_show_config_window(LayoutWindow *lw)
        pref_checkbox_new_int(group, _("Show date in directories list view"),
                              lc->options.show_directory_date, &lc->options.show_directory_date);
 
-       pref_checkbox_new_int(group, _("Exit program when this window is closed"),
-                             lc->options.exit_on_close, &lc->options.exit_on_close);
-
        group = pref_group_new(vbox, FALSE, _("Start-up directory:"), GTK_ORIENTATION_VERTICAL);
 
        button = pref_radiobutton_new(group, NULL, _("No change"),
@@ -2147,6 +2302,7 @@ void layout_show_config_window(LayoutWindow *lw)
        group = pref_group_new(vbox, FALSE, _("Layout"), GTK_ORIENTATION_VERTICAL);
 
        lc->layout_widget = layout_config_new();
+       DEBUG_NAME(lc->layout_widget);
        layout_config_set(lc->layout_widget, lw->options.style, lw->options.order);
        gtk_box_pack_start(GTK_BOX(group), lc->layout_widget, TRUE, TRUE, 0);
 
@@ -2210,12 +2366,53 @@ void layout_apply_options(LayoutWindow *lw, LayoutOptions *lop)
        if (refresh_lists) layout_refresh(lw);
 }
 
+void save_layout(LayoutWindow *lw)
+{
+       gchar *path;
+       gchar *xml_name;
+
+       if (!g_str_has_prefix(lw->options.id, "lw") && !g_str_equal(lw->options.id, "main"))
+               {
+               xml_name = g_strdup_printf("%s.xml", lw->options.id);
+               path = g_build_filename(get_window_layouts_dir(), xml_name, NULL);
+               save_config_to_file(path, options, lw);
+
+               g_free(xml_name);
+               g_free(path);
+               }
+}
 
 void layout_close(LayoutWindow *lw)
 {
-       if (!lw->options.exit_on_close && layout_window_list && layout_window_list->next)
+       GList *list;
+       LayoutWindow *tmp_lw;
+
+       if (layout_window_list && layout_window_list->next)
                {
-               layout_free(lw);
+               if (g_strcmp0(lw->options.id, "main") == 0)
+                       {
+                       while (layout_window_list && layout_window_list->next)
+                               {
+                               list = layout_window_list;
+                               while (list)
+                                       {
+                                       tmp_lw = list->data;
+                                       if (g_strcmp0(tmp_lw->options.id, "main") != 0)
+                                               {
+                                               save_layout(list->data);
+                                               layout_free(list->data);
+                                               break;
+                                               }
+                                       list = list->next;
+                                       }
+                               }
+                       exit_program();
+                       }
+               else
+                       {
+                       save_layout(lw);
+                       layout_free(lw);
+                       }
                }
        else
                {
@@ -2272,6 +2469,11 @@ LayoutWindow *layout_new(FileData *dir_fd, LayoutOptions *lop)
        return layout_new_with_geometry(dir_fd, lop, NULL);
 }
 
+gboolean release_cb(GtkWidget *widget, GdkEventButton *event, gpointer data)
+{
+       return defined_mouse_buttons(widget, event, data);
+}
+
 LayoutWindow *layout_new_with_geometry(FileData *dir_fd, LayoutOptions *lop,
                                       const gchar *geometry)
 {
@@ -2316,9 +2518,12 @@ LayoutWindow *layout_new_with_geometry(FileData *dir_fd, LayoutOptions *lop,
        /* window */
 
        lw->window = window_new(GTK_WINDOW_TOPLEVEL, GQ_APPNAME_LC, NULL, NULL, NULL);
+       DEBUG_NAME(lw->window);
        gtk_window_set_resizable(GTK_WINDOW(lw->window), TRUE);
        gtk_container_set_border_width(GTK_CONTAINER(lw->window), 0);
 
+       g_signal_connect(G_OBJECT(lw->window), "button_release_event", G_CALLBACK(release_cb), lw);
+
        if (options->save_window_positions)
                {
                hint_mask = GDK_HINT_USER_POS;
@@ -2362,6 +2567,7 @@ LayoutWindow *layout_new_with_geometry(FileData *dir_fd, LayoutOptions *lop,
 #endif
 
        lw->main_box = gtk_vbox_new(FALSE, 0);
+       DEBUG_NAME(lw->main_box);
        gtk_container_add(GTK_CONTAINER(lw->window), lw->main_box);
        gtk_widget_show(lw->main_box);
 
@@ -2421,13 +2627,15 @@ void layout_write_attributes(LayoutOptions *layout, GString *outstr, gint indent
        WRITE_NL(); WRITE_CHAR(*layout, order);
        WRITE_NL(); WRITE_UINT(*layout, dir_view_type);
        WRITE_NL(); WRITE_UINT(*layout, file_view_type);
+       WRITE_NL(); WRITE_UINT(*layout, dir_view_list_sort.method);
+       WRITE_NL(); WRITE_BOOL(*layout, dir_view_list_sort.ascend);
        WRITE_NL(); WRITE_BOOL(*layout, show_marks);
+       WRITE_NL(); WRITE_BOOL(*layout, show_file_filter);
        WRITE_NL(); WRITE_BOOL(*layout, show_thumbnails);
        WRITE_NL(); WRITE_BOOL(*layout, show_directory_date);
        WRITE_NL(); WRITE_CHAR(*layout, home_path);
        WRITE_NL(); WRITE_CHAR(*layout, last_path);
        WRITE_NL(); WRITE_UINT(*layout, startup_path);
-       WRITE_NL(); WRITE_BOOL(*layout, exit_on_close);
        WRITE_SEPARATOR();
 
        WRITE_NL(); WRITE_INT(*layout, main_window.x);
@@ -2459,6 +2667,14 @@ void layout_write_attributes(LayoutOptions *layout, GString *outstr, gint indent
 
        WRITE_NL(); WRITE_BOOL(*layout, toolbar_hidden);
        WRITE_NL(); WRITE_BOOL(*layout, show_info_pixel);
+       WRITE_SEPARATOR();
+
+       WRITE_NL(); WRITE_BOOL(*layout, bars_state.info);
+       WRITE_NL(); WRITE_BOOL(*layout, bars_state.sort);
+       WRITE_NL(); WRITE_BOOL(*layout, bars_state.tools_float);
+       WRITE_NL(); WRITE_BOOL(*layout, bars_state.tools_hidden);
+       WRITE_NL(); WRITE_BOOL(*layout, bars_state.hidden);
+       WRITE_SEPARATOR();
 
        WRITE_NL(); WRITE_UINT(*layout, image_overlay.state);
        WRITE_NL(); WRITE_INT(*layout, image_overlay.histogram_channel);
@@ -2484,6 +2700,13 @@ void layout_write_config(LayoutWindow *lw, GString *outstr, gint indent)
        bar_sort_write_config(lw->bar_sort, outstr, indent + 1);
        bar_write_config(lw->bar, outstr, indent + 1);
 
+       WRITE_SEPARATOR();
+       generic_dialog_windows_write_config(outstr, indent + 1);
+
+       WRITE_SEPARATOR();
+       layout_toolbar_write_config(lw, TOOLBAR_MAIN, outstr, indent + 1);
+       layout_toolbar_write_config(lw, TOOLBAR_STATUS, outstr, indent + 1);
+
        WRITE_NL(); WRITE_STRING("</layout>");
 }
 
@@ -2504,13 +2727,15 @@ void layout_load_attributes(LayoutOptions *layout, const gchar **attribute_names
 
                if (READ_UINT(*layout, dir_view_type)) continue;
                if (READ_UINT(*layout, file_view_type)) continue;
+               if (READ_UINT(*layout, dir_view_list_sort.method)) continue;
+               if (READ_BOOL(*layout, dir_view_list_sort.ascend)) continue;
                if (READ_BOOL(*layout, show_marks)) continue;
+               if (READ_BOOL(*layout, show_file_filter)) continue;
                if (READ_BOOL(*layout, show_thumbnails)) continue;
                if (READ_BOOL(*layout, show_directory_date)) continue;
                if (READ_CHAR(*layout, home_path)) continue;
                if (READ_CHAR(*layout, last_path)) continue;
                if (READ_UINT_CLAMP(*layout, startup_path, 0, STARTUP_PATH_HOME)) continue;
-               if (READ_BOOL(*layout, exit_on_close)) continue;
 
                /* window positions */
 
@@ -2538,6 +2763,12 @@ void layout_load_attributes(LayoutOptions *layout, const gchar **attribute_names
                if (READ_BOOL(*layout, toolbar_hidden)) continue;
                if (READ_BOOL(*layout, show_info_pixel)) continue;
 
+               if (READ_BOOL(*layout, bars_state.info)) continue;
+               if (READ_BOOL(*layout, bars_state.sort)) continue;
+               if (READ_BOOL(*layout, bars_state.tools_float)) continue;
+               if (READ_BOOL(*layout, bars_state.tools_hidden)) continue;
+               if (READ_BOOL(*layout, bars_state.hidden)) continue;
+
                if (READ_UINT(*layout, image_overlay.state)) continue;
                if (READ_INT(*layout, image_overlay.histogram_channel)) continue;
                if (READ_INT(*layout, image_overlay.histogram_mode)) continue;