clang-tidy: modernize-use-nullptr
[geeqie.git] / src / ui-tree-edit.cc
index 3e578cf..2a53ce6 100644 (file)
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#include <string.h>
+#include <cstring>
 
 #include "main.h"
+
+#include "misc.h"
 #include "ui-tree-edit.h"
 
 /*
@@ -36,7 +38,7 @@ static void tree_edit_close(TreeEditData *ted)
        gdk_keyboard_ungrab(GDK_CURRENT_TIME);
        gdk_pointer_ungrab(GDK_CURRENT_TIME);
 
-       gtk_widget_destroy(ted->window);
+       g_object_unref(ted->window);
 
        g_free(ted->old_name);
        g_free(ted->new_name);
@@ -47,7 +49,7 @@ static void tree_edit_close(TreeEditData *ted)
 
 static void tree_edit_do(TreeEditData *ted)
 {
-       ted->new_name = g_strdup(gtk_entry_get_text(GTK_ENTRY(ted->entry)));
+       ted->new_name = g_strdup(gq_gtk_entry_get_text(GTK_ENTRY(ted->entry)));
 
        if (strcmp(ted->new_name, ted->old_name) != 0)
                {
@@ -61,7 +63,7 @@ static void tree_edit_do(TreeEditData *ted)
                }
 }
 
-static gboolean tree_edit_click_end_cb(GtkWidget *UNUSED(widget), GdkEventButton *UNUSED(event), gpointer data)
+static gboolean tree_edit_click_end_cb(GtkWidget *, GdkEventButton *, gpointer data)
 {
        auto ted = static_cast<TreeEditData *>(data);
 
@@ -71,7 +73,7 @@ static gboolean tree_edit_click_end_cb(GtkWidget *UNUSED(widget), GdkEventButton
        return TRUE;
 }
 
-static gboolean tree_edit_click_cb(GtkWidget *UNUSED(widget), GdkEventButton *event, gpointer data)
+static gboolean tree_edit_click_cb(GtkWidget *, GdkEventButton *event, gpointer data)
 {
        auto ted = static_cast<TreeEditData *>(data);
        GdkWindow *window = gtk_widget_get_window(ted->window);
@@ -81,8 +83,8 @@ static gboolean tree_edit_click_cb(GtkWidget *UNUSED(widget), GdkEventButton *ev
 
        gint xr, yr;
 
-       xr = (gint)event->x_root;
-       yr = (gint)event->y_root;
+       xr = static_cast<gint>(event->x_root);
+       yr = static_cast<gint>(event->y_root);
 
        gdk_window_get_origin(window, &x, &y);
        w = gdk_window_get_width(window);
@@ -98,7 +100,7 @@ static gboolean tree_edit_click_cb(GtkWidget *UNUSED(widget), GdkEventButton *ev
        return FALSE;
 }
 
-static gboolean tree_edit_key_press_cb(GtkWidget *UNUSED(widget), GdkEventKey *event, gpointer data)
+static gboolean tree_edit_key_press_cb(GtkWidget *, GdkEventKey *event, gpointer data)
 {
        auto ted = static_cast<TreeEditData *>(data);
 
@@ -157,7 +159,7 @@ static gboolean tree_edit_by_path_idle_cb(gpointer data)
        /* now show it */
        gtk_widget_set_size_request(ted->window, w, h);
        gtk_widget_realize(ted->window);
-       gtk_window_move(GTK_WINDOW(ted->window), x, y);
+       gq_gtk_window_move(GTK_WINDOW(ted->window), x, y);
        gtk_window_resize(GTK_WINDOW(ted->window), w, h);
        gtk_widget_show(ted->window);
 
@@ -170,7 +172,7 @@ static gboolean tree_edit_by_path_idle_cb(gpointer data)
        gtk_grab_add(ted->window);
        gdk_pointer_grab(gtk_widget_get_window(ted->window), TRUE,
                         static_cast<GdkEventMask>(GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_BUTTON_MOTION_MASK),
-                        NULL, NULL, GDK_CURRENT_TIME);
+                        nullptr, nullptr, GDK_CURRENT_TIME);
        gdk_keyboard_grab(gtk_widget_get_window(ted->window), TRUE, GDK_CURRENT_TIME);
 
        return G_SOURCE_REMOVE;
@@ -181,7 +183,7 @@ gboolean tree_edit_by_path(GtkTreeView *tree, GtkTreePath *tpath, gint column, c
 {
        TreeEditData *ted;
        GtkTreeViewColumn *tcolumn;
-       GtkCellRenderer *cell = NULL;
+       GtkCellRenderer *cell = nullptr;
        GList *list;
        GList *work;
 
@@ -198,7 +200,7 @@ gboolean tree_edit_by_path(GtkTreeView *tree, GtkTreePath *tpath, gint column, c
                cell = static_cast<GtkCellRenderer *>(work->data);
                if (!GTK_IS_CELL_RENDERER_TEXT(cell))
                        {
-                       cell = NULL;
+                       cell = nullptr;
                        }
                work = work->next;
                }
@@ -232,15 +234,15 @@ gboolean tree_edit_by_path(GtkTreeView *tree, GtkTreePath *tpath, gint column, c
                         G_CALLBACK(tree_edit_key_press_cb), ted);
 
        ted->entry = gtk_entry_new();
-       gtk_entry_set_text(GTK_ENTRY(ted->entry), ted->old_name);
+       gq_gtk_entry_set_text(GTK_ENTRY(ted->entry), ted->old_name);
        gtk_editable_select_region(GTK_EDITABLE(ted->entry), 0, strlen(ted->old_name));
-       gtk_container_add(GTK_CONTAINER(ted->window), ted->entry);
+       gq_gtk_container_add(GTK_WIDGET(ted->window), ted->entry);
        gtk_widget_show(ted->entry);
 
        /* due to the fact that gtktreeview scrolls in an idle loop, we cannot
         * reliably get the cell position until those scroll priority signals are processed
         */
-       g_idle_add_full(G_PRIORITY_DEFAULT_IDLE - 2, tree_edit_by_path_idle_cb, ted, NULL);
+       g_idle_add_full(G_PRIORITY_DEFAULT_IDLE - 2, tree_edit_by_path_idle_cb, ted, nullptr);
 
        return TRUE;
 }
@@ -283,7 +285,7 @@ gboolean tree_view_get_cell_origin(GtkTreeView *widget, GtkTreePath *tpath, gint
 
        if (text_cell_only)
                {
-               GtkCellRenderer *cell = NULL;
+               GtkCellRenderer *cell = nullptr;
                GList *renderers;
                GList *work;
                gint cell_x;
@@ -295,7 +297,7 @@ gboolean tree_view_get_cell_origin(GtkTreeView *widget, GtkTreePath *tpath, gint
                        {
                        cell = static_cast<GtkCellRenderer *>(work->data);
                        work = work->next;
-                       if (!GTK_IS_CELL_RENDERER_TEXT(cell)) cell = NULL;
+                       if (!GTK_IS_CELL_RENDERER_TEXT(cell)) cell = nullptr;
                        }
                g_list_free(renderers);
 
@@ -397,15 +399,15 @@ gint tree_view_row_make_visible(GtkTreeView *widget, GtkTreeIter *iter, gboolean
        tpath = gtk_tree_model_get_path(gtk_tree_view_get_model(widget), iter);
        if (center && vis != 0)
                {
-               gtk_tree_view_scroll_to_cell(widget, tpath, NULL, TRUE, 0.5, 0.0);
+               gtk_tree_view_scroll_to_cell(widget, tpath, nullptr, TRUE, 0.5, 0.0);
                }
        else if (vis < 0)
                {
-               gtk_tree_view_scroll_to_cell(widget, tpath, NULL, TRUE, 0.0, 0.0);
+               gtk_tree_view_scroll_to_cell(widget, tpath, nullptr, TRUE, 0.0, 0.0);
                }
        else if (vis > 0)
                {
-               gtk_tree_view_scroll_to_cell(widget, tpath, NULL, TRUE, 1.0, 0.0);
+               gtk_tree_view_scroll_to_cell(widget, tpath, nullptr, TRUE, 1.0, 0.0);
                }
        gtk_tree_path_free(tpath);
 
@@ -423,7 +425,7 @@ gboolean tree_view_move_cursor_away(GtkTreeView *widget, GtkTreeIter *iter, gboo
 
        store = gtk_tree_view_get_model(widget);
        tpath = gtk_tree_model_get_path(store, iter);
-       gtk_tree_view_get_cursor(widget, &fpath, NULL);
+       gtk_tree_view_get_cursor(widget, &fpath, nullptr);
 
        if (fpath && gtk_tree_path_compare(tpath, fpath) == 0)
                {
@@ -450,7 +452,7 @@ gboolean tree_view_move_cursor_away(GtkTreeView *widget, GtkTreeIter *iter, gboo
 
                        if (move)
                                {
-                               gtk_tree_view_set_cursor(widget, tpath, NULL, FALSE);
+                               gtk_tree_view_set_cursor(widget, tpath, nullptr, FALSE);
                                }
                        }
                }
@@ -461,15 +463,18 @@ gboolean tree_view_move_cursor_away(GtkTreeView *widget, GtkTreeIter *iter, gboo
        return move;
 }
 
-//gint tree_path_to_row(GtkTreePath *tpath)
-//{
-       //gint *indices;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-function"
+gint tree_path_to_row_unused(GtkTreePath *tpath)
+{
+       gint *indices;
 
-       //indices = gtk_tree_path_get_indices(tpath);
-       //if (indices) return indices[0];
+       indices = gtk_tree_path_get_indices(tpath);
+       if (indices) return indices[0];
 
-       //return -1;
-//}
+       return -1;
+}
+#pragma GCC diagnostic pop
 
 
 /*
@@ -478,9 +483,9 @@ gboolean tree_view_move_cursor_away(GtkTreeView *widget, GtkTreeIter *iter, gboo
  *-------------------------------------------------------------------
  */
 
-void shift_color(GdkColor *src, gshort val, gint direction)
+void shift_color(GdkRGBA *src, gshort val, gint direction)
 {
-       gshort cs;
+       gdouble cs;
 
        if (val == -1)
                {
@@ -490,11 +495,11 @@ void shift_color(GdkColor *src, gshort val, gint direction)
                {
                val = CLAMP(val, 1, 100);
                }
-       cs = 0xffff / 100 * val;
+
+       cs = 1.0 / 100 * val;
 
        /* up or down ? */
-       if (direction < 0 ||
-           (direction == 0 &&((gint)src->red + (gint)src->green + (gint)src->blue) / 3 > 0xffff / 2))
+       if (direction < 0 || (direction == 0 &&(static_cast<gdouble>(src->red) + static_cast<gdouble>(src->green) + static_cast<gdouble>(src->blue)) / 3 > 1.0 / 2))
                {
                src->red = MAX(0 , src->red - cs);
                src->green = MAX(0 , src->green - cs);
@@ -502,23 +507,12 @@ void shift_color(GdkColor *src, gshort val, gint direction)
                }
        else
                {
-               src->red = MIN(0xffff, src->red + cs);
-               src->green = MIN(0xffff, src->green + cs);
-               src->blue = MIN(0xffff, src->blue + cs);
+               src->red = MIN(1.0, src->red + cs);
+               src->green = MIN(1.0, src->green + cs);
+               src->blue = MIN(1.0, src->blue + cs);
                }
 }
 
-/* darkens or lightens a style's color for given state
- * esp. useful for alternating dark/light in (c)lists
- */
-//void style_shift_color(GtkStyle *style, GtkStateType type, gshort shift_value, gint direction)
-//{
-       //if (!style) return;
-
-       //shift_color(&style->base[type], shift_value, direction);
-       //shift_color(&style->bg[type], shift_value, direction);
-//}
-
 /*
  *-------------------------------------------------------------------
  * auto scroll by mouse position
@@ -528,8 +522,7 @@ void shift_color(GdkColor *src, gshort val, gint direction)
 #define AUTO_SCROLL_DEFAULT_SPEED 100
 #define AUTO_SCROLL_DEFAULT_REGION 20
 
-typedef struct _AutoScrollData AutoScrollData;
-struct _AutoScrollData
+struct AutoScrollData
 {
        guint timer_id; /* event source id */
        gint region_size;
@@ -547,7 +540,7 @@ void widget_auto_scroll_stop(GtkWidget *widget)
 
        sd = static_cast<AutoScrollData *>(g_object_get_data(G_OBJECT(widget), "autoscroll"));
        if (!sd) return;
-       g_object_set_data(G_OBJECT(widget), "autoscroll", NULL);
+       g_object_set_data(G_OBJECT(widget), "autoscroll", nullptr);
 
        if (sd->timer_id) g_source_remove(sd->timer_id);
        g_free(sd);
@@ -571,7 +564,7 @@ static gboolean widget_auto_scroll_cb(gpointer data)
        window = gtk_widget_get_window(sd->widget);
        seat = gdk_display_get_default_seat(gdk_window_get_display(window));
        device = gdk_seat_get_pointer(seat);
-       gdk_window_get_device_position(window, device, &x, &y, NULL);
+       gdk_window_get_device_position(window, device, &x, &y, nullptr);
 
        w = gdk_window_get_width(window);
        h = gdk_window_get_height(window);