Fix #982: random crash (SIGSEGV) while running two instances of geeqie
[geeqie.git] / src / advanced_exif.c
index c527e58..a6851ad 100644 (file)
@@ -1,16 +1,24 @@
 /*
- * Geeqie
- * (C) 2004 John Ellis
- * Copyright (C) 2008 - 2009 The Geeqie Team
+ * Copyright (C) 2004 John Ellis
+ * Copyright (C) 2008 - 2016 The Geeqie Team
  *
  * Author: John Ellis
  *
- * This software is released under the GNU General Public License (GNU GPL).
- * Please read the included file COPYING for more information.
- * This software comes with no warranty of any kind, use at your own risk!
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-
 #include "main.h"
 #include "advanced_exif.h"
 
 #include "metadata.h"
 #include "filedata.h"
 #include "history_list.h"
+#include "layout_util.h"
 #include "misc.h"
 #include "ui_misc.h"
 #include "window.h"
 #include "dnd.h"
 
-/* FIXME: not needed when bar_exif.c is improved */
+/** @FIXME not needed when bar_exif.c is improved */
 #include "bar_exif.h"
 
 #include <math.h>
@@ -59,6 +68,15 @@ enum {
        EXIF_ADVCOL_COUNT
 };
 
+gint display_order [6] = {
+       EXIF_ADVCOL_DESCRIPTION,
+       EXIF_ADVCOL_VALUE,
+       EXIF_ADVCOL_NAME,
+       EXIF_ADVCOL_TAG,
+       EXIF_ADVCOL_FORMAT,
+       EXIF_ADVCOL_ELEMENTS
+};
+
 static gboolean advanced_exif_row_enabled(const gchar *name)
 {
        GList *list;
@@ -85,11 +103,11 @@ static void advanced_exif_update(ExifWin *ew)
        ExifItem *item;
 
        exif = exif_read_fd(ew->fd);
-       
+
        gtk_widget_set_sensitive(ew->scrolled, !!exif);
 
        if (!exif) return;
-       
+
        exif_original = exif_get_original(exif);
 
        store = GTK_LIST_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(ew->listview)));
@@ -114,7 +132,7 @@ static void advanced_exif_update(ExifWin *ew)
                g_free(text);
                elements = g_strdup_printf("%d", exif_item_get_elements(item));
                description = exif_item_get_description(item);
-               if (!description || *description == '\0') 
+               if (!description || *description == '\0')
                        {
                        g_free(description);
                        description = g_strdup(tag_name);
@@ -165,67 +183,6 @@ void advanced_exif_set_fd(GtkWidget *window, FileData *fd)
        advanced_exif_update(ew);
 }
 
-#if 0
-static void advanced_exif_row_toggled_cb(GtkCellRendererToggle *toggle, const gchar *path, gpointer data)
-{
-       GtkWidget *listview = data;
-       GtkTreeModel *store;
-       GtkTreeIter iter;
-       GtkTreePath *tpath;
-       gchar *name = NULL;
-       gboolean active;
-
-       store = gtk_tree_view_get_model(GTK_TREE_VIEW(listview));
-
-       tpath = gtk_tree_path_new_from_string(path);
-       gtk_tree_model_get_iter(store, &iter, tpath);
-       gtk_tree_path_free(tpath);
-
-       gtk_tree_model_get(store, &iter, EXIF_ADVCOL_ENABLED, &active,
-                                        EXIF_ADVCOL_NAME, &name, -1);
-       active = (!active);
-
-       if (active &&
-           g_list_length(history_list_get_by_key("exif_extras")) >= EXIF_BAR_CUSTOM_COUNT)
-               {
-               active = FALSE;
-               }
-
-       gtk_list_store_set(GTK_LIST_STORE(store), &iter, EXIF_ADVCOL_ENABLED, active, -1);
-
-       if (active)
-               {
-               history_list_add_to_key("exif_extras", name, EXIF_BAR_CUSTOM_COUNT);
-               }
-       else
-               {
-               history_list_item_change("exif_extras", name, NULL);
-               }
-
-       g_free(name);
-}
-#endif 
-
-#if 0
-static void advanced_exif_add_column_check(GtkWidget *listview, const gchar *title, gint n)
-{
-       GtkTreeViewColumn *column;
-       GtkCellRenderer *renderer;
-
-       column = gtk_tree_view_column_new();
-       gtk_tree_view_column_set_title(column, title);
-       gtk_tree_view_column_set_sizing(column, GTK_TREE_VIEW_COLUMN_AUTOSIZE);
-
-       renderer = gtk_cell_renderer_toggle_new();
-       gtk_tree_view_column_pack_start(column, renderer, TRUE);
-       gtk_tree_view_column_add_attribute(column, renderer, "active", n);
-       gtk_tree_view_append_column(GTK_TREE_VIEW(listview), column);
-
-       g_signal_connect(G_OBJECT(renderer), "toggled",
-                        G_CALLBACK(advanced_exif_row_toggled_cb), listview);
-}
-#endif
-
 static GtkTargetEntry advanced_exif_drag_types[] = {
        { "text/plain", 0, TARGET_TEXT_PLAIN }
 };
@@ -237,10 +194,10 @@ static void advanced_exif_dnd_get(GtkWidget *listview, GdkDragContext *context,
                                  guint time, gpointer data)
 {
        //ExifWin *ew = data;
-       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(listview)); 
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(listview));
        GtkTreeIter iter;
 
-       if (gtk_tree_selection_get_selected(sel, NULL, &iter)) 
+       if (gtk_tree_selection_get_selected(sel, NULL, &iter))
                {
                GtkTreeModel *store = gtk_tree_view_get_model(GTK_TREE_VIEW(listview));
                gchar *key;
@@ -257,10 +214,10 @@ static void advanced_exif_dnd_get(GtkWidget *listview, GdkDragContext *context,
 static void advanced_exif_dnd_begin(GtkWidget *listview, GdkDragContext *context, gpointer data)
 {
        //ExifWin *ew = data;
-       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(listview)); 
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(listview));
        GtkTreeIter iter;
 
-       if (gtk_tree_selection_get_selected(sel, NULL, &iter)) 
+       if (gtk_tree_selection_get_selected(sel, NULL, &iter))
                {
                GtkTreeModel *store = gtk_tree_view_get_model(GTK_TREE_VIEW(listview));
                gchar *key;
@@ -291,8 +248,10 @@ static void advanced_exif_add_column(GtkWidget *listview, const gchar *title, gi
                {
                gtk_tree_view_column_set_sizing(column, GTK_TREE_VIEW_COLUMN_AUTOSIZE);
                }
-       
+
+#if GTK_CHECK_VERSION(3,0,0)
        gtk_tree_view_column_set_resizable(column, TRUE);
+#endif
        gtk_tree_view_column_set_sort_column_id(column, n);
 
        renderer = gtk_cell_renderer_text_new();
@@ -301,21 +260,45 @@ static void advanced_exif_add_column(GtkWidget *listview, const gchar *title, gi
        gtk_tree_view_append_column(GTK_TREE_VIEW(listview), column);
 }
 
-void advanced_exif_close(GtkWidget *window)
+static void advanced_exif_window_get_geometry(ExifWin *ew)
 {
-       ExifWin *ew;
+       GdkWindow *window;
+       LayoutWindow *lw = NULL;
 
-       ew = g_object_get_data(G_OBJECT(window), "advanced_exif_data");
+       layout_valid(&lw);
+
+       if (!ew || !lw) return;
+
+       window = gtk_widget_get_window(ew->window);
+       gdk_window_get_position(window, &lw->options.advanced_exif_window.x, &lw->options.advanced_exif_window.y);
+       lw->options.advanced_exif_window.w = gdk_window_get_width(window);
+       lw->options.advanced_exif_window.h = gdk_window_get_height(window);
+}
+
+void advanced_exif_close(ExifWin *ew)
+{
        if (!ew) return;
 
-       gtk_widget_destroy(ew->vbox);
+       advanced_exif_window_get_geometry(ew);
+       file_data_unref(ew->fd);
+
+       gtk_widget_destroy(ew->window);
+
+       g_free(ew);
 }
 
-static void advanced_exif_destroy(GtkWidget *widget, gpointer data)
+static gboolean advanced_exif_delete_cb(GtkWidget *widget, GdkEvent *event, gpointer data)
 {
        ExifWin *ew = data;
+
+       if (!ew) return FALSE;
+
+       advanced_exif_window_get_geometry(ew);
        file_data_unref(ew->fd);
+
        g_free(ew);
+
+       return FALSE;
 }
 
 static gint advanced_exif_sort_cb(GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b, gpointer data)
@@ -359,7 +342,90 @@ static gint advanced_exif_sort_cb(GtkTreeModel *model, GtkTreeIter *a, GtkTreeIt
        return ret;
 }
 
-GtkWidget *advanced_exif_new(void)
+static gboolean advanced_exif_mouseclick(GtkWidget *widget,
+                                               GdkEventButton *bevent, gpointer data)
+{
+       ExifWin *ew = data;
+       GtkTreePath *path;
+       GtkTreeViewColumn *column;
+       GtkTreeIter iter;
+       GtkTreeModel *store;
+       gchar *value;
+       GList *cols;
+       gint col_num;
+       GtkClipboard *clipboard;
+
+       gtk_tree_view_get_cursor(GTK_TREE_VIEW(ew->listview), &path, &column);
+       if (path && column)
+               {
+               store = gtk_tree_view_get_model(GTK_TREE_VIEW(ew->listview));
+               gtk_tree_model_get_iter(store, &iter, path);
+
+               cols = gtk_tree_view_get_columns(GTK_TREE_VIEW(ew->listview));
+               col_num = g_list_index(cols, (gpointer)column);
+               gtk_tree_model_get(store, &iter, display_order[col_num], &value, -1);
+
+               clipboard = gtk_clipboard_get(GDK_SELECTION_PRIMARY);
+               gtk_clipboard_set_text(clipboard, value, -1);
+
+               g_list_free(cols);
+               g_free(value);
+
+               gtk_tree_view_set_search_column(GTK_TREE_VIEW(ew->listview), gtk_tree_view_column_get_sort_column_id(column));
+               }
+
+       return TRUE;
+}
+
+static gboolean advanced_exif_keypress(GtkWidget *widget, GdkEventKey *event, gpointer data)
+{
+       ExifWin *ew = data;
+       gboolean stop_signal = FALSE;
+
+       if (event->state & GDK_CONTROL_MASK)
+               {
+               switch (event->keyval)
+                       {
+                       case 'W': case 'w':
+                               advanced_exif_close(ew);
+                               stop_signal = TRUE;
+                               break;
+                       }
+               } // if (event->state & GDK_CONTROL...
+       if (!stop_signal && is_help_key(event))
+               {
+               help_window_show("GuideOtherWindowsExif.html");
+               stop_signal = TRUE;
+               }
+
+       return stop_signal;
+} // static gboolean advanced_exif_...
+
+static gboolean search_function_cb(GtkTreeModel *model, gint column, const gchar *key, GtkTreeIter *iter, gpointer data)
+{
+       gboolean ret = TRUE;
+       gchar *field_contents;
+       gchar *field_contents_nocase;
+       gchar *key_nocase;
+
+       gtk_tree_model_get(model, iter, column, &field_contents, -1);
+
+       field_contents_nocase = g_utf8_casefold(field_contents, -1);
+       key_nocase = g_utf8_casefold(key, -1);
+
+       if (g_strstr_len(field_contents_nocase, -1, key_nocase))
+               {
+               ret = FALSE;
+               }
+
+       g_free(field_contents);
+       g_free(field_contents_nocase);
+       g_free(key_nocase);
+
+       return ret;
+}
+
+GtkWidget *advanced_exif_new(LayoutWindow *lw)
 {
        ExifWin *ew;
        GtkListStore *store;
@@ -371,6 +437,7 @@ GtkWidget *advanced_exif_new(void)
        ew = g_new0(ExifWin, 1);
 
        ew->window = window_new(GTK_WINDOW_TOPLEVEL, "view", NULL, NULL, _("Metadata"));
+       DEBUG_NAME(ew->window);
 
        geometry.min_width = 900;
        geometry.min_height = 600;
@@ -378,9 +445,14 @@ GtkWidget *advanced_exif_new(void)
 
        gtk_window_set_resizable(GTK_WINDOW(ew->window), TRUE);
 
+       gtk_window_resize(GTK_WINDOW(ew->window), lw->options.advanced_exif_window.w, lw->options.advanced_exif_window.h);
+       if (lw->options.advanced_exif_window.x != 0 && lw->options.advanced_exif_window.y != 0)
+               {
+               gtk_window_move(GTK_WINDOW(ew->window), lw->options.advanced_exif_window.x, lw->options.advanced_exif_window.y);
+               }
+
        g_object_set_data(G_OBJECT(ew->window), "advanced_exif_data", ew);
-       g_signal_connect_after(G_OBJECT(ew->window), "destroy",
-                              G_CALLBACK(advanced_exif_destroy), ew);
+       g_signal_connect(G_OBJECT(ew->window), "delete_event", G_CALLBACK(advanced_exif_delete_cb), ew);
 
        ew->vbox = gtk_vbox_new(FALSE, PREF_PAD_GAP);
        gtk_container_add(GTK_CONTAINER(ew->window), ew->vbox);
@@ -391,7 +463,12 @@ GtkWidget *advanced_exif_new(void)
        ew->label_file_name = gtk_label_new("");
        gtk_label_set_ellipsize(GTK_LABEL(ew->label_file_name), PANGO_ELLIPSIZE_START);
        gtk_label_set_selectable(GTK_LABEL(ew->label_file_name), TRUE);
+#if GTK_CHECK_VERSION(3,16,0)
+       gtk_label_set_xalign(GTK_LABEL(ew->label_file_name), 0.5);
+       gtk_label_set_yalign(GTK_LABEL(ew->label_file_name), 0.5);
+#else
        gtk_misc_set_alignment(GTK_MISC(ew->label_file_name), 0.5, 0.5);
+#endif
        gtk_box_pack_start(GTK_BOX(box), ew->label_file_name, TRUE, TRUE, 0);
        gtk_widget_show(ew->label_file_name);
 
@@ -424,7 +501,10 @@ GtkWidget *advanced_exif_new(void)
        advanced_exif_add_column(ew->listview, _("Tag"), EXIF_ADVCOL_TAG, FALSE);
        advanced_exif_add_column(ew->listview, _("Format"), EXIF_ADVCOL_FORMAT, FALSE);
        advanced_exif_add_column(ew->listview, _("Elements"), EXIF_ADVCOL_ELEMENTS, FALSE);
-       
+
+       gtk_tree_view_set_enable_search(GTK_TREE_VIEW(ew->listview), TRUE);
+       gtk_tree_view_set_search_column(GTK_TREE_VIEW(ew->listview), EXIF_ADVCOL_DESCRIPTION);
+       gtk_tree_view_set_search_equal_func(GTK_TREE_VIEW(ew->listview), search_function_cb, ew, NULL);
 
        gtk_drag_source_set(ew->listview,
                           GDK_BUTTON1_MASK | GDK_BUTTON2_MASK,
@@ -437,6 +517,12 @@ GtkWidget *advanced_exif_new(void)
        g_signal_connect(G_OBJECT(ew->listview), "drag_begin",
                         G_CALLBACK(advanced_exif_dnd_begin), ew);
 
+       g_signal_connect(G_OBJECT(ew->window), "key_press_event",
+                        G_CALLBACK(advanced_exif_keypress), ew);
+
+       g_signal_connect(G_OBJECT(ew->listview), "button_release_event",
+                       G_CALLBACK(advanced_exif_mouseclick), ew);
+
        ew->scrolled = gtk_scrolled_window_new(NULL, NULL);
        gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(ew->scrolled), GTK_SHADOW_IN);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(ew->scrolled),