Change sidebar rating pane layout
[geeqie.git] / src / bar.c
index 3e956d2..9d81b73 100644 (file)
--- a/src/bar.c
+++ b/src/bar.c
@@ -1,16 +1,24 @@
 /*
- * Geeqie
- * (C) 2004 John Ellis
- * Copyright (C) 2008 - 2009 The Geeqie Team
+ * Copyright (C) 2004 John Ellis
+ * Copyright (C) 2008 - 2016 The Geeqie Team
  *
  * Author: Vladimir Nadvornik
  *
- * This software is released under the GNU General Public License (GNU GPL).
- * Please read the included file COPYING for more information.
- * This software comes with no warranty of any kind, use at your own risk!
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-
 #include "main.h"
 #include "bar.h"
 
@@ -29,6 +37,9 @@
 #include "bar_histogram.h"
 #include "histogram.h"
 #include "rcfile.h"
+#include "bar_gps.h"
+
+#include <gdk/gdkkeysyms.h>
 
 typedef struct _KnownPanes KnownPanes;
 struct _KnownPanes
@@ -39,7 +50,7 @@ struct _KnownPanes
        const gchar *config;
 };
 
-static const gchar default_config_histogram[] = 
+static const gchar default_config_histogram[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -48,7 +59,7 @@ static const gchar default_config_histogram[] =
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_title[] = 
+static const gchar default_config_title[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -57,7 +68,16 @@ static const gchar default_config_title[] =
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_keywords[] = 
+static const gchar default_config_headline[] =
+"<gq>"
+"    <layout id = '_current_'>"
+"        <bar>"
+"            <pane_comment id = 'headline' expanded = 'true' key = 'Xmp.photoshop.Headline'  height = '40' />"
+"        </bar>"
+"    </layout>"
+"</gq>";
+
+static const gchar default_config_keywords[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -66,7 +86,7 @@ static const gchar default_config_keywords[] =
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_comment[] = 
+static const gchar default_config_comment[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -74,14 +94,23 @@ static const gchar default_config_comment[] =
 "        </bar>"
 "    </layout>"
 "</gq>";
+static const gchar default_config_rating[] =
+"<gq>"
+"    <layout id = '_current_'>"
+"        <bar>"
+"            <pane_rating id = 'rating' expanded = 'true' />"
+"        </bar>"
+"    </layout>"
+"</gq>";
 
-static const gchar default_config_exif[] = 
+static const gchar default_config_exif[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
 "            <pane_exif id = 'exif' expanded = 'true' >"
 "                <entry key = 'formatted.Camera' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.DateTime' if_set = 'true' editable = 'false' />"
+"                <entry key = 'formatted.localtime' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.ShutterSpeed' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.Aperture' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.ExposureBias' if_set = 'true' editable = 'false' />"
@@ -95,13 +124,14 @@ static const gchar default_config_exif[] =
 "                <entry key = 'formatted.ColorProfile' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.SubjectDistance' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.Resolution' if_set = 'true' editable = 'false' />"
-"                <entry key = 'Exif.Image.Orientation' if_set = 'true' editable = 'false' />"
+"                <entry key = '" ORIENTATION_KEY "' if_set = 'true' editable = 'false' />"
+"                <entry key = 'formatted.star_rating' if_set = 'true' editable = 'false' />"
 "            </pane_exif>"
 "        </bar>"
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_file_info[] = 
+static const gchar default_config_file_info[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -109,18 +139,23 @@ static const gchar default_config_file_info[] =
 "                <entry key = 'file.mode' if_set = 'false' editable = 'false' />"
 "                <entry key = 'file.date' if_set = 'false' editable = 'false' />"
 "                <entry key = 'file.size' if_set = 'false' editable = 'false' />"
+"                <entry key = 'file.owner' if_set = 'false' editable = 'false' />"
+"                <entry key = 'file.group' if_set = 'false' editable = 'false' />"
+"                <entry key = 'file.class' if_set = 'false' editable = 'false' />"
+"                <entry key = 'file.link' if_set = 'false' editable = 'false' />"
 "            </pane_exif>"
 "        </bar>"
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_location[] = 
+static const gchar default_config_location[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
 "            <pane_exif id = 'location' expanded = 'true' >"
 "                <entry key = 'formatted.GPSPosition' if_set = 'true' editable = 'false' />"
 "                <entry key = 'formatted.GPSAltitude' if_set = 'true' editable = 'false' />"
+"                <entry key = 'formatted.timezone' if_set = 'true' editable = 'false' />"
 "                <entry key = 'Xmp.photoshop.Country' if_set = 'false' editable = 'true' />"
 "                <entry key = 'Xmp.iptc.CountryCode' if_set = 'false' editable = 'true' />"
 "                <entry key = 'Xmp.photoshop.State' if_set = 'false' editable = 'true' />"
@@ -131,7 +166,7 @@ static const gchar default_config_location[] =
 "    </layout>"
 "</gq>";
 
-static const gchar default_config_copyright[] = 
+static const gchar default_config_copyright[] =
 "<gq>"
 "    <layout id = '_current_'>"
 "        <bar>"
@@ -144,18 +179,41 @@ static const gchar default_config_copyright[] =
 "    </layout>"
 "</gq>";
 
+#ifdef HAVE_LIBCHAMPLAIN
+#ifdef HAVE_LIBCHAMPLAIN_GTK
+static const gchar default_config_gps[] =
+"<gq>"
+"    <layout id = '_current_'>"
+"        <bar>"
+"            <pane_gps id = 'gps' expanded = 'true'"
+"                      map-id = 'osm::mapnik'"
+"                      zoom-level = '8'"
+"                      latitude = '50116666'"
+"                      longitude = '8683333' />"
+"        </bar>"
+"    </layout>"
+"</gq>";
+#endif
+#endif
+
 static const KnownPanes known_panes[] = {
 /* default sidebar */
        {PANE_HISTOGRAM,        "histogram",    N_("Histogram"),        default_config_histogram},
        {PANE_COMMENT,          "title",        N_("Title"),            default_config_title},
        {PANE_KEYWORDS,         "keywords",     N_("Keywords"),         default_config_keywords},
        {PANE_COMMENT,          "comment",      N_("Comment"),          default_config_comment},
+       {PANE_RATING,           "rating",       N_("Star Rating"),      default_config_rating},
+       {PANE_COMMENT,          "headline",     N_("Headline"),         default_config_headline},
        {PANE_EXIF,             "exif",         N_("Exif"),             default_config_exif},
 /* other pre-configured panes */
        {PANE_EXIF,             "file_info",    N_("File info"),        default_config_file_info},
-       {PANE_EXIF,             "location",     N_("Location"),         default_config_location},
+       {PANE_EXIF,             "location",     N_("Location and GPS"), default_config_location},
        {PANE_EXIF,             "copyright",    N_("Copyright"),        default_config_copyright},
-
+#ifdef HAVE_LIBCHAMPLAIN
+#ifdef HAVE_LIBCHAMPLAIN_GTK
+       {PANE_GPS,              "gps",  N_("GPS Map"),  default_config_gps},
+#endif
+#endif
        {PANE_UNDEF,            NULL,           NULL,                   NULL}
 };
 
@@ -166,6 +224,7 @@ struct _BarData
        GtkWidget *vbox;
        FileData *fd;
        GtkWidget *label_file_name;
+       GtkWidget *add_button;
 
        LayoutWindow *lw;
        gint width;
@@ -180,9 +239,9 @@ static void bar_expander_move(GtkWidget *widget, gpointer data, gboolean up, gbo
        if (!expander) return;
        box = gtk_widget_get_ancestor(expander, GTK_TYPE_BOX);
        if (!box) return;
-       
+
        gtk_container_child_get(GTK_CONTAINER(box), expander, "position", &pos, NULL);
-       
+
        if (single_step)
                {
                pos = up ? (pos - 1) : (pos + 1);
@@ -192,7 +251,7 @@ static void bar_expander_move(GtkWidget *widget, gpointer data, gboolean up, gbo
                {
                pos = up ? 0 : -1;
                }
-       
+
        gtk_box_reorder_child(GTK_BOX(box), expander, pos);
 }
 
@@ -217,6 +276,72 @@ static void bar_expander_move_bottom_cb(GtkWidget *widget, gpointer data)
        bar_expander_move(widget, data, FALSE, FALSE);
 }
 
+static void height_spin_changed_cb(GtkSpinButton *spin, gpointer data)
+{
+
+       gtk_widget_set_size_request(GTK_WIDGET(data), -1, gtk_spin_button_get_value_as_int(spin));
+}
+
+static gboolean height_spin_key_press_cb(GtkWidget *widget, GdkEventKey *event, gpointer data)
+{
+       if ((event->keyval == GDK_KEY_Return || event->keyval == GDK_KEY_Escape))
+               {
+               gtk_widget_destroy(GTK_WIDGET(data));
+               }
+
+       return TRUE;
+}
+
+static void bar_expander_height_cb(GtkWidget *widget, gpointer data)
+{
+       GtkWidget *expander = data;
+       GtkWidget *spin;
+       GtkWidget *window;
+       GtkWidget *data_box;
+       GList *list;
+       gint x, y;
+       gint w, h;
+#if GTK_CHECK_VERSION(3,0,0)
+       GdkDisplay *display;
+       GdkDeviceManager *device_manager;
+       GdkDevice *device;
+#endif
+
+#if GTK_CHECK_VERSION(3,0,0)
+       display = gdk_display_get_default();
+       device_manager = gdk_display_get_device_manager(display);
+       device = gdk_device_manager_get_client_pointer(device_manager);
+       gdk_device_get_position(device, NULL, &x, &y);
+#else
+       gdk_window_get_pointer(NULL, &x, &y, NULL);
+#endif
+
+       list = gtk_container_get_children(GTK_CONTAINER(expander));
+       data_box = list->data;
+
+       window = gtk_window_new(GTK_WINDOW_POPUP);
+
+       gtk_window_set_modal(GTK_WINDOW(window), TRUE);
+       gtk_window_set_keep_above(GTK_WINDOW(window), TRUE);
+       gtk_window_set_default_size(GTK_WINDOW(window), 50, 30); //** @FIXME set these values in a more sensible way */
+
+       gtk_window_move(GTK_WINDOW(window), x, y);
+       gtk_widget_show(window);
+
+       gtk_widget_get_size_request(GTK_WIDGET(data_box), &w, &h);
+
+       spin = gtk_spin_button_new_with_range(1, 1000, 1);
+       g_signal_connect(G_OBJECT(spin), "value-changed", G_CALLBACK(height_spin_changed_cb), data_box);
+       g_signal_connect(G_OBJECT(spin), "key-press-event", G_CALLBACK(height_spin_key_press_cb), window);
+
+       gtk_spin_button_set_value(GTK_SPIN_BUTTON(spin), h);
+       gtk_container_add(GTK_CONTAINER(window), spin);
+       gtk_widget_show(spin);
+       gtk_widget_grab_focus(GTK_WIDGET(spin));
+
+       g_list_free(list);
+}
+
 static void bar_expander_delete_cb(GtkWidget *widget, gpointer data)
 {
        GtkWidget *expander = data;
@@ -231,14 +356,14 @@ static void bar_expander_add_cb(GtkWidget *widget, gpointer data)
        const gchar *config;
 
        if (!id) return;
-       
+
        while (pane->id)
                {
                if (strcmp(pane->id, id) == 0) break;
                pane++;
                }
        if (!pane->id) return;
-       
+
        config = bar_pane_get_default_config(id);
        if (config) load_config_from_buf(config, strlen(config), FALSE);
 
@@ -250,24 +375,33 @@ static void bar_menu_popup(GtkWidget *widget)
        GtkWidget *menu;
        GtkWidget *bar;
        GtkWidget *expander;
-       const KnownPanes *pane = known_panes;
        BarData *bd;
+       gboolean display_height_option = FALSE;
+       gchar const *label;
+
+       label = gtk_expander_get_label(GTK_EXPANDER(widget));
+       display_height_option = (g_strcmp0(label, "Comment") == 0) ||
+                                                       (g_strcmp0(label, "Rating") == 0) ||
+                                                       (g_strcmp0(label, "Title") == 0) ||
+                                                       (g_strcmp0(label, "Headline") == 0) ||
+                                                       (g_strcmp0(label, "Keywords") == 0) ||
+                                                       (g_strcmp0(label, "GPS Map") == 0);
 
        bd = g_object_get_data(G_OBJECT(widget), "bar_data");
-       if (bd) 
+       if (bd)
                {
                expander = NULL;
-               bar = widget; 
+               bar = widget;
                }
        else
                {
                expander = widget;
-               bar = widget->parent;
+               bar = gtk_widget_get_parent(widget);
                while (bar && !g_object_get_data(G_OBJECT(bar), "bar_data"))
-                       bar = bar->parent;
+                       bar = gtk_widget_get_parent(bar);
                if (!bar) return;
                }
+
        menu = popup_menu_short_lived();
 
        if (expander)
@@ -277,10 +411,30 @@ static void bar_menu_popup(GtkWidget *widget)
                menu_item_add_stock(menu, _("Move _down"), GTK_STOCK_GO_DOWN, G_CALLBACK(bar_expander_move_down_cb), expander);
                menu_item_add_stock(menu, _("Move to _bottom"), GTK_STOCK_GOTO_BOTTOM, G_CALLBACK(bar_expander_move_bottom_cb), expander);
                menu_item_add_divider(menu);
-               menu_item_add_stock(menu, _("Delete"), GTK_STOCK_DELETE, G_CALLBACK(bar_expander_delete_cb), expander);
+
+               if (gtk_expander_get_expanded(GTK_EXPANDER(expander)) && display_height_option)
+                       {
+                       menu_item_add_stock(menu, _("Height..."), GTK_STOCK_PREFERENCES, G_CALLBACK(bar_expander_height_cb), expander);
+                       menu_item_add_divider(menu);
+                       }
+
+               menu_item_add_stock(menu, _("Remove"), GTK_STOCK_DELETE, G_CALLBACK(bar_expander_delete_cb), expander);
                menu_item_add_divider(menu);
                }
 
+       gtk_menu_popup(GTK_MENU(menu), NULL, NULL, NULL, bar, 0, GDK_CURRENT_TIME);
+}
+
+static void bar_menu_add_popup(GtkWidget *widget)
+{
+       GtkWidget *menu;
+       GtkWidget *bar;
+       const KnownPanes *pane = known_panes;
+
+       bar = widget;
+
+       menu = popup_menu_short_lived();
+
        while (pane->id)
                {
                GtkWidget *item;
@@ -288,20 +442,44 @@ static void bar_menu_popup(GtkWidget *widget)
                g_object_set_data(G_OBJECT(item), "pane_add_id", pane->id);
                pane++;
                }
-       
+
        gtk_menu_popup(GTK_MENU(menu), NULL, NULL, NULL, bar, 0, GDK_CURRENT_TIME);
 }
 
 
-static gboolean bar_menu_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer data) 
-{ 
+static gboolean bar_menu_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer data)
+{
        if (bevent->button == MOUSE_BUTTON_RIGHT)
                {
                bar_menu_popup(widget);
                return TRUE;
                }
        return FALSE;
-} 
+}
+
+static void bar_expander_cb(GObject *object, GParamSpec *param_spec, gpointer data)
+{
+       GtkExpander *expander;
+       GtkWidget *child;
+
+       expander = GTK_EXPANDER(object);
+       child = gtk_bin_get_child(GTK_BIN(expander));
+
+       if (gtk_expander_get_expanded(expander))
+               {
+               gtk_widget_show_all(child);
+               }
+       else
+               {
+               gtk_widget_hide(child);
+               }
+}
+
+static gboolean bar_menu_add_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer data)
+{
+       bar_menu_add_popup(widget);
+       return TRUE;
+}
 
 
 static void bar_pane_set_fd_cb(GtkWidget *expander, gpointer data)
@@ -322,7 +500,7 @@ void bar_set_fd(GtkWidget *bar, FileData *fd)
        bd->fd = file_data_ref(fd);
 
        gtk_container_foreach(GTK_CONTAINER(bd->vbox), bar_pane_set_fd_cb, fd);
-       
+
        gtk_label_set_text(GTK_LABEL(bd->label_file_name), (bd->fd) ? bd->fd->name : "");
 
 }
@@ -349,19 +527,19 @@ gboolean bar_event(GtkWidget *bar, GdkEvent *event)
        BarData *bd;
        GList *list, *work;
        gboolean ret = FALSE;
-       
+
        bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        if (!bd) return FALSE;
 
        list = gtk_container_get_children(GTK_CONTAINER(bd->vbox));
-       
+
        work = list;
        while (work)
                {
                GtkWidget *widget = gtk_bin_get_child(GTK_BIN(work->data));
                PaneData *pd = g_object_get_data(G_OBJECT(widget), "pane_data");
                if (!pd) continue;
-       
+
                if (pd->pane_event && pd->pane_event(widget, event))
                        {
                        ret = TRUE;
@@ -378,21 +556,21 @@ GtkWidget *bar_find_pane_by_id(GtkWidget *bar, PaneType type, const gchar *id)
        BarData *bd;
        GList *list, *work;
        GtkWidget *ret = NULL;
-       
+
        if (!id || !id[0]) return NULL;
-       
+
        bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        if (!bd) return NULL;
 
        list = gtk_container_get_children(GTK_CONTAINER(bd->vbox));
-       
+
        work = list;
        while (work)
                {
                GtkWidget *widget = gtk_bin_get_child(GTK_BIN(work->data));
                PaneData *pd = g_object_get_data(G_OBJECT(widget), "pane_data");
                if (!pd) continue;
-       
+
                if (type == pd->type && strcmp(id, pd->id) == 0)
                        {
                        ret = widget;
@@ -408,12 +586,12 @@ void bar_clear(GtkWidget *bar)
 {
        BarData *bd;
        GList *list, *work;
-       
+
        bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        if (!bd) return;
 
        list = gtk_container_get_children(GTK_CONTAINER(bd->vbox));
-       
+
        work = list;
        while (work)
                {
@@ -430,19 +608,19 @@ void bar_write_config(GtkWidget *bar, GString *outstr, gint indent)
        GList *list, *work;
 
        if (!bar) return;
-       
+
        bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        if (!bd) return;
 
        WRITE_NL(); WRITE_STRING("<bar ");
-       write_bool_option(outstr, indent, "enabled", GTK_WIDGET_VISIBLE(bar));
+       write_bool_option(outstr, indent, "enabled", gtk_widget_get_visible(bar));
        write_uint_option(outstr, indent, "width", bd->width);
        WRITE_STRING(">");
-       
+
        indent++;
        WRITE_NL(); WRITE_STRING("<clear/>");
 
-       list = gtk_container_get_children(GTK_CONTAINER(bd->vbox));     
+       list = gtk_container_get_children(GTK_CONTAINER(bd->vbox));
        work = list;
        while (work)
                {
@@ -467,11 +645,11 @@ void bar_update_expander(GtkWidget *pane)
 {
        PaneData *pd = g_object_get_data(G_OBJECT(pane), "pane_data");
        GtkWidget *expander;
-       
+
        if (!pd) return;
 
-       expander = pane->parent;
-       
+       expander = gtk_widget_get_parent(pane);
+
        gtk_expander_set_expanded(GTK_EXPANDER(expander), pd->expanded);
 }
 
@@ -480,25 +658,27 @@ void bar_add(GtkWidget *bar, GtkWidget *pane)
        GtkWidget *expander;
        BarData *bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        PaneData *pd = g_object_get_data(G_OBJECT(pane), "pane_data");
-       
+
        if (!bd) return;
 
        pd->lw = bd->lw;
        pd->bar = bar;
-       
+
        expander = gtk_expander_new(NULL);
+       DEBUG_NAME(expander);
        if (pd && pd->title)
                {
                gtk_expander_set_label_widget(GTK_EXPANDER(expander), pd->title);
                gtk_widget_show(pd->title);
                }
-               
+
        gtk_box_pack_start(GTK_BOX(bd->vbox), expander, FALSE, TRUE, 0);
-       
-       g_signal_connect(expander, "button_press_event", G_CALLBACK(bar_menu_cb), bd); 
-       
+
+       g_signal_connect(expander, "button_release_event", G_CALLBACK(bar_menu_cb), bd);
+       g_signal_connect(expander, "notify::expanded", G_CALLBACK(bar_expander_cb), pd);
+
        gtk_container_add(GTK_CONTAINER(expander), pane);
-       
+
        gtk_expander_set_expanded(GTK_EXPANDER(expander), pd->expanded);
 
        gtk_widget_show(expander);
@@ -509,9 +689,9 @@ void bar_add(GtkWidget *bar, GtkWidget *pane)
 
 void bar_populate_default(GtkWidget *bar)
 {
-       const gchar *populate_id[] = {"histogram", "title", "keywords", "comment", "exif", NULL};
+       const gchar *populate_id[] = {"histogram", "title", "keywords", "comment", "rating", "exif", NULL};
        const gchar **id = populate_id;
-       
+
        while (*id)
                {
                const gchar *config = bar_pane_get_default_config(*id);
@@ -523,14 +703,14 @@ void bar_populate_default(GtkWidget *bar)
 static void bar_size_allocate(GtkWidget *widget, GtkAllocation *allocation, gpointer data)
 {
        BarData *bd = data;
-       
-       bd->width = allocation->width;
+
+       bd->width = gtk_paned_get_position(GTK_PANED(bd->lw->utility_paned));
 }
 
 gint bar_get_width(GtkWidget *bar)
 {
        BarData *bd;
-       
+
        bd = g_object_get_data(G_OBJECT(bar), "bar_data");
        if (!bd) return 0;
 
@@ -555,17 +735,35 @@ static void bar_destroy(GtkWidget *widget, gpointer data)
        g_free(bd);
 }
 
+#ifdef HAVE_LIBCHAMPLAIN_GTK
+/**
+   @FIXME this is an ugly hack that works around this bug:
+   https://bugzilla.gnome.org/show_bug.cgi?id=590692
+   http://bugzilla.openedhand.com/show_bug.cgi?id=1751
+   it should be removed as soon as a better solution exists
+*/
+
+static void bar_unrealize_clutter_fix_cb(GtkWidget *widget, gpointer data)
+{
+       GtkWidget *child = gtk_bin_get_child(GTK_BIN(widget));
+       if (child) gtk_widget_unrealize(child);
+}
+#endif
+
 GtkWidget *bar_new(LayoutWindow *lw)
 {
        BarData *bd;
        GtkWidget *box;
        GtkWidget *scrolled;
+       GtkWidget *tbar;
+       GtkWidget *add_box;
 
        bd = g_new0(BarData, 1);
 
        bd->lw = lw;
-       
+
        bd->widget = gtk_vbox_new(FALSE, PREF_PAD_GAP);
+       DEBUG_NAME(bd->widget);
        g_object_set_data(G_OBJECT(bd->widget), "bar_data", bd);
        g_signal_connect(G_OBJECT(bd->widget), "destroy",
                         G_CALLBACK(bar_destroy), bd);
@@ -573,17 +771,22 @@ GtkWidget *bar_new(LayoutWindow *lw)
        g_signal_connect(G_OBJECT(bd->widget), "size-allocate",
                         G_CALLBACK(bar_size_allocate), bd);
 
-       g_signal_connect(G_OBJECT(bd->widget), "button_press_event", G_CALLBACK(bar_menu_cb), bd); 
+       g_signal_connect(G_OBJECT(bd->widget), "button_release_event", G_CALLBACK(bar_menu_cb), bd);
 
        bd->width = SIDEBAR_DEFAULT_WIDTH;
-       gtk_widget_set_size_request(bd->widget, bd->width, -1);
 
        box = gtk_hbox_new(FALSE, 0);
+       DEBUG_NAME(box);
 
        bd->label_file_name = gtk_label_new("");
        gtk_label_set_ellipsize(GTK_LABEL(bd->label_file_name), PANGO_ELLIPSIZE_END);
        gtk_label_set_selectable(GTK_LABEL(bd->label_file_name), TRUE);
+#if GTK_CHECK_VERSION(3,16,0)
+       gtk_label_set_xalign(GTK_LABEL(bd->label_file_name), 0.5);
+       gtk_label_set_yalign(GTK_LABEL(bd->label_file_name), 0.5);
+#else
        gtk_misc_set_alignment(GTK_MISC(bd->label_file_name), 0.5, 0.5);
+#endif
        gtk_box_pack_start(GTK_BOX(box), bd->label_file_name, TRUE, TRUE, 0);
        gtk_widget_show(bd->label_file_name);
 
@@ -591,6 +794,7 @@ GtkWidget *bar_new(LayoutWindow *lw)
        gtk_widget_show(box);
 
        scrolled = gtk_scrolled_window_new(NULL, NULL);
+       DEBUG_NAME(scrolled);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolled),
                GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
        gtk_box_pack_start(GTK_BOX(bd->widget), scrolled, TRUE, TRUE, 0);
@@ -600,14 +804,27 @@ GtkWidget *bar_new(LayoutWindow *lw)
        bd->vbox = gtk_vbox_new(FALSE, 0);
        gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scrolled), bd->vbox);
        gtk_viewport_set_shadow_type(GTK_VIEWPORT(gtk_bin_get_child(GTK_BIN(scrolled))), GTK_SHADOW_NONE);
-       
+
+       add_box = gtk_vbox_new(FALSE, 0);
+       DEBUG_NAME(add_box);
+       gtk_box_pack_end(GTK_BOX(bd->widget), add_box, FALSE, FALSE, 0);
+       tbar = pref_toolbar_new(add_box, GTK_TOOLBAR_ICONS);
+       bd->add_button = pref_toolbar_button(tbar, GTK_STOCK_ADD, NULL, FALSE,
+                                            _("Add Pane"),
+                                            G_CALLBACK(bar_menu_add_cb), bd);
+       gtk_widget_show(add_box);
+
+#ifdef HAVE_LIBCHAMPLAIN_GTK
+       g_signal_connect(G_OBJECT(gtk_bin_get_child(GTK_BIN(scrolled))), "unrealize", G_CALLBACK(bar_unrealize_clutter_fix_cb), NULL);
+#endif
+
        gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(scrolled), GTK_SHADOW_NONE);
        gtk_widget_show(bd->vbox);
        return bd->widget;
 }
 
 
-GtkWidget *bar_update_from_config(GtkWidget *bar, const gchar **attribute_names, const gchar **attribute_values)
+GtkWidget *bar_update_from_config(GtkWidget *bar, const gchar **attribute_names, const gchar **attribute_values, LayoutWindow *lw)
 {
        gboolean enabled = TRUE;
        gint width = SIDEBAR_DEFAULT_WIDTH;
@@ -619,13 +836,14 @@ GtkWidget *bar_update_from_config(GtkWidget *bar, const gchar **attribute_names,
 
                if (READ_BOOL_FULL("enabled", enabled)) continue;
                if (READ_INT_FULL("width", width)) continue;
-               
+
 
                log_printf("unknown attribute %s = %s\n", option, value);
                }
-       
-       gtk_widget_set_size_request(bar, width, -1);
-       if (enabled) 
+
+       gtk_paned_set_position(GTK_PANED(lw->utility_paned), width);
+
+       if (enabled)
                {
                gtk_widget_show(bar);
                }
@@ -639,7 +857,7 @@ GtkWidget *bar_update_from_config(GtkWidget *bar, const gchar **attribute_names,
 GtkWidget *bar_new_from_config(LayoutWindow *lw, const gchar **attribute_names, const gchar **attribute_values)
 {
        GtkWidget *bar = bar_new(lw);
-       return bar_update_from_config(bar, attribute_names, attribute_values);
+       return bar_update_from_config(bar, attribute_names, attribute_values, lw);
 }
 
 GtkWidget *bar_pane_expander_title(const gchar *title)
@@ -647,7 +865,8 @@ GtkWidget *bar_pane_expander_title(const gchar *title)
        GtkWidget *widget = gtk_label_new(title);
 
        pref_label_bold(widget, TRUE, FALSE);
-       //gtk_label_set_ellipsize(GTK_LABEL(widget), PANGO_ELLIPSIZE_END); //FIXME: do not work
+       //gtk_label_set_ellipsize(GTK_LABEL(widget), PANGO_ELLIPSIZE_END);
+       /** @FIXME do not work */
 
        return widget;
 }
@@ -655,7 +874,7 @@ GtkWidget *bar_pane_expander_title(const gchar *title)
 gboolean bar_pane_translate_title(PaneType type, const gchar *id, gchar **title)
 {
        const KnownPanes *pane = known_panes;
-       
+
        if (!title) return FALSE;
        while (pane->id)
                {
@@ -663,9 +882,9 @@ gboolean bar_pane_translate_title(PaneType type, const gchar *id, gchar **title)
                pane++;
                }
        if (!pane->id) return FALSE;
-       
+
        if (*title && **title && strcmp(pane->title, *title) != 0) return FALSE;
-       
+
        g_free(*title);
        *title = g_strdup(_(pane->title));
        return TRUE;
@@ -674,7 +893,7 @@ gboolean bar_pane_translate_title(PaneType type, const gchar *id, gchar **title)
 const gchar *bar_pane_get_default_config(const gchar *id)
 {
        const KnownPanes *pane = known_panes;
-       
+
        while (pane->id)
                {
                if (strcmp(pane->id, id) == 0) break;
@@ -683,5 +902,5 @@ const gchar *bar_pane_get_default_config(const gchar *id)
        if (!pane->id) return NULL;
        return pane->config;
 }
-       
+
 /* vim: set shiftwidth=8 softtabstop=0 cindent cinoptions={1s: */