Fix crash when loading collection listing inexistent files.
[geeqie.git] / src / collect.c
index f0d09f2..e3c0157 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * Geeqie
  * (C) 2006 John Ellis
- * Copyright (C) 2008 The Geeqie Team
+ * Copyright (C) 2008 - 2012 The Geeqie Team
  *
  * Author: John Ellis
  *
@@ -20,7 +20,6 @@
 #include "editors.h"
 #include "filedata.h"
 #include "img-view.h"
-#include "info.h"
 #include "layout.h"
 #include "layout_image.h"
 #include "misc.h"
@@ -95,7 +94,7 @@ void collection_info_set_thumb(CollectInfo *ci, GdkPixbuf *pixbuf)
        ci->pixbuf = pixbuf;
 }
 
-gint collection_info_load_thumb(CollectInfo *ci)
+gboolean collection_info_load_thumb(CollectInfo *ci)
 {
        if (!ci) return FALSE;
 
@@ -103,14 +102,6 @@ gint collection_info_load_thumb(CollectInfo *ci)
 
        log_printf("collection_info_load_thumb not implemented!\n(because an instant thumb loader not implemented)");
        return FALSE;
-#if 0
-       if (create_thumbnail(ci->fd->path, &ci->pixmap, &ci->mask) < 0) return FALSE;
-
-       if (ci->pixmap) gdk_pixmap_ref(ci->pixmap);
-       if (ci->mask) gdk_bitmap_ref(ci->mask);
-
-       return TRUE;
-#endif
 }
 
 void collection_list_free(GList *list)
@@ -133,7 +124,7 @@ static gint collection_list_sort_cb(gconstpointer a, gconstpointer b)
        const CollectInfo *cia = a;
        const CollectInfo *cib = b;
 
-       switch(collection_list_sort_method)
+       switch (collection_list_sort_method)
                {
                case SORT_NAME:
                        break;
@@ -177,6 +168,30 @@ GList *collection_list_sort(GList *list, SortType method)
        return g_list_sort(list, collection_list_sort_cb);
 }
 
+GList *collection_list_randomize(GList *list)
+{
+       guint random, length, i;
+       gpointer tmp;
+       GList *nlist, *olist;
+
+       length = g_list_length(list);
+       if (!length) return NULL;
+
+       srand((unsigned int)time(NULL)); // Initialize random generator (hasn't to be that much strong)
+
+       for (i = 0; i < length; i++)
+               {
+               random = (guint) (1.0 * length * rand()/(RAND_MAX + 1.0));
+               olist = g_list_nth(list, i);
+               nlist = g_list_nth(list, random);
+               tmp = olist->data;
+               olist->data = nlist->data;
+               nlist->data = tmp;
+               }
+
+       return list;
+}
+
 GList *collection_list_add(GList *list, CollectInfo *ci, SortType method)
 {
        if (method != SORT_NONE)
@@ -231,38 +246,6 @@ CollectInfo *collection_list_find_fd(GList *list, FileData *fd)
        return NULL;
 }
 
-#if 0
-static GList *collection_list_find_link(GList *list, gchar *path)
-{
-       GList *work = list;
-
-       while (work)
-               {
-               CollectInfo *ci = work->data;
-               if (strcmp(ci->fd->path, path) == 0) return work;
-               work = work->next;
-               }
-
-       return NULL;
-}
-
-static gint collection_list_find_index(GList *list, gchar *path)
-{
-       gint c = 0;
-       GList *work = list;
-
-       while (work)
-               {
-               CollectInfo *ci = work->data;
-               if (strcmp(ci->fd->path, path) == 0) return c;
-               work = work->next;
-               c++;
-               }
-
-       return -1;
-}
-#endif
-
 GList *collection_list_to_filelist(GList *list)
 {
        GList *filelist = NULL;
@@ -324,23 +307,10 @@ CollectionData *collection_new(const gchar *path)
 
        cd = g_new0(CollectionData, 1);
 
-       collection_list = g_list_append(collection_list, cd);
-
        cd->ref = 1;    /* starts with a ref of 1 */
-
-       cd->list = NULL;
        cd->sort_method = SORT_NONE;
-       cd->thumb_loader = NULL;
-       cd->info_updated_func = NULL;
-
-       cd->window_read = FALSE;
-       cd->window_x = 0;
-       cd->window_y = 0;
        cd->window_w = COLLECT_DEF_WIDTH;
        cd->window_h = COLLECT_DEF_HEIGHT;
-
-       cd->changed = FALSE;
-
        cd->existence = g_hash_table_new(NULL, NULL);
 
        if (path)
@@ -351,8 +321,6 @@ CollectionData *collection_new(const gchar *path)
                }
        else
                {
-               cd->path = NULL;
-
                if (untitled_counter == 0)
                        {
                        cd->name = g_strdup(_("Untitled"));
@@ -367,6 +335,9 @@ CollectionData *collection_new(const gchar *path)
 
        file_data_register_notify_func(collection_notify_cb, cd, NOTIFY_PRIORITY_MEDIUM);
 
+
+       collection_list = g_list_append(collection_list, cd);
+
        return cd;
 }
 
@@ -378,7 +349,7 @@ void collection_free(CollectionData *cd)
 
        collection_load_stop(cd);
        collection_list_free(cd->list);
-       
+
        file_data_unregister_notify_func(collection_notify_cb, cd);
 
        collection_list = g_list_remove(collection_list, cd);
@@ -435,15 +406,15 @@ CollectionData *collection_from_dnd_data(const gchar *data, GList **list, GList
        if (info_list) *info_list = NULL;
 
        if (strncmp(data, "COLLECTION:", 11) != 0) return NULL;
-       
+
        ptr = data + 11;
-               
+
        collection_number = atoi(ptr);
        cd = collection_from_number(collection_number);
        if (!cd) return NULL;
 
        if (!list && !info_list) return cd;
-       
+
        while (*ptr != '\0' && *ptr != '\n' ) ptr++;
        if (*ptr == '\0') return cd;
        ptr++;
@@ -452,7 +423,7 @@ CollectionData *collection_from_dnd_data(const gchar *data, GList **list, GList
                {
                guint item_number;
                CollectInfo *info;
-               
+
                item_number = (guint) atoi(ptr);
                while (*ptr != '\n' && *ptr != '\0') ptr++;
                if (*ptr == '\0')
@@ -466,7 +437,7 @@ CollectionData *collection_from_dnd_data(const gchar *data, GList **list, GList
                if (list) *list = g_list_append(*list, file_data_ref(info->fd));
                if (info_list) *info_list = g_list_append(*info_list, info);
                }
-       
+
        return cd;
 }
 
@@ -497,7 +468,7 @@ gchar *collection_info_list_to_dnd_data(CollectionData *cd, GList *list, gint *l
                work = work->next;
 
                if (item_number < 0) continue;
-               
+
                text = g_strdup_printf("%d\n", item_number);
                temp = g_list_prepend(temp, text);
                *length += strlen(text);
@@ -590,6 +561,17 @@ void collection_set_sort_method(CollectionData *cd, SortType method)
        collection_window_refresh(collection_window_find(cd));
 }
 
+void collection_randomize(CollectionData *cd)
+{
+       if (!cd) return;
+
+       cd->list = collection_list_randomize(cd->list);
+       cd->sort_method = SORT_NONE;
+       if (cd->list) cd->changed = TRUE;
+
+       collection_window_refresh(collection_window_find(cd));
+}
+
 void collection_set_update_info_func(CollectionData *cd,
                                     void (*func)(CollectionData *, CollectInfo *, gpointer), gpointer data)
 {
@@ -608,10 +590,14 @@ static CollectInfo *collection_info_new_if_not_exists(CollectionData *cd, struct
        return ci;
 }
 
-gint collection_add_check(CollectionData *cd, FileData *fd, gint sorted, gint must_exist)
+gboolean collection_add_check(CollectionData *cd, FileData *fd, gboolean sorted, gboolean must_exist)
 {
        struct stat st;
-       gint valid;
+       gboolean valid;
+
+       if (!fd) return FALSE;
+
+       g_assert(fd->magick == FD_MAGICK);
 
        if (must_exist)
                {
@@ -648,12 +634,12 @@ gint collection_add_check(CollectionData *cd, FileData *fd, gint sorted, gint mu
        return valid;
 }
 
-gint collection_add(CollectionData *cd, FileData *fd, gint sorted)
+gboolean collection_add(CollectionData *cd, FileData *fd, gboolean sorted)
 {
        return collection_add_check(cd, fd, sorted, TRUE);
 }
 
-gint collection_insert(CollectionData *cd, FileData *fd, CollectInfo *insert_ci, gint sorted)
+gboolean collection_insert(CollectionData *cd, FileData *fd, CollectInfo *insert_ci, gboolean sorted)
 {
        struct stat st;
 
@@ -679,7 +665,7 @@ gint collection_insert(CollectionData *cd, FileData *fd, CollectInfo *insert_ci,
        return FALSE;
 }
 
-gint collection_remove(CollectionData *cd, FileData *fd)
+gboolean collection_remove(CollectionData *cd, FileData *fd)
 {
        CollectInfo *ci;
 
@@ -733,7 +719,7 @@ void collection_remove_by_info_list(CollectionData *cd, GList *list)
        collection_window_refresh(collection_window_find(cd));
 }
 
-gint collection_rename(CollectionData *cd, FileData *fd)
+gboolean collection_rename(CollectionData *cd, FileData *fd)
 {
        CollectInfo *ci;
        ci = collection_list_find_fd(cd->list, fd);
@@ -762,9 +748,11 @@ static void collection_notify_cb(FileData *fd, NotifyType type, gpointer data)
 {
        CollectionData *cd = data;
 
-       if (type != NOTIFY_TYPE_CHANGE || !fd->change) return;
-       
-       switch(fd->change->type)
+       if (!(type & NOTIFY_CHANGE) || !fd->change) return;
+
+       DEBUG_1("Notify collection: %s %04x", fd->path, type);
+
+       switch (fd->change->type)
                {
                case FILEDATA_CHANGE_MOVE:
                case FILEDATA_CHANGE_RENAME:
@@ -776,6 +764,7 @@ static void collection_notify_cb(FileData *fd, NotifyType type, gpointer data)
                        while (collection_remove(cd, fd));
                        break;
                case FILEDATA_CHANGE_UNSPECIFIED:
+               case FILEDATA_CHANGE_WRITE_METADATA:
                        break;
                }
 
@@ -788,11 +777,10 @@ static void collection_notify_cb(FileData *fd, NotifyType type, gpointer data)
  *-------------------------------------------------------------------
  */
 
-static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gpointer data)
+static gboolean collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
        CollectWindow *cw = data;
-       gint stop_signal = FALSE;
-       gint edit_val = -1;
+       gboolean stop_signal = FALSE;
        GList *list;
 
        if (event->state & GDK_CONTROL_MASK)
@@ -801,34 +789,15 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
                switch (event->keyval)
                        {
                        case '1':
-                               edit_val = 0;
-                               break;
                        case '2':
-                               edit_val = 1;
-                               break;
                        case '3':
-                               edit_val = 2;
-                               break;
                        case '4':
-                               edit_val = 3;
-                               break;
                        case '5':
-                               edit_val = 4;
-                               break;
                        case '6':
-                               edit_val = 5;
-                               break;
                        case '7':
-                               edit_val = 6;
-                               break;
                        case '8':
-                               edit_val = 7;
-                               break;
                        case '9':
-                               edit_val = 8;
-                               break;
                        case '0':
-                               edit_val = 9;
                                break;
                        case 'A': case 'a':
                                if (event->state & GDK_SHIFT_MASK)
@@ -860,9 +829,6 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
                        case 'D': case 'd':
                                file_util_delete(NULL, collection_table_selection_get_list(cw->table), cw->window);
                                break;
-                       case 'P': case 'p':
-                               info_window_new(NULL, collection_table_selection_get_list(cw->table), NULL);
-                               break;
                        case 'S': case 's':
                                collection_dialog_save_as(NULL, cw->cd);
                                break;
@@ -879,7 +845,7 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
                stop_signal = TRUE;
                switch (event->keyval)
                        {
-                       case GDK_Return: case GDK_KP_Enter:
+                       case GDK_KEY_Return: case GDK_KEY_KP_Enter:
                                layout_image_set_collection(NULL, cw->cd,
                                        collection_table_get_focus_info(cw->table));
                                break;
@@ -929,7 +895,7 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
                                        collection_set_sort_method(cw->cd, SORT_PATH);
                                        }
                                break;
-                       case GDK_Delete: case GDK_KP_Delete:
+                       case GDK_KEY_Delete: case GDK_KEY_KP_Delete:
                                list = g_list_copy(cw->table->selection);
                                if (list)
                                        {
@@ -946,14 +912,6 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
                                break;
                        }
                }
-
-       if (edit_val != -1)
-               {
-               list = collection_table_selection_get_list(cw->table);
-               file_util_start_editor_from_filelist(edit_val, list, cw->window);
-               filelist_free(list);
-               }
-
        return stop_signal;
 }
 
@@ -965,12 +923,15 @@ static gint collection_window_keypress(GtkWidget *widget, GdkEventKey *event, gp
 static void collection_window_get_geometry(CollectWindow *cw)
 {
        CollectionData *cd;
+       GdkWindow *window;
 
        if (!cw) return;
 
        cd = cw->cd;
-       gdk_window_get_position(cw->window->window, &cd->window_x, &cd->window_y);
-       gdk_drawable_get_size(cw->window->window, &cd->window_w, &cd->window_h);
+       window = gtk_widget_get_window(cw->window);
+       gdk_window_get_position(window, &cd->window_x, &cd->window_y);
+       cd->window_w = gdk_window_get_width(window);
+       cd->window_h = gdk_window_get_height(window);
        cd->window_read = TRUE;
 }
 
@@ -983,11 +944,24 @@ static void collection_window_refresh(CollectWindow *cw)
 
 static void collection_window_update_title(CollectWindow *cw)
 {
+       gboolean free_name = FALSE;
+       gchar *name;
        gchar *buf;
 
        if (!cw) return;
 
-       buf = g_strdup_printf(_("%s - Collection - %s"), cw->cd->name, GQ_APPNAME);
+       if (file_extension_match(cw->cd->name, GQ_COLLECTION_EXT))
+               {
+               name = remove_extension_from_path(cw->cd->name);
+               free_name = TRUE;
+               }
+       else
+               {
+               name = cw->cd->name;
+               }
+
+       buf = g_strdup_printf(_("%s - Collection - %s"), name, GQ_APPNAME);
+       if (free_name) g_free(name);
        gtk_window_set_title(GTK_WINDOW(cw->window), buf);
        g_free(buf);
 }
@@ -1016,13 +990,6 @@ static void collection_window_insert(CollectWindow *cw, CollectInfo *ci)
        if (!cw) return;
 }
 
-#if 0
-static void collection_window_move(CollectWindow *cw, CollectInfo *ci)
-{
-       if (!cw) return;
-}
-#endif
-
 static void collection_window_remove(CollectWindow *cw, CollectInfo *ci)
 {
        if (!cw) return;
@@ -1139,7 +1106,7 @@ void collection_window_close_by_collection(CollectionData *cd)
        if (cw) collection_window_close_final(cw);
 }
 
-gint collection_window_modified_exists(void)
+gboolean collection_window_modified_exists(void)
 {
        GList *work;
 
@@ -1154,7 +1121,7 @@ gint collection_window_modified_exists(void)
        return FALSE;
 }
 
-static gint collection_window_delete(GtkWidget *widget, GdkEvent *event, gpointer data)
+static gboolean collection_window_delete(GtkWidget *widget, GdkEvent *event, gpointer data)
 {
        CollectWindow *cw = data;
        collection_window_close(cw);
@@ -1173,8 +1140,6 @@ CollectWindow *collection_window_new(const gchar *path)
 
        cw = g_new0(CollectWindow, 1);
 
-       cw->close_dialog = NULL;
-
        collection_window_list = g_list_append(collection_window_list, cw);
 
        cw->cd = collection_new(path);
@@ -1189,7 +1154,7 @@ CollectWindow *collection_window_new(const gchar *path)
                                      GDK_HINT_MIN_SIZE | GDK_HINT_BASE_SIZE);
 
 
-       if (options->layout.save_window_positions && path && collection_load_only_geometry(cw->cd, path))
+       if (options->save_window_positions && path && collection_load_only_geometry(cw->cd, path))
                {
                /* FIXME: x, y is not implemented */
                gtk_window_set_default_size(GTK_WINDOW(cw->window), cw->cd->window_w, cw->cd->window_h);