Use std::swap instead of temporary values
[geeqie.git] / src / pixbuf-util.cc
index f6ee36b..0d87b7f 100644 (file)
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#include "main.h"
 #include "pixbuf-util.h"
+
+#include <algorithm>
+#include <cmath>
+#include <cstdlib>
+#include <cstring>
+#include <utility>
+
+#include <cairo.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <pango/pangocairo.h>
+
+#include <config.h>
+
+#include "debug.h"
 #include "exif.h"
+#include "filedata.h"
+#include "main-defines.h"
+#include "typedefs.h"
 #include "ui-fileops.h"
 
-#include <math.h>
-
 
 /*
  *-----------------------------------------------------------------------------
@@ -35,7 +50,7 @@
 
 gboolean pixbuf_to_file_as_png(GdkPixbuf *pixbuf, const gchar *filename)
 {
-       GError *error = NULL;
+       GError *error = nullptr;
        gboolean ret;
 
        if (!pixbuf || !filename) return FALSE;
@@ -58,33 +73,36 @@ gboolean pixbuf_to_file_as_png(GdkPixbuf *pixbuf, const gchar *filename)
  *-----------------------------------------------------------------------------
  */
 
-//gboolean pixbuf_to_file_as_jpg(GdkPixbuf *pixbuf, const gchar *filename, gint quality)
-//{
-       //GError *error = NULL;
-       //gchar *qbuf;
-       //gboolean ret;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-function"
+gboolean pixbuf_to_file_as_jpg_unused(GdkPixbuf *pixbuf, const gchar *filename, gint quality)
+{
+       GError *error = nullptr;
+       gchar *qbuf;
+       gboolean ret;
 
-       //if (!pixbuf || !filename) return FALSE;
+       if (!pixbuf || !filename) return FALSE;
 
-       //if (quality == -1) quality = 75;
-       //if (quality < 1 || quality > 100)
-               //{
-               //log_printf("Jpeg not saved, invalid quality %d\n", quality);
-               //return FALSE;
-               //}
+       if (quality == -1) quality = 75;
+       if (quality < 1 || quality > 100)
+               {
+               log_printf("Jpeg not saved, invalid quality %d\n", quality);
+               return FALSE;
+               }
 
-       //qbuf = g_strdup_printf("%d", quality);
-       //ret = gdk_pixbuf_save(pixbuf, filename, "jpeg", &error, "quality", qbuf, NULL);
-       //g_free(qbuf);
+       qbuf = g_strdup_printf("%d", quality);
+       ret = gdk_pixbuf_save(pixbuf, filename, "jpeg", &error, "quality", qbuf, NULL);
+       g_free(qbuf);
 
-       //if (error)
-               //{
-               //log_printf("Error saving jpeg to %s\n%s\n", filename, error->message);
-               //g_error_free(error);
-               //}
+       if (error)
+               {
+               log_printf("Error saving jpeg to %s\n%s\n", filename, error->message);
+               g_error_free(error);
+               }
 
-       //return ret;
-//}
+       return ret;
+}
+#pragma GCC diagnostic pop
 
 /*
  *-----------------------------------------------------------------------------
@@ -92,101 +110,114 @@ gboolean pixbuf_to_file_as_png(GdkPixbuf *pixbuf, const gchar *filename)
  *-----------------------------------------------------------------------------
  */
 
-typedef struct _PixbufInline PixbufInline;
-struct _PixbufInline
+struct PixbufInline
 {
        const gchar *key;
        const gchar *data;
 };
 
 static PixbufInline inline_pixbuf_data[] = {
-       { PIXBUF_INLINE_ARCHIVE,        "gq-archive-file.png" },
-       { PIXBUF_INLINE_BROKEN, "gq-sheet-broken.png" },
-       { PIXBUF_INLINE_COLLECTION,     "gq-collection.png" },
-       { PIXBUF_INLINE_FOLDER_CLOSED,  "gq-folder-closed.png" },
-       { PIXBUF_INLINE_FOLDER_LOCKED,  "gq-folder-locked.png" },
-       { PIXBUF_INLINE_FOLDER_OPEN,    "gq-folder-open.png" },
-       { PIXBUF_INLINE_FOLDER_UP,      "gq-folder-up.png" },
-       { PIXBUF_INLINE_ICON,   "gqview-icon.png" },
-       { PIXBUF_INLINE_ICON_180,       "gq-icon-rotate-180.png" },
-       { PIXBUF_INLINE_ICON_BOOK,      "gq-icon-book.png" },
-       { PIXBUF_INLINE_ICON_CCW,       "gq-icon-rotate-counter-clockwise.png" },
-       { PIXBUF_INLINE_ICON_CONFIG,    "gq-icon-config.png" },
-       { PIXBUF_INLINE_ICON_CW,        "gq-icon-rotate-clockwise.png" },
-       { PIXBUF_INLINE_ICON_DRAW_RECTANGLE,    "gq-icon-draw-rectangle.png" },
-       { PIXBUF_INLINE_ICON_EXIF,      "gq-icon-exif.png" },
-       { PIXBUF_INLINE_ICON_EXPOSURE,  "gq-icon-exposure.png" },
-       { PIXBUF_INLINE_ICON_FILE_FILTER,       "gq-icon-file-filter.png" },
-       { PIXBUF_INLINE_ICON_FLIP,      "gq-icon-flip.png" },
-       { PIXBUF_INLINE_ICON_FLOAT,     "gq-icon-float.png" },
-       { PIXBUF_INLINE_ICON_GRAYSCALE, "gq-icon-grayscale.png" },
-       { PIXBUF_INLINE_ICON_HEIF,      "gq-icon-heic.png" },
-       { PIXBUF_INLINE_ICON_HIDETOOLS,         "gq-icon-hidetools.png" },
-       { PIXBUF_INLINE_ICON_INFO,      "gq-icon-info.png" },
-       { PIXBUF_INLINE_ICON_MAINTENANCE,       "gq-icon-maintenance.png" },
-       { PIXBUF_INLINE_ICON_MARKS,     "gq-icon-marks.png" },
-       { PIXBUF_INLINE_ICON_MIRROR,    "gq-icon-mirror.png" },
-       { PIXBUF_INLINE_ICON_MOVE,      "gq-icon-move.png" },
-       { PIXBUF_INLINE_ICON_ORIGINAL,  "gq-icon-original.png" },
-       { PIXBUF_INLINE_ICON_PANORAMA,  "gq-icon-panorama.png" },
-       { PIXBUF_INLINE_ICON_PDF,       "gq-icon-pdf.png" },
-       { PIXBUF_INLINE_ICON_RENAME,    "gq-icon-rename.png" },
-       { PIXBUF_INLINE_ICON_SELECT_ALL,        "gq-icon-select-all.png" },
-       { PIXBUF_INLINE_ICON_SELECT_INVERT,     "gq-icon-select-invert.png" },
-       { PIXBUF_INLINE_ICON_SELECT_NONE,       "gq-icon-select-none.png" },
-       { PIXBUF_INLINE_ICON_SELECT_RECTANGLE,  "gq-icon-select-rectangle.png" },
-       { PIXBUF_INLINE_ICON_SORT,      "gq-icon-sort.png" },
-       { PIXBUF_INLINE_ICON_THUMB,     "gq-icon-thumb.png" },
-       { PIXBUF_INLINE_ICON_TOOLS,             "gq-icon-tools.png" },
-       { PIXBUF_INLINE_ICON_TRASH,     "gq-icon-trash.png" },
-       { PIXBUF_INLINE_ICON_VIEW,      "gq-icon-view.png" },
-       { PIXBUF_INLINE_ICON_ZOOMFILLHOR,       "gq-icon-zoomfillhor.png" },
-       { PIXBUF_INLINE_ICON_ZOOMFILLVERT,      "gq-icon-zoomfillvert.png" },
-       { PIXBUF_INLINE_LOGO,   "geeqie-logo.png" },
-       { PIXBUF_INLINE_METADATA,       "gq-sheet-metadata.png" },
-       { PIXBUF_INLINE_SCROLLER,       "gq-scroller.png" },
-       { PIXBUF_INLINE_SPLIT_PANE_SYNC, "gq-icon-split-pane-sync.png" },
-       { PIXBUF_INLINE_UNKNOWN,        "gq-sheet-unknown.png" },
-       { PIXBUF_INLINE_VIDEO,  "gq-sheet-video.png" },
-       { NULL, NULL }
+       {  PIXBUF_INLINE_ARCHIVE,                "gq-icon-archive-file" },
+       {  PIXBUF_INLINE_BROKEN,                 "gq-icon-broken" },
+       {  PIXBUF_INLINE_COLLECTION,             "gq-icon-collection" },
+       {  PIXBUF_INLINE_ICON_180,               "gq-icon-rotate-180" },
+       {  PIXBUF_INLINE_ICON_BOOK,              "gq-icon-book" },
+       {  PIXBUF_INLINE_ICON_CONFIG,            "gq-icon-config" },
+       {  PIXBUF_INLINE_ICON_DRAW_RECTANGLE,    "gq-icon-draw-rectangle" },
+       {  PIXBUF_INLINE_ICON_EXIF,              "gq-icon-exif" },
+       {  PIXBUF_INLINE_ICON_EXPOSURE,          "gq-icon-exposure" },
+       {  PIXBUF_INLINE_ICON_FLOAT,             "gq-icon-float" },
+       {  PIXBUF_INLINE_ICON,                   "gqview-icon" },
+       {  PIXBUF_INLINE_ICON_GRAYSCALE,         "gq-icon-grayscale" },
+       {  PIXBUF_INLINE_ICON_HEIF,              "gq-icon-heic" },
+       {  PIXBUF_INLINE_ICON_HIDETOOLS,         "gq-icon-hidetools" },
+       {  PIXBUF_INLINE_ICON_MAINTENANCE,       "gq-icon-maintenance" },
+       {  PIXBUF_INLINE_ICON_MARKS,             "gq-icon-marks" },
+       {  PIXBUF_INLINE_ICON_MOVE,              "gq-icon-move" },
+       {  PIXBUF_INLINE_ICON_ORIGINAL,          "gq-icon-original" },
+       {  PIXBUF_INLINE_ICON_PANORAMA,          "gq-icon-panorama" },
+       {  PIXBUF_INLINE_ICON_PDF,               "gq-icon-pdf" },
+       {  PIXBUF_INLINE_ICON_PROPERTIES,        "gq-icon-properties" },
+       {  PIXBUF_INLINE_ICON_RENAME,            "gq-icon-rename" },
+       {  PIXBUF_INLINE_ICON_SELECT_ALL,        "gq-icon-select-all" },
+       {  PIXBUF_INLINE_ICON_SELECT_INVERT,     "gq-icon-select-invert" },
+       {  PIXBUF_INLINE_ICON_SELECT_NONE,       "gq-icon-select-none" },
+       {  PIXBUF_INLINE_ICON_SELECT_RECTANGLE,  "gq-icon-select-rectangle" },
+       {  PIXBUF_INLINE_ICON_SORT,              "gq-icon-sort" },
+       {  PIXBUF_INLINE_ICON_THUMB,             "gq-icon-thumb" },
+       {  PIXBUF_INLINE_ICON_TOOLS,             "gq-icon-tools" },
+       {  PIXBUF_INLINE_ICON_VIEW,              "gq-icon-view" },
+       {  PIXBUF_INLINE_ICON_ZOOMFILLHOR,       "gq-icon-zoomfillhor" },
+       {  PIXBUF_INLINE_ICON_ZOOMFILLVERT,      "gq-icon-zoomfillvert" },
+       {  PIXBUF_INLINE_LOGO,                   "geeqie-logo" },
+       {  PIXBUF_INLINE_METADATA,               "gq-icon-metadata" },
+       {  PIXBUF_INLINE_SCROLLER,               "gq-scroller" },
+       {  PIXBUF_INLINE_SPLIT_PANE_SYNC,        "gq-icon-split-pane-sync" },
+       {  PIXBUF_INLINE_UNKNOWN,                "gq-icon-unknown" },
+       {  PIXBUF_INLINE_VIDEO,                  "gq-icon-video" },
+       {  nullptr,                              nullptr }
 };
 
 GdkPixbuf *pixbuf_inline(const gchar *key)
 {
-       GError *error = NULL;
-       GInputStream *in_stream;
-       GdkPixbuf *icon_pixbuf;
+       gboolean dark = FALSE;
+       gchar *file_name = nullptr;
        gchar *path;
+       gchar *theme_name;
+       GdkPixbuf *icon_pixbuf;
+       GError *error = nullptr;
+       GInputStream *in_stream;
        gint i;
+       GtkSettings *settings;
 
-       if (!key) return NULL;
+       if (!key) return nullptr;
+
+       settings = gtk_settings_get_default();
+       g_object_get(settings, "gtk-theme-name", &theme_name, nullptr);
+       dark = g_str_has_suffix(theme_name, "dark");
+       g_free(theme_name);
 
        i = 0;
        while (inline_pixbuf_data[i].key)
                {
                if (strcmp(inline_pixbuf_data[i].key, key) == 0)
                        {
-                       path = g_build_filename(GQ_RESOURCE_PATH_ICONS, inline_pixbuf_data[i].data, NULL);
+                       file_name = g_strconcat(inline_pixbuf_data[i].data, dark ? "-dark" : "", ".png", nullptr);
+                       path = g_build_filename(GQ_RESOURCE_PATH_ICONS, file_name, nullptr);
+                       g_free(file_name);
 
                        in_stream = g_resources_open_stream(path, G_RESOURCE_LOOKUP_FLAGS_NONE, &error);
                        g_free(path);
 
+                       if (error)
+                               {
+                               g_error_free(error);
+                               error = nullptr;
+
+                               file_name = g_strconcat(inline_pixbuf_data[i].data, ".png", nullptr);
+                               path = g_build_filename(GQ_RESOURCE_PATH_ICONS, file_name, nullptr);
+                               g_free(file_name);
+
+                               in_stream = g_resources_open_stream(path, G_RESOURCE_LOOKUP_FLAGS_NONE, &error);
+                               g_free(path);
+                               }
+
                        if (error)
                                {
                                log_printf("warning: inline pixbuf error: %s", error->message);
                                g_error_free(error);
                                g_object_unref(in_stream);
-                               return NULL;
+                               return nullptr;
                                }
 
-                       icon_pixbuf = gdk_pixbuf_new_from_stream(in_stream, NULL, &error);
+                       icon_pixbuf = gdk_pixbuf_new_from_stream(in_stream, nullptr, &error);
                        g_object_unref(in_stream);
 
                        if (error)
                                {
                                log_printf("warning: inline pixbuf error: %s", error->message);
                                g_error_free(error);
-                               return NULL;
+                               return nullptr;
                                }
 
                        return icon_pixbuf;
@@ -196,12 +227,12 @@ GdkPixbuf *pixbuf_inline(const gchar *key)
 
        log_printf("warning: inline pixbuf key \"%s\" not found.\n", key);
 
-       return NULL;
+       return nullptr;
 }
 
 static void register_stock_icon(const gchar *key, GdkPixbuf *pixbuf)
 {
-       static GtkIconFactory *icon_factory = NULL;
+       static GtkIconFactory *icon_factory = nullptr;
        GtkIconSet *icon_set;
 
        if (!icon_factory)
@@ -215,7 +246,7 @@ static void register_stock_icon(const gchar *key, GdkPixbuf *pixbuf)
 }
 
 
-void pixbuf_inline_register_stock_icons(void)
+void pixbuf_inline_register_stock_icons()
 {
        gint i;
 
@@ -231,7 +262,7 @@ gboolean register_theme_icon_as_stock(const gchar *key, const gchar *icon)
 {
        GtkIconTheme *icon_theme;
        GdkPixbuf *pixbuf;
-       GError *error = NULL;
+       GError *error = nullptr;
 
        icon_theme = gtk_icon_theme_get_default();
 
@@ -248,7 +279,7 @@ gboolean register_theme_icon_as_stock(const gchar *key, const gchar *icon)
                        {
                        DEBUG_1("Couldn't load icon %s: %s", icon, error->message);
                        g_error_free(error);
-                       error = NULL;
+                       error = nullptr;
                        }
 
                if (strchr(icon, '.'))
@@ -264,7 +295,7 @@ gboolean register_theme_icon_as_stock(const gchar *key, const gchar *icon)
                                {
                                DEBUG_1("Couldn't load icon %s: %s", icon2, error->message);
                                g_error_free(error);
-                               error = NULL;
+                               error = nullptr;
 
                                /* try as an absolute path */
                                pixbuf = gdk_pixbuf_new_from_file(icon, &error);
@@ -288,16 +319,16 @@ gboolean pixbuf_scale_aspect(gint req_w, gint req_h,
                             gint old_w, gint old_h,
                             gint *new_w, gint *new_h)
 {
-       if (((gdouble)req_w / old_w) < ((gdouble)req_h / old_h))
+       if ((static_cast<gdouble>(req_w) / old_w) < (static_cast<gdouble>(req_h) / old_h))
                {
                *new_w = req_w;
-               *new_h = (gdouble)*new_w / old_w * old_h;
+               *new_h = static_cast<gdouble>(*new_w) / old_w * old_h;
                if (*new_h < 1) *new_h = 1;
                }
        else
                {
                *new_h = req_h;
-               *new_w = (gdouble)*new_h / old_h * old_w;
+               *new_w = static_cast<gdouble>(*new_h) / old_h * old_w;
                if (*new_w < 1) *new_w = 1;
                }
 
@@ -339,7 +370,8 @@ GdkPixbuf *pixbuf_fallback(FileData *fd, gint requested_width, gint requested_he
 
                if (w > requested_width || h > requested_height)
                        {
-                       gint nw, nh;
+                       gint nw;
+                       gint nh;
 
                        if (pixbuf_scale_aspect(requested_width, requested_height,
                                                          w, h, &nw, &nh))
@@ -393,7 +425,8 @@ static void pixbuf_copy_block_rotate(guchar *src, gint src_row_stride, gint x, g
                                     guchar *dest, gint dest_row_stride, gint w, gint h,
                                     gint bytes_per_pixel, gboolean counter_clockwise)
 {
-       gint i, j;
+       gint i;
+       gint j;
        guchar *sp;
        guchar *dp;
 
@@ -434,8 +467,10 @@ static void pixbuf_copy_block(guchar *src, gint src_row_stride, gint w, gint h,
                }
 }
 
-#define ROTATE_BUFFER_WIDTH 48
-#define ROTATE_BUFFER_HEIGHT 48
+enum {
+       ROTATE_BUFFER_WIDTH = 48,
+       ROTATE_BUFFER_HEIGHT = 48
+};
 
 /*
  * Returns a copy of pixbuf src rotated 90 degrees clockwise or 90 counterclockwise
@@ -445,18 +480,24 @@ GdkPixbuf *pixbuf_copy_rotate_90(GdkPixbuf *src, gboolean counter_clockwise)
 {
        GdkPixbuf *dest;
        gboolean has_alpha;
-       gint sw, sh, srs;
-       gint dw, dh, drs;
+       gint sw;
+       gint sh;
+       gint srs;
+       gint dw;
+       gint dh;
+       gint drs;
        guchar *s_pix;
        guchar *d_pix;
-       gint i, j;
+       gint i;
+       gint j;
        gint a;
        GdkPixbuf *buffer;
        guchar *b_pix;
        gint brs;
-       gint w, h;
+       gint w;
+       gint h;
 
-       if (!src) return NULL;
+       if (!src) return nullptr;
 
        sw = gdk_pixbuf_get_width(src);
        sh = gdk_pixbuf_get_height(src);
@@ -482,7 +523,8 @@ GdkPixbuf *pixbuf_copy_rotate_90(GdkPixbuf *src, gboolean counter_clockwise)
                w = MIN(ROTATE_BUFFER_WIDTH, (sh - i));
                for (j = 0; j < sw; j += ROTATE_BUFFER_HEIGHT)
                        {
-                       gint x, y;
+                       gint x;
+                       gint y;
 
                        h = MIN(ROTATE_BUFFER_HEIGHT, (sw - j));
                        pixbuf_copy_block_rotate(s_pix, srs, j, i,
@@ -543,16 +585,19 @@ GdkPixbuf *pixbuf_copy_mirror(GdkPixbuf *src, gboolean mirror, gboolean flip)
 {
        GdkPixbuf *dest;
        gboolean has_alpha;
-       gint w, h, srs;
+       gint w;
+       gint h;
+       gint srs;
        gint drs;
        guchar *s_pix;
        guchar *d_pix;
        guchar *sp;
        guchar *dp;
-       gint i, j;
+       gint i;
+       gint j;
        gint a;
 
-       if (!src) return NULL;
+       if (!src) return nullptr;
 
        w = gdk_pixbuf_get_width(src);
        h = gdk_pixbuf_get_height(src);
@@ -607,7 +652,7 @@ GdkPixbuf *pixbuf_copy_mirror(GdkPixbuf *src, gboolean mirror, gboolean flip)
 GdkPixbuf *pixbuf_apply_orientation(GdkPixbuf *pixbuf, gint orientation)
 {
        GdkPixbuf *dest;
-       GdkPixbuf *tmp = NULL;
+       GdkPixbuf *tmp = nullptr;
 
        switch (orientation)
                {
@@ -668,10 +713,13 @@ void pixbuf_draw_rect_fill(GdkPixbuf *pb,
                           gint r, gint g, gint b, gint a)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
+       gint pw;
+       gint ph;
+       gint prs;
        guchar *p_pix;
        guchar *pp;
-       gint i, j;
+       gint i;
+       gint j;
 
        if (!pb) return;
 
@@ -685,46 +733,51 @@ void pixbuf_draw_rect_fill(GdkPixbuf *pb,
        prs = gdk_pixbuf_get_rowstride(pb);
        p_pix = gdk_pixbuf_get_pixels(pb);
 
+       const gint p_step = has_alpha ? 4 : 3;
+
        for (i = 0; i < h; i++)
                {
-               pp = p_pix + (y + i) * prs + (x * (has_alpha ? 4 : 3));
+               pp = p_pix + (y + i) * prs + (x * p_step);
                for (j = 0; j < w; j++)
                        {
-                       *pp = (r * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       *pp = (g * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       *pp = (b * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       if (has_alpha) pp++;
+                       pp[0] = (r * a + pp[0] * (256-a)) >> 8;
+                       pp[1] = (g * a + pp[1] * (256-a)) >> 8;
+                       pp[2] = (b * a + pp[2] * (256-a)) >> 8;
+                       pp += p_step;
                        }
                }
 }
 
-//void pixbuf_draw_rect(GdkPixbuf *pb,
-                     //gint x, gint y, gint w, gint h,
-                     //gint r, gint g, gint b, gint a,
-                     //gint left, gint right, gint top, gint bottom)
-//{
-       //pixbuf_draw_rect_fill(pb, x + left, y, w - left - right, top,
-                             //r, g, b ,a);
-       //pixbuf_draw_rect_fill(pb, x + w - right, y, right, h,
-                             //r, g, b ,a);
-       //pixbuf_draw_rect_fill(pb, x + left, y + h - bottom, w - left - right, bottom,
-                             //r, g, b ,a);
-       //pixbuf_draw_rect_fill(pb, x, y, left, h,
-                             //r, g, b ,a);
-//}
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-function"
+void pixbuf_draw_rect_unused(GdkPixbuf *pb,
+                     gint x, gint y, gint w, gint h,
+                     gint r, gint g, gint b, gint a,
+                     gint left, gint right, gint top, gint bottom)
+{
+       pixbuf_draw_rect_fill(pb, x + left, y, w - left - right, top,
+                             r, g, b ,a);
+       pixbuf_draw_rect_fill(pb, x + w - right, y, right, h,
+                             r, g, b ,a);
+       pixbuf_draw_rect_fill(pb, x + left, y + h - bottom, w - left - right, bottom,
+                             r, g, b ,a);
+       pixbuf_draw_rect_fill(pb, x, y, left, h,
+                             r, g, b ,a);
+}
+#pragma GCC diagnostic pop
 
 void pixbuf_set_rect_fill(GdkPixbuf *pb,
                          gint x, gint y, gint w, gint h,
                          gint r, gint g, gint b, gint a)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
+       gint pw;
+       gint ph;
+       gint prs;
        guchar *p_pix;
        guchar *pp;
-       gint i, j;
+       gint i;
+       gint j;
 
        if (!pb) return;
 
@@ -738,9 +791,11 @@ void pixbuf_set_rect_fill(GdkPixbuf *pb,
        prs = gdk_pixbuf_get_rowstride(pb);
        p_pix = gdk_pixbuf_get_pixels(pb);
 
+       const gint p_step = has_alpha ? 4 : 3;
+
        for (i = 0; i < h; i++)
                {
-               pp = p_pix + (y + i) * prs + (x * (has_alpha ? 4 : 3));
+               pp = p_pix + (y + i) * prs + (x * p_step);
                for (j = 0; j < w; j++)
                        {
                        *pp = r; pp++;
@@ -799,18 +854,23 @@ static void pixbuf_copy_font(GdkPixbuf *src, gint sx, gint sy,
                             gint w, gint h,
                             guint8 r, guint8 g, guint8 b, guint8 a)
 {
-       gint sw, sh, srs;
+       gint sw;
+       gint sh;
+       gint srs;
        gboolean s_alpha;
        gint s_step;
        guchar *s_pix;
-       gint dw, dh, drs;
+       gint dw;
+       gint dh;
+       gint drs;
        gboolean d_alpha;
        gint d_step;
        guchar *d_pix;
 
        guchar *sp;
        guchar *dp;
-       gint i, j;
+       gint i;
+       gint j;
 
        if (!src || !dest) return;
 
@@ -872,14 +932,17 @@ static void pixbuf_copy_font(GdkPixbuf *src, gint sx, gint sy,
                }
 }
 
-void pixbuf_draw_layout(GdkPixbuf *pixbuf, PangoLayout *layout, GtkWidget *UNUSED(widget),
+void pixbuf_draw_layout(GdkPixbuf *pixbuf, PangoLayout *layout, GtkWidget *,
                        gint x, gint y,
                        guint8 r, guint8 g, guint8 b, guint8 a)
 {
        GdkPixbuf *buffer;
-       gint w, h;
-       gint sx, sy;
-       gint dw, dh;
+       gint w;
+       gint h;
+       gint sx;
+       gint sy;
+       gint dw;
+       gint dh;
        cairo_surface_t *source;
        cairo_t *cr;
 
@@ -903,8 +966,8 @@ void pixbuf_draw_layout(GdkPixbuf *pixbuf, PangoLayout *layout, GtkWidget *UNUSE
                                           cairo_image_surface_get_width (source),
                                           cairo_image_surface_get_height (source),
                                           cairo_image_surface_get_stride (source),
-                                          NULL,
-                                          NULL);
+                                          nullptr,
+                                          nullptr);
 
        sx = 0;
        sy = 0;
@@ -943,23 +1006,12 @@ void pixbuf_draw_layout(GdkPixbuf *pixbuf, PangoLayout *layout, GtkWidget *UNUSE
  */
 
 void util_clip_triangle(gint x1, gint y1, gint x2, gint y2, gint x3, gint y3,
-                       gint *rx, gint *ry, gint *rw, gint *rh)
+                        gint &rx, gint &ry, gint &rw, gint &rh)
 {
-       gint tx, ty, tw, th;
-
-       tx = MIN(x1, x2);
-       tx = MIN(tx, x3);
-       ty = MIN(y1, y2);
-       ty = MIN(ty, y3);
-       tw = MAX(abs(x1 - x2), abs(x2 - x3));
-       tw = MAX(tw, abs(x3 - x1));
-       th = MAX(abs(y1 - y2), abs(y2 - y3));
-       th = MAX(th, abs(y3 - y1));
-
-       *rx = tx;
-       *ry = ty;
-       *rw = tw;
-       *rh = th;
+       rx = std::min({x1, x2, x3});
+       ry = std::min({y1, y2, y3});
+       rw = std::max({abs(x1 - x2), abs(x2 - x3), abs(x3 - x1)});
+       rh = std::max({abs(y1 - y2), abs(y2 - y3), abs(y3 - y1)});
 }
 
 void pixbuf_draw_triangle(GdkPixbuf *pb,
@@ -968,19 +1020,31 @@ void pixbuf_draw_triangle(GdkPixbuf *pb,
                          guint8 r, guint8 g, guint8 b, guint8 a)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
-       gint rx, ry, rw, rh;
-       gint tx, ty, tw, th;
-       gint fx1, fy1;
-       gint fx2, fy2;
-       gint fw, fh;
+       gint pw;
+       gint ph;
+       gint prs;
+       gint rx;
+       gint ry;
+       gint rw;
+       gint rh;
+       gint tx;
+       gint ty;
+       gint tw;
+       gint th;
+       gint fx1;
+       gint fy1;
+       gint fx2;
+       gint fy2;
+       gint fw;
+       gint fh;
        guchar *p_pix;
        guchar *pp;
        gint p_step;
-       gdouble slope1, slope2;
-       gint slope1_x, slope1_y;
+       gdouble slope1;
+       gdouble slope2;
+       gint slope1_x;
+       gint slope1_y;
        gint y;
-       gint t;
        gboolean middle = FALSE;
 
        if (!pb) return;
@@ -993,7 +1057,7 @@ void pixbuf_draw_triangle(GdkPixbuf *pb,
                              &rx, &ry, &rw, &rh)) return;
 
        util_clip_triangle(x1, y1, x2, y2, x3, y3,
-                          &tx, &ty, &tw, &th);
+                          tx, ty, tw, th);
 
        if (!util_clip_region(rx, ry, rw, rh,
                              tx, ty, tw, th,
@@ -1009,47 +1073,48 @@ void pixbuf_draw_triangle(GdkPixbuf *pb,
 
        if (y1 > y2)
                {
-               t = x1; x1 = x2; x2 = t;
-               t = y1; y1 = y2; y2 = t;
+               std::swap(x1, x2);
+               std::swap(y1, y2);
                }
        if (y2 > y3)
                {
-               t = x2; x2 = x3; x3 = t;
-               t = y2; y2 = y3; y3 = t;
+               std::swap(x2, x3);
+               std::swap(y2, y3);
                }
        if (y1 > y2)
                {
-               t = x1; x1 = x2; x2 = t;
-               t = y1; y1 = y2; y2 = t;
+               std::swap(x1, x2);
+               std::swap(y1, y2);
                }
 
-       slope1 = (gdouble)(y2 - y1);
-       if (slope1) slope1 = (gdouble)(x2 - x1) / slope1;
+       slope1 = static_cast<gdouble>(y2 - y1);
+       if (slope1) slope1 = static_cast<gdouble>(x2 - x1) / slope1;
        slope1_x = x1;
        slope1_y = y1;
-       slope2 = (gdouble)(y3 - y1);
-       if (slope2) slope2 = (gdouble)(x3 - x1) / slope2;
+       slope2 = static_cast<gdouble>(y3 - y1);
+       if (slope2) slope2 = static_cast<gdouble>(x3 - x1) / slope2;
 
        for (y = fy1; y < fy2; y++)
                {
-               gint xa, xb;
+               gint xa;
+               gint xb;
 
                if (!middle && y > y2)
                        {
-                       slope1 = (gdouble)(y3 - y2);
-                       if (slope1) slope1 = (gdouble)(x3 - x2) / slope1;
+                       slope1 = static_cast<gdouble>(y3 - y2);
+                       if (slope1) slope1 = static_cast<gdouble>(x3 - x2) / slope1;
                        slope1_x = x2;
                        slope1_y = y2;
 
                        middle = TRUE;
                        }
 
-               xa = slope1_x + ((gdouble)slope1 * (y - slope1_y) + 0.5);
-               xb = x1 + ((gdouble)slope2 * (y - y1) + 0.5);
+               xa = slope1_x + (slope1 * (y - slope1_y) + 0.5);
+               xb = x1 + (slope2 * (y - y1) + 0.5);
 
                if (xa > xb)
                        {
-                       t = xa; xa = xb; xb = t;
+                       std::swap(xa, xb);
                        }
 
                xa = CLAMP(xa, fx1, fx2);
@@ -1059,13 +1124,10 @@ void pixbuf_draw_triangle(GdkPixbuf *pb,
 
                while (xa < xb)
                        {
-                       *pp = (r * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       *pp = (g * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       *pp = (b * a + *pp * (256-a)) >> 8;
-                       pp++;
-                       if (has_alpha) pp++;
+                       pp[0] = (r * a + pp[0] * (256-a)) >> 8;
+                       pp[1] = (g * a + pp[1] * (256-a)) >> 8;
+                       pp[2] = (b * a + pp[2] * (256-a)) >> 8;
+                       pp += p_step;
 
                        xa++;
                        }
@@ -1087,10 +1149,8 @@ static gboolean util_clip_line(gdouble clip_x, gdouble clip_y, gdouble clip_w, g
 
        if (x1 > x2)
                {
-               gdouble t;
-
-               t = x1; x1 = x2; x2 = t;
-               t = y1; y1 = y2; y2 = t;
+               std::swap(x1, x2);
+               std::swap(y1, y2);
                flip = TRUE;
                }
 
@@ -1129,12 +1189,10 @@ static gboolean util_clip_line(gdouble clip_x, gdouble clip_y, gdouble clip_w, g
                }
        else
                {
-               gdouble t;
-
                if (y1 < clip_y || y2 > clip_y + clip_h) return FALSE;
 
-               t = x1; x1 = x2; x2 = t;
-               t = y1; y1 = y2; y2 = t;
+               std::swap(x1, x2);
+               std::swap(y1, y2);
                flip = !flip;
                }
 
@@ -1180,16 +1238,29 @@ void pixbuf_draw_line(GdkPixbuf *pb,
                      guint8 r, guint8 g, guint8 b, guint8 a)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
-       gint rx, ry, rw, rh;
-       gdouble rx1, ry1, rx2, ry2;
+       gint pw;
+       gint ph;
+       gint prs;
+       gint rx;
+       gint ry;
+       gint rw;
+       gint rh;
+       gdouble rx1;
+       gdouble ry1;
+       gdouble rx2;
+       gdouble ry2;
        guchar *p_pix;
        guchar *pp;
        gint p_step;
        gdouble slope;
-       gdouble x, y;
-       gint px, py;
-       gint cx1, cy1, cx2, cy2;
+       gdouble x;
+       gdouble y;
+       gint px;
+       gint py;
+       gint cx1;
+       gint cy1;
+       gint cx2;
+       gint cy2;
 
        if (!pb) return;
 
@@ -1199,8 +1270,8 @@ void pixbuf_draw_line(GdkPixbuf *pb,
        if (!util_clip_region(0, 0, pw, ph,
                              clip_x, clip_y, clip_w, clip_h,
                              &rx, &ry, &rw, &rh)) return;
-       if (!util_clip_line((gdouble)rx, (gdouble)ry, (gdouble)rw, (gdouble)rh,
-                           (gdouble)x1, (gdouble)y1, (gdouble)x2, (gdouble)y2,
+       if (!util_clip_line(static_cast<gdouble>(rx), static_cast<gdouble>(ry), static_cast<gdouble>(rw), static_cast<gdouble>(rh),
+                           static_cast<gdouble>(x1), static_cast<gdouble>(y1), static_cast<gdouble>(x2), static_cast<gdouble>(y2),
                            &rx1, &ry1, &rx2, &ry2)) return;
 
        cx1 = rx;
@@ -1218,17 +1289,16 @@ void pixbuf_draw_line(GdkPixbuf *pb,
                {
                if (rx1 > rx2)
                        {
-                       gdouble t;
-                       t = rx1; rx1 = rx2; rx2 = t;
-                       t = ry1; ry1 = ry2; ry2 = t;
+                       std::swap(rx1, rx2);
+                       std::swap(ry1, ry2);
                        }
 
                slope = rx2 - rx1;
                if (slope != 0.0) slope = (ry2 - ry1) / slope;
                for (x = rx1; x < rx2; x += 1.0)
                        {
-                       px = (gint)(x + 0.5);
-                       py = (gint)(ry1 + (x - rx1) * slope + 0.5);
+                       px = static_cast<gint>(x + 0.5);
+                       py = static_cast<gint>(ry1 + (x - rx1) * slope + 0.5);
 
                        if (px >=  cx1 && px < cx2 && py >= cy1 && py < cy2)
                                {
@@ -1245,17 +1315,16 @@ void pixbuf_draw_line(GdkPixbuf *pb,
                {
                if (ry1 > ry2)
                        {
-                       gdouble t;
-                       t = rx1; rx1 = rx2; rx2 = t;
-                       t = ry1; ry1 = ry2; ry2 = t;
+                       std::swap(rx1, rx2);
+                       std::swap(ry1, ry2);
                        }
 
                slope = ry2 - ry1;
                if (slope != 0.0) slope = (rx2 - rx1) / slope;
                for (y = ry1; y < ry2; y += 1.0)
                        {
-                       px = (gint)(rx1 + (y - ry1) * slope + 0.5);
-                       py = (gint)(y + 0.5);
+                       px = static_cast<gint>(rx1 + (y - ry1) * slope + 0.5);
+                       py = static_cast<gint>(y + 0.5);
 
                        if (px >=  cx1 && px < cx2 && py >= cy1 && py < cy2)
                                {
@@ -1284,7 +1353,8 @@ static void pixbuf_draw_fade_linear(guchar *p_pix, gint prs, gboolean has_alpha,
        guchar *pp;
        gint p_step;
        guint8 n = a;
-       gint i, j;
+       gint i;
+       gint j;
 
        p_step = (has_alpha) ? 4 : 3;
        for (j = y1; j < y2; j++)
@@ -1294,13 +1364,10 @@ static void pixbuf_draw_fade_linear(guchar *p_pix, gint prs, gboolean has_alpha,
                for (i = x1; i < x2; i++)
                        {
                        if (vertical) n = a - a * abs(i - s) / border;
-                       *pp = (r * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       *pp = (g * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       *pp = (b * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       if (has_alpha) pp++;
+                       pp[0] = (r * n + pp[0] * (256-n)) >> 8;
+                       pp[1] = (g * n + pp[1] * (256-n)) >> 8;
+                       pp[2] = (b * n + pp[2] * (256-n)) >> 8;
+                       pp += p_step;
                        }
                }
 }
@@ -1308,11 +1375,12 @@ static void pixbuf_draw_fade_linear(guchar *p_pix, gint prs, gboolean has_alpha,
 static void pixbuf_draw_fade_radius(guchar *p_pix, gint prs, gboolean has_alpha,
                                    gint sx, gint sy, gint border,
                                    gint x1, gint y1, gint x2, gint y2,
-                                   guint8 UNUSED(r), guint8 g, guint8 b, guint8 a)
+                                   guint8, guint8 g, guint8 b, guint8 a)
 {
        guchar *pp;
        gint p_step;
-       gint i, j;
+       gint i;
+       gint j;
 
        p_step = (has_alpha) ? 4 : 3;
        for (j = y1; j < y2; j++)
@@ -1323,15 +1391,12 @@ static void pixbuf_draw_fade_radius(guchar *p_pix, gint prs, gboolean has_alpha,
                        guint8 n;
                        gint r;
 
-                       r = MIN(border, (gint)sqrt((i-sx)*(i-sx) + (j-sy)*(j-sy)));
+                       r = MIN(border, (gint)hypot(i - sx, j - sy));
                        n = a - a * r / border;
-                       *pp = (r * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       *pp = (g * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       *pp = (b * n + *pp * (256-n)) >> 8;
-                       pp++;
-                       if (has_alpha) pp++;
+                       pp[0] = (r * n + pp[0] * (256-n)) >> 8;
+                       pp[1] = (g * n + pp[1] * (256-n)) >> 8;
+                       pp[2] = (b * n + pp[2] * (256-n)) >> 8;
+                       pp += p_step;
                        }
                }
 }
@@ -1342,9 +1407,17 @@ void pixbuf_draw_shadow(GdkPixbuf *pb,
                        guint8 r, guint8 g, guint8 b, guint8 a)
 {
        gint has_alpha;
-       gint pw, ph, prs;
-       gint rx, ry, rw, rh;
-       gint fx, fy, fw, fh;
+       gint pw;
+       gint ph;
+       gint prs;
+       gint rx;
+       gint ry;
+       gint rw;
+       gint rh;
+       gint fx;
+       gint fy;
+       gint fw;
+       gint fh;
        guchar *p_pix;
 
        if (!pb) return;
@@ -1454,10 +1527,13 @@ void pixbuf_desaturate_rect(GdkPixbuf *pb,
                            gint x, gint y, gint w, gint h)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
+       gint pw;
+       gint ph;
+       gint prs;
        guchar *p_pix;
        guchar *pp;
-       gint i, j;
+       gint i;
+       gint j;
 
        if (!pb) return;
 
@@ -1471,21 +1547,20 @@ void pixbuf_desaturate_rect(GdkPixbuf *pb,
        prs = gdk_pixbuf_get_rowstride(pb);
        p_pix = gdk_pixbuf_get_pixels(pb);
 
+       const gint p_step = has_alpha ? 4 : 3;
+
        for (i = 0; i < h; i++)
                {
-               pp = p_pix + (y + i) * prs + (x * (has_alpha ? 4 : 3));
+               pp = p_pix + (y + i) * prs + (x * p_step);
                for (j = 0; j < w; j++)
                        {
                        guint8 grey;
 
                        grey = (pp[0] + pp[1] + pp[2]) / 3;
-                       *pp = grey;
-                       pp++;
-                       *pp = grey;
-                       pp++;
-                       *pp = grey;
-                       pp++;
-                       if (has_alpha) pp++;
+                       pp[0] = grey;
+                       pp[1] = grey;
+                       pp[2] = grey;
+                       pp += p_step;
                        }
                }
 }
@@ -1497,10 +1572,13 @@ void pixbuf_desaturate_rect(GdkPixbuf *pb,
 void pixbuf_highlight_overunderexposed(GdkPixbuf *pb, gint x, gint y, gint w, gint h)
 {
        gboolean has_alpha;
-       gint pw, ph, prs;
+       gint pw;
+       gint ph;
+       gint prs;
        guchar *p_pix;
        guchar *pp;
-       gint i, j;
+       gint i;
+       gint j;
 
        if (!pb) return;
 
@@ -1514,26 +1592,20 @@ void pixbuf_highlight_overunderexposed(GdkPixbuf *pb, gint x, gint y, gint w, gi
        prs = gdk_pixbuf_get_rowstride(pb);
        p_pix = gdk_pixbuf_get_pixels(pb);
 
+       const gint p_step = has_alpha ? 4 : 3;
+
        for (i = 0; i < h; i++)
                {
-               pp = p_pix + (y + i) * prs + (x * (has_alpha ? 4 : 3));
+               pp = p_pix + (y + i) * prs + (x * p_step);
                for (j = 0; j < w; j++)
                        {
                        if (pp[0] == 255 || pp[1] == 255 || pp[2] == 255 || pp[0] == 0 || pp[1] == 0 || pp[2] == 0)
                                {
-                               *pp = 255;
-                               pp++;
-                               *pp = 0;
-                               pp++;
-                               *pp = 0;
-                               pp++;
-                               if (has_alpha) pp++;
-                               }
-                       else
-                               {
-                               pp = pp + 3;
-                               if (has_alpha) pp++;
+                               pp[0] = 255;
+                               pp[1] = 0;
+                               pp[2] = 0;
                                }
+                       pp += p_step;
                        }
                }
 }
@@ -1547,10 +1619,13 @@ void pixbuf_ignore_alpha_rect(GdkPixbuf *pb,
                  gint x, gint y, gint w, gint h)
 {
    gboolean has_alpha;
-   gint pw, ph, prs;
+   gint pw;
+   gint ph;
+   gint prs;
    guchar *p_pix;
    guchar *pp;
-   gint i, j;
+   gint i;
+   gint j;
 
    if (!pb) return;