Use gdk_rectangle_intersect() in pan-view
[geeqie.git] / src / ui-utildlg.cc
index cbef47e..1130b47 100644 (file)
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#include <string.h>
-
-#include "main.h"
 #include "ui-utildlg.h"
 
+#include <cstdint>
+#include <cstdio>
+#include <cstring>
+#include <ctime>
+
+#include <gdk/gdk.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+
+#include <config.h>
+
+#include "compat.h"
+#include "debug.h"
 #include "filedata.h"
+#include "intl.h"
+#include "main-defines.h"
+#include "misc.h"
+#include "options.h"
 #include "rcfile.h"
 #include "ui-fileops.h"
 #include "ui-misc.h"
 #include "ui-tabcomp.h"
 #include "window.h"
 
+namespace
+{
+
+constexpr gint max_buffer_size = 16384;
+} // namespace
+
 /*
  *-----------------------------------------------------------------------------
  * generic dialog
  *-----------------------------------------------------------------------------
  */
 
-typedef struct _DialogWindow DialogWindow;
-struct _DialogWindow
+struct DialogWindow
 {
        gint x;
        gint y;
@@ -49,7 +68,7 @@ struct _DialogWindow
        gchar *role;
 };
 
-static GList *dialog_windows = NULL;
+static GList *dialog_windows = nullptr;
 
 static void generic_dialog_save_window(const gchar *title, const gchar *role, gint x, gint y, gint h, gint w)
 {
@@ -58,7 +77,7 @@ static void generic_dialog_save_window(const gchar *title, const gchar *role, gi
        work = g_list_first(dialog_windows);
        while (work)
                {
-               DialogWindow *dw = work->data;
+               auto dw = static_cast<DialogWindow *>(work->data);
                if (g_strcmp0(dw->title ,title) == 0 && g_strcmp0(dw->role, role) == 0)
                        {
                        dw->x = x;
@@ -70,7 +89,7 @@ static void generic_dialog_save_window(const gchar *title, const gchar *role, gi
                work = work->next;
                }
 
-       DialogWindow *dw = g_new0(DialogWindow, 1);
+       auto dw = g_new0(DialogWindow, 1);
        dw->title = g_strdup(title);
        dw->role = g_strdup(role);
        dw->x = x;
@@ -88,7 +107,7 @@ static gboolean generic_dialog_find_window(const gchar *title, const gchar *role
        work = g_list_first(dialog_windows);
        while (work)
                {
-               DialogWindow *dw = work->data;
+               auto dw = static_cast<DialogWindow *>(work->data);
 
                if (g_strcmp0(dw->title,title) == 0 && g_strcmp0(dw->role, role) == 0)
                        {
@@ -108,7 +127,10 @@ void generic_dialog_close(GenericDialog *gd)
        gchar *ident_string;
        gchar *full_title;
        gchar *actual_title;
-       gint x, y, h, w;
+       gint x;
+       gint y;
+       gint h;
+       gint w;
 
        gdk_window_get_root_origin(gtk_widget_get_window (gd->dialog), &x, &y);
        w = gdk_window_get_width(gtk_widget_get_window (gd->dialog));
@@ -123,7 +145,7 @@ void generic_dialog_close(GenericDialog *gd)
 
        generic_dialog_save_window(actual_title, gtk_window_get_role(GTK_WINDOW(gd->dialog)), x, y, w, h);
 
-       gtk_widget_destroy(gd->dialog);
+       gq_gtk_widget_destroy(gd->dialog);
        g_free(gd);
        g_free(ident_string);
        g_free(full_title);
@@ -132,11 +154,11 @@ void generic_dialog_close(GenericDialog *gd)
 
 static void generic_dialog_click_cb(GtkWidget *widget, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
        void (*func)(GenericDialog *, gpointer);
        gboolean auto_close;
 
-       func = (void(*)(GenericDialog *, gpointer))(g_object_get_data(G_OBJECT(widget), "dialog_function"));
+       func = reinterpret_cast<void(*)(GenericDialog *, gpointer)>(g_object_get_data(G_OBJECT(widget), "dialog_function"));
        auto_close = gd->auto_close;
 
        if (func) func(gd, gd->data);
@@ -145,7 +167,7 @@ static void generic_dialog_click_cb(GtkWidget *widget, gpointer data)
 
 static gboolean generic_dialog_default_key_press_cb(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
 
        if (event->keyval == GDK_KEY_Return && gtk_widget_has_focus(widget)
            && gd->default_cb)
@@ -170,7 +192,7 @@ void generic_dialog_attach_default(GenericDialog *gd, GtkWidget *widget)
 
 static gboolean generic_dialog_key_press_cb(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
        gboolean auto_close = gd->auto_close;
 
        if (event->keyval == GDK_KEY_Escape)
@@ -189,9 +211,9 @@ static gboolean generic_dialog_key_press_cb(GtkWidget *widget, GdkEventKey *even
        return FALSE;
 }
 
-static gboolean generic_dialog_delete_cb(GtkWidget *UNUSED(w), GdkEventAny *UNUSED(event), gpointer data)
+static gboolean generic_dialog_delete_cb(GtkWidget *, GdkEventAny *, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
        gboolean auto_close;
 
        auto_close = gd->auto_close;
@@ -204,7 +226,7 @@ static gboolean generic_dialog_delete_cb(GtkWidget *UNUSED(w), GdkEventAny *UNUS
 
 static void generic_dialog_show_cb(GtkWidget *widget, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
        if (gd->cancel_button)
                {
                gtk_box_reorder_child(GTK_BOX(gd->hbox), gd->cancel_button, -1);
@@ -229,19 +251,19 @@ gboolean generic_dialog_get_alternative_button_order(GtkWidget *widget)
        return alternative_order;
 }
 
-GtkWidget *generic_dialog_add_button(GenericDialog *gd, const gchar *stock_id, const gchar *text,
+GtkWidget *generic_dialog_add_button(GenericDialog *gd, const gchar *icon_name, const gchar *text,
                                     void (*func_cb)(GenericDialog *, gpointer), gboolean is_default)
 {
        GtkWidget *button;
        gboolean alternative_order;
 
-       button = pref_button_new(NULL, stock_id, text, FALSE,
+       button = pref_button_new(nullptr, icon_name, text,
                                 G_CALLBACK(generic_dialog_click_cb), gd);
 
        gtk_widget_set_can_default(button, TRUE);
-       g_object_set_data(G_OBJECT(button), "dialog_function", (void *)func_cb);
+       g_object_set_data(G_OBJECT(button), "dialog_function", reinterpret_cast<void *>(func_cb));
 
-       gtk_container_add(GTK_CONTAINER(gd->hbox), button);
+       gq_gtk_container_add(GTK_WIDGET(gd->hbox), button);
 
        alternative_order = generic_dialog_get_alternative_button_order(gd->hbox);
 
@@ -264,17 +286,17 @@ GtkWidget *generic_dialog_add_button(GenericDialog *gd, const gchar *stock_id, c
 }
 
 /**
- * @brief 
- * @param gd 
- * @param icon_stock_id 
- * @param heading 
- * @param text 
- * @param expand Used as the "expand" and "fill" parameters in the eventual call to gtk_box_pack_start() 
- * @returns 
- * 
- * 
+ * @brief
+ * @param gd
+ * @param icon_stock_id
+ * @param heading
+ * @param text
+ * @param expand Used as the "expand" and "fill" parameters in the eventual call to gq_gtk_box_pack_start()
+ * @returns
+ *
+ *
  */
-GtkWidget *generic_dialog_add_message(GenericDialog *gd, const gchar *icon_stock_id,
+GtkWidget *generic_dialog_add_message(GenericDialog *gd, const gchar *icon_name,
                                      const gchar *heading, const gchar *text, gboolean expand)
 {
        GtkWidget *hbox;
@@ -282,14 +304,14 @@ GtkWidget *generic_dialog_add_message(GenericDialog *gd, const gchar *icon_stock
        GtkWidget *label;
 
        hbox = pref_box_new(gd->vbox, expand, GTK_ORIENTATION_HORIZONTAL, PREF_PAD_SPACE);
-       if (icon_stock_id)
+       if (icon_name)
                {
                GtkWidget *image;
 
-               image = gtk_image_new_from_stock(icon_stock_id, GTK_ICON_SIZE_DIALOG);
+               image = gtk_image_new_from_icon_name(icon_name, GTK_ICON_SIZE_DIALOG);
                gtk_widget_set_halign(GTK_WIDGET(image), GTK_ALIGN_CENTER);
                gtk_widget_set_valign(GTK_WIDGET(image), GTK_ALIGN_START);
-               gtk_box_pack_start(GTK_BOX(hbox), image, FALSE, FALSE, 0);
+               gq_gtk_box_pack_start(GTK_BOX(hbox), image, FALSE, FALSE, 0);
                gtk_widget_show(image);
                }
 
@@ -314,9 +336,9 @@ GtkWidget *generic_dialog_add_message(GenericDialog *gd, const gchar *icon_stock
 
 void generic_dialog_windows_load_config(const gchar **attribute_names, const gchar **attribute_values)
 {
-       DialogWindow *dw =  g_new0(DialogWindow, 1);
-       gchar *title = NULL;
-       gchar *role = NULL;
+       auto dw =  g_new0(DialogWindow, 1);
+       gchar *title = nullptr;
+       gchar *role = nullptr;
        gint x = 0;
        gint y = 0;
        gint w = 0;
@@ -361,7 +383,7 @@ void generic_dialog_windows_write_config(GString *outstr, gint indent)
                work = g_list_first(dialog_windows);
                while (work)
                        {
-                       DialogWindow *dw = work->data;
+                       auto dw = static_cast<DialogWindow *>(work->data);
                        WRITE_NL(); WRITE_STRING("<window ");
                        write_char_option(outstr, indent + 1, "title", dw->title);
                        write_char_option(outstr, indent + 1, "role", dw->role);
@@ -384,14 +406,17 @@ static void generic_dialog_setup(GenericDialog *gd,
                                 void (*cancel_cb)(GenericDialog *, gpointer), gpointer data)
 {
        GtkWidget *vbox;
-       gint x, y, w, h;
+       gint x;
+       gint y;
+       gint w;
+       gint h;
        GtkWidget *scrolled;
 
        gd->auto_close = auto_close;
        gd->data = data;
        gd->cancel_cb = cancel_cb;
 
-       gd->dialog = window_new(GTK_WINDOW_TOPLEVEL, role, NULL, NULL, title);
+       gd->dialog = window_new(role, nullptr, nullptr, title);
        DEBUG_NAME(gd->dialog);
        gtk_window_set_type_hint(GTK_WINDOW(gd->dialog), GDK_WINDOW_TYPE_HINT_DIALOG);
 
@@ -400,13 +425,13 @@ static void generic_dialog_setup(GenericDialog *gd,
                if (generic_dialog_find_window(title, role, &x, &y, &w, &h))
                        {
                        gtk_window_set_default_size(GTK_WINDOW(gd->dialog), w, h);
-                       gtk_window_move(GTK_WINDOW(gd->dialog), x, y);
+                       gq_gtk_window_move(GTK_WINDOW(gd->dialog), x, y);
                        }
                }
 
        if (parent)
                {
-               GtkWindow *window = NULL;
+               GtkWindow *window = nullptr;
 
                if (GTK_IS_WINDOW(parent))
                        {
@@ -431,33 +456,33 @@ static void generic_dialog_setup(GenericDialog *gd,
        gtk_window_set_resizable(GTK_WINDOW(gd->dialog), TRUE);
        gtk_container_set_border_width(GTK_CONTAINER(gd->dialog), PREF_PAD_BORDER);
 
-       scrolled = gtk_scrolled_window_new(NULL, NULL);
+       scrolled = gq_gtk_scrolled_window_new(nullptr, nullptr);
        gtk_scrolled_window_set_propagate_natural_height(GTK_SCROLLED_WINDOW(scrolled), TRUE);
        gtk_scrolled_window_set_propagate_natural_width(GTK_SCROLLED_WINDOW(scrolled), TRUE);
        vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, PREF_PAD_BUTTON_SPACE);
-       gtk_container_add(GTK_CONTAINER(scrolled), vbox);
-       gtk_container_add(GTK_CONTAINER(gd->dialog), scrolled);
+       gq_gtk_container_add(GTK_WIDGET(scrolled), vbox);
+       gq_gtk_container_add(GTK_WIDGET(gd->dialog), scrolled);
        gtk_widget_show(scrolled);
 
        gtk_widget_show(vbox);
 
        gd->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, PREF_PAD_GAP);
-       gtk_box_pack_start(GTK_BOX(vbox), gd->vbox, TRUE, TRUE, 0);
+       gq_gtk_box_pack_start(GTK_BOX(vbox), gd->vbox, TRUE, TRUE, 0);
        gtk_widget_show(gd->vbox);
 
-       gd->hbox = gtk_hbutton_box_new();
+       gd->hbox = gtk_button_box_new(GTK_ORIENTATION_HORIZONTAL);
        gtk_button_box_set_layout(GTK_BUTTON_BOX(gd->hbox), GTK_BUTTONBOX_END);
        gtk_box_set_spacing(GTK_BOX(gd->hbox), PREF_PAD_BUTTON_GAP);
-       gtk_box_pack_start(GTK_BOX(vbox), gd->hbox, FALSE, FALSE, 0);
+       gq_gtk_box_pack_start(GTK_BOX(vbox), gd->hbox, FALSE, FALSE, 0);
        gtk_widget_show(gd->hbox);
 
        if (gd->cancel_cb)
                {
-               gd->cancel_button = generic_dialog_add_button(gd, GTK_STOCK_CANCEL, NULL, gd->cancel_cb, TRUE);
+               gd->cancel_button = generic_dialog_add_button(gd, GQ_ICON_CANCEL, _("Cancel"), gd->cancel_cb, TRUE);
                }
        else
                {
-               gd->cancel_button = NULL;
+               gd->cancel_button = nullptr;
                }
 
        if (generic_dialog_get_alternative_button_order(gd->hbox))
@@ -466,7 +491,7 @@ static void generic_dialog_setup(GenericDialog *gd,
                                 G_CALLBACK(generic_dialog_show_cb), gd);
                }
 
-       gd->default_cb = NULL;
+       gd->default_cb = nullptr;
 }
 
 GenericDialog *generic_dialog_new(const gchar *title,
@@ -487,26 +512,204 @@ GenericDialog *generic_dialog_new(const gchar *title,
  *-----------------------------------------------------------------------------
  */
 
-static void warning_dialog_ok_cb(GenericDialog *UNUSED(gd), gpointer UNUSED(data))
+static void warning_dialog_ok_cb(GenericDialog *, gpointer)
 {
        /* no op */
 }
 
 GenericDialog *warning_dialog(const gchar *heading, const gchar *text,
-                             const gchar *icon_stock_id, GtkWidget *parent)
+                             const gchar *icon_name, GtkWidget *parent)
 {
        GenericDialog *gd;
 
-       gd = generic_dialog_new(heading, "warning", parent, TRUE, NULL, NULL);
-       generic_dialog_add_button(gd, GTK_STOCK_OK, NULL, warning_dialog_ok_cb, TRUE);
+       gd = generic_dialog_new(heading, "warning", parent, TRUE, nullptr, nullptr);
+       generic_dialog_add_button(gd, GQ_ICON_OK, "OK", warning_dialog_ok_cb, TRUE);
 
-       generic_dialog_add_message(gd, icon_stock_id, heading, text, TRUE);
+       generic_dialog_add_message(gd, icon_name, heading, text, TRUE);
 
        gtk_widget_show(gd->dialog);
 
        return gd;
 }
 
+/*
+ *-----------------------------------------------------------------------------
+ * AppImage version update notification message with fade-out
+ *-----------------------------------------------------------------------------
+ *
+ * If the current version is not on GitHub, assume a newer one is available
+ * and show a fade-out message.
+ */
+
+struct AppImageData
+{
+       GThreadPool *thread_pool;
+       GtkWidget *window;
+       guint id;
+};
+
+static gboolean appimage_notification_close_cb(gpointer data)
+{
+       auto appimage_data = static_cast<AppImageData *>(data);
+
+       if (appimage_data->window && gtk_widget_get_opacity(appimage_data->window) != 0)
+               {
+               g_source_remove(appimage_data->id);
+               }
+
+       if (appimage_data->window)
+               {
+               gq_gtk_widget_destroy(appimage_data->window);
+               }
+
+       g_thread_pool_free(appimage_data->thread_pool, TRUE, TRUE);
+       g_free(appimage_data);
+
+       return G_SOURCE_REMOVE;
+}
+
+static gboolean appimage_notification_fade_cb(gpointer data)
+{
+       auto appimage_data = static_cast<AppImageData *>(data);
+
+       gtk_widget_set_opacity(appimage_data->window, (gtk_widget_get_opacity(appimage_data->window) - 0.02));
+
+       if (gtk_widget_get_opacity(appimage_data->window) == 0)
+               {
+               g_idle_add(appimage_notification_close_cb, data);
+
+               return FALSE;
+               }
+
+       return TRUE;
+}
+
+static gboolean user_close_cb(GtkWidget *, GdkEvent *, gpointer data)
+{
+       auto appimage_data = static_cast<AppImageData *>(data);
+
+       g_idle_add(appimage_notification_close_cb, appimage_data);
+
+       return FALSE;
+}
+
+static void show_notification_message(AppImageData *appimage_data)
+{
+       GtkBuilder *builder;
+
+       builder = gtk_builder_new_from_resource(GQ_RESOURCE_PATH_UI "/appimage-notification.ui");
+
+       appimage_data->window = GTK_WIDGET(gtk_builder_get_object(builder, "appimage_notification"));
+
+       GdkRectangle workarea;
+       gdk_monitor_get_workarea(gdk_display_get_primary_monitor(gdk_display_get_default()),
+                             &workarea);
+       gq_gtk_window_move(GTK_WINDOW(appimage_data->window), workarea.width * 0.8, workarea.height / 20);
+       g_signal_connect(appimage_data->window, "focus-in-event", G_CALLBACK(user_close_cb), appimage_data);
+       appimage_data->id = g_timeout_add(100, appimage_notification_fade_cb, appimage_data);
+
+       g_object_unref(builder);
+       gtk_widget_show(appimage_data->window);
+}
+
+void appimage_notification_func(gpointer data, gpointer)
+{
+       FILE *pipe;
+       GNetworkMonitor *net_mon;
+       GSocketConnectable *geeqie_github;
+       auto appimage_data = static_cast<AppImageData *>(data);
+       char buffer[max_buffer_size];
+       char result[max_buffer_size];
+       gboolean internet_available = FALSE;
+       gchar **github_split;
+       gchar **version_split;
+       gchar *start_date;
+       struct tm current_version_date;
+       struct tm github_version_date;
+       unsigned int day;
+       unsigned int month;
+       unsigned int year;
+
+       /* If this is a release version, do not check for updates */
+       if (g_strrstr(VERSION, "git"))
+               {
+               net_mon = g_network_monitor_get_default();
+               geeqie_github = g_network_address_parse_uri("https://github.com/", 80, nullptr);
+
+               if (geeqie_github)
+                       {
+                       internet_available = g_network_monitor_can_reach(net_mon, geeqie_github, nullptr, nullptr);
+                       g_object_unref(geeqie_github);
+                       }
+
+               if (internet_available)
+                       {
+                       /* VERSION looks like: 2.0.1+git20220116-c791cbee */
+                       version_split = g_strsplit_set(VERSION, "+-", -1);
+
+                       sscanf(version_split[1] + 3, "%4u%2u%2u", &year, &month, &day);
+                       current_version_date.tm_year  = year - 1900;
+                       current_version_date.tm_mon   = month - 1;
+                       current_version_date.tm_mday  = day;
+                       current_version_date.tm_hour  = 0;
+                       current_version_date.tm_min   = 0;
+                       current_version_date.tm_sec   = 0;
+                       current_version_date.tm_isdst = 0;
+
+                       pipe = popen("curl --max-time 2 --silent https://api.github.com/repos/BestImageViewer/geeqie/releases/tags/continuous", "r");
+
+                       if (pipe == nullptr)
+                               {
+                               log_printf("Failed to get date from GitHub");
+                               }
+                       else
+                               {
+                               while (fgets(buffer, max_buffer_size, pipe) != nullptr)
+                                       {
+                                       strcat(result, buffer);
+                                       }
+                               pclose(pipe);
+
+                               /* GitHub date looks like: "published_at": "2024-04-17T08:50:08Z" */
+                               start_date = g_strstr_len(result, -1, "published");
+                               start_date[26] = '\0';
+
+                               github_split = g_strsplit_set(start_date, "\"-", -1);
+
+                               sscanf(github_split[2], "%4u", &year);
+                               sscanf(github_split[3], "%2u", &month);
+                               sscanf(github_split[4], "%2u", &day);
+
+                               github_version_date.tm_year  = year - 1900;
+                               github_version_date.tm_mon   = month - 1;
+                               github_version_date.tm_mday  = day;
+                               github_version_date.tm_hour  = 0;
+                               github_version_date.tm_min   = 0;
+                               github_version_date.tm_sec   = 0;
+                               github_version_date.tm_isdst = 0;
+
+                               if (mktime(&github_version_date) > mktime(&current_version_date))
+                                       {
+                                       show_notification_message(appimage_data);
+                                       }
+
+                               g_strfreev(github_split);
+                               }
+                       g_strfreev(version_split);
+                       }
+               }
+}
+
+void appimage_notification()
+{
+       AppImageData *appimage_data;
+
+       appimage_data = g_new0(AppImageData, 1);
+
+       appimage_data->thread_pool = g_thread_pool_new(appimage_notification_func, appimage_data, 1, FALSE, nullptr);
+       g_thread_pool_push(appimage_data->thread_pool, appimage_data, nullptr);
+}
+
 /*
  *-----------------------------------------------------------------------------
  * generic file ops dialog routines
@@ -527,13 +730,13 @@ FileDialog *file_dialog_new(const gchar *title,
                            GtkWidget *parent,
                            void (*cancel_cb)(FileDialog *, gpointer), gpointer data)
 {
-       FileDialog *fdlg = NULL;
+       FileDialog *fdlg = nullptr;
 
        fdlg = g_new0(FileDialog, 1);
 
        generic_dialog_setup(GENERIC_DIALOG(fdlg), title,
                             role, parent, FALSE,
-                            (void(*)(GenericDialog *, gpointer))cancel_cb, data);
+                            reinterpret_cast<void(*)(GenericDialog *, gpointer)>(cancel_cb), data);
 
        return fdlg;
 }
@@ -542,21 +745,21 @@ GtkWidget *file_dialog_add_button(FileDialog *fdlg, const gchar *stock_id, const
                                  void (*func_cb)(FileDialog *, gpointer), gboolean is_default)
 {
        return generic_dialog_add_button(GENERIC_DIALOG(fdlg), stock_id, text,
-                                        (void(*)(GenericDialog *, gpointer))func_cb, is_default);
+                                        reinterpret_cast<void(*)(GenericDialog *, gpointer)>(func_cb), is_default);
 }
 
-static void file_dialog_entry_cb(GtkWidget *UNUSED(widget), gpointer data)
+static void file_dialog_entry_cb(GtkWidget *, gpointer data)
 {
-       FileDialog *fdlg = data;
+       auto fdlg = static_cast<FileDialog *>(data);
        g_free(fdlg->dest_path);
-       fdlg->dest_path = remove_trailing_slash(gtk_entry_get_text(GTK_ENTRY(fdlg->entry)));
+       fdlg->dest_path = remove_trailing_slash(gq_gtk_entry_get_text(GTK_ENTRY(fdlg->entry)));
 }
 
-static void file_dialog_entry_enter_cb(const gchar *UNUSED(path), gpointer data)
+static void file_dialog_entry_enter_cb(const gchar *, gpointer data)
 {
-       GenericDialog *gd = data;
+       auto gd = static_cast<GenericDialog *>(data);
 
-       file_dialog_entry_cb(NULL, data);
+       file_dialog_entry_cb(nullptr, data);
 
        if (gd->default_cb) gd->default_cb(gd, gd->data);
 }
@@ -569,9 +772,9 @@ void file_dialog_add_path_widgets(FileDialog *fdlg, const gchar *default_path, c
 
        if (fdlg->entry) return;
 
-       tabcomp = tab_completion_new_with_history(&fdlg->entry, NULL,
+       tabcomp = tab_completion_new_with_history(&fdlg->entry, nullptr,
                  history_key, -1, file_dialog_entry_enter_cb, fdlg);
-       gtk_box_pack_end(GTK_BOX(GENERIC_DIALOG(fdlg)->vbox), tabcomp, FALSE, FALSE, 0);
+       gq_gtk_box_pack_end(GTK_BOX(GENERIC_DIALOG(fdlg)->vbox), tabcomp, FALSE, FALSE, 0);
        generic_dialog_attach_default(GENERIC_DIALOG(fdlg), fdlg->entry);
        gtk_widget_show(tabcomp);
 
@@ -600,13 +803,13 @@ void file_dialog_add_path_widgets(FileDialog *fdlg, const gchar *default_path, c
 
        list = path_selection_new_with_files(fdlg->entry, fdlg->dest_path, filter, filter_desc);
        path_selection_add_select_func(fdlg->entry, file_dialog_entry_enter_cb, fdlg);
-       gtk_box_pack_end(GTK_BOX(GENERIC_DIALOG(fdlg)->vbox), list, TRUE, TRUE, 0);
+       gq_gtk_box_pack_end(GTK_BOX(GENERIC_DIALOG(fdlg)->vbox), list, TRUE, TRUE, 0);
        gtk_widget_show(list);
 
        gtk_widget_grab_focus(fdlg->entry);
        if (fdlg->dest_path)
                {
-               gtk_entry_set_text(GTK_ENTRY(fdlg->entry), fdlg->dest_path);
+               gq_gtk_entry_set_text(GTK_ENTRY(fdlg->entry), fdlg->dest_path);
                gtk_editable_set_position(GTK_EDITABLE(fdlg->entry), strlen(fdlg->dest_path));
                }
 
@@ -614,17 +817,20 @@ void file_dialog_add_path_widgets(FileDialog *fdlg, const gchar *default_path, c
                         G_CALLBACK(file_dialog_entry_cb), fdlg);
 }
 
-//void file_dialog_add_filter(FileDialog *fdlg, const gchar *filter, const gchar *filter_desc, gboolean set)
-//{
-       //if (!fdlg->entry) return;
-       //path_selection_add_filter(fdlg->entry, filter, filter_desc, set);
-//}
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-function"
+void file_dialog_add_filter_unused(FileDialog *fdlg, const gchar *filter, const gchar *filter_desc, gboolean set)
+{
+       if (!fdlg->entry) return;
+       path_selection_add_filter(fdlg->entry, filter, filter_desc, set);
+}
 
-//void file_dialog_clear_filter(FileDialog *fdlg)
-//{
-       //if (!fdlg->entry) return;
-       //path_selection_clear_filter(fdlg->entry);
-//}
+void file_dialog_clear_filter_unused(FileDialog *fdlg)
+{
+       if (!fdlg->entry) return;
+       path_selection_clear_filter(fdlg->entry);
+}
+#pragma GCC diagnostic pop
 
 void file_dialog_sync_history(FileDialog *fdlg, gboolean dir_only)
 {