Drop unused variables.
[geeqie.git] / src / view_file_icon.c
index 712d939..b11a9db 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * Geeqie
  * (C) 2006 John Ellis
- * Copyright (C) 2008 - 2009 The Geeqie Team
+ * Copyright (C) 2008 - 2012 The Geeqie Team
  *
  * Author: John Ellis
  *
@@ -99,7 +99,7 @@ static gint iconlist_read(FileData *dir_fd, GList **list)
                IconData *id;
 
                fd = work->data;
-               g_assert(fd->magick == 0x12345678);
+               g_assert(fd->magick == FD_MAGICK);
                id = g_new0(IconData, 1);
 
                id->selected = SELECTION_NONE;
@@ -161,6 +161,11 @@ static void vficon_populate_at_new_size(ViewFile *vf, gint w, gint h, gboolean f
  *-----------------------------------------------------------------------------
  */
 
+GList *vficon_selection_get_one(ViewFile *vf, FileData *fd)
+{
+       return g_list_prepend(filelist_copy(fd->sidecar_files), file_data_ref(fd));
+}
+
 GList *vficon_pop_menu_file_list(ViewFile *vf)
 {
        if (!VFICON(vf)->click_id) return NULL;
@@ -170,7 +175,7 @@ GList *vficon_pop_menu_file_list(ViewFile *vf)
                return vf_selection_get_list(vf);
                }
 
-       return g_list_append(NULL, file_data_ref(VFICON(vf)->click_id->fd));
+       return vficon_selection_get_one(vf, VFICON(vf)->click_id->fd);
 }
 
 void vficon_pop_menu_view_cb(GtkWidget *widget, gpointer data)
@@ -262,10 +267,12 @@ static void vficon_send_layout_select(ViewFile *vf, IconData *id)
 
 static void vficon_toggle_filenames(ViewFile *vf)
 {
+       GtkAllocation allocation;
        VFICON(vf)->show_text = !VFICON(vf)->show_text;
        options->show_icon_names = VFICON(vf)->show_text;
 
-       vficon_populate_at_new_size(vf, vf->listview->allocation.width, vf->listview->allocation.height, TRUE);
+       gtk_widget_get_allocation(vf->listview, &allocation);
+       vficon_populate_at_new_size(vf, allocation.width, allocation.height, TRUE);
 }
 
 static gint vficon_get_icon_width(ViewFile *vf)
@@ -426,7 +433,7 @@ static void tip_show(ViewFile *vf)
 
        gdk_window_get_pointer(NULL, &x, &y, NULL);
 
-       if (!GTK_WIDGET_REALIZED(VFICON(vf)->tip_window)) gtk_widget_realize(VFICON(vf)->tip_window);
+       if (!gtk_widget_get_realized(VFICON(vf)->tip_window)) gtk_widget_realize(VFICON(vf)->tip_window);
        gtk_window_move(GTK_WINDOW(VFICON(vf)->tip_window), x + 16, y + 16);
        gtk_widget_show(VFICON(vf)->tip_window);
 }
@@ -446,8 +453,8 @@ static gboolean tip_schedule_cb(gpointer data)
 
        window = gtk_widget_get_toplevel(vf->listview);
 
-       if (GTK_WIDGET_SENSITIVE(window) &&
-           GTK_WINDOW(window)->has_focus)
+       if (gtk_widget_get_sensitive(window) &&
+           gtk_window_has_toplevel_focus(GTK_WINDOW(window)))
                {
                tip_show(vf);
                }
@@ -527,8 +534,6 @@ static void vficon_dnd_get(GtkWidget *widget, GdkDragContext *context,
 {
        ViewFile *vf = data;
        GList *list = NULL;
-       gchar *uri_text = NULL;
-       gint total;
 
        if (!VFICON(vf)->click_id) return;
 
@@ -542,14 +547,8 @@ static void vficon_dnd_get(GtkWidget *widget, GdkDragContext *context,
                }
 
        if (!list) return;
-       uri_text = uri_text_from_filelist(list, &total, (info == TARGET_TEXT_PLAIN));
+       uri_selection_data_set_uris_from_filelist(selection_data, list);
        filelist_free(list);
-
-       DEBUG_1("%s", uri_text);
-
-       gtk_selection_data_set(selection_data, selection_data->target,
-                              8, (guchar *)uri_text, total);
-       g_free(uri_text);
 }
 
 static void vficon_drag_data_received(GtkWidget *entry_widget, GdkDragContext *context,
@@ -564,7 +563,7 @@ static void vficon_drag_data_received(GtkWidget *entry_widget, GdkDragContext *c
                if (id && id->fd) {
                        /* Add keywords to file */
                        FileData *fd = id->fd;
-                       gchar *str = g_strndup((gchar *)selection->data, selection->length);
+                       gchar *str = gtk_selection_data_get_text(selection);
                        GList *kw_list = string_to_keywords_list(str);
                        
                        metadata_append_list(fd, KEYWORD_KEY, kw_list);
@@ -605,7 +604,7 @@ static void vficon_dnd_end(GtkWidget *widget, GdkDragContext *context, gpointer
 
        vficon_selection_remove(vf, VFICON(vf)->click_id, SELECTION_PRELIGHT, NULL);
 
-       if (context->action == GDK_ACTION_MOVE)
+       if (gdk_drag_context_get_selected_action(context) == GDK_ACTION_MOVE)
                {
                vf_refresh(vf);
                }
@@ -683,7 +682,9 @@ static void vficon_selection_remove(ViewFile *vf, IconData *id, SelectionType ma
 
 void vficon_marks_set(ViewFile *vf, gint enable)
 {
-       vficon_populate_at_new_size(vf, vf->listview->allocation.width, vf->listview->allocation.height, TRUE);
+       GtkAllocation allocation;
+       gtk_widget_get_allocation(vf->listview, &allocation);
+       vficon_populate_at_new_size(vf, allocation.width, allocation.height, TRUE);
 }
 
 /*
@@ -892,7 +893,7 @@ guint vficon_selection_count(ViewFile *vf, gint64 *bytes)
                        {
                        IconData *id = work->data;
                        FileData *fd = id->fd;
-                       g_assert(fd->magick == 0x12345678);
+                       g_assert(fd->magick == FD_MAGICK);
                        b += fd->size;
 
                        work = work->next;
@@ -907,16 +908,24 @@ guint vficon_selection_count(ViewFile *vf, gint64 *bytes)
 GList *vficon_selection_get_list(ViewFile *vf)
 {
        GList *list = NULL;
-       GList *work;
+       GList *work, *work2;
 
        work = VFICON(vf)->selection;
        while (work)
                {
                IconData *id = work->data;
                FileData *fd = id->fd;
-               g_assert(fd->magick == 0x12345678);
+               g_assert(fd->magick == FD_MAGICK);
 
                list = g_list_prepend(list, file_data_ref(fd));
+               
+               work2 = fd->sidecar_files;
+               while (work2)
+                       {
+                       fd = work2->data;
+                       list = g_list_prepend(list, file_data_ref(fd));
+                       work2 = work2->next;
+                       }
 
                work = work->next;
                }
@@ -984,7 +993,7 @@ void vficon_mark_to_selection(ViewFile *vf, gint mark, MarkToSelectionMode mode)
                FileData *fd = id->fd;
                gboolean mark_val, selected;
 
-               g_assert(fd->magick == 0x12345678);
+               g_assert(fd->magick == FD_MAGICK);
 
                mark_val = file_data_get_mark(fd, n);
                selected = (id->selected & SELECTION_SELECTED);
@@ -993,11 +1002,11 @@ void vficon_mark_to_selection(ViewFile *vf, gint mark, MarkToSelectionMode mode)
                        {
                        case MTS_MODE_SET: selected = mark_val;
                                break;
-                       case MTS_MODE_OR: selected = mark_val | selected;
+                       case MTS_MODE_OR: selected = mark_val || selected;
                                break;
-                       case MTS_MODE_AND: selected = mark_val & selected;
+                       case MTS_MODE_AND: selected = mark_val && selected;
                                break;
-                       case MTS_MODE_MINUS: selected = !mark_val & selected;
+                       case MTS_MODE_MINUS: selected = !mark_val && selected;
                                break;
                        }
 
@@ -1230,7 +1239,7 @@ static gint page_height(ViewFile *vf)
        gint ret;
 
        adj = gtk_tree_view_get_vadjustment(GTK_TREE_VIEW(vf->listview));
-       page_size = (gint)adj->page_increment;
+       page_size = (gint)gtk_adjustment_get_page_increment(adj);
 
        row_height = options->thumbnails.max_height + THUMB_BORDER_PADDING * 2;
        if (VFICON(vf)->show_text) row_height += options->thumbnails.max_height / 3;
@@ -1276,33 +1285,33 @@ gboolean vficon_press_key_cb(GtkWidget *widget, GdkEventKey *event, gpointer dat
        stop_signal = TRUE;
        switch (event->keyval)
                {
-               case GDK_Left: case GDK_KP_Left:
+               case GDK_KEY_Left: case GDK_KEY_KP_Left:
                        focus_col = -1;
                        break;
-               case GDK_Right: case GDK_KP_Right:
+               case GDK_KEY_Right: case GDK_KEY_KP_Right:
                        focus_col = 1;
                        break;
-               case GDK_Up: case GDK_KP_Up:
+               case GDK_KEY_Up: case GDK_KEY_KP_Up:
                        focus_row = -1;
                        break;
-               case GDK_Down: case GDK_KP_Down:
+               case GDK_KEY_Down: case GDK_KEY_KP_Down:
                        focus_row = 1;
                        break;
-               case GDK_Page_Up: case GDK_KP_Page_Up:
+               case GDK_KEY_Page_Up: case GDK_KEY_KP_Page_Up:
                        focus_row = -page_height(vf);
                        break;
-               case GDK_Page_Down: case GDK_KP_Page_Down:
+               case GDK_KEY_Page_Down: case GDK_KEY_KP_Page_Down:
                        focus_row = page_height(vf);
                        break;
-               case GDK_Home: case GDK_KP_Home:
+               case GDK_KEY_Home: case GDK_KEY_KP_Home:
                        focus_row = -VFICON(vf)->focus_row;
                        focus_col = -VFICON(vf)->focus_column;
                        break;
-               case GDK_End: case GDK_KP_End:
+               case GDK_KEY_End: case GDK_KEY_KP_End:
                        focus_row = VFICON(vf)->rows - 1 - VFICON(vf)->focus_row;
                        focus_col = VFICON(vf)->columns - 1 - VFICON(vf)->focus_column;
                        break;
-               case GDK_space:
+               case GDK_KEY_space:
                        id = vficon_find_data(vf, VFICON(vf)->focus_row, VFICON(vf)->focus_column, NULL);
                        if (id)
                                {
@@ -1330,7 +1339,7 @@ gboolean vficon_press_key_cb(GtkWidget *widget, GdkEventKey *event, gpointer dat
                                        }
                                }
                        break;
-               case GDK_Menu:
+               case GDK_KEY_Menu:
                        id = vficon_find_data(vf, VFICON(vf)->focus_row, VFICON(vf)->focus_column, NULL);
                        VFICON(vf)->click_id = id;
 
@@ -1427,7 +1436,7 @@ gboolean vficon_press_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer dat
        switch (bevent->button)
                {
                case MOUSE_BUTTON_LEFT:
-                       if (!GTK_WIDGET_HAS_FOCUS(vf->listview))
+                       if (!gtk_widget_has_focus(vf->listview))
                                {
                                gtk_widget_grab_focus(vf->listview);
                                }
@@ -1546,6 +1555,10 @@ static gboolean vficon_destroy_node_cb(GtkTreeModel *store, GtkTreePath *tpath,
        GList *list;
 
        gtk_tree_model_get(store, iter, FILE_COLUMN_POINTER, &list, -1);
+       
+       /* it seems that gtk_list_store_clear may call some callbacks
+          that use the column. Set the pointer to NULL to be safe. */
+       gtk_list_store_set(GTK_LIST_STORE(store), iter, FILE_COLUMN_POINTER, NULL, -1);
        g_list_free(list);
 
        return FALSE;
@@ -1590,7 +1603,7 @@ static void vficon_populate(ViewFile *vf, gboolean resize, gboolean keep_positio
 
        store = gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview));
 
-       if (keep_position && GTK_WIDGET_REALIZED(vf->listview) &&
+       if (keep_position && gtk_widget_get_realized(vf->listview) &&
            gtk_tree_view_get_path_at_pos(GTK_TREE_VIEW(vf->listview), 0, 0, &tpath, NULL, NULL, NULL))
                {
                GtkTreeIter iter;
@@ -1623,7 +1636,7 @@ static void vficon_populate(ViewFile *vf, gboolean resize, gboolean keep_positio
                        gtk_tree_view_column_set_visible(column, (i < VFICON(vf)->columns));
                        gtk_tree_view_column_set_fixed_width(column, thumb_width + (THUMB_BORDER_PADDING * 6));
 
-                       list = gtk_tree_view_column_get_cell_renderers(column);
+                       list = gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(column));
                        cell = (list) ? list->data : NULL;
                        g_list_free(list);
 
@@ -1637,7 +1650,7 @@ static void vficon_populate(ViewFile *vf, gboolean resize, gboolean keep_positio
                                                             NULL);
                                }
                        }
-               if (GTK_WIDGET_REALIZED(vf->listview)) gtk_tree_view_columns_autosize(GTK_TREE_VIEW(vf->listview));
+               if (gtk_widget_get_realized(vf->listview)) gtk_tree_view_columns_autosize(GTK_TREE_VIEW(vf->listview));
                }
 
        r = -1;
@@ -1735,76 +1748,6 @@ static void vficon_populate_at_new_size(ViewFile *vf, gint w, gint h, gboolean f
        DEBUG_1("col tab pop cols=%d rows=%d", VFICON(vf)->columns, VFICON(vf)->rows);
 }
 
-#if 0
-static void vficon_sync(ViewFile *vf)
-{
-       GtkTreeModel *store;
-       GtkTreeIter iter;
-       GList *work;
-       gint r, c;
-       gint valid;
-
-       if (VFICON(vf)->rows == 0) return;
-
-       store = gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview));
-
-       r = -1;
-       c = 0;
-
-       valid = gtk_tree_model_iter_children(store, &iter, NULL);
-
-       work = vf->list;
-       while (work)
-               {
-               GList *list;
-               r++;
-               c = 0;
-               if (valid)
-                       {
-                       gtk_tree_model_get(store, &iter, FILE_COLUMN_POINTER, &list, -1);
-                       gtk_list_store_set(GTK_LIST_STORE(store), &iter, FILE_COLUMN_POINTER, list, -1);
-                       }
-               else
-                       {
-                       list = vficon_add_row(vf, &iter);
-                       }
-
-               while (list)
-                       {
-                       IconData *id;
-
-                       if (work)
-                               {
-                               id = work->data;
-                               work = work->next;
-                               c++;
-                               }
-                       else
-                               {
-                               id = NULL;
-                               }
-
-                       list->data = id;
-                       list = list->next;
-                       }
-               if (valid) valid = gtk_tree_model_iter_next(store, &iter);
-               }
-
-       r++;
-       while (valid)
-               {
-               GList *list;
-
-               gtk_tree_model_get(store, &iter, FILE_COLUMN_POINTER, &list, -1);
-               valid = gtk_list_store_remove(GTK_LIST_STORE(store), &iter);
-               g_list_free(list);
-               }
-
-       VFICON(vf)->rows = r;
-
-       vficon_update_focus(vf);
-}
-#endif
 
 #if 0
 static void vficon_sync_idle(ViewFile *vf)
@@ -2218,7 +2161,7 @@ static void vficon_cell_data_cb(GtkTreeViewColumn *tree_column, GtkCellRenderer
                gchar *link;
                GtkStateType state = GTK_STATE_NORMAL;
 
-               g_assert(id->fd->magick == 0x12345678);
+               g_assert(id->fd->magick == FD_MAGICK);
 
                link = islink(id->fd->path) ? GQ_LINK_STR : "";
                if (id->fd->sidecar_files)