Trim trailing white spaces.
[geeqie.git] / src / view_file_list.c
index edb1d4f..b0bd169 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * Geeqie
  * (C) 2004 John Ellis
- * Copyright (C) 2008 - 2009 The Geeqie Team
+ * Copyright (C) 2008 - 2012 The Geeqie Team
  *
  * Author: John Ellis
  *
@@ -37,10 +37,12 @@ enum {
        FILE_COLUMN_POINTER = 0,
        FILE_COLUMN_VERSION,
        FILE_COLUMN_THUMB,
+       FILE_COLUMN_FORMATTED,
        FILE_COLUMN_NAME,
-       FILE_COLUMN_MULTILINE,
+       FILE_COLUMN_SIDECARS,
        FILE_COLUMN_SIZE,
        FILE_COLUMN_DATE,
+       FILE_COLUMN_EXPANDED,
        FILE_COLUMN_COLOR,
        FILE_COLUMN_MARKS,
        FILE_COLUMN_MARKS_LAST = FILE_COLUMN_MARKS + FILEDATA_MARKS_SIZE - 1,
@@ -53,8 +55,7 @@ enum {
        FILE_VIEW_COLUMN_MARKS = 0,
        FILE_VIEW_COLUMN_MARKS_LAST = FILE_VIEW_COLUMN_MARKS + FILEDATA_MARKS_SIZE - 1,
        FILE_VIEW_COLUMN_THUMB,
-       FILE_VIEW_COLUMN_MULTILINE,
-       FILE_VIEW_COLUMN_NAME,
+       FILE_VIEW_COLUMN_FORMATTED,
        FILE_VIEW_COLUMN_SIZE,
        FILE_VIEW_COLUMN_DATE,
        FILE_VIEW_COLUMN_COUNT
@@ -64,7 +65,9 @@ enum {
 
 static gboolean vflist_row_is_selected(ViewFile *vf, FileData *fd);
 static gboolean vflist_row_rename_cb(TreeEditData *td, const gchar *old, const gchar *new, gpointer data);
-static void vflist_populate_view(ViewFile *vf);
+static void vflist_populate_view(ViewFile *vf, gboolean force);
+static gboolean vflist_is_multiline(ViewFile *vf);
+static void vflist_set_expanded(ViewFile *vf, GtkTreeIter *iter, gboolean expanded);
 
 
 /*
@@ -133,55 +136,14 @@ static FileData *vflist_find_data_by_coord(ViewFile *vf, gint x, gint y, GtkTree
        return NULL;
 }
 
-#if 0
-static gint vflist_find_sidecar_list_idx(GList *work, FileData *fd)
-{
-       gint i = 0;
-       while (work)
-               {
-               FileData *fd_p = work->data;
-               if (fd == fd_p) return i;
-
-               i++;
-
-               GList *work2 = fd_p->sidecar_files;
-               while (work2)
-                       {
-                       fd_p = work2->data;
-                       if (fd == fd_p) return i;
-
-                       i++;
-                       work2 = work2->next;
-                       }
-               work = work->next;
-               }
-       return -1;
-}
-
-static gint vflist_sidecar_list_count(GList *work)
-{
-       gint i = 0;
-       while (work)
-               {
-               FileData *fd = work->data;
-               i++;
-
-               GList *work2 = fd->sidecar_files;
-               while (work2)
-                       {
-                       i++;
-                       work2 = work2->next;
-                       }
-               work = work->next;
-               }
-       return i;
-}
-#endif
-
 static gboolean vflist_store_clear_cb(GtkTreeModel *model, GtkTreePath *path, GtkTreeIter *iter, gpointer data)
 {
        FileData *fd;
        gtk_tree_model_get(model, iter, FILE_COLUMN_POINTER, &fd, -1);
+
+       /* it seems that gtk_tree_store_clear may call some callbacks
+          that use the column. Set the pointer to NULL to be safe. */
+       gtk_tree_store_set(GTK_TREE_STORE(model), iter, FILE_COLUMN_POINTER, NULL, -1);
        file_data_unref(fd);
        return FALSE;
 }
@@ -217,27 +179,6 @@ static void vflist_move_cursor(ViewFile *vf, GtkTreeIter *iter)
 }
 
 
-static gint vflist_column_idx(ViewFile *vf, gint store_idx)
-{
-       GList *columns, *work;
-       gint i = 0;
-
-       columns = gtk_tree_view_get_columns(GTK_TREE_VIEW(vf->listview));
-       work = columns;
-       while (work)
-               {
-               GtkTreeViewColumn *column = work->data;
-               if (store_idx == GPOINTER_TO_INT(g_object_get_data(G_OBJECT(column), "column_store_idx")))
-                       break;
-               work = work->next;
-               i++;
-               }
-
-       g_list_free(columns);
-       return i;
-}
-
-
 /*
  *-----------------------------------------------------------------------------
  * dnd
@@ -250,8 +191,6 @@ static void vflist_dnd_get(GtkWidget *widget, GdkDragContext *context,
 {
        ViewFile *vf = data;
        GList *list = NULL;
-       gchar *uri_text = NULL;
-       gint total;
 
        if (!VFLIST(vf)->click_fd) return;
 
@@ -265,15 +204,8 @@ static void vflist_dnd_get(GtkWidget *widget, GdkDragContext *context,
                }
 
        if (!list) return;
-
-       uri_text = uri_text_from_filelist(list, &total, (info == TARGET_TEXT_PLAIN));
+       uri_selection_data_set_uris_from_filelist(selection_data, list);
        filelist_free(list);
-
-       DEBUG_1("%s", uri_text);
-
-       gtk_selection_data_set(selection_data, selection_data->target,
-                              8, (guchar *)uri_text, total);
-       g_free(uri_text);
 }
 
 static void vflist_dnd_begin(GtkWidget *widget, GdkDragContext *context, gpointer data)
@@ -302,7 +234,7 @@ static void vflist_dnd_end(GtkWidget *widget, GdkDragContext *context, gpointer
 
        vflist_color_set(vf, VFLIST(vf)->click_fd, FALSE);
 
-       if (context->action == GDK_ACTION_MOVE)
+       if (gdk_drag_context_get_selected_action(context) == GDK_ACTION_MOVE)
                {
                vf_refresh(vf);
                }
@@ -319,18 +251,12 @@ static void vflist_drag_data_received(GtkWidget *entry_widget, GdkDragContext *c
 
                if (fd) {
                        /* Add keywords to file */
-                       gchar *str = g_strndup((gchar *)selection->data, selection->length);
+                       gchar *str = (gchar *) gtk_selection_data_get_text(selection);
                        GList *kw_list = string_to_keywords_list(str);
                        
                        metadata_append_list(fd, KEYWORD_KEY, kw_list);
                        string_list_free(kw_list);
                        g_free(str);
-/*
-file notification should handle this automatically
-                       if (vf->layout && vf->layout->bar_info) {
-                               bar_set_fd(vf->layout->bar_info, fd);
-                       }
-*/
                }
        }
 }
@@ -360,6 +286,41 @@ void vflist_dnd_init(ViewFile *vf)
  *-----------------------------------------------------------------------------
  */
 
+GList *vflist_selection_get_one(ViewFile *vf, FileData *fd)
+{
+       GList *list = g_list_append(NULL, file_data_ref(fd));
+
+       if (fd->sidecar_files)
+               {
+               /* check if the row is expanded */
+               GtkTreeModel *store;
+               GtkTreeIter iter;
+               
+               store = gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview));
+               if (vflist_find_row(vf, fd, &iter) >= 0)
+                       {
+                       GtkTreePath *tpath;
+
+                       tpath = gtk_tree_model_get_path(store, &iter);
+                       if (!gtk_tree_view_row_expanded(GTK_TREE_VIEW(vf->listview), tpath))
+                               {
+                               /* unexpanded - add whole group */
+                               GList *work = fd->sidecar_files;
+                               while (work)
+                                       {
+                                       FileData *sfd = work->data;
+                                       list = g_list_prepend(list, file_data_ref(sfd));
+                                       work = work->next;
+                                       }
+                               }
+                       gtk_tree_path_free(tpath);
+                       }
+               list = g_list_reverse(list);
+               }
+
+       return list;
+}
+
 GList *vflist_pop_menu_file_list(ViewFile *vf)
 {
        if (!VFLIST(vf)->click_fd) return NULL;
@@ -368,10 +329,10 @@ GList *vflist_pop_menu_file_list(ViewFile *vf)
                {
                return vf_selection_get_list(vf);
                }
-
-       return g_list_append(NULL, file_data_ref(VFLIST(vf)->click_fd));
+       return vflist_selection_get_one(vf, VFLIST(vf)->click_fd);
 }
 
+
 void vflist_pop_menu_view_cb(GtkWidget *widget, gpointer data)
 {
        ViewFile *vf = data;
@@ -411,7 +372,7 @@ void vflist_pop_menu_rename_cb(GtkWidget *widget, gpointer data)
 
                        tpath = gtk_tree_model_get_path(store, &iter);
                        tree_edit_by_path(GTK_TREE_VIEW(vf->listview), tpath,
-                                         vflist_column_idx(vf, FILE_COLUMN_NAME), VFLIST(vf)->click_fd->name,
+                                         FILE_VIEW_COLUMN_FORMATTED, VFLIST(vf)->click_fd->name,
                                          vflist_row_rename_cb, vf);
                        gtk_tree_path_free(tpath);
                        }
@@ -442,6 +403,7 @@ void vflist_pop_menu_refresh_cb(GtkWidget *widget, gpointer data)
 
        vflist_color_set(vf, VFLIST(vf)->click_fd, FALSE);
        vf_refresh(vf);
+       gtk_tree_view_columns_autosize(GTK_TREE_VIEW(vf->listview));
 }
 
 void vflist_popup_destroy_cb(GtkWidget *widget, gpointer data)
@@ -477,7 +439,7 @@ static gboolean vflist_row_rename_cb(TreeEditData *td, const gchar *old, const g
        else
                {
                gchar *old_path = g_build_filename(vf->dir_fd->path, old, NULL);
-               FileData *fd = file_data_new_simple(old_path); /* get the fd from cache */
+               FileData *fd = file_data_new_group(old_path); /* get the fd from cache */
                file_util_rename_simple(fd, new_path, vf->listview);
                file_data_unref(fd);
                g_free(old_path);
@@ -510,7 +472,7 @@ gboolean vflist_press_key_cb(GtkWidget *widget, GdkEventKey *event, gpointer dat
        ViewFile *vf = data;
        GtkTreePath *tpath;
 
-       if (event->keyval != GDK_Menu) return FALSE;
+       if (event->keyval != GDK_KEY_Menu) return FALSE;
 
        gtk_tree_view_get_cursor(GTK_TREE_VIEW(vf->listview), &tpath, NULL);
        if (tpath)
@@ -561,9 +523,6 @@ gboolean vflist_press_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer dat
 
                gtk_tree_model_get_iter(store, &iter, tpath);
                gtk_tree_model_get(store, &iter, FILE_COLUMN_POINTER, &fd, -1);
-#if 0
-               gtk_tree_view_set_cursor(GTK_TREE_VIEW(widget), tpath, NULL, FALSE);
-#endif
                gtk_tree_path_free(tpath);
                }
 
@@ -607,12 +566,10 @@ gboolean vflist_press_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer dat
                return (gtk_tree_selection_count_selected_rows(selection) > 1);
                }
 
-#if 1
        if (bevent->button == MOUSE_BUTTON_LEFT && bevent->type == GDK_2BUTTON_PRESS)
                {
                if (vf->layout) layout_image_full_screen_start(vf->layout);
                }
-#endif
 
        return FALSE;
 }
@@ -676,7 +633,6 @@ gboolean vflist_release_cb(GtkWidget *widget, GdkEventButton *bevent, gpointer d
                gtk_tree_selection_unselect_all(selection);
                gtk_tree_selection_select_iter(selection, &iter);
                vflist_move_cursor(vf, &iter);
-//             return TRUE;// FIXME - expand
                }
 
        return FALSE;
@@ -768,49 +724,100 @@ static gboolean vflist_select_cb(GtkTreeSelection *selection, GtkTreeModel *stor
        return TRUE;
 }
 
+static void vflist_expand_cb(GtkTreeView *tree_view, GtkTreeIter *iter, GtkTreePath *path, gpointer data)
+{
+       ViewFile *vf = data;
+       vflist_set_expanded(vf, iter, TRUE);
+}
+
+static void vflist_collapse_cb(GtkTreeView *tree_view, GtkTreeIter *iter, GtkTreePath *path, gpointer data)
+{
+       ViewFile *vf = data;
+       vflist_set_expanded(vf, iter, FALSE);
+}
+
 /*
  *-----------------------------------------------------------------------------
  * misc
  *-----------------------------------------------------------------------------
  */
 
-/*
-static gboolean vflist_dummy_select_cb(GtkTreeSelection *selection, GtkTreeModel *store, GtkTreePath *tpath,
-                                       gboolean path_currently_selected, gpointer data)
+
+static gchar* vflist_get_formatted(ViewFile *vf, const gchar *name, const gchar *sidecars, const gchar *size, const gchar *time, gboolean expanded)
+ {
+       gboolean multiline = vflist_is_multiline(vf);
+       gchar *text;
+
+       if (multiline)
+               {
+               text = g_strdup_printf("%s %s\n%s\n%s", name, expanded ? "" : sidecars, size, time);
+               }
+       else
+               {
+               text = g_strdup_printf("%s %s", name, expanded ? "" : sidecars);
+               }
+       return text;
+}
+
+static void vflist_set_expanded(ViewFile *vf, GtkTreeIter *iter, gboolean expanded)
 {
-       return TRUE;
+       GtkTreeStore *store;
+       gchar *name;
+       gchar *sidecars;
+       gchar *size;
+       gchar *time;
+       gchar *formatted;
+
+       store = GTK_TREE_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview)));
+
+       gtk_tree_model_get(GTK_TREE_MODEL(store), iter,
+                                       FILE_COLUMN_NAME, &name,
+                                       FILE_COLUMN_SIDECARS, &sidecars,
+                                       FILE_COLUMN_SIZE, &size,
+                                       FILE_COLUMN_DATE, &time,
+                                       -1);
+       formatted = vflist_get_formatted(vf, name, sidecars, size, time, expanded);
+
+       gtk_tree_store_set(store, iter, FILE_COLUMN_FORMATTED, formatted,
+                                       FILE_COLUMN_EXPANDED, expanded,
+                                       -1);
+       g_free(time);
+       g_free(size);
+       g_free(sidecars);
+       g_free(name);
+       g_free(formatted);
 }
-*/
 
 static void vflist_setup_iter(ViewFile *vf, GtkTreeStore *store, GtkTreeIter *iter, FileData *fd)
 {
        gchar *size;
        gchar *sidecars = NULL;
-       gchar *name_sidecars;
-       gchar *multiline;
+       gchar *name;
        const gchar *time = text_from_time(fd->date);
        gchar *link = islink(fd->path) ? GQ_LINK_STR : "";
-
-
-       if (fd->sidecar_files)
-               {
-               sidecars = file_data_sc_list_to_string(fd);
-               name_sidecars = g_strdup_printf("%s%s %s", link, fd->name, sidecars);
-               }
-       else
+       const gchar *disabled_grouping;
+       gchar *formatted;
+       gboolean expanded = FALSE;
+       
+       if (fd->sidecar_files) /* expanded has no effect on files without sidecars */
                {
-               gchar *disabled_grouping = fd->disable_grouping ? _(" [NO GROUPING]") : "";
-               name_sidecars = g_strdup_printf("%s%s%s", link, fd->name, disabled_grouping);
+               gtk_tree_model_get(GTK_TREE_MODEL(store), iter, FILE_COLUMN_EXPANDED, &expanded, -1);
                }
+
+       sidecars = file_data_sc_list_to_string(fd);
+
+       disabled_grouping = fd->disable_grouping ? _(" [NO GROUPING]") : "";
+       name = g_strdup_printf("%s%s%s", link, fd->name, disabled_grouping);
        size = text_from_size(fd->size);
        
-       multiline = g_strdup_printf("%s\n%s\n%s", name_sidecars, size, time);
-
+       formatted = vflist_get_formatted(vf, name, sidecars, size, time, expanded);
+       
        gtk_tree_store_set(store, iter, FILE_COLUMN_POINTER, fd,
                                        FILE_COLUMN_VERSION, fd->version,
                                        FILE_COLUMN_THUMB, fd->thumb_pixbuf,
-                                       FILE_COLUMN_MULTILINE, multiline,
-                                       FILE_COLUMN_NAME, name_sidecars,
+                                       FILE_COLUMN_FORMATTED, formatted,
+                                       FILE_COLUMN_SIDECARS, sidecars,
+                                       FILE_COLUMN_NAME, name,
                                        FILE_COLUMN_SIZE, size,
                                        FILE_COLUMN_DATE, time,
 #define STORE_SET_IS_SLOW 1
@@ -837,11 +844,11 @@ static void vflist_setup_iter(ViewFile *vf, GtkTreeStore *store, GtkTreeIter *it
 #endif
        g_free(size);
        g_free(sidecars);
-       g_free(name_sidecars);
-       g_free(multiline);
+       g_free(name);
+       g_free(formatted);
 }
 
-static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTreeIter *parent_iter, GList *list, GList *selected)
+static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTreeIter *parent_iter, GList *list, GList *selected, gboolean force)
 {
        GList *work;
        GtkTreeIter iter;
@@ -865,7 +872,6 @@ static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTr
 
                        if (valid)
                                {
-                               num_ordered++;
                                gtk_tree_model_get(GTK_TREE_MODEL(store), &iter,
                                                   FILE_COLUMN_POINTER, &old_fd,
                                                   FILE_COLUMN_VERSION, &old_version,
@@ -897,6 +903,7 @@ static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTr
 
                                if (valid)
                                        {
+                                       num_ordered++;
                                        gtk_tree_store_insert_before(store, &new, parent_iter, &iter);
                                        }
                                else
@@ -910,7 +917,7 @@ static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTr
                                        }
 
                                vflist_setup_iter(vf, store, &new, file_data_ref(fd));
-                               vflist_setup_iter_recursive(vf, store, &new, fd->sidecar_files, selected);
+                               vflist_setup_iter_recursive(vf, store, &new, fd->sidecar_files, selected, force);
                                
                                if (g_list_find(selected, fd))
                                        {
@@ -929,10 +936,11 @@ static void vflist_setup_iter_recursive(ViewFile *vf, GtkTreeStore *store, GtkTr
                                }
                        else
                                {
-                               if (fd->version != old_version)
+                               num_ordered++;
+                               if (fd->version != old_version || force)
                                        {
                                        vflist_setup_iter(vf, store, &iter, fd);
-                                       vflist_setup_iter_recursive(vf, store, &iter, fd->sidecar_files, selected);
+                                       vflist_setup_iter_recursive(vf, store, &iter, fd->sidecar_files, selected, force);
                                        }
 
                                if (valid) valid = gtk_tree_model_iter_next(GTK_TREE_MODEL(store), &iter);
@@ -1152,7 +1160,7 @@ gint vflist_index_by_fd(ViewFile *vf, FileData *fd)
                while (work2)
                        {
                        /* FIXME: return the same index also for sidecars
-                          it is sufficient for next/prev navigation but it should be rewritten 
+                          it is sufficient for next/prev navigation but it should be rewritten
                           without using indexes at all
                        */
                        FileData *sidecar_fd = work2->data;
@@ -1307,6 +1315,18 @@ GList *vflist_selection_get_list(ViewFile *vf)
                gtk_tree_model_get(store, &iter, FILE_COLUMN_POINTER, &fd, -1);
 
                list = g_list_prepend(list, file_data_ref(fd));
+               
+               if (!fd->parent && !gtk_tree_view_row_expanded(GTK_TREE_VIEW(vf->listview), tpath))
+                       {
+                       /* unexpanded - add whole group */
+                       GList *work2 = fd->sidecar_files;
+                       while (work2)
+                               {
+                               FileData *sfd = work2->data;
+                               list = g_list_prepend(list, file_data_ref(sfd));
+                               work2 = work2->next;
+                               }
+                       }
 
                work = work->next;
                }
@@ -1500,11 +1520,11 @@ void vflist_mark_to_selection(ViewFile *vf, gint mark, MarkToSelectionMode mode)
                        {
                        case MTS_MODE_SET: selected = mark_val;
                                break;
-                       case MTS_MODE_OR: selected = mark_val | selected;
+                       case MTS_MODE_OR: selected = mark_val || selected;
                                break;
-                       case MTS_MODE_AND: selected = mark_val & selected;
+                       case MTS_MODE_AND: selected = mark_val && selected;
                                break;
-                       case MTS_MODE_MINUS: selected = !mark_val & selected;
+                       case MTS_MODE_MINUS: selected = !mark_val && selected;
                                break;
                        }
 
@@ -1539,6 +1559,8 @@ void vflist_selection_to_mark(ViewFile *vf, gint mark, SelectionToMarkMode mode)
                gtk_tree_model_get_iter(store, &iter, tpath);
                gtk_tree_model_get(store, &iter, FILE_COLUMN_POINTER, &fd, -1);
 
+               /* the change has a very limited range and the standard notification would trigger
+                  complete re-read of the directory - try to do only minimal update instead */
                file_data_unregister_notify_func(vf_notify_cb, vf); /* we don't need the notification */
 
                switch (mode)
@@ -1559,6 +1581,8 @@ void vflist_selection_to_mark(ViewFile *vf, gint mark, SelectionToMarkMode mode)
                        {
                        /* mark functions can have various side effects - update all columns to be sure */
                        vflist_setup_iter(vf, GTK_TREE_STORE(store), &iter, fd);
+                       /* mark functions can change sidecars too */
+                       vflist_setup_iter_recursive(vf, GTK_TREE_STORE(store), &iter, fd->sidecar_files, NULL, FALSE);
                        }
 
                
@@ -1576,19 +1600,18 @@ void vflist_selection_to_mark(ViewFile *vf, gint mark, SelectionToMarkMode mode)
  *-----------------------------------------------------------------------------
  */
 
-static void vflist_listview_set_columns(GtkWidget *listview, gboolean thumb)
+static void vflist_listview_set_columns(GtkWidget *listview, gboolean thumb, gboolean multiline)
 {
        GtkTreeViewColumn *column;
        GtkCellRenderer *cell;
        GList *list;
-       gboolean multiline;
 
        column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_THUMB);
        if (!column) return;
 
        gtk_tree_view_column_set_fixed_width(column, options->thumbnails.max_width + 4);
 
-       list = gtk_tree_view_column_get_cell_renderers(column);
+       list = gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(column));
        if (!list) return;
        cell = list->data;
        g_list_free(list);
@@ -1596,17 +1619,9 @@ static void vflist_listview_set_columns(GtkWidget *listview, gboolean thumb)
        g_object_set(G_OBJECT(cell), "height", options->thumbnails.max_height, NULL);
        gtk_tree_view_column_set_visible(column, thumb);
 
-       multiline = (thumb && options->thumbnails.max_height >= 48);
-       
-       column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_MULTILINE);
-       if (!column) return;
-       gtk_tree_view_column_set_visible(column, multiline);
-       if (multiline) gtk_tree_view_set_expander_column(GTK_TREE_VIEW(listview), column);
-
-       column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_NAME);
+       column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_FORMATTED);
        if (!column) return;
-       gtk_tree_view_column_set_visible(column, !multiline);
-       if (!multiline) gtk_tree_view_set_expander_column(GTK_TREE_VIEW(listview), column);
+       gtk_tree_view_set_expander_column(GTK_TREE_VIEW(listview), column);
 
        column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_SIZE);
        if (!column) return;
@@ -1615,18 +1630,20 @@ static void vflist_listview_set_columns(GtkWidget *listview, gboolean thumb)
        column = gtk_tree_view_get_column(GTK_TREE_VIEW(listview), FILE_VIEW_COLUMN_DATE);
        if (!column) return;
        gtk_tree_view_column_set_visible(column, !multiline);
+}
 
-       gtk_tree_view_columns_autosize(GTK_TREE_VIEW(listview));
+static gboolean vflist_is_multiline(ViewFile *vf)
+{
+       return (VFLIST(vf)->thumbs_enabled && options->thumbnails.max_height >= 48);
 }
 
-static void vflist_populate_view(ViewFile *vf)
+
+static void vflist_populate_view(ViewFile *vf, gboolean force)
 {
        GtkTreeStore *store;
-       gboolean thumbs_enabled;
        GList *selected;
 
        store = GTK_TREE_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview)));
-       thumbs_enabled = VFLIST(vf)->thumbs_enabled;
 
        vf_thumb_stop(vf);
 
@@ -1637,11 +1654,11 @@ static void vflist_populate_view(ViewFile *vf)
                return;
                }
 
-       vflist_listview_set_columns(vf->listview, thumbs_enabled);
+       vflist_listview_set_columns(vf->listview, VFLIST(vf)->thumbs_enabled, vflist_is_multiline(vf));
 
        selected = vflist_selection_get_list(vf);
        
-       vflist_setup_iter_recursive(vf, store, NULL, vf->list, selected);
+       vflist_setup_iter_recursive(vf, store, NULL, vf->list, selected, force);
 
        if (selected && vflist_selection_count(vf, NULL) == 0)
                {
@@ -1678,7 +1695,7 @@ gboolean vflist_refresh(ViewFile *vf)
 
        DEBUG_1("%s vflist_refresh: populate view", get_exec_time());
 
-       vflist_populate_view(vf);
+       vflist_populate_view(vf, FALSE);
 
        filelist_free(old_list);
        DEBUG_1("%s vflist_refresh: done", get_exec_time());
@@ -1794,7 +1811,10 @@ static void vflist_listview_mark_toggled_cb(GtkCellRendererToggle *cell, gchar *
 
        gtk_tree_model_get(GTK_TREE_MODEL(store), &iter, FILE_COLUMN_POINTER, &fd, col_idx, &marked, -1);
        marked = !marked;
-       file_data_unregister_notify_func(vf_notify_cb, vf); /* we don't need the notification */
+       
+       /* the change has a very limited range and the standard notification would trigger
+          complete re-read of the directory - try to do only minimal update instead */
+       file_data_unregister_notify_func(vf_notify_cb, vf);
        file_data_set_mark(fd, col_idx - FILE_COLUMN_MARKS, marked);
        if (!file_data_filter_marks(fd, vf_marks_get_filter(vf))) /* file no longer matches the filter -> remove it */
                {
@@ -1804,6 +1824,8 @@ static void vflist_listview_mark_toggled_cb(GtkCellRendererToggle *cell, gchar *
                {
                /* mark functions can have various side effects - update all columns to be sure */
                vflist_setup_iter(vf, GTK_TREE_STORE(store), &iter, fd);
+               /* mark functions can change sidecars too */
+               vflist_setup_iter_recursive(vf, GTK_TREE_STORE(store), &iter, fd->sidecar_files, NULL, FALSE);
                }
        file_data_register_notify_func(vf_notify_cb, vf, NOTIFY_PRIORITY_MEDIUM);
 
@@ -1814,10 +1836,6 @@ static void vflist_listview_add_column_toggle(ViewFile *vf, gint n, const gchar
 {
        GtkTreeViewColumn *column;
        GtkCellRenderer *renderer;
-       GtkTreeStore *store;
-       gint index;
-
-       store = GTK_TREE_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(vf->listview)));
 
        renderer = gtk_cell_renderer_toggle_new();
        column = gtk_tree_view_column_new_with_attributes(title, renderer, "active", n, NULL);
@@ -1826,7 +1844,7 @@ static void vflist_listview_add_column_toggle(ViewFile *vf, gint n, const gchar
        g_object_set_data(G_OBJECT(column), "column_store_idx", GUINT_TO_POINTER(n));
        g_object_set_data(G_OBJECT(renderer), "column_store_idx", GUINT_TO_POINTER(n));
 
-       index = gtk_tree_view_append_column(GTK_TREE_VIEW(vf->listview), column);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(vf->listview), column);
        gtk_tree_view_column_set_fixed_width(column, 22);
        gtk_tree_view_column_set_visible(column, vf->marks_enabled);
 
@@ -1842,6 +1860,7 @@ static void vflist_listview_add_column_toggle(ViewFile *vf, gint n, const gchar
 
 gboolean vflist_set_fd(ViewFile *vf, FileData *dir_fd)
 {
+       gboolean ret;
        if (!dir_fd) return FALSE;
        if (vf->dir_fd == dir_fd) return TRUE;
 
@@ -1854,7 +1873,9 @@ gboolean vflist_set_fd(ViewFile *vf, FileData *dir_fd)
        filelist_free(vf->list);
        vf->list = NULL;
 
-       return vf_refresh(vf);
+       ret = vf_refresh(vf);
+       gtk_tree_view_columns_autosize(GTK_TREE_VIEW(vf->listview));
+       return ret;
 }
 
 void vflist_destroy_cb(GtkWidget *widget, gpointer data)
@@ -1883,10 +1904,12 @@ ViewFile *vflist_new(ViewFile *vf, FileData *dir_fd)
        flist_types[FILE_COLUMN_POINTER] = G_TYPE_POINTER;
        flist_types[FILE_COLUMN_VERSION] = G_TYPE_INT;
        flist_types[FILE_COLUMN_THUMB] = GDK_TYPE_PIXBUF;
+       flist_types[FILE_COLUMN_FORMATTED] = G_TYPE_STRING;
        flist_types[FILE_COLUMN_NAME] = G_TYPE_STRING;
-       flist_types[FILE_COLUMN_MULTILINE] = G_TYPE_STRING;
+       flist_types[FILE_COLUMN_SIDECARS] = G_TYPE_STRING;
        flist_types[FILE_COLUMN_SIZE] = G_TYPE_STRING;
        flist_types[FILE_COLUMN_DATE] = G_TYPE_STRING;
+       flist_types[FILE_COLUMN_EXPANDED] = G_TYPE_BOOLEAN;
        flist_types[FILE_COLUMN_COLOR] = G_TYPE_BOOLEAN;
        for (i = FILE_COLUMN_MARKS; i < FILE_COLUMN_MARKS + FILEDATA_MARKS_SIZE; i++)
                flist_types[i] = G_TYPE_BOOLEAN;
@@ -1896,6 +1919,12 @@ ViewFile *vflist_new(ViewFile *vf, FileData *dir_fd)
        vf->listview = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
        g_object_unref(store);
 
+       g_signal_connect(G_OBJECT(vf->listview), "row-expanded",
+                        G_CALLBACK(vflist_expand_cb), vf);
+
+       g_signal_connect(G_OBJECT(vf->listview), "row-collapsed",
+                        G_CALLBACK(vflist_collapse_cb), vf);
+
        selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(vf->listview));
        gtk_tree_selection_set_mode(GTK_TREE_SELECTION(selection), GTK_SELECTION_MULTIPLE);
        gtk_tree_selection_set_select_function(selection, vflist_select_cb, vf, NULL);
@@ -1916,12 +1945,8 @@ ViewFile *vflist_new(ViewFile *vf, FileData *dir_fd)
        g_assert(column == FILE_VIEW_COLUMN_THUMB);
        column++;
        
-       vflist_listview_add_column(vf, FILE_COLUMN_MULTILINE, _("Name"), FALSE, FALSE, TRUE);
-       g_assert(column == FILE_VIEW_COLUMN_MULTILINE);
-       column++;
-
-       vflist_listview_add_column(vf, FILE_COLUMN_NAME, _("Name"), FALSE, FALSE, TRUE);
-       g_assert(column == FILE_VIEW_COLUMN_NAME);
+       vflist_listview_add_column(vf, FILE_COLUMN_FORMATTED, _("Name"), FALSE, FALSE, TRUE);
+       g_assert(column == FILE_VIEW_COLUMN_FORMATTED);
        column++;
 
        vflist_listview_add_column(vf, FILE_COLUMN_SIZE, _("Size"), FALSE, TRUE, FALSE);
@@ -1941,7 +1966,16 @@ void vflist_thumb_set(ViewFile *vf, gboolean enable)
        if (VFLIST(vf)->thumbs_enabled == enable) return;
 
        VFLIST(vf)->thumbs_enabled = enable;
-       if (vf->layout) vf_refresh(vf);
+       
+       /* vflist_populate_view is better than vf_refresh:
+          - no need to re-read the directory
+          - force update because the formatted string has changed
+       */
+       if (vf->layout)
+               {
+               vflist_populate_view(vf, TRUE);
+               gtk_tree_view_columns_autosize(GTK_TREE_VIEW(vf->listview));
+               }
 }
 
 void vflist_marks_set(ViewFile *vf, gboolean enable)
@@ -1962,7 +1996,6 @@ void vflist_marks_set(ViewFile *vf, gboolean enable)
                }
 
        g_list_free(columns);
-       //vf_refresh(vf);
 }
 
 /* vim: set shiftwidth=8 softtabstop=0 cindent cinoptions={1s: */