Colin Clark [Wed, 8 May 2024 10:31:59 +0000 (11:31 +0100)]
Eliminate some GitHub action warnings
Update version number of some GitHub actions
Colin Clark [Sun, 5 May 2024 16:01:27 +0000 (17:01 +0100)]
Some command line options are not GNU/POSIX compliant (4)
Update the plugins for the change from colon to equals sign.
Colin Clark [Sun, 5 May 2024 15:56:58 +0000 (16:56 +0100)]
Eliminate meson deprecation (2)
mkdir --parents is not legal in FreeBSD
Colin Clark [Sun, 5 May 2024 12:55:13 +0000 (13:55 +0100)]
Eliminate meson deprecation
The feature '@0@'.format(name) was used - probably derived from:
https://github.com/mesonbuild/meson/issues/5273
This resulted in the warning:
DEPRECATION: Project uses feature that was always broken, and is now
deprecated since '1.3.0'
Rework meson.build files so that this feature is no longer used.
Colin Clark [Sun, 5 May 2024 11:23:00 +0000 (12:23 +0100)]
Update .clang-tidy for Ubuntu 24.04
Additional excludes are required for .clang-tidy, presumably because of
a new clang-tidy version.
Arkadiy Illarionov [Wed, 1 May 2024 12:21:57 +0000 (15:21 +0300)]
Simplify vflist_get_formatted()
Use GString for result.
Remove redundant with_stars parameter.
Arkadiy Illarionov [Wed, 1 May 2024 10:13:36 +0000 (13:13 +0300)]
Remove ToolbarButtonData::stock_id
No need to keep it.
Arkadiy Illarionov [Mon, 29 Apr 2024 14:19:54 +0000 (17:19 +0300)]
Remove last GTK_STOCK items
Replace GQ_ICON_COLLECTION with PIXBUF_INLINE_COLLECTION.
Also use PIXBUF_INLINE_COLLECTION macro instead of "gq-icon-collection".
Replace GQ_ICON_DND with GQ_ICON_DIRECTORY for "Dropped list includes folders." dialog.
Omari Stephens [Mon, 29 Apr 2024 18:44:02 +0000 (18:44 +0000)]
Disables clang-tidy check for multiple declarations on the same line for rect dimension variables rx, ry, rw, rh.
Echoing https://www.reddit.com/r/learnprogramming/comments/9zgvlk/comment/ea942uh/
"My recommendation is that you only declare multiple per line if they represent
more or less the same thing, and are used together in such a way that they
logically belong to each other."
Omari Stephens [Mon, 29 Apr 2024 18:11:51 +0000 (18:11 +0000)]
Clean up hard-coded hidpi scale factor in debug codepath
Omari Stephens [Mon, 29 Apr 2024 18:02:02 +0000 (18:02 +0000)]
Adds comments to rt_source_tile_render
Plus, some further tidying.
Omari Stephens [Sun, 28 Apr 2024 17:21:52 +0000 (17:21 +0000)]
Reverts a diagnostic change to rt_hidpi_aware_draw
Omari Stephens [Sun, 28 Apr 2024 17:20:01 +0000 (17:20 +0000)]
Significant cleanup and simplification of rt_source_tile_render
Omari Stephens [Sun, 28 Apr 2024 09:10:01 +0000 (09:10 +0000)]
Baby steps! Rendering seems to be working, but there are still some bugs.
Colin Clark [Mon, 29 Apr 2024 15:53:40 +0000 (16:53 +0100)]
Include check for untranslated text
- Meson check for untranslated text strings
- Fix some untranslated text strings
Arkadiy Illarionov [Mon, 29 Apr 2024 10:31:27 +0000 (13:31 +0300)]
Silence GtkAction deprecation warnings
Add aliases for deprecated functions.
Also move gq_gtk_container_add() out of ifdefs.
Arkadiy Illarionov [Sun, 28 Apr 2024 15:13:56 +0000 (18:13 +0300)]
Deduplicate mark_to_selection and selection_to_mark
Colin Clark [Wed, 24 Apr 2024 08:54:10 +0000 (09:54 +0100)]
Some command line options are not GNU/POSIX compliant (3)
Update the plugins for the change from colon to equals sign.
Omari Stephens [Sun, 21 Apr 2024 06:31:17 +0000 (06:31 +0000)]
Adds API documentation to functions in pixbuf-util.h
Also renames some variables to clarify operation.
Also notes but does not perform some function renames that would dramatically clarify what those functions do.
This change should be a no-op.
Arkadiy Illarionov [Sun, 21 Apr 2024 18:09:30 +0000 (21:09 +0300)]
Prefer internal ViewFile submodule functions
Avoid redundant type checks.
Colin Clark [Sun, 21 Apr 2024 16:15:55 +0000 (17:15 +0100)]
Option to hide window decorations
The option is in Edit/Preferences/Windows
When selected and if supported by the window manager, window title bar,
resize controls, etc will not be displayed.
Arkadiy Illarionov [Sun, 21 Apr 2024 14:07:43 +0000 (17:07 +0300)]
Deduplicate ViewFile pop menu functions
Arkadiy Illarionov [Sun, 21 Apr 2024 12:14:03 +0000 (15:14 +0300)]
Deduplicate ViewFile dnd
Colin Clark [Sun, 21 Apr 2024 12:39:18 +0000 (13:39 +0100)]
Tidy AppImage generation files
Colin Clark [Sat, 20 Apr 2024 17:29:26 +0000 (18:29 +0100)]
Auto-completion - split standard and remote options
- Only complete remote options after --remote has been given
- Delete --remote-help option - it has no value
Arkadiy Illarionov [Sat, 20 Apr 2024 12:55:20 +0000 (15:55 +0300)]
Simplify ViewFile callbacks
Remove unused declarations.
Add vf*_pop_menu_add_items().
Split vf_selection_foreach().
Move ViewFileInfo* structs to submodules.
Colin Clark [Fri, 19 Apr 2024 09:35:42 +0000 (10:35 +0100)]
Bug fix: AppImage notification not working (2)
g_file_query_info does not get the date from GitHub. Use curl instead.
Arkadiy Illarionov [Wed, 17 Apr 2024 21:12:26 +0000 (00:12 +0300)]
Move common click_fd member to ViewFile
Arkadiy Illarionov [Wed, 17 Apr 2024 20:42:44 +0000 (23:42 +0300)]
Deduplicate "Show star rating" menu item creation
Arkadiy Illarionov [Tue, 16 Apr 2024 19:54:22 +0000 (22:54 +0300)]
Add vf_selection_foreach()
Hide implementation and deduplicate code.
Also simplify layout_menu_write_rotate() a bit.
Colin Clark [Tue, 16 Apr 2024 09:09:42 +0000 (10:09 +0100)]
Some command line options are not GNU/POSIX compliant (2)
Update the plugins for the change from colon to equals sign.
Colin Clark [Mon, 15 Apr 2024 14:13:21 +0000 (15:13 +0100)]
Bug fix: AppImage notification not working
AppImage new issue notification did not work if run from an extracted
AppImage.
Colin Clark [Sun, 14 Apr 2024 18:08:56 +0000 (19:08 +0100)]
Update AppImage download script for command line completions
If the extract option is given, create a symbolic link from
$HOME/.local/share/bash-completion to the extracted executable.
If this is not done, the command line auto-completion function will not
work for AppImages,
Colin Clark [Sun, 14 Apr 2024 15:54:41 +0000 (16:54 +0100)]
Command line auto-completion - further enhancements
- Include auto-completion for remaining options.
- Fix some text errors
Colin Clark [Sun, 14 Apr 2024 10:58:15 +0000 (11:58 +0100)]
Option --cache-maintenance is not GNU compliant
https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html
The option requires an equals sign as a separator.
Arkadiy Illarionov [Sat, 13 Apr 2024 22:43:23 +0000 (01:43 +0300)]
Simplify pan_item_image_find_size()
Arkadiy Illarionov [Sat, 13 Apr 2024 22:32:33 +0000 (01:32 +0300)]
Deduplicate PanCacheData destroying
Colin Clark [Sat, 13 Apr 2024 17:38:33 +0000 (18:38 +0100)]
Some command line options are not GNU/POSIX compliant
The definitions are:
https://pubs.opengroup.org/onlinepubs/
9699919799/basedefs/V1_chap12.html
https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html
Colons in an option have been replaced by an equals sign.
Multi-character short options have been deleted.
The option --cache-render-shared-recurse remains illegal because it
exceeds the three--word limit.
Arkadiy Illarionov [Sat, 13 Apr 2024 12:31:44 +0000 (15:31 +0300)]
Use references in pan_layout_compute() parameters
Simplify related functions.
Arkadiy Illarionov [Fri, 12 Apr 2024 19:23:18 +0000 (22:23 +0300)]
Move some types and constants from pan-types to specific modules
Colin Clark [Thu, 11 Apr 2024 16:29:22 +0000 (17:29 +0100)]
Minor change to AppImage download script
Display an animated "spinner" character while extracting the AppImage.
Colin Clark [Thu, 11 Apr 2024 11:36:32 +0000 (12:36 +0100)]
Bug fix: Collections and unmounted drives (2)
Did not compile on FreeBSD
This is a blind fix.
Arkadiy Illarionov [Wed, 10 Apr 2024 20:46:50 +0000 (23:46 +0300)]
Merge SCROLL_RESET_* macros with PixbufRendererScrollResetType
Rename to ScrollReset.
Colin Clark [Tue, 9 Apr 2024 09:48:01 +0000 (10:48 +0100)]
Bug fix: Collections and unmounted drives
The bug:
If a collection file is on the local filesystem
The collection file contains references to files on a mounted drive
The drive is unmounted
The collection file is opened
Geeqie sees that the files do not exist and deletes them from the
collection file.
The fix:
If Geeqie does not find the file-
If the file path prefix contains /home, /tmp or /usr it is assumed that
the file was on the local drive and has been deleted by the user. It is
ignored.
If the file path prefix contains a mount path, it is assumed that the
file was on a currently mounted drive and has been deleted.
Otherwise it is assumed that the file is on a removable drive that is
not currently mounted. The collection will not be opened.
If this is not the case the user may need to use a text editor to remove
the offending line from the collection file.
Created problem:
When a collection window contents have not been changed, but its
geometry has, the geometry changes will not be saved. The user must make
a minor positional change to any thumbnail to trigger a save.
Arkadiy Illarionov [Mon, 8 Apr 2024 21:08:58 +0000 (00:08 +0300)]
Drop obsolete GTK_OBJECT_FLOATING
Arkadiy Illarionov [Sun, 7 Apr 2024 13:10:51 +0000 (16:10 +0300)]
Move some defines from main-defines to modules
Convert to constants.
Arkadiy Illarionov [Sun, 7 Apr 2024 12:16:16 +0000 (15:16 +0300)]
Move keyboard_scroll_calc() to layout-util
Convert parameters from pointers to references.
Move Shift processing inside keyboard_scroll_calc().
Arkadiy Illarionov [Sat, 6 Apr 2024 14:07:41 +0000 (17:07 +0300)]
Simplify lists handling in history-list
Arkadiy Illarionov [Sat, 6 Apr 2024 12:21:17 +0000 (15:21 +0300)]
Simplify max value search in history-list
Arkadiy Illarionov [Fri, 5 Apr 2024 20:59:48 +0000 (23:59 +0300)]
Remove unused key_press_cb() declaration
Arkadiy Illarionov [Fri, 5 Apr 2024 20:36:31 +0000 (23:36 +0300)]
Replace custom PI with G_PI
Arkadiy Illarionov [Tue, 2 Apr 2024 18:22:59 +0000 (21:22 +0300)]
Simplify pixels sorting in image_sim_channel_equal()
And move it to anonymous namespace.
Colin Clark [Thu, 4 Apr 2024 17:31:37 +0000 (18:31 +0100)]
Additional test for temporary comments
- The only sequence checked for is "//~"
- Delete existing temporary comments
Colin Clark [Thu, 4 Apr 2024 16:15:13 +0000 (17:15 +0100)]
Command line auto-completion enhancements
- Limit completions to a list of file extensions known to Geeqie
- Limit completions to a specific extension where possible e.g. gqv
- Change option +t to -T and +w to -w. The plus character affected the
output of _parse_help
- Additional warning to user for invalid parameters - unknown option or
valid remote option used without a --remote command
- New remote.cc function for above feature
- Update man page and documentation
Arkadiy Illarionov [Tue, 2 Apr 2024 18:46:19 +0000 (21:46 +0300)]
Replace mround with STL lround
Colin Clark [Tue, 2 Apr 2024 15:26:18 +0000 (16:26 +0100)]
Include xmllint checks
Colin Clark [Tue, 2 Apr 2024 13:56:54 +0000 (14:56 +0100)]
Command line auto-completion - AppImages
- Auto-completion does not work with AppImages. Document a work-around.
- Change the format of the completions file to be the same as similar
files.
Arkadiy Illarionov [Mon, 1 Apr 2024 18:37:53 +0000 (21:37 +0300)]
Simplify ImageSimilarityData comparison
* Run alternate_image_sim_compare_fast() once
* Deduplicate ImageSimilarityData comparison
Colin Clark [Mon, 1 Apr 2024 18:56:50 +0000 (19:56 +0100)]
Implement basic command line auto-completion
_parse_help is used to provide auto-completion for long options.
No other processing is done.
Colin Clark [Sun, 31 Mar 2024 18:10:25 +0000 (19:10 +0100)]
Fix #259: Zoom by drawing rectangle
https://github.com/BestImageViewer/geeqie/issues/259
Menu item View/Zoom/Zoom To Rectangle
Arkadiy Illarionov [Sat, 30 Mar 2024 12:43:04 +0000 (15:43 +0300)]
Add HtmlBrowser class and replace C array with std::array
Colin Clark [Fri, 29 Mar 2024 13:24:11 +0000 (13:24 +0000)]
Fix 1302: Cut image to clipboard
https://github.com/BestImageViewer/geeqie/issues/1302
Shortcut key Control-X and menu item Cut To Clipboard function as in
other programs.
This feature is only available in the main window.
Colin Clark [Fri, 29 Mar 2024 10:10:39 +0000 (10:10 +0000)]
Fix #1089: Sync xmp:Rating across all sidecar images (2)
https://github.com/BestImageViewer/geeqie/issues/1089
Fix the documentation.
Colin Clark [Thu, 28 Mar 2024 14:57:19 +0000 (14:57 +0000)]
Fix #1303: Automatically hide image overlay in fullscreen mode
https://github.com/BestImageViewer/geeqie/issues/1303
Additional option Edit/Preferences/Behavior/Hide OSD In Fullscreen
Colin Clark [Thu, 28 Mar 2024 11:35:24 +0000 (11:35 +0000)]
Additional meson test - look for stray debug statements
Check if DEBUG_0, DEBUG_BT or DEBUG_FD statements have been erroneously
left in the code.
Colin Clark [Wed, 27 Mar 2024 18:46:10 +0000 (18:46 +0000)]
Fix #1089: Sync xmp:Rating across all sidecar images
https://github.com/BestImageViewer/geeqie/issues/1089
Include Xmp.xmp.Rating in list of tags written to all sidecars.
Colin Clark [Wed, 27 Mar 2024 15:27:35 +0000 (15:27 +0000)]
Fix #1240: Regression: Option to open new full-function window directly is missing
https://github.com/BestImageViewer/geeqie/issues/1240
Ensure that the sort sidebar is displayed if set in a saved window.
Colin Clark [Wed, 27 Mar 2024 13:05:13 +0000 (13:05 +0000)]
Documentation update - plugin filter
Note that a restart is required for a plugin of this type to be
registered.
Colin Clark [Tue, 26 Mar 2024 17:17:00 +0000 (17:17 +0000)]
Fix #1241: 'Go to directory view' uses hard-coded default values
https://github.com/BestImageViewer/geeqie/issues/1241
If the image is already displayed, bring that window to the top.
If not, a new layout window is opened using the values set by the user
in Edit/Preferences/Windows/Use Current Layout For Default.
If this option has not been set, use the fixed default values.
Arkadiy Illarionov [Sun, 24 Mar 2024 12:16:25 +0000 (15:16 +0300)]
Cleanup rt_overlay_get_position() and use in rt_draw_cb()
Colin Clark [Sun, 24 Mar 2024 10:38:07 +0000 (10:38 +0000)]
New plugin - set file mtime to Exif.Image.DateTime
Arkadiy Illarionov [Sun, 24 Mar 2024 10:22:30 +0000 (13:22 +0300)]
Deduplicate rt_border_draw
Arkadiy Illarionov [Sat, 23 Mar 2024 20:46:40 +0000 (23:46 +0300)]
Use g_list_free_full to free draw_queue and draw_queue_2pass
Arkadiy Illarionov [Sat, 23 Mar 2024 20:38:05 +0000 (23:38 +0300)]
Remove unused RendererTiles::tile_cols
Arkadiy Illarionov [Sat, 23 Mar 2024 15:05:19 +0000 (18:05 +0300)]
Convert GET_{LEFT,RIGHT}_PIXBUF_OFFSET macro to function
Also cleanup a bit.
Colin Clark [Sat, 23 Mar 2024 13:57:49 +0000 (13:57 +0000)]
Release v2.4 files
Colin Clark [Sat, 23 Mar 2024 11:17:13 +0000 (11:17 +0000)]
Update documentation and translations
Colin Clark [Sat, 23 Mar 2024 10:02:52 +0000 (10:02 +0000)]
Fix #1289: tar.xz contains symlinks that are wrong for plugins (3)
https://github.com/BestImageViewer/geeqie/issues/1289
Colin Clark [Fri, 22 Mar 2024 12:23:04 +0000 (12:23 +0000)]
Fix #1289: tar.xz contains symlinks that are wrong for plugins (2)
https://github.com/BestImageViewer/geeqie/issues/1289
Colin Clark [Fri, 22 Mar 2024 11:27:01 +0000 (11:27 +0000)]
Fix #1289: tar.xz contains symlinks that are wrong for plugins
https://github.com/BestImageViewer/geeqie/issues/1289
Also fix scripts so that tests can be run from the source tar.
Colin Clark [Mon, 18 Mar 2024 10:26:19 +0000 (10:26 +0000)]
Fix #1296: AppImage doesn't distribute libffmpegthumbnailer
https://github.com/BestImageViewer/geeqie/issues/1296
Arkadiy Illarionov [Sun, 17 Mar 2024 18:04:59 +0000 (21:04 +0300)]
Silence GTK deprecation warning in unused function
Also use G_GNUC_BEGIN/END_IGNORE_DEPRECATIONS macros instead of pragmas.
Arkadiy Illarionov [Sun, 17 Mar 2024 13:35:26 +0000 (16:35 +0300)]
Replace deprecated gdk_screen_make_display_name
Colin Clark [Sat, 16 Mar 2024 16:01:31 +0000 (16:01 +0000)]
Ensure plugins check for external command
Ensure all plugins check that required external commands such as
exiftool are installed.
Arkadiy Illarionov [Sat, 16 Mar 2024 15:22:24 +0000 (18:22 +0300)]
Convert group_keys to std::array
Arkadiy Illarionov [Sat, 16 Mar 2024 13:12:28 +0000 (16:12 +0300)]
Enable and fix clang-tidy readability-simplify-boolean-expr
Replace some macros with inline functions.
Arkadiy Illarionov [Sat, 16 Mar 2024 11:19:48 +0000 (14:19 +0300)]
Replace deprecated gdk_window_get_pointer
Simplify comparison a bit.
Colin Clark [Fri, 15 Mar 2024 14:19:38 +0000 (14:19 +0000)]
Aditional remote command - window list
Arkadiy Illarionov [Thu, 14 Mar 2024 19:46:46 +0000 (22:46 +0300)]
Silence GTK deprecation warnings in champlain-gtk
Also remove unused pragma
Arkadiy Illarionov [Wed, 13 Mar 2024 21:31:32 +0000 (00:31 +0300)]
Colin Clark [Wed, 13 Mar 2024 14:00:38 +0000 (14:00 +0000)]
Include check compile on FreeBSD as a GitHub action
Colin Clark [Wed, 13 Mar 2024 09:50:29 +0000 (09:50 +0000)]
Include appstreamcli in ancillary files check
appstreamcli is used to lint org.geeqie.Geeqie.appdata.xml.in
Colin Clark [Tue, 12 Mar 2024 18:00:03 +0000 (18:00 +0000)]
Eliminate some warnings from the appdata file
Hofer-Julian [Tue, 12 Mar 2024 10:38:48 +0000 (11:38 +0100)]
Adapt appdata to stricter requirements
Flathub nowadays has stricter requirements for the appdata.
This commit adapts the appdata file accordingly
Arkadiy Illarionov [Mon, 11 Mar 2024 20:53:41 +0000 (23:53 +0300)]
Fix some GTK deprecation warnings
Arkadiy Illarionov [Sun, 10 Mar 2024 22:50:36 +0000 (01:50 +0300)]
Blind fix macOS build
Arkadiy Illarionov [Sun, 10 Mar 2024 11:57:45 +0000 (14:57 +0300)]
Use std::swap instead of temporary values
Arkadiy Illarionov [Sun, 10 Mar 2024 10:52:01 +0000 (13:52 +0300)]
Use p_step to avoid has_alpha comparison in loop
Colin Clark [Sat, 9 Mar 2024 17:44:11 +0000 (17:44 +0000)]
Include icon name column in Preferences/Keyboard table
Arkadiy Illarionov [Sat, 9 Mar 2024 16:45:19 +0000 (19:45 +0300)]
Simplify util_clip_triangle()