clang-tidy; -bugprone-suspicious-string-compare, misc-unused-parameters

- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file

diff --git a/.clang-tidy b/.clang-tidy
index 2e57660..cf32229 100644 (file)
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -37,12 +37,10 @@ Checks: >
   -bugprone-reserved-identifier,
   -bugprone-sizeof-expression,
   -bugprone-suspicious-missing-comma,
-  -bugprone-suspicious-string-compare,
   -misc-const-correctness,
   -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
   -misc-redundant-expression,
-  -misc-unused-parameters,
   -misc-use-anonymous-namespace,
   -modernize-avoid-c-arrays,
   -modernize-macro-to-enum,

diff --git a/src/ui-tabcomp.cc b/src/ui-tabcomp.cc
index a652d22..0196cd5 100644 (file)
--- a/src/ui-tabcomp.cc
+++ b/src/ui-tabcomp.cc
@@ -208,7 +208,7 @@ void tab_completion_iter_menu_items(GtkWidget *widget, gpointer data)
                const gchar *prefix = filename_from_path(entry_text);
                guint prefix_len = strlen(prefix);
 
-               if (strlen(text) < prefix_len || strncmp(text, prefix, prefix_len))
+               if (strlen(text) < prefix_len || strncmp(text, prefix, prefix_len) != 0)
                        {
                        /* Hide menu items not matching */
                        gtk_widget_hide(widget);

diff --git a/src/zonedetect.cc b/src/zonedetect.cc
index 2763e2d..6ec9808 100644 (file)
--- a/src/zonedetect.cc
+++ b/src/zonedetect.cc
@@ -265,7 +265,7 @@ static int ZDParseHeader(ZoneDetect *library)
 #if defined(_MSC_VER)
     __try {
 #endif
-        if(memcmp(library->mapping, "PLB", 3)) {
+        if(memcmp(library->mapping, "PLB", 3) != 0) {
             return -1;
         }