clang-tidy: use override
authorRosen Penev <rosenp@gmail.com>
Mon, 5 Jun 2023 10:11:44 +0000 (03:11 -0700)
committerColin Clark <colin.clark@cclark.uk>
Fri, 9 Jun 2023 10:10:03 +0000 (11:10 +0100)
Found with modernize-use-override

Signed-off-by: Rosen Penev <rosenp@gmail.com>
src/exiv2.cc

index 609a101..8d365d1 100644 (file)
@@ -123,9 +123,7 @@ struct _ExifData
        Exiv2::XmpData::const_iterator xmpIter; /* for exif_get_next_item */
 #endif
 
-       virtual ~_ExifData()
-       {
-       }
+       virtual ~_ExifData() = default;
 
        virtual void writeMetadata(gchar *UNUSED(path) = NULL)
        {
@@ -228,46 +226,46 @@ public:
                        }
        }
 
-       virtual ~_ExifDataOriginal()
+       ~_ExifDataOriginal() override
        {
                if (cp_data_) g_free(cp_data_);
                if (pathl_) g_free(pathl_);
        }
 
-       virtual Exiv2::Image *image()
+       Exiv2::Image *image() override
        {
                if (!valid_) return NULL;
                return image_.get();
        }
 
-       virtual Exiv2::ExifData &exifData ()
+       Exiv2::ExifData &exifData () override
        {
                if (!valid_) return emptyExifData_;
                return image_->exifData();
        }
 
-       virtual Exiv2::IptcData &iptcData ()
+       Exiv2::IptcData &iptcData () override
        {
                if (!valid_) return emptyIptcData_;
                return image_->iptcData();
        }
 
 #if EXIV2_TEST_VERSION(0,16,0)
-       virtual Exiv2::XmpData &xmpData ()
+       Exiv2::XmpData &xmpData () override
        {
                if (!valid_) return emptyXmpData_;
                return image_->xmpData();
        }
 #endif
 
-       virtual void add_jpeg_color_profile(unsigned char *cp_data, guint cp_length)
+       void add_jpeg_color_profile(unsigned char *cp_data, guint cp_length) override
        {
                if (cp_data_) g_free(cp_data_);
                cp_data_ = cp_data;
                cp_length_ = cp_length;
        }
 
-       virtual guchar *get_jpeg_color_profile(guint *data_len)
+       guchar *get_jpeg_color_profile(guint *data_len) override
        {
                if (cp_data_)
                {
@@ -281,12 +279,12 @@ public:
                return NULL;
        }
 
-       virtual std::string image_comment() const
+       std::string image_comment() const override
        {
                return image_.get() ? image_->comment() : "";
        }
 
-       virtual void set_image_comment(const std::string& comment)
+       void set_image_comment(const std::string& comment) override
        {
                if (image_.get())
                        image_->setComment(comment);
@@ -343,12 +341,12 @@ public:
                        }
        }
 
-       virtual ExifData *original()
+       ExifData *original() override
        {
                return imageData_.get();
        }
 
-       virtual void writeMetadata(gchar *path = NULL)
+       void writeMetadata(gchar *path = NULL) override
        {
                if (!path)
                        {
@@ -399,44 +397,44 @@ public:
                        }
        }
 
-       virtual Exiv2::Image *image()
+       Exiv2::Image *image() override
        {
                return imageData_->image();
        }
 
-       virtual Exiv2::ExifData &exifData ()
+       Exiv2::ExifData &exifData () override
        {
                return exifData_;
        }
 
-       virtual Exiv2::IptcData &iptcData ()
+       Exiv2::IptcData &iptcData () override
        {
                return iptcData_;
        }
 
 #if EXIV2_TEST_VERSION(0,16,0)
-       virtual Exiv2::XmpData &xmpData ()
+       Exiv2::XmpData &xmpData () override
        {
                return xmpData_;
        }
 #endif
 
-       virtual void add_jpeg_color_profile(unsigned char *cp_data, guint cp_length)
+       void add_jpeg_color_profile(unsigned char *cp_data, guint cp_length) override
        {
                imageData_->add_jpeg_color_profile(cp_data, cp_length);
        }
 
-       virtual guchar *get_jpeg_color_profile(guint *data_len)
+       guchar *get_jpeg_color_profile(guint *data_len) override
        {
                return imageData_->get_jpeg_color_profile(data_len);
        }
 
-       virtual std::string image_comment() const
+       std::string image_comment() const override
        {
                return imageData_->image_comment();
        }
 
-       virtual void set_image_comment(const std::string& comment)
+       void set_image_comment(const std::string& comment) override
        {
                imageData_->set_image_comment(comment);
        }