Vladimir Nadvornik [Sun, 4 May 2008 21:54:20 +0000 (21:54 +0000)]
dropped path_list functions, use filelist functions everywhere
Laurent Monin [Sun, 4 May 2008 19:00:39 +0000 (19:00 +0000)]
Remove unused functions:
vflist_set_status_func()
vflist_set_thumb_status_func()
vflist_set_layout()
vficon_set_status_func()
vficon_set_thumb_status_func()
vficon_set_layout()
Laurent Monin [Sun, 4 May 2008 18:45:06 +0000 (18:45 +0000)]
Drop ViewFileIcon, use ViewFile and ViewFileInfoIcon instead.
Laurent Monin [Sun, 4 May 2008 16:16:07 +0000 (16:16 +0000)]
Drop ViewFileList, use ViewFile and ViewFileInfoList instead.
Laurent Monin [Sun, 4 May 2008 11:47:36 +0000 (11:47 +0000)]
Prepare switch to ViewFile (unused yet).
Laurent Monin [Sun, 4 May 2008 00:32:05 +0000 (00:32 +0000)]
Shorten Edit menu labels, dropping "in ". It will ease
translations too, and user can define its own label in Preferences.
Laurent Monin [Sun, 4 May 2008 00:21:14 +0000 (00:21 +0000)]
Do not show Copy, Move, Rename, Delete, New Folder external commands
in the Edit section of contextual menus.
Laurent Monin [Sun, 4 May 2008 00:16:37 +0000 (00:16 +0000)]
Use GQ_EDITOR_GENERIC_SLOTS instead of hardcoded value.
Laurent Monin [Sat, 3 May 2008 20:55:16 +0000 (20:55 +0000)]
exif_get_description_by_key(): check for "formatted." prefix, and optimize.
Laurent Monin [Sat, 3 May 2008 20:49:25 +0000 (20:49 +0000)]
exif_get_formatted_by_key(): skip prefix when comparing.
Laurent Monin [Sat, 3 May 2008 20:40:50 +0000 (20:40 +0000)]
Change the prefix of formatted exif tags to a more explicit "formatted." prefix
instead of the shorter "f".
Warning: custom overlay info string has to be modified since old names are no
more recognized, one can reset it to default through Preferences > Advanced.
Laurent Monin [Sat, 3 May 2008 16:58:17 +0000 (16:58 +0000)]
Fix a bug occuring when using certain actions on a collection
item which is not in the selection.
Triggering it will either result in an assertion failure or a
segfault.
To reproduce:
- open a collection
- right-click on a non-selected image
- select Delete... menu entry (or Copy, Move, Rename, Properties...)
It results in the best case:
** ERROR **: file filelist.c: line 905 (file_data_ref): assertion failed: (fd->magick == 0x12345678)
or a pure segfault due to corrupted data.
collection_table_popup_file_list() has to return a list of filedata *
not a list of gchar *.
Laurent Monin [Sat, 3 May 2008 15:19:35 +0000 (15:19 +0000)]
Move marks-related fields from _ViewFileInfoList to _ViewFile, since
they'll be used for file icon view too.
Laurent Monin [Sat, 3 May 2008 15:17:24 +0000 (15:17 +0000)]
Move common thumbs_* fields from _ViewFileInfoIcon and _ViewFileInfoList
to _ViewFile.
Laurent Monin [Sat, 3 May 2008 15:13:15 +0000 (15:13 +0000)]
Rename thumbs_fd to thumbs_filedata in ViewFileIcon struct to match
the name used in ViewFileList.
Laurent Monin [Sat, 3 May 2008 15:09:21 +0000 (15:09 +0000)]
Remove useless thumbs_list from ViewFileIcon.
Laurent Monin [Sat, 3 May 2008 12:50:52 +0000 (12:50 +0000)]
Add function prototypes (yet unused).
Laurent Monin [Sat, 3 May 2008 12:48:45 +0000 (12:48 +0000)]
Drop redundant vflist_thumbs_set() introduced in revision 649,
modify and use existing vflist_thumb_set().
Laurent Monin [Sat, 3 May 2008 12:21:22 +0000 (12:21 +0000)]
Remove redundant prototype.
Laurent Monin [Sat, 3 May 2008 11:58:41 +0000 (11:58 +0000)]
Introduce ViewFileInfoList and ViewFileInfoIcon (not used yet).
Laurent Monin [Sat, 3 May 2008 11:34:13 +0000 (11:34 +0000)]
Replace Layout icon_view field by more generic file_view_type.
Replace option layout.view_as_icons by layout.file_view_type.
Laurent Monin [Sat, 3 May 2008 10:31:37 +0000 (10:31 +0000)]
Set thumbs_enabled through new function vflist_thumbs_set() instead
of vflist_new().
Laurent Monin [Sat, 3 May 2008 09:41:09 +0000 (09:41 +0000)]
Prepare merging of some parts of view_file_list and view_file_icon and
simplification of view_file* interface.
Laurent Monin [Sat, 3 May 2008 08:35:08 +0000 (08:35 +0000)]
Change default positions of dividers since width of the main menu
was increased.
Laurent Monin [Fri, 2 May 2008 23:11:31 +0000 (23:11 +0000)]
Make exif_rational_to_double() and exif_get_rational_as_double() static.
Laurent Monin [Fri, 2 May 2008 23:08:18 +0000 (23:08 +0000)]
info_notebook_reordered_cb(): do not call info_tabs_sync(), it causes exif
info disappearing when moving the tab.
Laurent Monin [Fri, 2 May 2008 22:59:04 +0000 (22:59 +0000)]
Fix a Pango warning related to UTF8 when displaying internationalized
description in Advanced Exif Properties panel.
Laurent Monin [Fri, 2 May 2008 22:31:24 +0000 (22:31 +0000)]
exif_get_description_by_key(): tidy up.
Laurent Monin [Fri, 2 May 2008 22:28:39 +0000 (22:28 +0000)]
Add a pointer to the build function in the formatted exif tags struct
and use a loop in exif_get_formatted_by_key().
Laurent Monin [Fri, 2 May 2008 21:58:36 +0000 (21:58 +0000)]
Indentation fix.
Laurent Monin [Fri, 2 May 2008 21:34:26 +0000 (21:34 +0000)]
Explode exif_get_formatted_by_key() in smaller functions prefixed "exif_build_f".
An helper macro was added to call them.
Laurent Monin [Fri, 2 May 2008 20:56:59 +0000 (20:56 +0000)]
Remove unused checksum_simple() function.
Laurent Monin [Fri, 2 May 2008 20:40:47 +0000 (20:40 +0000)]
Simplify remove_extension_from_path().
Laurent Monin [Fri, 2 May 2008 20:27:47 +0000 (20:27 +0000)]
remove_level_from_path() was simplified.
Laurent Monin [Fri, 2 May 2008 09:03:52 +0000 (09:03 +0000)]
Move variable declaration and affectation near where it is used.
Laurent Monin [Fri, 2 May 2008 08:41:32 +0000 (08:41 +0000)]
Replace GQView by Geeqie.
Laurent Monin [Thu, 1 May 2008 23:20:26 +0000 (23:20 +0000)]
Use sizeof() instead of hardcoded buffer sizes.
Laurent Monin [Thu, 1 May 2008 22:59:54 +0000 (22:59 +0000)]
cache_sim_write_similarity(): cleanup and simplification.
Laurent Monin [Thu, 1 May 2008 22:31:14 +0000 (22:31 +0000)]
Use secure_save stuff to write .sim files.
Laurent Monin [Thu, 1 May 2008 22:30:16 +0000 (22:30 +0000)]
save_options(): minor code simplification.
Laurent Monin [Thu, 1 May 2008 22:27:44 +0000 (22:27 +0000)]
Add a wrapper to fwrite().
Laurent Monin [Thu, 1 May 2008 21:42:22 +0000 (21:42 +0000)]
Typo fix.
Laurent Monin [Thu, 1 May 2008 18:37:50 +0000 (18:37 +0000)]
Indentation fixes.
Laurent Monin [Thu, 1 May 2008 18:26:30 +0000 (18:26 +0000)]
Simplify and optimize extension_find_dot().
Vladimir Nadvornik [Tue, 29 Apr 2008 22:44:06 +0000 (22:44 +0000)]
fixed a memory leak
Vladimir Nadvornik [Tue, 29 Apr 2008 18:12:49 +0000 (18:12 +0000)]
cleanup: use image_get_image_size
Vladimir Nadvornik [Tue, 29 Apr 2008 17:52:12 +0000 (17:52 +0000)]
fixed connected zoom and scroll that didn't work in some cases
http://sourceforge.net/tracker/index.php?func=detail&aid=
1952429&group_id=222125&atid=
1054680
Petr Ostadal [Sun, 27 Apr 2008 23:31:20 +0000 (23:31 +0000)]
fix warning cast from pointer to integer of different size (when an integer is
passed instead of a pointer to a callback, GINT_TO_POINTER(i) should be used)
Vladimir Nadvornik [Sun, 27 Apr 2008 20:05:11 +0000 (20:05 +0000)]
Added LIRC patch written by Matteo Beniamino
Laurent Monin [Fri, 25 Apr 2008 20:23:21 +0000 (20:23 +0000)]
Fix number of directory views, bug introduced in revision 617.
Vladimir Nadvornik [Fri, 25 Apr 2008 20:08:47 +0000 (20:08 +0000)]
fixed dragging multiple files from file list
http://sourceforge.net/tracker/index.php?func=detail&aid=
1950740&group_id=222125&atid=
1054680
Laurent Monin [Fri, 25 Apr 2008 09:31:32 +0000 (09:31 +0000)]
Add a line about variable and function names.
Laurent Monin [Fri, 25 Apr 2008 09:28:45 +0000 (09:28 +0000)]
Document the Geeqie coding style.
This is a draft, please improve.
Laurent Monin [Fri, 25 Apr 2008 08:07:22 +0000 (08:07 +0000)]
Handle the case of reduction of the number of view directory types.
Previously it was leading to a segfault.
Laurent Monin [Thu, 24 Apr 2008 20:29:09 +0000 (20:29 +0000)]
Allow to copy the path of a directory to clipboard from directory views.
Show Copy path option has to be enabled.
Suggested by Frédéric Mantegazza.
Laurent Monin [Thu, 24 Apr 2008 20:18:59 +0000 (20:18 +0000)]
Do not allow to add anything but directories to sort bar in
folder mode through drag'n'drop.
Introduce a new field only_directories to _BookMarkData struct.
Laurent Monin [Thu, 24 Apr 2008 16:35:02 +0000 (16:35 +0000)]
Add missing spaces around equal sign.
Laurent Monin [Thu, 24 Apr 2008 16:32:20 +0000 (16:32 +0000)]
Cleanup exif_get_formatted_by_key().
Laurent Monin [Thu, 24 Apr 2008 15:57:58 +0000 (15:57 +0000)]
Add missing space.
Laurent Monin [Thu, 24 Apr 2008 15:53:08 +0000 (15:53 +0000)]
6 for() vs 201 for (): winner is for ().
Laurent Monin [Thu, 24 Apr 2008 15:49:57 +0000 (15:49 +0000)]
Convert the minority of while() to while ().
Laurent Monin [Thu, 24 Apr 2008 15:44:43 +0000 (15:44 +0000)]
Use only one secure_fprintf() call instead of two.
Laurent Monin [Thu, 24 Apr 2008 15:31:21 +0000 (15:31 +0000)]
Use sizeof().
Laurent Monin [Thu, 24 Apr 2008 12:47:09 +0000 (12:47 +0000)]
Remove whitespace between function name and first parenthesis for the sake of consistency. (pass 2)
Laurent Monin [Thu, 24 Apr 2008 12:23:02 +0000 (12:23 +0000)]
Remove whitespace between function name and first parenthesis for the sake of consistency.
Laurent Monin [Thu, 24 Apr 2008 11:40:26 +0000 (11:40 +0000)]
Indentation fix.
Laurent Monin [Thu, 24 Apr 2008 09:50:37 +0000 (09:50 +0000)]
Display file_data debug messages only at level 2.
Laurent Monin [Thu, 24 Apr 2008 09:43:23 +0000 (09:43 +0000)]
Move get_exec_time() to debug.{c,h}.
Laurent Monin [Thu, 24 Apr 2008 09:09:48 +0000 (09:09 +0000)]
Move options stuff to options.{c,h} and remove globals.c
Laurent Monin [Thu, 24 Apr 2008 08:53:39 +0000 (08:53 +0000)]
Move debug macros from main.h to new debug.h.
Make debug_level static to debug.c and add utility functions
to manipulate it.
Add #include "debug.h" where needed.
Laurent Monin [Thu, 24 Apr 2008 00:15:03 +0000 (00:15 +0000)]
Handle the newline in DEBUG_N() macro instead of adding one
in each debug message string.
Laurent Monin [Wed, 23 Apr 2008 23:52:20 +0000 (23:52 +0000)]
French translation was updated.
Laurent Monin [Wed, 23 Apr 2008 23:51:02 +0000 (23:51 +0000)]
Make image_osd_histogram_onoff_toggle() and image_osd_histogram_onoff_status() static.
Laurent Monin [Wed, 23 Apr 2008 23:47:53 +0000 (23:47 +0000)]
Fix image overlay displayed only on second "I" press in layout view.
Laurent Monin [Wed, 23 Apr 2008 23:35:13 +0000 (23:35 +0000)]
Display file and line along debug messages for any debug level but level 1.
Add a DEBUG_0() macro for instant debugging.
Laurent Monin [Wed, 23 Apr 2008 22:40:55 +0000 (22:40 +0000)]
Fix Gtk-CRITICAL **: gtk_entry_set_text: assertion `GTK_IS_ENTRY (entry)' failed
occuring when toggling file list view <-> file icon view.
Vladimir Nadvornik [Wed, 23 Apr 2008 22:38:34 +0000 (22:38 +0000)]
clear the buffer before loading of an image
Laurent Monin [Wed, 23 Apr 2008 22:33:18 +0000 (22:33 +0000)]
Use menu_item_add_stock_sensitive() and menu_item_add_sensitive().
Laurent Monin [Wed, 23 Apr 2008 22:22:37 +0000 (22:22 +0000)]
Update to contributors list.
Laurent Monin [Wed, 23 Apr 2008 22:17:21 +0000 (22:17 +0000)]
Allow the copy of file paths to clipboard.
This feature is disabled by default, it can be set through
Preferences > Advanced > Behavior > Show "Copy path" ...
When enabled, it adds a menu entry "Copy path" that let the
user copies current selection's paths to X clipboard.
It is very convenient to paste paths to xterm for example.
Patch by Carles Pina i Estany and me.
Vladimir Nadvornik [Wed, 23 Apr 2008 21:08:29 +0000 (21:08 +0000)]
fixed a bug in opening files with non-utf8 locales in exiv2.cc
Laurent Monin [Wed, 23 Apr 2008 20:47:19 +0000 (20:47 +0000)]
Introduce macros to display debug messages.
if (debug) printf(...) is now replaced by variadic macros:
DEBUG_1()
And for higher debugging levels:
DEBUG_2()
DEBUG_3()
DEBUG_4()
Laurent Monin [Wed, 23 Apr 2008 13:46:18 +0000 (13:46 +0000)]
Honor Control and Shift keys while drag'n'droping files
to directories.
Before a menu (Copy/Move/Cancel) was always displayed, now
if the user hold Shift key or Control key, the menu
is not shown, but move or copy actions take place.
If no modifier key is used, the menu is displayed as usual.
Laurent Monin [Wed, 23 Apr 2008 13:03:04 +0000 (13:03 +0000)]
Only display message if in debug mode.
Laurent Monin [Wed, 23 Apr 2008 09:56:21 +0000 (09:56 +0000)]
Fix adding a selection to a collection with no window open
using the sort manager. Only one file was added, now all
files in the selection are added (but duplicates).
A pointer was not reset correctly.
Laurent Monin [Tue, 22 Apr 2008 23:53:24 +0000 (23:53 +0000)]
Save sort manager state to rc file.
Laurent Monin [Tue, 22 Apr 2008 22:45:51 +0000 (22:45 +0000)]
Remove unused function bar_info_size_request().
Laurent Monin [Tue, 22 Apr 2008 22:44:10 +0000 (22:44 +0000)]
Save state and width of exif, info and sort panels to rc file.
Width is restored only if save windows dimensions is set.
Vladimir Nadvornik [Tue, 22 Apr 2008 19:26:07 +0000 (19:26 +0000)]
updated ChangeLog from svn log
Vladimir Nadvornik [Tue, 22 Apr 2008 18:06:38 +0000 (18:06 +0000)]
fixed version string ;)
Vladimir Nadvornik [Tue, 22 Apr 2008 17:45:08 +0000 (17:45 +0000)]
updated version number
Vladimir Nadvornik [Tue, 22 Apr 2008 17:40:29 +0000 (17:40 +0000)]
fixed reading of signed rational type with Exiv2
Vladimir Nadvornik [Tue, 22 Apr 2008 09:57:26 +0000 (09:57 +0000)]
fixed instalation of doc files
Laurent Monin [Tue, 22 Apr 2008 09:40:05 +0000 (09:40 +0000)]
Correctly escape data before using pango_layout_set_markup().
Exif data may contain characters like & or < >.
Laurent Monin [Tue, 22 Apr 2008 09:01:29 +0000 (09:01 +0000)]
Use image_osd_toggle() in layout_menu_overlay_cb().
Drop layout_image_overlay_update().
Laurent Monin [Tue, 22 Apr 2008 08:53:07 +0000 (08:53 +0000)]
Merge view_overlay_toggle() and layout_image_overlay_toggle() into new image_osd_toggle().
Laurent Monin [Tue, 22 Apr 2008 08:34:30 +0000 (08:34 +0000)]
Make histogram depends on image window not layout window.
It simplifies the code, and make more sense.
Laurent Monin [Tue, 22 Apr 2008 08:16:02 +0000 (08:16 +0000)]
Ensure Properties dialog is displayed above fullscreen window.
Add a parameter to info_window_new() to pass parent window and
revert patch 472.
Laurent Monin [Mon, 21 Apr 2008 22:19:32 +0000 (22:19 +0000)]
Indicate bugs and feature requests trackers, remove obsolete stuff.
Laurent Monin [Mon, 21 Apr 2008 22:15:56 +0000 (22:15 +0000)]
Lowercased name.