Colin Clark [Tue, 11 Jul 2023 15:53:16 +0000 (16:53 +0100)]
Include clang-tidy check
- Initial check setup
- Separate log files for GitHub workflow runs
Rosen Penev [Sat, 8 Jul 2023 21:18:35 +0000 (14:18 -0700)]
vector conversion
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 29 Jun 2023 23:20:37 +0000 (16:20 -0700)]
add missing free
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sun, 9 Jul 2023 07:59:59 +0000 (08:59 +0100)]
Remove redundant compiler options
Colin Clark [Sat, 8 Jul 2023 16:04:51 +0000 (17:04 +0100)]
Eliminate “might be clobbered” warnings
- image-load-cr3 Will be deleted when libraw and exiv2 handle .cr3 files
- image-load-jpeg - this code is so old it should not be changed
Rosen Penev [Fri, 30 Jun 2023 02:54:53 +0000 (19:54 -0700)]
manual loop conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 1 Jul 2023 17:44:17 +0000 (10:44 -0700)]
use vector
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 29 Jun 2023 22:48:26 +0000 (15:48 -0700)]
clang-tidy: remove misleading const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 29 Jun 2023 22:42:46 +0000 (15:42 -0700)]
clang-tidy: get rid of const in declarations
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 29 Jun 2023 22:19:32 +0000 (15:19 -0700)]
clang-tidy: simplify booleans
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Thu, 6 Jul 2023 14:44:41 +0000 (15:44 +0100)]
Insert #ifdef HAVE_ around some #includes
Colin Clark [Thu, 6 Jul 2023 11:23:21 +0000 (12:23 +0100)]
Clean up UNUSED warnings and others
Colin Clark [Thu, 6 Jul 2023 09:01:16 +0000 (10:01 +0100)]
Eliminate gq-marshal compile warning
glib-genmarshal produces code that results in:
warning: ISO C forbids conversion of object pointer to function pointer
type [-Wpedantic]
Insert a pragma at the start of the code to inhibit this.
Colin Clark [Wed, 5 Jul 2023 14:56:14 +0000 (15:56 +0100)]
Eliminate gchar return ignored warning
warning: ignoring return value of ‘gchar*
g_string_free_and_steal(GString*)’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
Colin Clark [Wed, 5 Jul 2023 14:48:21 +0000 (15:48 +0100)]
Eliminate gchar return ignored warning
warning: ignoring return value of ‘gchar*
g_string_free_and_steal(GString*)’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
Colin Clark [Wed, 5 Jul 2023 14:41:30 +0000 (15:41 +0100)]
Eliminate gchar return ignored warning
warning: ignoring return value of ‘gchar*
g_string_free_and_steal(GString*)’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
Colin Clark [Wed, 5 Jul 2023 14:01:41 +0000 (15:01 +0100)]
Eliminate compiler warning - used unititialized
Colin Clark [Wed, 5 Jul 2023 13:36:58 +0000 (14:36 +0100)]
Eliminate variable length array warning
warning: ISO C++ forbids variable length array ‘IDs’ [-Wvla]
Colin Clark [Wed, 5 Jul 2023 11:26:19 +0000 (12:26 +0100)]
Eliminate gchar conversion warnings
warning: ISO C++ forbids converting a string constant to ‘gchar*’ {aka
‘char*’} [-Wwrite-strings]
Colin Clark [Wed, 5 Jul 2023 10:19:43 +0000 (11:19 +0100)]
Eliminate "not used" warnings
Colin Clark [Wed, 5 Jul 2023 08:33:50 +0000 (09:33 +0100)]
Bug fix: GitHub workflow image tests
Avoid running the remote until it is initialized
Rosen Penev [Thu, 29 Jun 2023 22:16:09 +0000 (15:16 -0700)]
clang-tidy: fixes from version 16
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Tue, 4 Jul 2023 15:33:01 +0000 (16:33 +0100)]
Bug fix: GitHub workflow image tests
libjxl is not in Ubuntu 22.04
Colin Clark [Tue, 4 Jul 2023 14:00:30 +0000 (15:00 +0100)]
Bug fix: GitHub workflow image tests
More fixes
Colin Clark [Tue, 4 Jul 2023 13:19:41 +0000 (14:19 +0100)]
Bug fix: GitHub workflow image tests
Various fixes.
Colin Clark [Tue, 4 Jul 2023 11:29:28 +0000 (12:29 +0100)]
Include faulty image test in GitHub workflow tests
Colin Clark [Tue, 4 Jul 2023 10:04:53 +0000 (11:04 +0100)]
libdwarf is required for Ddevel=enabled on GitHub
Colin Clark [Tue, 4 Jul 2023 09:52:01 +0000 (10:52 +0100)]
libunwind is required for Ddevel=enabled on GitHub
Colin Clark [Tue, 4 Jul 2023 09:46:13 +0000 (10:46 +0100)]
libdw is required for Ddevel=enabled on GitHub
Colin Clark [Tue, 4 Jul 2023 09:39:25 +0000 (10:39 +0100)]
Include image tests in GitHub workflow
Colin Clark [Mon, 3 Jul 2023 15:26:37 +0000 (16:26 +0100)]
File formats no longer supported - .apm, .icns, .wmf
- .apm Aldus Placeable Metafile
- .icns macOS icon
- .wmf Windows Metafile
Colin Clark [Sun, 2 Jul 2023 08:49:10 +0000 (09:49 +0100)]
Remote --get-file-info method
If no pixbuf has been created, return file class Unknown
Colin Clark [Sun, 2 Jul 2023 08:40:59 +0000 (09:40 +0100)]
File formats no longer supported - .ptx, .x3f
- .x3f (Sigma) Exiv2 no longer suports this format -
https://github.com/Exiv2/exiv2/issues/2325
- .ptx (Pentax) No test images could be found
Colin Clark [Sat, 1 Jul 2023 13:48:06 +0000 (14:48 +0100)]
Bug fix: .xbm files are not recognized unless the mime type is given
Colin Clark [Sat, 1 Jul 2023 09:00:38 +0000 (10:00 +0100)]
Optimize GitHub workflow tests
Run shellcheck and gtk-builder-tool only when all options are disabled.
Colin Clark [Fri, 30 Jun 2023 14:26:00 +0000 (15:26 +0100)]
Update AppImage notification
- AppImages are now on GitHub
- Update regen_potfiles.sh to include .ui files
Colin Clark [Thu, 29 Jun 2023 09:40:59 +0000 (10:40 +0100)]
Fix #1124: Search in keyboard preferences tab
https://github.com/BestImageViewer/geeqie/issues/1124
Click anywhere in a column and type.
Colin Clark [Wed, 28 Jun 2023 10:34:17 +0000 (11:34 +0100)]
Create .asc files for AppImages
Colin Clark [Tue, 27 Jun 2023 15:25:35 +0000 (16:25 +0100)]
Run github delete workflows once a week
Colin Clark [Tue, 27 Jun 2023 15:17:42 +0000 (16:17 +0100)]
Bug fix: gtk-builder-tool needs a gui
Colin Clark [Tue, 27 Jun 2023 14:42:27 +0000 (15:42 +0100)]
Bug fix: gtk-builder-tool operates on a single file
Colin Clark [Tue, 27 Jun 2023 14:24:57 +0000 (15:24 +0100)]
Install github workflow libgtk-3-bin for gtk-builder-tool
Colin Clark [Tue, 27 Jun 2023 14:11:49 +0000 (15:11 +0100)]
Convert search-and-run window to GtkBuilder .ui file
Conversion done only for future reference.
Colin Clark [Sun, 25 Jun 2023 09:21:10 +0000 (10:21 +0100)]
Bug fix: Seg. fault when OSD font not set
If Geeqie is started with no geeqierc.xml file and OSD is selected,
there will be a seg.fault.
Set the OSD font in default options - the font set does not seem to
matter.
Rosen Penev [Thu, 22 Jun 2023 09:47:00 +0000 (02:47 -0700)]
fix typo
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 22 Jun 2023 03:34:51 +0000 (20:34 -0700)]
auto with g_new
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Thu, 22 Jun 2023 02:56:08 +0000 (19:56 -0700)]
clang-tidy: more
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 24 Jun 2023 15:30:30 +0000 (08:30 -0700)]
Revert "undo one conversion and reduce casting"
This change was wrong and crashes.
This reverts commit
d4f7d83269fdb13acaa0e5bc25018a8bc75a0ee9.
Colin Clark [Thu, 22 Jun 2023 08:34:42 +0000 (09:34 +0100)]
Fix #1120: Geeqie crashes on problematic geeqie.xml config file
https://github.com/BestImageViewer/geeqie/issues/1120
Object not unreffed.
Colin Clark [Wed, 21 Jun 2023 13:24:41 +0000 (14:24 +0100)]
Remove exiv2 0.28.0 restriction
https://github.com/BestImageViewer/geeqie/pull/1119
The bug was fixed in the above commit.
Kevin Backhouse [Wed, 21 Jun 2023 11:23:33 +0000 (12:23 +0100)]
Add ExifData as extra argument to exif_item_get_data_as_text().
Colin Clark [Tue, 20 Jun 2023 14:38:54 +0000 (15:38 +0100)]
Bug fix: _XOPEN_SOURCE redefined error
The inclusion of <stdlib.h> causes this error. One solution is just to
move the declaration.
Rosen Penev [Tue, 20 Jun 2023 12:40:37 +0000 (05:40 -0700)]
clang-tidy: fix readability stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Mon, 19 Jun 2023 14:33:08 +0000 (15:33 +0100)]
Fix #1116: meson: Disabling pandoc disables installation of all documentation
https://github.com/BestImageViewer/geeqie/issues/1116
Rosen Penev [Sun, 18 Jun 2023 15:58:00 +0000 (08:58 -0700)]
clang-tidy: more missing fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Thomas Klausner [Sun, 18 Jun 2023 16:10:20 +0000 (18:10 +0200)]
Apply feedback from Colin Clark
Thomas Klausner [Sun, 18 Jun 2023 12:11:50 +0000 (14:11 +0200)]
Find and use libexecinfo (for backtrace()).
Fixes build on NetBSD.
Colin Clark [Sun, 18 Jun 2023 11:56:16 +0000 (12:56 +0100)]
GitHub action to purge old workflow runs
Thomas Klausner [Sat, 17 Jun 2023 16:47:28 +0000 (18:47 +0200)]
Add missing header for setlocale().
Thomas Klausner [Sat, 17 Jun 2023 16:47:14 +0000 (18:47 +0200)]
Add missing header for setenv().
Tobias Gruetzmacher [Sun, 18 Jun 2023 07:12:39 +0000 (09:12 +0200)]
Fix #ifdef for JPEG XL support
Colin Clark [Sat, 17 Jun 2023 13:46:16 +0000 (14:46 +0100)]
Minor text changes to CHECKLIST.md
Colin Clark [Sat, 17 Jun 2023 12:14:33 +0000 (13:14 +0100)]
Release v2.1 files
Colin Clark [Sat, 17 Jun 2023 09:17:36 +0000 (10:17 +0100)]
Update .po files
Colin Clark [Sat, 17 Jun 2023 09:12:42 +0000 (10:12 +0100)]
Update shortcuts documentation
Colin Clark [Sat, 17 Jun 2023 09:01:45 +0000 (10:01 +0100)]
Update create-shortcuts-xml.sh
Update to take into account change from NULL to nullptr and change to
use of static_cast.
Colin Clark [Fri, 16 Jun 2023 11:21:04 +0000 (12:21 +0100)]
Remove unused declarations
Rosen Penev [Mon, 12 Jun 2023 15:10:06 +0000 (08:10 -0700)]
add missing stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 12 Jun 2023 14:02:14 +0000 (07:02 -0700)]
more typedef removals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 12 Jun 2023 11:17:20 +0000 (04:17 -0700)]
clang-tidy: more C cast removals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Fri, 16 Jun 2023 09:02:58 +0000 (10:02 +0100)]
Exclude exiv2 version 0.28.0 from meson.build
Version 0.28.0 of exiv2 can cause a seg.fault in Geeqie.
See https://github.com/BestImageViewer/geeqie/issues/1090 for the
background.
Colin Clark [Thu, 15 Jun 2023 10:31:07 +0000 (11:31 +0100)]
Fix #1106: Split/Split pane sync - Shift+Arrow keys scrolling is out of sync on high zoom
https://github.com/BestImageViewer/geeqie/issues/1106
I do not know which situations the previous code was designed to handle
- there may be some problems in test cases I did not use.
Colin Clark [Wed, 14 Jun 2023 09:52:07 +0000 (10:52 +0100)]
Fix coding errors
Fix "Use of memory after it is freed" errors identified by clang-tidy
Colin Clark [Mon, 12 Jun 2023 15:35:04 +0000 (16:35 +0100)]
Script to install files needed for development use
Colin Clark [Mon, 12 Jun 2023 15:01:30 +0000 (16:01 +0100)]
Include descriptive text for Generate-ClayRGB1998-icc-h.sh
Colin Clark [Sun, 11 Jun 2023 15:08:47 +0000 (16:08 +0100)]
Update JPEG XL handling
Rosen Penev [Sun, 11 Jun 2023 11:38:51 +0000 (04:38 -0700)]
clang-tify: remove void
Found with modernize-redundant-void-args
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sun, 11 Jun 2023 10:34:22 +0000 (11:34 +0100)]
Rationalize shellchecks in meson.build
Rosen Penev [Thu, 8 Jun 2023 20:44:33 +0000 (13:44 -0700)]
clang-tidy: use using
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sat, 10 Jun 2023 15:25:31 +0000 (16:25 +0100)]
Simple script to generate doxgen documentation
- Ignore ./subprojects folder from doxygen documentation
Colin Clark [Sat, 10 Jun 2023 13:58:20 +0000 (14:58 +0100)]
Run shellcheck in meson tests
Colin Clark [Sat, 10 Jun 2023 11:14:13 +0000 (12:14 +0100)]
Run shellcheck on script files
Run using:
for file in $(find . -not \( -path ./subprojects -prune \) -name "*.sh")
do
realfile=$(realpath "$file")
shellcheck --norc --format=diff --shell sh
--enable=add-default-case,avoid-nullary-conditions,check-unassigned-uppercase,deprecate-which,quote-safe-variables
"$realfile"| patch "$realfile"
done
exit
Plus manual edits.
Rosen Penev [Tue, 6 Jun 2023 09:40:37 +0000 (02:40 -0700)]
clang-tidy: use nullptr
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 5 Jun 2023 10:11:44 +0000 (03:11 -0700)]
clang-tidy: use override
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Tue, 6 Jun 2023 08:48:05 +0000 (01:48 -0700)]
exiv2: use unique_ptr
Shorter and no delete needed.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Tue, 6 Jun 2023 08:27:16 +0000 (01:27 -0700)]
meson: set cpp standard to 14
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 5 Jun 2023 10:08:46 +0000 (03:08 -0700)]
clang-tidy: replace int with bool
Found with modernize-use-bool-literals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Thu, 8 Jun 2023 14:32:25 +0000 (15:32 +0100)]
Run GitHub actions also on pull_request
Rosen Penev [Mon, 5 Jun 2023 09:05:06 +0000 (02:05 -0700)]
manual fixes for C casts
clang-tidy does not fix these as they require both const and
reinterpret_cast.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 18:59:59 +0000 (11:59 -0700)]
remove const_cast
No need for it. Nothing is modified.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 18:53:51 +0000 (11:53 -0700)]
undo one conversion and reduce casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 14:46:18 +0000 (07:46 -0700)]
clang-tidy: C to C++ casts
Ran with:
run-clang-tidy -fix -checks=google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Thu, 8 Jun 2023 09:43:55 +0000 (10:43 +0100)]
Fix #1100:
https://github.com/BestImageViewer/geeqie/issues/1100#issuecomment-
1581251045
Another signature for .heic files.
Colin Clark [Sun, 4 Jun 2023 10:16:25 +0000 (11:16 +0100)]
clang-tidy: modernize-use-auto
Rosen Penev [Sun, 4 Jun 2023 07:55:57 +0000 (00:55 -0700)]
clang-tidy: modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:56:44 +0000 (06:56 -0700)]
convert loops to for range
simpler
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:52:00 +0000 (06:52 -0700)]
remove bad form in if statement
clang-tidy suggests braces here. instead of that, fix the condition
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:50:57 +0000 (06:50 -0700)]
remove register
depricated and removed in future standards
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sat, 3 Jun 2023 15:19:04 +0000 (16:19 +0100)]
Fix #1093: Double click for full screen
https://github.com/BestImageViewer/geeqie/issues/1093
Rosen Penev [Fri, 2 Jun 2023 15:41:12 +0000 (16:41 +0100)]
Fix #1090: exiv2 0.28.0 support
https://github.com/BestImageViewer/geeqie/issues/1090