Fix #782: dangerous duplicate finder deletes original, leaves dangling symlink

https://github.com/BestImageViewer/geeqie/issues/782

Ignore symlinks to files

diff --git a/doc/docbook/GuideImageSearchFindingDuplicates.xml b/doc/docbook/GuideImageSearchFindingDuplicates.xml
index d84e33b..c5d0a97 100644 (file)
--- a/doc/docbook/GuideImageSearchFindingDuplicates.xml
+++ b/doc/docbook/GuideImageSearchFindingDuplicates.xml
@@ -37,6 +37,11 @@
         </listitem>\r
       </varlistentry>\r
     </variablelist>\r
+    <para>\r
+      <note>\r
+        <para>Symbolic links to folders will be followed, but symbolic links to files will be ignored. Only actual files will be tested.</para>\r
+      </note>\r
+    </para>\r
   </section>\r
   <section id="Comparisonmethods">\r
     <title>Comparison methods</title>\r

diff --git a/src/dupe.c b/src/dupe.c
index cdbe630..d64f69d 100644 (file)
--- a/src/dupe.c
+++ b/src/dupe.c
@@ -1840,7 +1840,7 @@ static void dupe_files_add(DupeWindow *dw, CollectionData *collection, CollectIn
                }
        else if (fd)
                {
-               if (isfile(fd->path))
+               if (isfile(fd->path) && !g_file_test(fd->path, G_FILE_TEST_IS_SYMLINK))
                        {
                        di = dupe_item_new(fd);
                        }