Klaus Ethgen [Sun, 6 Mar 2016 23:00:26 +0000 (00:00 +0100)]
Merge branch 'compiler_warnings'
* compiler_warnings:
This potentially fixes most deprecated warnings
Fix wrong gtk3 function calls in gtk2
Export file_data_new_simple into other source files
Fixed one wrongly function call with pointer
Klaus Ethgen [Sun, 6 Mar 2016 22:49:43 +0000 (23:49 +0100)]
This potentially fixes most deprecated warnings
However, I tested it with gtk 2.46.2 on debian that pretend to be
version 2.24.29. So I still get that warnings.
Klaus Ethgen [Sun, 6 Mar 2016 22:48:42 +0000 (23:48 +0100)]
Fix wrong gtk3 function calls in gtk2
Klaus Ethgen [Sun, 6 Mar 2016 22:47:14 +0000 (23:47 +0100)]
Export file_data_new_simple into other source files
Klaus Ethgen [Sun, 6 Mar 2016 22:45:10 +0000 (23:45 +0100)]
Fixed one wrongly function call with pointer
This is a potentional dangerous call to LCMS function. There was a
compiler warning but nobody cared about before.
Klaus Ethgen [Fri, 4 Mar 2016 10:45:17 +0000 (11:45 +0100)]
Merge branch 'sort-by-ctime'
* sort-by-ctime:
Applying that sort method also to collections
Klaus Ethgen [Fri, 4 Mar 2016 10:44:47 +0000 (11:44 +0100)]
Applying that sort method also to collections
Klaus Ethgen [Fri, 4 Mar 2016 10:21:49 +0000 (11:21 +0100)]
Merge branch 'sort-by-ctime'
* sort-by-ctime:
Implementing sorting by file creation
Klaus Ethgen [Fri, 4 Mar 2016 10:21:09 +0000 (11:21 +0100)]
Implementing sorting by file creation
Solomon Peachy [Fri, 4 Mar 2016 00:47:26 +0000 (19:47 -0500)]
exiv2: Fix use-after-free of the image filename/path.
This caused garbage to be returned when we attempted to use the path to
determine if the file is a RAW image. Now, RAWs are detected properly
and the proper full-res previews are used.
Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
Signed-off-by: Klaus Ethgen <Klaus@Ethgen.de>
Klaus Ethgen [Fri, 4 Mar 2016 08:14:17 +0000 (09:14 +0100)]
Remove some useless spaces in exiv2.cc
Klaus Ethgen [Fri, 26 Feb 2016 11:37:28 +0000 (12:37 +0100)]
Updating README
Klaus Ethgen [Thu, 25 Feb 2016 15:48:22 +0000 (16:48 +0100)]
Reintroduce file_data_new_simple()
This was removed by Vladimir with
efc8096527d6f743d17c44b9982616a169973f39 to always check for sidecars.
However, the newly introduced function file_data_new_group() is very
expensive. Having it in collection (in sort manager) where the dirs of
that files have huge amount of files inside, that is simply blocking
whole geeqie.
It might be that the file_data_new_group() function need to be disarmed
on other places too.
Klaus Ethgen [Thu, 25 Feb 2016 15:46:32 +0000 (16:46 +0100)]
Tune some debug info
Klaus Ethgen [Wed, 24 Feb 2016 07:32:54 +0000 (08:32 +0100)]
Correcting return type
Klaus Ethgen [Tue, 16 Feb 2016 14:42:38 +0000 (15:42 +0100)]
Allow to choose to show parent folder
With
e9fc136 we learned buttons for parent folder in directory list.
This disabled the ".." handle in the view itself.
This was found to be not optimal as the users are used to it.
With this patch, that entry is now configurable in preferences. It is
enabled by default but could be disabled if the user don't like it.
Klaus Ethgen [Mon, 15 Feb 2016 21:09:52 +0000 (22:09 +0100)]
Fix nasty double free crashes
Old GTK+ versions seemed to be robust about this double free so we seen
that crashes or 100% CPU usages just with modern versions.
This patch takes care of it on two places:
1. Hashes will not be freed by g_hash_table_destroy when empty
2. NULLify the enty variable after free
Colin Clark [Tue, 2 Feb 2016 13:15:49 +0000 (13:15 +0000)]
Feature Request #70 Navigation menu option and button for parent directory
This request was made some years ago:
https://sourceforge.net/p/geeqie/feature-requests/70/
I have attached a patch which implements this. Also, keyboard-only users
will be able to use keyboard-accelerators to map a key to the Up function.
Unfortunately there is a usability problem. If the configuration file
geeqirc.xml exists (which it will except for first-time installations)
geeqie will not look at the programmed defaults, but will create the
toolbar from the config file - and the Up icon will not be displayed.
If the user first executes a command such as this:
sed -i '/toolitem action = "Back"/a <toolitem action = "Up" />'
~/.config/geeqie/geeqierc.xml
then all will be well.
This is not ideal, but I see no other solution.
Colin Clark
Klaus Ethgen [Fri, 18 Sep 2015 17:49:43 +0000 (18:49 +0100)]
Changing reference to sourceforge
Change sourceforge to geeqie.org.
Klaus Ethgen [Thu, 10 Sep 2015 14:34:59 +0000 (15:34 +0100)]
Include missing glua.h
Klaus Ethgen [Thu, 10 Sep 2015 13:32:18 +0000 (14:32 +0100)]
Updating web site
Vitaly Sinilin [Mon, 7 Sep 2015 21:18:56 +0000 (00:18 +0300)]
Fix toolbar visibility
The toolbar should not be visible on startup when the
configuration file has the line
toolbar_hidden = "true"
Its visibility state at startup should be the same it
was at the last shutdown.
Klaus Ethgen [Tue, 11 Aug 2015 22:26:32 +0000 (23:26 +0100)]
Merge requests 12, 13 and 14 into master
* origin/merge-requests/12:
Fix typo in debug messages
* origin/merge-requests/13:
fix include statements for large file support on 32-bit
* origin/merge-requests/14:
Add support for Green-Magenta and Yellow-Blue anaglyph modes
Michael Schwendt [Tue, 11 Aug 2015 22:21:37 +0000 (23:21 +0100)]
NULL-ptr crash in image_read_ahead_done_cb()
It's not easy to reproduce, but if one is mad and follows the steps and
presses the keys a few dozens times, there's a slight chance one can
trigger it. Not much to investigate it further.
Forwarding from Sami Farin 2015-08-07 16:40:44 EDT:
| to reproduce: quickly keep pressing f (fullscreen) and page down
| (next file) keys.
|
| attached patch is a kind of workaround, I did not inspect further
| is this threading issue etc
Full backtrace: https://bugzilla.redhat.com/attachment.cgi?id=
1027647
Patch: https://bugzilla.redhat.com/attachment.cgi?id=
1060482&action=diff&context=patch&collapsed=&headers=1&format=raw
Klaus Ethgen [Tue, 11 Aug 2015 22:19:25 +0000 (23:19 +0100)]
Remove over optimization
Thanks Uwe Ohse <uwe@ohse.de> for this find.
"it looks good, but is dead slow, for each and every call to
gdk_cairo_set_source_pixbuf takes at least 15 milliseconds on my not
really slow machine, which amounts to over 2 seconds if 144 tiles have
to be drawn (tested with many jpegs and a few large pngs).
i propose to remove this optimization until someone fixes it. After
removal geeqie is fast, again."
Alexey Akishin [Mon, 8 Dec 2014 11:46:18 +0000 (11:46 +0000)]
Add support for Green-Magenta and Yellow-Blue anaglyph modes
Michael Schwendt [Sun, 30 Nov 2014 12:09:37 +0000 (13:09 +0100)]
fix include statements for large file support on 32-bit
Volker Grabsch [Tue, 4 Nov 2014 07:41:30 +0000 (08:41 +0100)]
Fix typo in debug messages
vindow -> window
Klaus Ethgen [Sat, 27 Sep 2014 11:07:10 +0000 (12:07 +0100)]
Fix lcms2 integration
Thanks Michael Schwendt <mschwendt@gmail.com> for the bug reporting and
the patch.
Klaus Ethgen [Sun, 20 Jul 2014 13:16:02 +0000 (14:16 +0100)]
updated ChangeLog file
Klaus Ethgen [Sun, 20 Jul 2014 12:57:40 +0000 (13:57 +0100)]
Merge remote-tracking branches 'merge-requests/6' and 'merge-requests/7'
* merge-requests/6:
Bug
3594998: make lirc initialization quieter
* merge-requests/7:
Add filedata counting to watch for filedata leaks
Use FileData locks to avoid expensive reloads with marks enabled
Add "lock" functionality to keep FileDatas in memory
Klaus Ethgen [Sun, 20 Jul 2014 12:54:56 +0000 (13:54 +0100)]
Merge remote-tracking branch 'origin/merge-requests/5'
* origin/merge-requests/5:
Fix crash when loading collection listing inexistent files.
This is now a combination of Leons patch
900e65e and merge request of
Laurent. Hopefully that is now a bit more stable.
Leon Winter [Mon, 26 May 2014 22:33:52 +0000 (23:33 +0100)]
Fix for the assertion when file gives an empty lookup
Thanks Leon for this patch.
Petr Vorel [Mon, 3 Mar 2014 23:31:04 +0000 (00:31 +0100)]
fix segfault while cancel rename dialog
Patch prevents calling gtk_widget_destroy(gd->dialog) twice - second is
in generic_dialog_click_cb:58
Steps to reproduce:
select more images on left section then is seen in on page (need to
scroll), roll to the top, click by right mouse button, select Rename
from menu and cancel it by key Esc (button Cancel is working).
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff79b2b16 in gtk_widget_destroy () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
(gdb) bt
#0 0x00007ffff79b2b16 in gtk_widget_destroy () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#1 0x0000000000429c6f in generic_dialog_close (gd=0x118d700) at ui_utildlg.c:44
#2 0x0000000000429cf2 in generic_dialog_click_cb (widget=0xb12220, data=0x118d700) at ui_utildlg.c:58
#3 0x0000000000429e4a in generic_dialog_key_press_cb (widget=0xb12220, event=0x11f0800, data=0x118d700) at ui_utildlg.c:93
#4 0x00007ffff78942bc in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#5 0x00007ffff6123f28 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x00007ffff6134edd in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x00007ffff613c922 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#8 0x00007ffff613cf32 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9 0x00007ffff79b4664 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007ffff78927cf in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x00007ffff7893f95 in gtk_main_do_event () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#12 0x00007ffff74cee12 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#13 0x00007ffff5e5cea6 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#14 0x00007ffff5e5d1f8 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x00007ffff5e5d5fa in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x00007ffff789344d in gtk_main () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#17 0x0000000000492cf1 in main (argc=2, argv=0x7fffffffd4c8) at main.c:921
Levin [Sun, 26 Jan 2014 12:46:01 +0000 (13:46 +0100)]
Updated Chinese locales
Signed-off-by: Klaus Ethgen <Klaus@Ethgen.de>
Klaus Ethgen [Sun, 26 Jan 2014 12:30:18 +0000 (13:30 +0100)]
Merge remote-tracking branches 'origin/merge-requests/10' and 'origin/merge-requests/9'
Merge in some trivial but useful merge requests. (Note that 9 includes 8.)
* origin/merge-requests/10:
transifex config file allowing to easily use transifex-client
* origin/merge-requests/9:
Skip over expanded keys.
Annotate debug_exception() with source file, line, and function.
Iune Trecet [Wed, 7 Aug 2013 16:38:16 +0000 (18:38 +0200)]
transifex config file allowing to easily use transifex-client
Emil Mikulic [Sun, 21 Apr 2013 05:13:40 +0000 (15:13 +1000)]
Skip over expanded keys.
This fixes handling of filenames with % in them.
Emil Mikulic [Sun, 21 Apr 2013 04:57:37 +0000 (14:57 +1000)]
Annotate debug_exception() with source file, line, and function.
Laurent Monin [Thu, 13 Dec 2012 12:17:47 +0000 (13:17 +0100)]
Bug
3594998: make lirc initialization quieter
Increasing debug level to 1 or 2 will give more information, level 0
will only output a message to user if lirc is initialized but can't
read config file.
Laurent Monin [Mon, 26 Nov 2012 08:29:17 +0000 (09:29 +0100)]
Fix crash when loading collection listing inexistent files.
Omari Stephens [Tue, 13 Nov 2012 06:08:21 +0000 (06:08 +0000)]
Add filedata counting to watch for filedata leaks
This basically counts the number of filedata instances in existence at
any given point in time. If the number doesn't drop down to where it's
supposed to be, there are leaks.
Omari Stephens [Mon, 12 Nov 2012 18:44:44 +0000 (18:44 +0000)]
Use FileData locks to avoid expensive reloads with marks enabled
Omari Stephens [Mon, 12 Nov 2012 06:03:02 +0000 (06:03 +0000)]
Add "lock" functionality to keep FileDatas in memory
Adds two primitives to keep a FileData in memory even after its refcount
drops to zero. Intended to be used in situations when an entire group of
FileDatas _should_ stay in memory as an optimization, even if the code
would continue to function properly even if the FileData were freed.
Vedran Rodic [Sun, 28 Oct 2012 11:07:41 +0000 (12:07 +0100)]
Fix a segfault caused by .desktop file with no exec= line.
https://bugs.launchpad.net/ubuntu/+source/geeqie/+bug/
1056532
Klaus Ethgen [Tue, 2 Oct 2012 22:07:47 +0000 (23:07 +0100)]
Reapply 'call notify functions in in an idle call'
085be43cb79e04341102a9922e0e0f531454089a did some regression that should
have fixed this.
Klaus Ethgen [Tue, 2 Oct 2012 21:49:52 +0000 (22:49 +0100)]
Whitespace cleanup
Klaus Ethgen [Tue, 2 Oct 2012 21:27:22 +0000 (22:27 +0100)]
Merge branch 'ke-lua'
Mostly implementing lua integration.
* ke-lua:
Revert "call notify functions in in an idle call"
Implementing some usefull data structures for lua
First usable lua callback
Using common path for lua files
Overlay info with lua
Adding support for lua scripting
Klaus Ethgen [Tue, 2 Oct 2012 21:19:13 +0000 (22:19 +0100)]
Merge branch 'master' into ke-lua
* master: (185 commits)
better fix for big-endian architectures
Minor indentation fixes.
Cleanup checker shader code.
Fix exif orientation in clutter rendering mode.
Silent 2 warnings using explicit type casting.
Polish translation was updated, thanks to Grzegorz Gibas.
Update pt_BR translation.
Add *~, *.rej, *.orig files to git ignore list.
Fix for support >=automake-1.11.4
Trim trailing white spaces on empty lines.
Trim trailing white spaces.
Add missing vim modeline.
Fix indentation and few trailing white spaces.
Clear few more warnings, unused variables mostly.
Drop unused variable.
Remove commented out code.
Remove commented out code.
Remove commented out code.
Remove commented out code.
Remove commented out code.
...
Vladimir Nadvornik [Sun, 23 Sep 2012 09:19:36 +0000 (11:19 +0200)]
better fix for big-endian architectures
Laurent Monin [Tue, 4 Sep 2012 13:05:41 +0000 (15:05 +0200)]
Minor indentation fixes.
Laurent Monin [Tue, 4 Sep 2012 13:02:42 +0000 (15:02 +0200)]
Cleanup checker shader code.
Size and colors can now be set outside the shader code.
Laurent Monin [Tue, 4 Sep 2012 09:15:45 +0000 (11:15 +0200)]
Fix exif orientation in clutter rendering mode.
Laurent Monin [Thu, 30 Aug 2012 20:16:43 +0000 (22:16 +0200)]
Silent 2 warnings using explicit type casting.
Laurent Monin [Thu, 30 Aug 2012 18:38:31 +0000 (20:38 +0200)]
Polish translation was updated, thanks to Grzegorz Gibas.
https://sourceforge.net/tracker/?func=detail&aid=
2982159&group_id=222125&atid=
1054682
Laurent Monin [Thu, 30 Aug 2012 18:33:01 +0000 (20:33 +0200)]
Update pt_BR translation.
I just polished the translation a bit making some menu entries more clear to understand.
Michal Čihař
Laurent Monin [Thu, 30 Aug 2012 16:51:22 +0000 (18:51 +0200)]
Add *~, *.rej, *.orig files to git ignore list.
Laurent Monin [Thu, 30 Aug 2012 16:46:00 +0000 (18:46 +0200)]
Fix for support >=automake-1.11.4
Patch by Marien Zwart
https://bugs.gentoo.org/show_bug.cgi?id=414863
http://sourceforge.net/tracker/?func=detail&aid=
3562437&group_id=222125&atid=
1054680
Laurent Monin [Thu, 30 Aug 2012 16:32:32 +0000 (18:32 +0200)]
Trim trailing white spaces on empty lines.
Laurent Monin [Thu, 30 Aug 2012 16:31:41 +0000 (18:31 +0200)]
Trim trailing white spaces.
Laurent Monin [Thu, 30 Aug 2012 16:26:06 +0000 (18:26 +0200)]
Add missing vim modeline.
Laurent Monin [Thu, 30 Aug 2012 16:22:50 +0000 (18:22 +0200)]
Fix indentation and few trailing white spaces.
Laurent Monin [Thu, 30 Aug 2012 16:10:47 +0000 (18:10 +0200)]
Clear few more warnings, unused variables mostly.
Laurent Monin [Thu, 30 Aug 2012 15:34:14 +0000 (17:34 +0200)]
Drop unused variable.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:29 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.
Laurent Monin [Thu, 30 Aug 2012 13:53:28 +0000 (15:53 +0200)]
Remove commented out code.