Colin Clark [Sat, 17 Jun 2023 12:14:12 +0000 (13:14 +0100)]
Preparing for release v2.1
Colin Clark [Sat, 17 Jun 2023 09:17:36 +0000 (10:17 +0100)]
Update .po files
Colin Clark [Sat, 17 Jun 2023 09:12:42 +0000 (10:12 +0100)]
Update shortcuts documentation
Colin Clark [Sat, 17 Jun 2023 09:01:45 +0000 (10:01 +0100)]
Update create-shortcuts-xml.sh
Update to take into account change from NULL to nullptr and change to
use of static_cast.
Colin Clark [Fri, 16 Jun 2023 11:21:04 +0000 (12:21 +0100)]
Remove unused declarations
Rosen Penev [Mon, 12 Jun 2023 15:10:06 +0000 (08:10 -0700)]
add missing stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 12 Jun 2023 14:02:14 +0000 (07:02 -0700)]
more typedef removals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 12 Jun 2023 11:17:20 +0000 (04:17 -0700)]
clang-tidy: more C cast removals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Fri, 16 Jun 2023 09:02:58 +0000 (10:02 +0100)]
Exclude exiv2 version 0.28.0 from meson.build
Version 0.28.0 of exiv2 can cause a seg.fault in Geeqie.
See https://github.com/BestImageViewer/geeqie/issues/1090 for the
background.
Colin Clark [Thu, 15 Jun 2023 10:31:07 +0000 (11:31 +0100)]
Fix #1106: Split/Split pane sync - Shift+Arrow keys scrolling is out of sync on high zoom
https://github.com/BestImageViewer/geeqie/issues/1106
I do not know which situations the previous code was designed to handle
- there may be some problems in test cases I did not use.
Colin Clark [Wed, 14 Jun 2023 09:52:07 +0000 (10:52 +0100)]
Fix coding errors
Fix "Use of memory after it is freed" errors identified by clang-tidy
Colin Clark [Mon, 12 Jun 2023 15:35:04 +0000 (16:35 +0100)]
Script to install files needed for development use
Colin Clark [Mon, 12 Jun 2023 15:01:30 +0000 (16:01 +0100)]
Include descriptive text for Generate-ClayRGB1998-icc-h.sh
Colin Clark [Sun, 11 Jun 2023 15:08:47 +0000 (16:08 +0100)]
Update JPEG XL handling
Rosen Penev [Sun, 11 Jun 2023 11:38:51 +0000 (04:38 -0700)]
clang-tify: remove void
Found with modernize-redundant-void-args
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sun, 11 Jun 2023 10:34:22 +0000 (11:34 +0100)]
Rationalize shellchecks in meson.build
Rosen Penev [Thu, 8 Jun 2023 20:44:33 +0000 (13:44 -0700)]
clang-tidy: use using
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sat, 10 Jun 2023 15:25:31 +0000 (16:25 +0100)]
Simple script to generate doxgen documentation
- Ignore ./subprojects folder from doxygen documentation
Colin Clark [Sat, 10 Jun 2023 13:58:20 +0000 (14:58 +0100)]
Run shellcheck in meson tests
Colin Clark [Sat, 10 Jun 2023 11:14:13 +0000 (12:14 +0100)]
Run shellcheck on script files
Run using:
for file in $(find . -not \( -path ./subprojects -prune \) -name "*.sh")
do
realfile=$(realpath "$file")
shellcheck --norc --format=diff --shell sh
--enable=add-default-case,avoid-nullary-conditions,check-unassigned-uppercase,deprecate-which,quote-safe-variables
"$realfile"| patch "$realfile"
done
exit
Plus manual edits.
Rosen Penev [Tue, 6 Jun 2023 09:40:37 +0000 (02:40 -0700)]
clang-tidy: use nullptr
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 5 Jun 2023 10:11:44 +0000 (03:11 -0700)]
clang-tidy: use override
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Tue, 6 Jun 2023 08:48:05 +0000 (01:48 -0700)]
exiv2: use unique_ptr
Shorter and no delete needed.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Tue, 6 Jun 2023 08:27:16 +0000 (01:27 -0700)]
meson: set cpp standard to 14
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Mon, 5 Jun 2023 10:08:46 +0000 (03:08 -0700)]
clang-tidy: replace int with bool
Found with modernize-use-bool-literals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Thu, 8 Jun 2023 14:32:25 +0000 (15:32 +0100)]
Run GitHub actions also on pull_request
Rosen Penev [Mon, 5 Jun 2023 09:05:06 +0000 (02:05 -0700)]
manual fixes for C casts
clang-tidy does not fix these as they require both const and
reinterpret_cast.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 18:59:59 +0000 (11:59 -0700)]
remove const_cast
No need for it. Nothing is modified.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 18:53:51 +0000 (11:53 -0700)]
undo one conversion and reduce casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sun, 4 Jun 2023 14:46:18 +0000 (07:46 -0700)]
clang-tidy: C to C++ casts
Ran with:
run-clang-tidy -fix -checks=google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Thu, 8 Jun 2023 09:43:55 +0000 (10:43 +0100)]
Fix #1100:
https://github.com/BestImageViewer/geeqie/issues/1100#issuecomment-
1581251045
Another signature for .heic files.
Colin Clark [Sun, 4 Jun 2023 10:16:25 +0000 (11:16 +0100)]
clang-tidy: modernize-use-auto
Rosen Penev [Sun, 4 Jun 2023 07:55:57 +0000 (00:55 -0700)]
clang-tidy: modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:56:44 +0000 (06:56 -0700)]
convert loops to for range
simpler
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:52:00 +0000 (06:52 -0700)]
remove bad form in if statement
clang-tidy suggests braces here. instead of that, fix the condition
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev [Sat, 3 Jun 2023 13:50:57 +0000 (06:50 -0700)]
remove register
depricated and removed in future standards
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Colin Clark [Sat, 3 Jun 2023 15:19:04 +0000 (16:19 +0100)]
Fix #1093: Double click for full screen
https://github.com/BestImageViewer/geeqie/issues/1093
Rosen Penev [Fri, 2 Jun 2023 15:41:12 +0000 (16:41 +0100)]
Fix #1090: exiv2 0.28.0 support
https://github.com/BestImageViewer/geeqie/issues/1090
Colin Clark [Fri, 2 Jun 2023 12:56:58 +0000 (13:56 +0100)]
Bug fix: AppImage notification
Do not check for an AppImage update if a release version is being run
Colin Clark [Fri, 2 Jun 2023 10:08:24 +0000 (11:08 +0100)]
Fix #1096: Debian install script fails on Debian 11.7
https://github.com/BestImageViewer/geeqie/issues/1096
Colin Clark [Tue, 30 May 2023 11:49:54 +0000 (12:49 +0100)]
Eliminate warnings when creating .pot file
Colin Clark [Sat, 27 May 2023 10:00:44 +0000 (11:00 +0100)]
Include check for existence of xvfb in meson.build
Colin Clark [Wed, 24 May 2023 14:50:01 +0000 (15:50 +0100)]
Update GitHub actions file (part 2)
- Run apt-get update
- Use specific Ubuntu version number
Colin Clark [Wed, 24 May 2023 14:46:37 +0000 (15:46 +0100)]
Update GitHub actions file
- Run apt-get update
- Use specific Ubuntu version number
Colin Clark [Wed, 24 May 2023 13:03:14 +0000 (14:03 +0100)]
Documentation: Use G_SOURCE_CONTINUE and G_SOURCE_REMOVE
Colin Clark [Mon, 22 May 2023 17:23:20 +0000 (18:23 +0100)]
Fix typo in Readme file
Colin Clark [Mon, 22 May 2023 12:25:09 +0000 (13:25 +0100)]
Include package status in the Readme file
Colin Clark [Sun, 21 May 2023 15:16:07 +0000 (16:16 +0100)]
Fix typo in previous commit
Colin Clark [Sun, 21 May 2023 14:52:34 +0000 (15:52 +0100)]
Include executable test in GitHub action
- Include basic executable test - get version
- Use -D<option>=disabled for the no-options test
Colin Clark [Sat, 20 May 2023 10:24:26 +0000 (11:24 +0100)]
Include a build status badge in the Readme file
Colin Clark [Fri, 19 May 2023 15:09:26 +0000 (16:09 +0100)]
Include GitHub action to check builds
Tomasz Golinski [Mon, 15 May 2023 22:40:13 +0000 (00:40 +0200)]
Protect another g_memdup2 in exif.cc with ifdef
Tomasz Golinski [Mon, 15 May 2023 21:57:13 +0000 (23:57 +0200)]
Replace g_memdup with safer g_memdup2
g_memdup is declared as deprecated in current GLib, safer replacement g_memdup2 is available since GLib-2.68.
Code is protected by GLIB_CHECK_VERSION macro, so should build on older distros as well.
See https://docs.gtk.org/glib/func.memdup2.html
Tomasz Golinski [Mon, 15 May 2023 21:38:41 +0000 (23:38 +0200)]
Add missing #ifdef for DEBUG_FD
Amends commit
cd72fa8
Colin Clark [Fri, 12 May 2023 09:01:28 +0000 (10:01 +0100)]
Revert "FIXME: this can be rather slow and blocks until the size is known"
This reverts commit
8aeeb06fa5ab39f9e58938c2a8af3029fd67cbff.
Uncomment the callbacks.
Colin Clark [Fri, 12 May 2023 08:48:25 +0000 (09:48 +0100)]
Revert "FIXME: this can be rather slow and blocks until the size is known"
This reverts commit
8aeeb06fa5ab39f9e58938c2a8af3029fd67cbff.
gdk_pixbuf_get_file_info() can only get the file info from file types that it knows.
Colin Clark [Tue, 9 May 2023 09:27:39 +0000 (10:27 +0100)]
Bug fix: Copy icon not displayed
In the Copy dialog, the Copy icon was shown as a broken icon. Reverting
from gtk_image_new_from_icon_name() to gtk_image_new_from_stock() solves
the problem. I do not know why.
Andreas Rönnquist [Sun, 7 May 2023 19:55:55 +0000 (21:55 +0200)]
Do more casting to avoid build errors
Colin Clark [Mon, 8 May 2023 15:36:15 +0000 (16:36 +0100)]
Use emblems for some folder icons
- Use emblems for read-only, symlink and no-access folder icons
- Use standard folder icon for shortcuts and bookmarks
- Remove redundant GQview icons
n.b. It was not possible to get g_emblemed_icon_new() to work, so the
interim solution is to use gdk_pixbuf_composite()
Andreas Rönnquist [Sun, 7 May 2023 13:52:41 +0000 (15:52 +0200)]
Don't use too new *_DEFAULT defines
Colin Clark [Sun, 7 May 2023 13:02:12 +0000 (14:02 +0100)]
Remove "dot" entry from shortcuts pane
The "dot" entry had no meaning in the shortcuts pane, so is removed from
the defaults.
Current users can now delete the entry with a right-click.
Colin Clark [Sun, 7 May 2023 10:51:14 +0000 (11:51 +0100)]
Fix #1080: Cannot build with meson 0.56.2
https://github.com/BestImageViewer/geeqie/issues/1080
Sam James [Sat, 6 May 2023 11:46:40 +0000 (12:46 +0100)]
Drop stale intltool references
Moved to gettext when porting to meson.
Signed-off-by: Sam James <sam@gentoo.org>
Colin Clark [Mon, 1 May 2023 15:45:34 +0000 (16:45 +0100)]
Bug fix: Generation of translators list
Wrong text offset used
Colin Clark [Mon, 1 May 2023 15:31:11 +0000 (16:31 +0100)]
Fix #1079: Delete a keyboard shortcut
https://github.com/BestImageViewer/geeqie/issues/1079
Additional button on Preferences/Keyboard to clear selected shortcuts
Colin Clark [Mon, 1 May 2023 09:51:43 +0000 (10:51 +0100)]
Credit webpage artwork
- Credit webpage artwork
- Remove unused variable
Colin Clark [Sun, 30 Apr 2023 14:38:23 +0000 (15:38 +0100)]
Revise gresources use
Colin Clark [Fri, 21 Apr 2023 10:01:59 +0000 (11:01 +0100)]
Auto-generate list of authors and translators
- Get list of authors from git log, ordered by number of commits
- Get list of translators from headers in the .po files
- Lists are displayed in the About dialog
Colin Clark [Mon, 17 Apr 2023 15:38:25 +0000 (16:38 +0100)]
Bug fix: Error in typecast
Colin Clark [Sun, 9 Apr 2023 16:02:16 +0000 (17:02 +0100)]
Fix #1077: allow split view with user specified layout
https://github.com/BestImageViewer/geeqie/issues/1077
Additional layout - 3 horizontal panes
Colin Clark [Fri, 7 Apr 2023 17:05:56 +0000 (18:05 +0100)]
Fix c++ compiler warnings
... and this one...
Colin Clark [Fri, 7 Apr 2023 17:04:29 +0000 (18:04 +0100)]
Fix c++ compiler wrnings
Most of the remaining warnings eliminated
Colin Clark [Fri, 7 Apr 2023 09:28:02 +0000 (10:28 +0100)]
Fix c++ compiler warnings
Geeqie compiles without the -fpermissive option,
Colin Clark [Mon, 3 Apr 2023 08:59:02 +0000 (09:59 +0100)]
Fix c++ cmpiler warnings
GdkModifierType cast
Colin Clark [Mon, 3 Apr 2023 08:42:35 +0000 (09:42 +0100)]
Fix c++ compiler warnings
Bug fix for previous commit
Colin Clark [Sun, 2 Apr 2023 09:16:00 +0000 (10:16 +0100)]
Fix c++ compiler warnings
const gchar * casts
Colin Clark [Fri, 31 Mar 2023 17:28:34 +0000 (18:28 +0100)]
Fix c++ cmpiler warnings
Include the gconstpointer casts missed from the previous commit
Colin Clark [Fri, 31 Mar 2023 16:59:46 +0000 (17:59 +0100)]
Fix c++ compiler warnings
An awk script was used to generate the changes. Hand editing was also
required:
function ltrim(s) { sub(/^[ \t\r\n]+/, "", s); return s }
function rtrim(s) { sub(/[ \t\r\n]+$/, "", s); return s }
function trim(s) { return rtrim(ltrim(s)); }
BEGIN {
}
/invalid conversion from ‘gpointer’/ {
split($0, file, ":"); # file-name line-number
split($0, fields, "[‘’]"); # get the typecast - these two characters are
UTF8 and are NOT the same
split(fields[6], cast, "*")
getline;
split($0, code, "[|=;]");
print "sed -i '" file[2]"s/"code[3]"/ static_cast<" cast[1] " *>("
trim(code[3]) ")/' " "./src/"file[1] ;
Colin Clark [Thu, 30 Mar 2023 16:00:17 +0000 (17:00 +0100)]
Change c-style typecasts to c++ style
Change the c-style typecasts inserted in commit
3de5f843397ae5f to c++
style static_casts
Colin Clark [Wed, 29 Mar 2023 18:27:41 +0000 (19:27 +0100)]
Fix more c++ compiler warnings
Colin Clark [Wed, 29 Mar 2023 15:41:11 +0000 (16:41 +0100)]
Fix some c++ compiler warnings
Colin Clark [Tue, 28 Mar 2023 17:51:01 +0000 (18:51 +0100)]
GTK4: button-press-event deprecated
GTK4 migration
- replace button-press-event with gtk_gesture_click
Colin Clark [Tue, 28 Mar 2023 17:26:44 +0000 (18:26 +0100)]
GTK4: button-press-event deprecated
GTK4 migration
- replace button-press-event with gtk_gesture_click
- include the mechanism for HAVE_GTK4 (but this is not for users)
Marcel Pol [Mon, 27 Mar 2023 09:22:33 +0000 (11:22 +0200)]
Add my name to translators
Marcel Pol [Mon, 27 Mar 2023 09:21:25 +0000 (11:21 +0200)]
Update Dutch translation (nl)
Colin Clark [Sun, 26 Mar 2023 18:11:50 +0000 (19:11 +0100)]
Update documentation for --selection options
Update man page and Help file/Reference for new command line options.
Colin Clark [Sun, 26 Mar 2023 17:53:05 +0000 (18:53 +0100)]
Ref #1025: "Move to trash" does not do anything (cross-filesystem)
https://github.com/BestImageViewer/geeqie/issues/1025
Co-authored-by: BecauseTheWorldIsRound
- A warning dialog is displayed if trash fails
- A workaround is documented
Colin Clark [Thu, 23 Mar 2023 16:10:17 +0000 (16:10 +0000)]
Bug fix: Layout window id not set
If there is no geeqierc.xml file, the lw->options.id is not set. This
leads to a glib critical error in some cases.
Omari Stephens [Mon, 13 Mar 2023 03:02:32 +0000 (03:02 +0000)]
Adds a `--selection-remove` command to the remote API.
This allows removing any selected file from the selection set, either by filename or full filepath.
Omari Stephens [Mon, 13 Mar 2023 03:02:32 +0000 (03:02 +0000)]
Adds a `--selection-clear` command to the remote API.
This simply clears the current selection. Note that this _does not_ re-add the current image to the selection.
Omari Stephens [Mon, 13 Mar 2023 03:02:32 +0000 (03:02 +0000)]
Adds a `--selection-add` command to the remote API.
This allows adding any listed file to the selection set, either by filename or full filepath.
Note that this is responsive to the UI, so (for instance) will rely on which directory is open, and whether sidecars for a given file are expanded or not.
Omari Stephens [Mon, 13 Mar 2023 02:45:22 +0000 (02:45 +0000)]
Adds a `--get-selection` remote command that shows selected files (including sidecars) in the same style as `--get-filelist:`
Colin Clark [Sun, 19 Mar 2023 10:28:13 +0000 (10:28 +0000)]
Bug fix: keyword_store not initialized
If no geeqierc.xml file, the keyword_store was not initialized which
resulted in glib critical errors.
Colin Clark [Sat, 18 Mar 2023 15:28:43 +0000 (15:28 +0000)]
Bug fix: Glib Critical error when no configuration file
If geeqierc.xml does not exist, there is a critical error -
file_data_pool is not initialized.
Colin Clark [Sat, 18 Mar 2023 10:48:18 +0000 (10:48 +0000)]
Extended stack trace
- Extended stack trace using backward-cpp. Enabled by option "devel"
- Trap more signals when not using backward-cpp
- Remove tee stderr to log window - does not work with backward-cpp, but
is of low value
Colin Clark [Thu, 16 Mar 2023 10:29:45 +0000 (10:29 +0000)]
Bug fix in debug backtrace
Colin Clark [Thu, 16 Mar 2023 10:04:09 +0000 (10:04 +0000)]
Document animated webp files
Colin Clark [Mon, 13 Mar 2023 14:13:19 +0000 (14:13 +0000)]
Use webp-pixbuf-loader instead of image-load-webp()
webp-pixbuf-loader also supports animation
Colin Clark [Mon, 13 Mar 2023 13:50:31 +0000 (13:50 +0000)]
Fix #1067: Restore zoom quality after viewing a GIF
https://github.com/BestImageViewer/geeqie/issues/1067
Colin Clark [Fri, 10 Mar 2023 15:56:13 +0000 (15:56 +0000)]
Seg fault handler
- Local handler for seg. fault
- Stack dump on seg. fault
- Stack dump option in meson_options.txt
- Bug fix in DEBUG_BT()