Colin Clark [Wed, 13 Mar 2024 14:00:38 +0000 (14:00 +0000)]
Include check compile on FreeBSD as a GitHub action
Colin Clark [Wed, 13 Mar 2024 09:50:29 +0000 (09:50 +0000)]
Include appstreamcli in ancillary files check
appstreamcli is used to lint org.geeqie.Geeqie.appdata.xml.in
Colin Clark [Tue, 12 Mar 2024 18:00:03 +0000 (18:00 +0000)]
Eliminate some warnings from the appdata file
Hofer-Julian [Tue, 12 Mar 2024 10:38:48 +0000 (11:38 +0100)]
Adapt appdata to stricter requirements
Flathub nowadays has stricter requirements for the appdata.
This commit adapts the appdata file accordingly
Arkadiy Illarionov [Mon, 11 Mar 2024 20:53:41 +0000 (23:53 +0300)]
Fix some GTK deprecation warnings
Arkadiy Illarionov [Sun, 10 Mar 2024 22:50:36 +0000 (01:50 +0300)]
Blind fix macOS build
Arkadiy Illarionov [Sun, 10 Mar 2024 11:57:45 +0000 (14:57 +0300)]
Use std::swap instead of temporary values
Arkadiy Illarionov [Sun, 10 Mar 2024 10:52:01 +0000 (13:52 +0300)]
Use p_step to avoid has_alpha comparison in loop
Colin Clark [Sat, 9 Mar 2024 17:44:11 +0000 (17:44 +0000)]
Include icon name column in Preferences/Keyboard table
Arkadiy Illarionov [Sat, 9 Mar 2024 16:45:19 +0000 (19:45 +0300)]
Simplify util_clip_triangle()
Arkadiy Illarionov [Sat, 9 Mar 2024 15:56:22 +0000 (18:56 +0300)]
Add PanColor to simplify pan functions
Move some defines to cc files.
Colin Clark [Sat, 9 Mar 2024 15:57:26 +0000 (15:57 +0000)]
Replace single value enums with constexpr <type>
Commit
a4ce95bc clang-tidy: modernize-macro-to-enum, resulted in some
enums containing a single value.
These are now replaced by a constexpr <type> statement.
The script used to identify these single value enum statements is now
included as a meson test.
Arkadiy Illarionov [Sat, 9 Mar 2024 11:02:22 +0000 (14:02 +0300)]
Deduplicate FILE_COLUMN_POINTER
Arkadiy Illarionov [Fri, 8 Mar 2024 16:14:12 +0000 (19:14 +0300)]
Deduplicate cell_renderer_height_override()
Andreas Rönnquist [Wed, 6 Mar 2024 19:40:41 +0000 (20:40 +0100)]
Updated Swedish translation
Colin Clark [Wed, 6 Mar 2024 16:03:11 +0000 (16:03 +0000)]
Release v2.3 files
Colin Clark [Wed, 6 Mar 2024 15:50:51 +0000 (15:50 +0000)]
Update translations
Colin Clark [Wed, 6 Mar 2024 14:37:33 +0000 (14:37 +0000)]
Bug fix: No toolbars on first entry
When Geeqie is started for the first time and geeqierc.xml does not
exist, the toolbars were not set to the default values.
Arkadiy Illarionov [Mon, 4 Mar 2024 22:20:45 +0000 (01:20 +0300)]
Fix build with LTO
* Move structs and some functions to anonymous namespace
* Replace some defines and enums with constants
* Replace macro with inline function
Arkadiy Illarionov [Sun, 3 Mar 2024 12:39:51 +0000 (15:39 +0300)]
Compile modules based on HAVE_* features
Colin Clark [Mon, 4 Mar 2024 10:56:16 +0000 (10:56 +0000)]
Remove Code Correctness checks on GitHub
muxee/clang-tidy-action runs only on pull requests.
It is necessary to run the checks also on pushes.
Colin Clark [Sun, 3 Mar 2024 14:23:00 +0000 (14:23 +0000)]
Run Code Correctness checks on GitHub
Arkadiy Illarionov [Sun, 3 Mar 2024 10:53:36 +0000 (13:53 +0300)]
Remove set but not used variables
Colin Clark [Sat, 2 Mar 2024 17:16:17 +0000 (17:16 +0000)]
Add file class Archive to the Search page
Arkadiy Illarionov [Sat, 2 Mar 2024 11:52:30 +0000 (14:52 +0300)]
Move open_archive() to separate module
Also make parameter const and move static functions to anonymous namespace.
Colin Clark [Sat, 2 Mar 2024 10:53:07 +0000 (10:53 +0000)]
Fix untranslated text
Arkadiy Illarionov [Wed, 28 Feb 2024 19:26:45 +0000 (22:26 +0300)]
Fix warnings in exiv2
Also fix indentation.
Andreas Rönnquist [Thu, 29 Feb 2024 15:45:50 +0000 (16:45 +0100)]
For POTFILES, look for whereami and zonedetect in third-party folder
Colin Clark [Thu, 29 Feb 2024 12:45:42 +0000 (12:45 +0000)]
Update some untranslated text strings
In some cases, double quotes within a text string have been replaced by
single quotes to make it easier to search for untranslated strings.
Colin Clark [Thu, 29 Feb 2024 11:23:38 +0000 (11:23 +0000)]
Run Code Correctness checks on all source files
In tests, run Code Correctness checks on all source files rather than
just modified files.
Files in the third-party directory are not checked.
Colin Clark [Thu, 29 Feb 2024 10:05:11 +0000 (10:05 +0000)]
Fix #1248: Crash when hiding file list
https://github.com/BestImageViewer/geeqie/issues/1248
Fix problems resulting from 6d72bf GTK4: Reduce the use of
gtk_widget_destroy()
Colin Clark [Wed, 28 Feb 2024 15:45:36 +0000 (15:45 +0000)]
Move third-party sources to separate sub-directory
Move any third-party sources that have been copied verbatim to a
separate sub-directory.
This allows project checks to avoid these files.
These files are unlikely to change and do not need to be tracked for
changes.
Colin Clark [Wed, 28 Feb 2024 13:28:47 +0000 (13:28 +0000)]
Bug fix: Pan view not displayed correctly
Bug resulting from
684059d GTK4: GtkTable
Arkadiy Illarionov [Tue, 27 Feb 2024 21:25:00 +0000 (00:25 +0300)]
Simplify usage of set_page_num and get_page_total
Arkadiy Illarionov [Sat, 24 Feb 2024 11:36:01 +0000 (14:36 +0300)]
Convert ImageLoaderBackend to interface and backends to implementations
Add parameters to ImageLoaderBackend methods.
Remove unused members from backend implementations.
Rename ImageLoaderBackend loader_new to init.
Move callbacks aliases to ImageLoaderBackend and rename SizeCb to SizePreparedCb.
Colin Clark [Mon, 26 Feb 2024 12:14:30 +0000 (12:14 +0000)]
Include Code Correctness check in GitHub test runs (2)
Arkadiy Illarionov [Sat, 24 Feb 2024 17:01:42 +0000 (20:01 +0300)]
Fix deprecation warning for poppler >= 0.82
Arkadiy Illarionov [Fri, 23 Feb 2024 13:16:22 +0000 (16:16 +0300)]
Let image loader backend decide how to process image buffer
Remove ImageLoaderBackendFuncLoad.
Also move static functions to anonymous namespace.
Colin Clark [Sat, 24 Feb 2024 15:16:50 +0000 (15:16 +0000)]
Include Code Correctness check in GitHub test runs
Colin Clark [Wed, 21 Feb 2024 18:40:58 +0000 (18:40 +0000)]
Minor documentation update
Update cache-maintenance description.
Colin Clark [Wed, 21 Feb 2024 15:51:55 +0000 (15:51 +0000)]
Bug fix: clang-tidy checks missing sub-dirs
Sub-dirs ./src/pan-view and ./src/view-file were not checked
Arkadiy Illarionov [Tue, 20 Feb 2024 19:59:40 +0000 (22:59 +0300)]
Fix HAVE_* config values checks
Arkadiy Illarionov [Mon, 19 Feb 2024 20:07:48 +0000 (23:07 +0300)]
Deduplicate cr3 image loader
Make it wrapper of jpeg image loader.
Add HAVE_RAW define check to make consistent with usage in image-load.
Move static functions to anonymous namespace.
Andreas Rönnquist [Tue, 20 Feb 2024 14:45:06 +0000 (15:45 +0100)]
Remove plugin refresh-thumbnail from POTFILES
Andreas Rönnquist [Tue, 20 Feb 2024 12:48:32 +0000 (13:48 +0100)]
Fix representing percent in c-format string
Arkadiy Illarionov [Sat, 22 Jul 2023 22:26:31 +0000 (01:26 +0300)]
Fix include-what-you-use warnings
Use #if to check 0/1 config value
Arkadiy Illarionov [Sun, 18 Feb 2024 16:15:22 +0000 (19:15 +0300)]
Bump Exiv2 minimum version requirement to 0.18
Remove obsolete code.
Arkadiy Illarionov [Fri, 16 Feb 2024 20:56:43 +0000 (23:56 +0300)]
Remove redundant GdkRGBA memcpy
Colin Clark [Thu, 15 Feb 2024 15:21:30 +0000 (15:21 +0000)]
Fix missing translation
Colin Clark [Wed, 14 Feb 2024 11:20:44 +0000 (11:20 +0000)]
Include anonymous namespaces in Doxygen output
Arkadiy Illarionov [Tue, 13 Feb 2024 19:48:14 +0000 (22:48 +0300)]
Sort headers using clang-tidy
Add include order rule to CODING.md.
Arkadiy Illarionov [Thu, 8 Feb 2024 18:56:40 +0000 (21:56 +0300)]
Cleanup main.h header
* Include compat.h, config.h, debug.h, intl.h, options.h, typedefs.h where they are actually used.
* Remove standard library includes.
* Remove unused gdk-pixbuf includes.
* Make other headers self-contained.
* Move defines not related to main.cc from main.h to main-defines.h.
Arkadiy Illarionov [Thu, 8 Feb 2024 18:19:09 +0000 (21:19 +0300)]
Include backward.h where it is actually used
Colin Clark [Wed, 7 Feb 2024 18:52:21 +0000 (18:52 +0000)]
Document additional file management options
Document the special plugin options to override the standard commands
for file copy, move, rename, delete and folder create.
Colin Clark [Wed, 7 Feb 2024 16:50:33 +0000 (16:50 +0000)]
clang-tidy: readability-isolate-declaration
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Wed, 7 Feb 2024 16:20:11 +0000 (16:20 +0000)]
Fix #1242: Renaming files results in a crash
https://github.com/BestImageViewer/geeqie/issues/1242
Fix bug from GTK4: Reduce the use of gtk_widget_destroy()
6d72bf20cc
Colin Clark [Wed, 7 Feb 2024 12:26:09 +0000 (12:26 +0000)]
clang-tidy: modernize-macro-to-enum
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Clang-tidy fix resulted in indentation dissimilar to that used so far.
This awk script was run on the .diff file:
/^+[A-Z]/ {
sub (/\+/,"+\t",$0)
print
next
}
$0 !~ /^+[A-Z]/ {
print
next
}
The following files were hand-edited:
thumb-standard.cc
ui-bookmark.cc
Colin Clark [Tue, 6 Feb 2024 13:40:10 +0000 (13:40 +0000)]
clang-tidy: bugprone-integer-division
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Tue, 6 Feb 2024 12:18:24 +0000 (12:18 +0000)]
clang=tidy: readability-uppercase-literal-suffix
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Tue, 6 Feb 2024 11:48:56 +0000 (11:48 +0000)]
clang-tidy: readability-suspicious-call-argument
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Tue, 6 Feb 2024 11:06:19 +0000 (11:06 +0000)]
clang-tidy: readability-misleading-indentation
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Mon, 5 Feb 2024 11:13:01 +0000 (11:13 +0000)]
Fix clang-tidy: readability-non-const-parameter (5)
Colin Clark [Mon, 5 Feb 2024 10:12:33 +0000 (10:12 +0000)]
Fix clang-tidy: readability-non-const-parameter (4)
Colin Clark [Sun, 4 Feb 2024 09:45:07 +0000 (09:45 +0000)]
Fix clang-tidy: readability-non-const-parameter (3)
Colin Clark [Sat, 3 Feb 2024 18:41:44 +0000 (18:41 +0000)]
Fix clang-tidy: readability-non-const-parameter (2)
Colin Clark [Sat, 3 Feb 2024 16:02:43 +0000 (16:02 +0000)]
Fix clang-tidy: readability-non-const-parameter
The change suggested for exiv2.cc fails on further checks.
Colin Clark [Sat, 3 Feb 2024 15:43:51 +0000 (15:43 +0000)]
clang-tidy: readability-non-const-parameter
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Sat, 3 Feb 2024 15:27:28 +0000 (15:27 +0000)]
clang-tidy: readability-inconsistent-declaration-parameter-name
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Sat, 3 Feb 2024 14:48:24 +0000 (14:48 +0000)]
clang-tidy: readability-else-after-return
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Sat, 3 Feb 2024 13:02:18 +0000 (13:02 +0000)]
Additional excludes for testing
Additional excludes for getting error-free test runs
Colin Clark [Sat, 3 Feb 2024 11:52:43 +0000 (11:52 +0000)]
Fix errors in testing scripts
Colin Clark [Fri, 2 Feb 2024 16:55:37 +0000 (16:55 +0000)]
clang-tidy: readability-duplicate-include
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 16:34:35 +0000 (16:34 +0000)]
clang-tidy: modernize-use-auto
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 16:18:19 +0000 (16:18 +0000)]
clang-tidy: modernize-use-using
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 15:28:33 +0000 (15:28 +0000)]
clang-tidy: bugprone-macro-parentheses
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 14:58:16 +0000 (14:58 +0000)]
clang-tidy: misc-redundant-expression
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 14:33:35 +0000 (14:33 +0000)]
clang-tidy; -bugprone-suspicious-string-compare, misc-unused-parameters
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 14:06:23 +0000 (14:06 +0000)]
clang-tidy: modernize-redundant-void-arg
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 13:53:05 +0000 (13:53 +0000)]
Ensure default .geeqierc.xml is used in tests
Set XDG_* for local tests so that local user file are not affected.
Colin Clark [Fri, 2 Feb 2024 12:54:32 +0000 (12:54 +0000)]
clang-tidy: modernize-use-nullptr
- Fix warnings identified by this flag
- Remove the exclude from .clang-tidy file
Colin Clark [Fri, 2 Feb 2024 11:46:25 +0000 (11:46 +0000)]
Revise testing
- Move ancillary file checks from meson.build to test-ancillary-files.sh
- Scripts to run checks locally - test-all.sh, clang-tidy-check.sh
- revise .clang-tidy so that no errors are shown for current sources
- remove files erroneously in .git
- include .shellcheckrc
Colin Clark [Wed, 31 Jan 2024 13:39:52 +0000 (13:39 +0000)]
Fix #1236: Window Layouts with vertical split are shifted to the left if they are narrower than the application menu
https://github.com/BestImageViewer/geeqie/issues/1236
Add additional scrolled box for both menu and toolbar.
Thomas Klausner [Sun, 28 Jan 2024 20:50:36 +0000 (21:50 +0100)]
Limit definition of XOPEN_SOURCE to Linux, where it's needed.
The definition breaks the build on NetBSD where it hides symbols
(to match what the standard says).
Fixes #1230.
Arkadiy Illarionov [Sat, 27 Jan 2024 13:24:37 +0000 (16:24 +0300)]
Use GdkRectangle for LayoutOptions::log_window
Andreas Rönnquist [Sat, 27 Jan 2024 12:12:51 +0000 (13:12 +0100)]
Fix permissions for geocode-parameters plugin
Colin Clark [Sat, 27 Jan 2024 11:13:55 +0000 (11:13 +0000)]
Check and revise .desktop files
Include a .desktop file check using desktop-file-validate.
Revise .desktop files - most had an incorrect Categories entry.
Andreas Rönnquist [Thu, 25 Jan 2024 21:47:47 +0000 (22:47 +0100)]
Add keywords to desktop file
Colin Clark [Thu, 25 Jan 2024 12:01:36 +0000 (12:01 +0000)]
Release v2.2 files
Colin Clark [Thu, 25 Jan 2024 10:27:23 +0000 (10:27 +0000)]
Update .po files
Colin Clark [Thu, 25 Jan 2024 09:39:12 +0000 (09:39 +0000)]
Update template-desktop.sh
Take account that the menu is now in a file menu-classic.ui
Colin Clark [Wed, 24 Jan 2024 17:01:05 +0000 (17:01 +0000)]
Fix #1223: "Confirm move files to trash" not working
https://github.com/BestImageViewer/geeqie/issues/1223
Check for move to trash missing.
Colin Clark [Wed, 24 Jan 2024 14:56:10 +0000 (14:56 +0000)]
Option to select menu style
User option to select a "hamburger" style menu icon or the classic text
style.
The option is in Edit/Preferences/General.
Colin Clark [Mon, 22 Jan 2024 16:18:06 +0000 (16:18 +0000)]
Fix #1227: webp images load as black even with every prerequisite being green during compile
https://github.com/BestImageViewer/geeqie/issues/1227
https://github.com/BestImageViewer/geeqie/issues/1076
https://github.com/BestImageViewer/geeqie/pull/1225
Revert to using image-load-webp.cc
This Geeqie webp decoder will take precedence over an installed
webp-pixbuf-loader.
This decoder does not support webp animations.
If the user wants to use an installed webp-pixbuf-loader (e.g. to get
animations), Geeqie must be compiled with the option -Dwebp=disabled.
Colin Clark [Sat, 20 Jan 2024 16:02:25 +0000 (16:02 +0000)]
Fix #1184: Put main menu items into one hamburger menu
https://github.com/BestImageViewer/geeqie/issues/1184
A "hamburger" style menu icon is located to the left of the path entry
box.
Key F10 activates the menu.
Colin Clark [Sat, 20 Jan 2024 14:20:45 +0000 (14:20 +0000)]
Bug fix: SAR window crashes when escape pressed
Colin Clark [Fri, 19 Jan 2024 16:25:02 +0000 (16:25 +0000)]
Reduce the height of toolbars
The height of the toolbars was determined by a minimum size set in
GtkToolbar().
GtkToolbar is not in GTK4.
Horizontal boxes are used instead which result in a smaller icon size.
Colin Clark [Wed, 17 Jan 2024 15:55:08 +0000 (15:55 +0000)]
Use devel=enabled option for full-size AppImages
If the user crashes Geeqie, there may be useful data output.
Colin Clark [Sun, 7 Jan 2024 11:32:43 +0000 (11:32 +0000)]
Fix #1224: Dragging a keyword to another position causes Geeqie to crash
https://github.com/BestImageViewer/geeqie/issues/1224
Incorrect change in commit
6d72bf20cc
Colin Clark [Wed, 3 Jan 2024 16:35:25 +0000 (16:35 +0000)]
Remove web page links status from README
There are too many false alarms to make this a worthwhile notification.
Colin Clark [Wed, 3 Jan 2024 10:44:36 +0000 (10:44 +0000)]
Bug fix: Run-time errors when removing a toolbar icon
- In Edit/Preferences/Toolbar Main|Status, when an item is removed there
are run-time errors
- Replace g_object_unref() with gtk_container_remove()