Omari Stephens [Sun, 4 Sep 2022 21:03:14 +0000 (21:03 +0000)]
Manual .c->.cc fixups
Omari Stephens [Sun, 4 Sep 2022 19:04:55 +0000 (19:04 +0000)]
Reflects .c->.cc file renames across Geeqie.
Commit auto-generated with:
$(for file in $(find src/ -iname '*.c' -type f); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'c_fi=ENV["file"]; c_re=Regexp.new("(?<!\\w)"+Regexp.escape(c_fi)+"(?=\\W)"); cc_file=c_fi.gsub(/\.c$/, ".cc"); $_.gsub!(c_re, cc_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
Omari Stephens [Wed, 5 Oct 2022 04:16:07 +0000 (04:16 +0000)]
Merge pull request #1038 from xsdg/hyphen-filenames.3
Renames source files from using a mixture of hyphens and underscores to using hyphens everywhere
Omari Stephens [Thu, 1 Sep 2022 07:26:43 +0000 (07:26 +0000)]
Replaces underscores with hyphens in code filenames under src.
Auto-generated with:
$git mv src/view_file/ src/view-file/
$for file in $(find src/ -type f -iname '*_*.[ch]'); do hyphen=$(echo "$file" | sed -e 's#_#-#g'); git mv -- "$file" "$hyphen"; done
Followed by a manual touchup in src/typedefs.h
Omari Stephens [Tue, 6 Sep 2022 03:42:59 +0000 (03:42 +0000)]
Updates references from using underscore filenames to hyphen filenames for files under src/
Commit automatically generated using these commands on a clean tree:
$(for file in $(find src/ -iname '*_*.[ch]' -type f); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'us_fi=ENV["file"]; us_re=Regexp.new("(?<!\\w)"+Regexp.escape(us_fi)+"(?=\\W)"); hyphen_file=us_fi.gsub(/_/, "-"); $_.gsub!(us_re, hyphen_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
$(for file in $(find src/ -iname '*_*' -type d); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'us_fi=ENV["file"]; us_re=Regexp.new("(?<!\\w)"+Regexp.escape(us_fi)+"(?=\\W)"); hyphen_file=us_fi.gsub(/_/, "-"); $_.gsub!(us_re, hyphen_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
Followed by a manual touchup in src/typedefs.h
JungHee Lee [Tue, 27 Sep 2022 07:27:18 +0000 (16:27 +0900)]
Update ko.po
All newly translated.
Colin Clark [Thu, 22 Sep 2022 15:00:47 +0000 (16:00 +0100)]
Update README for OM-1 support
Colin Clark [Wed, 21 Sep 2022 14:50:00 +0000 (15:50 +0100)]
Update doxygen.conf
Update doxygen.conf for preprocessing options
Colin Clark [Wed, 21 Sep 2022 11:18:05 +0000 (12:18 +0100)]
Collections - sidecars
Set defaults so that collections may have sidecars.
Colin Clark [Sun, 18 Sep 2022 13:51:29 +0000 (14:51 +0100)]
GTK4: gtk_menu_popup() deprecated
GTK4 migration
- replace gtk_menu_popup() by gtk_menu_popup_at_widget() or
gtk_menu_popup_at_pointer()
Colin Clark [Sun, 18 Sep 2022 12:18:47 +0000 (13:18 +0100)]
Bug fix: gtk_hbox and gtk_vbox deprecated
Pan view not displayed correctly
Andreas Rönnquist [Sun, 11 Sep 2022 15:12:07 +0000 (17:12 +0200)]
Fix appstream validation
Colin Clark [Sat, 10 Sep 2022 12:08:30 +0000 (13:08 +0100)]
GTK4: Event signals replaced
GTK4 migration
- event signals replaced by event controllers
- (gtk_event_controller_focus_new() not backported to GTK3)
Colin Clark [Sat, 10 Sep 2022 10:41:07 +0000 (11:41 +0100)]
GTK4: gtk_hbox and gtk_vbox deprecated
GTK4 migration
- gtk_hbox_new() and gtk_vbox_new() replaced by gtk_box() and
GTK_ORIENTATION_HORIZONTAL or GTK_ORIENTATION_VERTICAL
Colin Clark [Sat, 10 Sep 2022 09:02:23 +0000 (10:02 +0100)]
GTK4: gtk_arrow_new is deprecated
GTK4 migration
- replace gtk_arrow_new() with gtk_image_new_from_icon_name()
Colin Clark [Thu, 8 Sep 2022 14:58:42 +0000 (15:58 +0100)]
GTK4: uint32 is deprecated
GTK4 migration
Eliminate deprecations
- replace uint32 with guint32
Colin Clark [Thu, 8 Sep 2022 14:12:27 +0000 (15:12 +0100)]
Update doxygen.conf
- Update doxygen.conf via: doxygen -u doxygen.conf
- Rename file diagrams.c to diagrams.dox
Colin Clark [Thu, 8 Sep 2022 09:17:25 +0000 (10:17 +0100)]
GTK4: GdkDeviceManager removed from GTK4
GTK4 migration
- gdk_display_get_device_manager() replaced by
gdk_display_get_default_seat()
- gdk_device_manager_get_client_pointer() replaced by
gdk_seat_get_pointer()
Colin Clark [Wed, 7 Sep 2022 10:53:10 +0000 (11:53 +0100)]
Bug fix: Thumbnail not shown unless filename text shown
Colin Clark [Mon, 5 Sep 2022 18:41:45 +0000 (19:41 +0100)]
Fix #1031: French translations borked since commit
9e019ed7e
https://github.com/BestImageViewer/geeqie/issues/1031
- POTFILES was mistakenly deleted
- .gitignore ignored POTFILES
- gettext requires extra parameter to see all strings
Dmitry Marakasov [Wed, 31 Aug 2022 16:17:22 +0000 (19:17 +0300)]
Detect libtiff properly through pkgconfig
Dmitry Marakasov [Wed, 31 Aug 2022 16:20:16 +0000 (19:20 +0300)]
Fix index.html symlink
Create relative symlink, as absolute one will point to temporary build directory
Dmitry Marakasov [Wed, 31 Aug 2022 16:14:36 +0000 (19:14 +0300)]
Detect strverscmp support properly
Colin Clark [Mon, 29 Aug 2022 15:21:24 +0000 (16:21 +0100)]
Bug fix: meson executable dependencies
The order of the dependencies is significant for the requested GTK
version to be picked up
Colin Clark [Thu, 18 Aug 2022 14:12:57 +0000 (15:12 +0100)]
Fix #1023: Unresponsive UI when Show Marks is enabled
https://github.com/BestImageViewer/geeqie/issues/1023
- Remove and unref the css_provider each iteration
- Two other small speed improvements
Julian Hofer [Sat, 13 Aug 2022 18:56:58 +0000 (20:56 +0200)]
Fix appdata and icon installation
- Appdata used invalid tags
- Icon was not installed
Colin Clark [Fri, 12 Aug 2022 15:20:22 +0000 (16:20 +0100)]
Fix #999: Adding a widget to the info sidebar resizes the sidebar to something around 70% of window width
https://github.com/BestImageViewer/geeqie/issues/999
Colin Clark [Fri, 12 Aug 2022 09:34:00 +0000 (10:34 +0100)]
Exclude build directories from release tar
(cherry picked from commit
71210120367eeb6ba5e5079c13952aa77bb91a40)
Colin Clark [Fri, 12 Aug 2022 09:36:53 +0000 (10:36 +0100)]
Release v2.0.1 files
Colin Clark [Thu, 11 Aug 2022 17:42:44 +0000 (18:42 +0100)]
Exclude build directory from doxygen output
Omari Stephens [Mon, 8 Aug 2022 01:43:58 +0000 (01:43 +0000)]
Fixes some whitespace issues
Omari Stephens [Mon, 8 Aug 2022 00:50:56 +0000 (00:50 +0000)]
Fixes compile warnings in files touched by the "C++ keywords" change
Note that the -Wpedantic function pointer warnings aren't fixable, given the GLIB/GTK API design:
https://stackoverflow.com/a/
14134283
Omari Stephens [Mon, 30 May 2022 06:39:12 +0000 (06:39 +0000)]
Renames variables to avoid conflicting with C++ keywords.
Colin Clark [Mon, 8 Aug 2022 14:22:47 +0000 (15:22 +0100)]
Release v2.0 files
Colin Clark [Mon, 8 Aug 2022 12:04:00 +0000 (13:04 +0100)]
Fix gettext use with Meson
- Also update translations
Omari Stephens [Mon, 1 Aug 2022 09:01:29 +0000 (09:01 +0000)]
*sigh* fixes multiple compile errors and warnings
Omari Stephens [Sun, 31 Jul 2022 21:35:32 +0000 (21:35 +0000)]
Whoops; make sure we check the return value of read_bool_option.
Omari Stephens [Sun, 31 Jul 2022 21:22:31 +0000 (21:22 +0000)]
Fixes a possible uninitialized value usage by modifying how we parse <filter_type> configuration elements
Omari Stephens [Mon, 30 May 2022 08:15:58 +0000 (08:15 +0000)]
Creates a more-explicitly-type-unsafe value reader for enums.
This code relies on our ability to read a guint into an enum address. C++ forbids this being done implicitly, so we do it explicitly.
Colin Clark [Sat, 6 Aug 2022 15:56:59 +0000 (16:56 +0100)]
Fix #1017: Use source root and not build root to install Changelogs and readme from
https://github.com/BestImageViewer/geeqie/pull/1017
Check for non-availability of git.
Carles Pina i Estany [Mon, 1 Aug 2022 19:02:23 +0000 (20:02 +0100)]
Update authors and emails of Catalan translators
Carles Pina i Estany [Mon, 1 Aug 2022 19:02:04 +0000 (20:02 +0100)]
Catalan translation: align text in the output of geeqie --help
Carles Pina i Estany [Mon, 1 Aug 2022 18:52:03 +0000 (19:52 +0100)]
Fix "geeqie --help" remote commands section translation
The strings were marked to be translated in the:
"static RemoteCommandEntry remote_commands" as N_("some string")
Now it translates the strings at printing time.
Carles Pina i Estany [Sun, 31 Jul 2022 20:46:13 +0000 (21:46 +0100)]
Use Catalan "str" («str»)
Carles Pina i Estany [Sun, 31 Jul 2022 20:42:52 +0000 (21:42 +0100)]
Translate fuzzy and untranslated messages
Carles Pina i Estany [Sun, 31 Jul 2022 19:43:17 +0000 (20:43 +0100)]
Add comment on the style used by the Catalan translation
Carles Pina i Estany [Sun, 31 Jul 2022 19:38:48 +0000 (20:38 +0100)]
Consolidate all the "Delete" to "Suprimir"
There was a mixture of other translations
Omari Stephens [Sun, 31 Jul 2022 17:23:17 +0000 (17:23 +0000)]
Fixes `-Wsign-compare` errors when comparing int versus sizeof
Omari Stephens [Mon, 30 May 2022 09:11:15 +0000 (09:11 +0000)]
Fixes jumps across variable declarations in same scope
Those jumps are not legal in C++. zonedetect.h is an imported library, so this is a minimal change that allows compilation as C++.
Omari Stephens [Sun, 31 Jul 2022 16:54:08 +0000 (16:54 +0000)]
Fixes one last int->uint
Omari Stephens [Wed, 27 Jul 2022 18:34:42 +0000 (18:34 +0000)]
Replaces inappropriate usage of (int) with (uint) throughout image_load_dds, which only ever deals with at-most-32-bit unsigned values.
Also adds return value checking for g_try_malloc() to avoid NULL dereference on failure.
Omari Stephens [Mon, 30 May 2022 08:23:15 +0000 (08:23 +0000)]
Avoids narrowing conversion by properly declaring 32-bit masks as uint instead of int.
Colin Clark [Sat, 30 Jul 2022 14:24:31 +0000 (15:24 +0100)]
Set mimimum requirement for lua to 5.3
Omari Stephens [Wed, 27 Jul 2022 17:49:47 +0000 (17:49 +0000)]
No longer attempts to run yelp-build from the docs build if it wasn't found previously.
Colin Clark [Thu, 28 Jul 2022 12:37:06 +0000 (13:37 +0100)]
Clean up generate new release scripts
Andreas Rönnquist [Wed, 27 Jul 2022 13:09:22 +0000 (15:09 +0200)]
Fix HAVE_FFMPEGTHUMBNAILER_METADATA to use mesondefine instead of standard define
Omari Stephens [Mon, 30 May 2022 06:58:32 +0000 (06:58 +0000)]
Stop relying on implicit conversion from TRUE to COLLECTION_LOAD_APPEND.
Colin Clark [Wed, 27 Jul 2022 11:33:48 +0000 (12:33 +0100)]
Meson build - use summary() function
- Use the summary() function instead of home-built solution
- Re-organize generation of ClayRGB1998_icc.h
Andreas Rönnquist [Mon, 25 Jul 2022 16:33:36 +0000 (18:33 +0200)]
Fix join command on meson 0.56
Colin Clark [Mon, 25 Jul 2022 16:19:38 +0000 (17:19 +0100)]
Fix #1004, 1005: Various meson problems
https://github.com/BestImageViewer/geeqie/issues/1004
https://github.com/BestImageViewer/geeqie/issues/1005
- Revise meson.build to run v 0.53
- Show user configuration summary from meson.build
- Remove ClayRGB1998_icch from repo.
- A few other minor bug fixes
Colin Clark [Thu, 21 Jul 2022 16:58:47 +0000 (17:58 +0100)]
GTK2 no longer supported
- GTK2 no longer supported
- LIRC deleted
- renderer-clutter() deleted
- all compiler warnings eliminated (except deprecated)
Colin Clark [Tue, 19 Jul 2022 08:27:13 +0000 (09:27 +0100)]
Bug fix: Meson - symlink missing
The symlink from GuideIndex.html to index.html was missing
Colin Clark [Mon, 18 Jul 2022 09:32:58 +0000 (10:32 +0100)]
Bug fix: Meson - doc/html missing
Empty sub-directories doc/html and doc/html/lua-api were not included.
Colin Clark [Sun, 17 Jul 2022 17:33:05 +0000 (18:33 +0100)]
Change configuration system from Autotools to Meson
Colin Clark [Sat, 16 Jul 2022 17:42:30 +0000 (18:42 +0100)]
Request sample image or file when reporting bugs
Colin Clark [Sat, 16 Jul 2022 10:29:50 +0000 (11:29 +0100)]
Fix #982: random crash (SIGSEGV) while running two instances of geeqie
https://github.com/BestImageViewer/geeqie/issues/982
User reports this fix works.
Yar [Thu, 14 Jul 2022 08:03:30 +0000 (10:03 +0200)]
Drop unconditional Xlib dependency
It was introduced
4eb2f5880956c8259d0b5e2084baf61a27ee82ad, to support XInitThreads, but XInitThreads was dropped later. Nothing else in this file needs this header, but it fails to compile on X11-less systems
Colin Clark [Thu, 30 Jun 2022 12:12:02 +0000 (13:12 +0100)]
Addl. fix #732: Allow to display keyboard shortcut within menu item
https://github.com/BestImageViewer/geeqie/issues/732
Also show shortcuts on plugin menu pop-ups
Colin Clark [Wed, 29 Jun 2022 09:05:03 +0000 (10:05 +0100)]
Fix #603, 971: lcms2 support broken / images with embedded color profile
https://github.com/BestImageViewer/geeqie/issues/603
https://github.com/BestImageViewer/geeqie/issues/971
The problem occurs when the screen scale factor is != 1
Colin Clark [Sat, 25 Jun 2022 14:23:14 +0000 (15:23 +0100)]
Bug fix: Minor coding error in bar gps - 2
Use text string instead of the name of a define.
Colin Clark [Sat, 25 Jun 2022 12:24:42 +0000 (13:24 +0100)]
Bug fix: Minor coding error in bar gps
The map_id format has changed.
Colin Clark [Fri, 24 Jun 2022 09:17:30 +0000 (10:17 +0100)]
Part fix #985: Fullscreen alwasys loads on the wrong screen in a dual-monitor setup
https://github.com/BestImageViewer/geeqie/issues/985
Removes the need for the user to set GDK_BACKEND.
User can still override the x11 setting by setting GDK_BACKEND to
something else.
Colin Clark [Thu, 23 Jun 2022 14:56:49 +0000 (15:56 +0100)]
Fix doc. error: doxygen - anonymous enum
Doxygen cannot document an anonymous enum, so use a Note instead.
Colin Clark [Thu, 23 Jun 2022 13:37:29 +0000 (14:37 +0100)]
Include duplicates data layout diagram
A duplicates data diagram in the doxygen-created documents
Colin Clark [Tue, 14 Jun 2022 15:23:20 +0000 (16:23 +0100)]
Update metadata handling documentation
Colin Clark [Tue, 14 Jun 2022 14:10:22 +0000 (15:10 +0100)]
Bug fix: --remote --config-load
Remove erroneous space character.
Tomasz Golinski [Tue, 31 May 2022 12:36:16 +0000 (14:36 +0200)]
Change filefilter.c: Modify order in which filefilter entries are populated
Move formats supported by dedicated custom loaders to the front. In this way their settings (writable, sidecar) get applied even if gdk-pixbuf also supports them. Note that cusom loaders have priority in image-load.c.
Tomasz Golinski [Tue, 31 May 2022 12:24:27 +0000 (14:24 +0200)]
Change filefilter.c: Merge Canon RAW file entries
Tomasz Golinski [Tue, 31 May 2022 12:23:34 +0000 (14:23 +0200)]
Change filefilter.c: WEBP files are writable just fine
Tomasz Golinski [Tue, 31 May 2022 12:23:19 +0000 (14:23 +0200)]
Change filefilter.c: HEIF and AVIF entries so that no duplicate occur in the case when gdk-pixbuf already supports the formats
Note that 'writable' flag is disabled as Exiv2 doesn't yet support writing BMFF tags. Caveat: gdk-pixbuf code doesn't take it into account.
Colin Clark [Tue, 31 May 2022 10:16:24 +0000 (11:16 +0100)]
Exif window search facility
A search of the Exif data can be initiated by clicking anywhere on the
column you wish to search, and then type Ctrl + F or press any
alpha-numeric key. The search is case-insensitive.
Colin Clark [Fri, 27 May 2022 09:59:29 +0000 (10:59 +0100)]
Fix #988: sort by file extension in preferences/files
https://github.com/BestImageViewer/geeqie/issues/988
- Sort on columns Enabled and Filter
- Improve UI when Add is pressed
Colin Clark [Thu, 26 May 2022 08:34:41 +0000 (09:34 +0100)]
Bug fix: geeqie-install-debian.sh
Fix errors which prevented installs.
Include libgspell as optional package.
Daniel Vogelbacher [Fri, 1 Apr 2022 17:14:58 +0000 (19:14 +0200)]
Add AVIF file extension to filefilter.c
AVIF is supported by geeqie via libheif, but files are filtered out because the extension is not registered yet.
Colin Clark [Sun, 8 May 2022 09:17:16 +0000 (10:17 +0100)]
File filter - include Clear icon
Include a Clear icon as the secondary icon in the File Filter box.
Colin Clark [Tue, 26 Apr 2022 16:14:43 +0000 (17:14 +0100)]
Fix #684: incompatible pointer types passing struct sockaddr_un
https://github.com/BestImageViewer/geeqie/issues/684
incompatible pointer types passing 'struct sockaddr_un *' to parameter
of type 'const struct sockaddr *'
Colin Clark [Sat, 23 Apr 2022 08:50:47 +0000 (09:50 +0100)]
Bug fix #934: Request to add image bookmarking/tagging within a folder
https://github.com/BestImageViewer/geeqie/issues/934
Check if image still exists.
Colin Clark [Fri, 22 Apr 2022 12:42:03 +0000 (13:42 +0100)]
Fix #934: Request to add image bookmarking/tagging within a folder
https://github.com/BestImageViewer/geeqie/issues/934
The last image viewed in a folder is stored in a list. If the folder is
re-opened, focus moves to the last image viewed.
An option on Preferences/Behavior sets the maximum size of the list.
Colin Clark [Sun, 17 Apr 2022 14:36:59 +0000 (15:36 +0100)]
Bug fix: Recent folder list max. size ignored
The Preferences/Behavior/Recent Folders Size parameter was being
over-ridden by a constant in history_list.c.
This parameter now affects other sections in
$HOME/.config/geeqie/history, but that should not be a problem.
Colin Clark [Sat, 16 Apr 2022 11:58:52 +0000 (12:58 +0100)]
Spelling checks for keywords auto-completion list
Include option to permit spelling checks on the keyword auto-completion
list in Preferences/Keywords.
Colin Clark [Sat, 16 Apr 2022 09:55:08 +0000 (10:55 +0100)]
Bug fix: Minor coding error in bar_rating.c
Colin Clark [Tue, 12 Apr 2022 15:25:06 +0000 (16:25 +0100)]
Change sidebar rating pane layout
Change the sidebar Star Rating pane to use radio buttons.
Colin Clark [Tue, 12 Apr 2022 10:49:11 +0000 (11:49 +0100)]
Bug fix: new release script
Colin Clark [Tue, 12 Apr 2022 09:50:53 +0000 (10:50 +0100)]
Release v1.7.3 files
Colin Clark [Sat, 9 Apr 2022 10:37:20 +0000 (11:37 +0100)]
Update installation script for metadata spelling
Include optional requirement for libgspell-1-dev
Colin Clark [Sat, 9 Apr 2022 10:23:36 +0000 (11:23 +0100)]
Hide bars - grave keystroke
Set scrolled window vertical policy to Never
Colin Clark [Sun, 3 Apr 2022 17:37:50 +0000 (18:37 +0100)]
Metadata spelling checks
Provide spelling checks for the Comment, Headline and Title metadata
panes.
Colin Clark [Sun, 27 Mar 2022 11:12:34 +0000 (12:12 +0100)]
Bug fix: Hide Bars - grave keystroke
The Hide Bars (keystroke grave) operation causes GTK Critical errors
from the show_menu_scrollbar_cb() function.
This function does not seem to do anything useful, so it is deleted.
Colin Clark [Sat, 26 Mar 2022 12:15:03 +0000 (12:15 +0000)]
Update new-release.sh
Check for -h option first.
Colin Clark [Tue, 22 Mar 2022 10:51:51 +0000 (10:51 +0000)]
Bug fix: Camera import plugin
Fix coding errors.