Colin Clark [Fri, 10 Mar 2023 12:52:39 +0000 (12:52 +0000)]
Fix error in README - meson configure
Colin Clark [Fri, 10 Mar 2023 11:48:38 +0000 (11:48 +0000)]
Update usage documentation in plugins template
Colin Clark [Wed, 8 Mar 2023 13:02:45 +0000 (13:02 +0000)]
Bug fix: Remote option --list-add parameter
If the parameter to --remote --list-add: is not a full path to an
existing file Geeqie will crash.
Colin Clark [Sun, 5 Mar 2023 11:34:13 +0000 (11:34 +0000)]
Additional doc. for X-Geeqie-Filter in Sort Manager
Andreas Rönnquist [Sat, 4 Mar 2023 14:31:19 +0000 (14:31 +0000)]
Bug Fix: Use GResource for icon files
String concatenation error.
Colin Clark [Fri, 3 Mar 2023 16:44:55 +0000 (16:44 +0000)]
Use GResource for icon files
Colin Clark [Mon, 20 Feb 2023 14:06:21 +0000 (14:06 +0000)]
Include DEBUG_BT() and DEBUG_FD() functions
- DEBUG_BT print backtrace of Geeqie calls
- DEBUG_FD print dump of FileData hash file
Colin Clark [Mon, 20 Feb 2023 09:45:25 +0000 (09:45 +0000)]
Fix #1061: meson fails to detect strverscmp
https://github.com/BestImageViewer/geeqie/issues/1061
Delete Sort By Number option. Use Natural Sort Order on
Edit/Preferences/File Filters instead.
Colin Clark [Thu, 26 Jan 2023 13:15:17 +0000 (13:15 +0000)]
Fix #1002: New build-dependency xxd
https://github.com/BestImageViewer/geeqie/issues/1002#
Colin Clark [Sat, 21 Jan 2023 16:38:37 +0000 (16:38 +0000)]
Fix #1002: New build-dependency xxd
https://github.com/BestImageViewer/geeqie/issues/1002
Include checks for xxd or xxdi.pl in meson.build. If neither exist,
disable color management.
Tomasz Goliński [Sat, 21 Jan 2023 16:32:38 +0000 (16:32 +0000)]
Fix #1002: New build-dependency xxd
xxdi.pl doesn't accept output file as a second parameter and needs a redirect >. Since vim xxd in case of no second parameter uses stdout by default, it is safe to add a redirect in any case.
Colin Clark [Tue, 3 Jan 2023 16:17:51 +0000 (16:17 +0000)]
Fix #990: Display full-resolution embedded jpg from CR3 files
https://github.com/BestImageViewer/geeqie/issues/990
- Use libraw in preference to exiv2, as it will extract the largest
preview image from a .cr3 file
- Revise export-jpeg plugin to also use exiftool when it detects a
larger number of preview images than exiv2, and additionally include
image auto-rotate
Colin Clark [Tue, 20 Dec 2022 13:15:18 +0000 (13:15 +0000)]
Script to compile linuxdeploy on arm
Colin Clark [Tue, 20 Dec 2022 12:56:20 +0000 (12:56 +0000)]
Bug fix: Ensure LUA API is displayed in Help files
The source file suffix is now .cc and not.c
Colin Clark [Tue, 20 Dec 2022 11:13:40 +0000 (11:13 +0000)]
Bug fix: Typo in Help file
Colin Clark [Fri, 16 Dec 2022 15:11:21 +0000 (15:11 +0000)]
Note that Geeqoe can be run on Windows 11
Colin Clark [Tue, 13 Dec 2022 19:03:46 +0000 (19:03 +0000)]
Preferred date format for documenttaion
Use ISO format (YYYY-MM-DD)
Colin Clark [Tue, 13 Dec 2022 11:09:39 +0000 (11:09 +0000)]
Reminder to update Wikipedia entry in CHECKLIST.md
Colin Clark [Thu, 8 Dec 2022 15:59:27 +0000 (15:59 +0000)]
FIXME: this can be rather slow and blocks until the size is known
Instead of using image_loader() use gdk_pixbuf_get_file_info() to get
image size - this function reads only a small part of the file.
Colin Clark [Mon, 5 Dec 2022 10:42:50 +0000 (10:42 +0000)]
AppImage version update notification
If Geeqie is being run as an AppImage and the version on the server is
newer than the one currently being run, a fade-out message is shown on
start-up.
This can be disabled via an option on Preferences/General.
An Internet connection is required.
The option is not displayed if not being run as an AppImage.
Colin Clark [Wed, 30 Nov 2022 13:19:46 +0000 (13:19 +0000)]
Fix #841: Copy image(s) to clipboard as file(s)
https://github.com/BestImageViewer/geeqie/issues/841
In Preferences/Behavior ensure that clipboard Selection is set to
"Clipboard" or "Both".
Colin Clark [Sat, 26 Nov 2022 11:36:35 +0000 (11:36 +0000)]
Change filetype from .c to .cc in untranslated-text.sh
Colin Clark [Sat, 26 Nov 2022 11:33:53 +0000 (11:33 +0000)]
Fix #1051: Add meson option to allow disabling doxygen detection
https://github.com/BestImageViewer/geeqie/pull/1051/commits/
eaea66dec93dea0e7b1d3638961f4f32658ca602
Also include options for evince, git, pandoc and yelp-build
Greg Troxel [Tue, 22 Nov 2022 13:57:16 +0000 (08:57 -0500)]
Disable SIGBUS handler
This handler leads to undefined behavior. Further, it calls mmap in a
way that POSIX says must fail with EBADF. This commit returns to
simply taking SIGBUS if it occurs and exiting. If that happens, then
an issue can be created and a way forward discusssed. See
https://github.com/BestImageViewer/geeqie/issues/1052 for more
context.
Colin Clark [Thu, 24 Nov 2022 15:42:03 +0000 (15:42 +0000)]
Bug fix: Segfault during DnD
There will be a segfault when making a DnD from the files pane to the
folders pane if the image has an extremely high aspect ratio - when
rescaled to icon size the pixbuf width or height may round to 0.
Colin Clark [Tue, 15 Nov 2022 10:10:12 +0000 (10:10 +0000)]
Fix #1049: Please don't hardcode lua version in lua package name
https://github.com/BestImageViewer/geeqie/pull/1049
Colin Clark [Sun, 13 Nov 2022 10:33:32 +0000 (10:33 +0000)]
Fix #981: Missing color profile support for AVIF/HEIF and possible others formats
https://github.com/BestImageViewer/geeqie/issues/981
Colin Clark [Tue, 25 Oct 2022 14:09:35 +0000 (15:09 +0100)]
Fix #1037: Fullscreen loads black
The problem occurs when zoom is set to Original Size.
An extra reload is required to force the image to be displayed.
This is probably not the correct solution.
Eli Schwartz [Thu, 20 Oct 2022 20:21:13 +0000 (16:21 -0400)]
meson: distribute changelog when running `meson dist`, and install it
Installing without a changelog is still supported, if building without
git *and* without an official dist tarball.
Fixes #1044
Eli Schwartz [Wed, 19 Oct 2022 22:08:18 +0000 (18:08 -0400)]
meson: only run doxygen when building from git
It uses git commands.
Eli Schwartz [Wed, 19 Oct 2022 22:08:15 +0000 (18:08 -0400)]
fix unpredictable behavior in doxygen generator script
We know that SRCDIR is the location of doxygen.conf, and that it is ../
from the doc directory. But we don't know that the current working
directory of the script is the doc directory -- the reference version of
Meson currently sets that, but other implementations of Meson such as
muon (c99) set it to the project root. Meson's own documentation says to
NOT rely on this as it is officially unspecified.
The solution is actually super simple though, because we already pass
the project root as a script argument, so just... use that. :D
Eli Schwartz [Wed, 19 Oct 2022 22:08:12 +0000 (18:08 -0400)]
meson: run pandoc as a build time rule
We don't need a proxy shell script at all, as it turns out. And Meson
can verify that the command succeeded, or update the built HTML if the
README itself changes.
Eli Schwartz [Wed, 19 Oct 2022 22:08:08 +0000 (18:08 -0400)]
meson: migrate ChangeLog generator to a proper build target
We still run the same script. But now it is run at build time, not
configure time, and Meson checks that it successfully ran -- it
really, really, really, should.
That is, assuming that git is installed and this is a git repo. If not,
we can simply refrain from running anything at all, instead of checking
the return code of gen_changelog.sh
Eli Schwartz [Wed, 19 Oct 2022 22:07:52 +0000 (18:07 -0400)]
meson: only calculate the version once
Once set in project() it will make that value accessible without
re-running a shell script, which speeds up configuration slightly due to
less forking.
Bernard Cafarelli [Tue, 18 Oct 2022 13:21:44 +0000 (15:21 +0200)]
Allow to use xxdi, lightweight alternative to vim's "xxd -i"
xxdi [0] is a lightweight script that can replace "xxd -i", which is now
needed to build geeqie. This is helpful on systems not running vim.
This checks for its availability on the system and falls back to
existing vim mode if not installed.
[0] https://github.com/gregkh/xxdi
Colin Clark [Sun, 16 Oct 2022 08:52:35 +0000 (09:52 +0100)]
Include arm64 AppImages
Colin Clark [Fri, 7 Oct 2022 12:58:41 +0000 (13:58 +0100)]
Bug fix: check-compiles.sh
- Did not change compilers correctly.
- Use --auto-features option
Colin Clark [Fri, 7 Oct 2022 09:57:24 +0000 (10:57 +0100)]
Remove unused functions
Most have been simply commented out, in case they may be of use in the
future
Colin Clark [Thu, 6 Oct 2022 14:19:44 +0000 (15:19 +0100)]
Remove redundant includes
The program deheader was used to create a list of redundant headers:
https://gitlab.com/esr/deheader
This change was necessary in the deheader python file:
command = maker
This script was run:
if [ $(echo $CFLAGS | grep -c "Werror-implicit-function-declaration" )
-ne 1 ]
then
export CFLAGS="$CFLAGS -Werror-implicit-function-declaration"
fi
rm -r build
meson setup build
ninja -C build
for file in "$@"
do
filename=${file##*/}
filestem=${filename%.*}
$HOME/bin/deheader/deheader -m 'ninja -C build' -i
"$filestem.h" "$file" # include -r for final run
touch "$file"
done
Colin Clark [Wed, 5 Oct 2022 13:11:17 +0000 (14:11 +0100)]
Include cppcheck configuration file
Omari Stephens [Sun, 4 Sep 2022 22:52:54 +0000 (22:52 +0000)]
Avoids C linkage in geeqie files now that we're trying to compile everything as C++
zonedetect.h and whereami.h are external libraries, so they're left as-is.
Omari Stephens [Fri, 26 Aug 2022 17:34:50 +0000 (17:34 +0000)]
Adds warning-as-error suppressions for C conventions that are deprecated in C++
Omari Stephens [Sun, 4 Sep 2022 21:18:21 +0000 (21:18 +0000)]
Changes language for Geeqie's source files from C to C++ by renaming 'src/**.c' files to 'src/**.cc'.
commit auto-generated with:
$for file in $(find src/ -type f -iname '*.c'); do ccfile=$(echo "$file" | sed -e 's#\.c$#.cc#'); git mv -- "$file" "$ccfile"; done
Omari Stephens [Sun, 4 Sep 2022 21:03:14 +0000 (21:03 +0000)]
Manual .c->.cc fixups
Omari Stephens [Sun, 4 Sep 2022 19:04:55 +0000 (19:04 +0000)]
Reflects .c->.cc file renames across Geeqie.
Commit auto-generated with:
$(for file in $(find src/ -iname '*.c' -type f); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'c_fi=ENV["file"]; c_re=Regexp.new("(?<!\\w)"+Regexp.escape(c_fi)+"(?=\\W)"); cc_file=c_fi.gsub(/\.c$/, ".cc"); $_.gsub!(c_re, cc_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
Omari Stephens [Wed, 5 Oct 2022 04:16:07 +0000 (04:16 +0000)]
Merge pull request #1038 from xsdg/hyphen-filenames.3
Renames source files from using a mixture of hyphens and underscores to using hyphens everywhere
Omari Stephens [Thu, 1 Sep 2022 07:26:43 +0000 (07:26 +0000)]
Replaces underscores with hyphens in code filenames under src.
Auto-generated with:
$git mv src/view_file/ src/view-file/
$for file in $(find src/ -type f -iname '*_*.[ch]'); do hyphen=$(echo "$file" | sed -e 's#_#-#g'); git mv -- "$file" "$hyphen"; done
Followed by a manual touchup in src/typedefs.h
Omari Stephens [Tue, 6 Sep 2022 03:42:59 +0000 (03:42 +0000)]
Updates references from using underscore filenames to hyphen filenames for files under src/
Commit automatically generated using these commands on a clean tree:
$(for file in $(find src/ -iname '*_*.[ch]' -type f); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'us_fi=ENV["file"]; us_re=Regexp.new("(?<!\\w)"+Regexp.escape(us_fi)+"(?=\\W)"); hyphen_file=us_fi.gsub(/_/, "-"); $_.gsub!(us_re, hyphen_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
$(for file in $(find src/ -iname '*_*' -type d); do export file=$(basename "$file"); echo "$file"; ruby -pi -e 'us_fi=ENV["file"]; us_re=Regexp.new("(?<!\\w)"+Regexp.escape(us_fi)+"(?=\\W)"); hyphen_file=us_fi.gsub(/_/, "-"); $_.gsub!(us_re, hyphen_file)' $(find * -type f | egrep -v 'ChangeLog|\.png|\.icc') ; echo; done)
Followed by a manual touchup in src/typedefs.h
JungHee Lee [Tue, 27 Sep 2022 07:27:18 +0000 (16:27 +0900)]
Update ko.po
All newly translated.
Colin Clark [Thu, 22 Sep 2022 15:00:47 +0000 (16:00 +0100)]
Update README for OM-1 support
Colin Clark [Wed, 21 Sep 2022 14:50:00 +0000 (15:50 +0100)]
Update doxygen.conf
Update doxygen.conf for preprocessing options
Colin Clark [Wed, 21 Sep 2022 11:18:05 +0000 (12:18 +0100)]
Collections - sidecars
Set defaults so that collections may have sidecars.
Colin Clark [Sun, 18 Sep 2022 13:51:29 +0000 (14:51 +0100)]
GTK4: gtk_menu_popup() deprecated
GTK4 migration
- replace gtk_menu_popup() by gtk_menu_popup_at_widget() or
gtk_menu_popup_at_pointer()
Colin Clark [Sun, 18 Sep 2022 12:18:47 +0000 (13:18 +0100)]
Bug fix: gtk_hbox and gtk_vbox deprecated
Pan view not displayed correctly
Andreas Rönnquist [Sun, 11 Sep 2022 15:12:07 +0000 (17:12 +0200)]
Fix appstream validation
Colin Clark [Sat, 10 Sep 2022 12:08:30 +0000 (13:08 +0100)]
GTK4: Event signals replaced
GTK4 migration
- event signals replaced by event controllers
- (gtk_event_controller_focus_new() not backported to GTK3)
Colin Clark [Sat, 10 Sep 2022 10:41:07 +0000 (11:41 +0100)]
GTK4: gtk_hbox and gtk_vbox deprecated
GTK4 migration
- gtk_hbox_new() and gtk_vbox_new() replaced by gtk_box() and
GTK_ORIENTATION_HORIZONTAL or GTK_ORIENTATION_VERTICAL
Colin Clark [Sat, 10 Sep 2022 09:02:23 +0000 (10:02 +0100)]
GTK4: gtk_arrow_new is deprecated
GTK4 migration
- replace gtk_arrow_new() with gtk_image_new_from_icon_name()
Colin Clark [Thu, 8 Sep 2022 14:58:42 +0000 (15:58 +0100)]
GTK4: uint32 is deprecated
GTK4 migration
Eliminate deprecations
- replace uint32 with guint32
Colin Clark [Thu, 8 Sep 2022 14:12:27 +0000 (15:12 +0100)]
Update doxygen.conf
- Update doxygen.conf via: doxygen -u doxygen.conf
- Rename file diagrams.c to diagrams.dox
Colin Clark [Thu, 8 Sep 2022 09:17:25 +0000 (10:17 +0100)]
GTK4: GdkDeviceManager removed from GTK4
GTK4 migration
- gdk_display_get_device_manager() replaced by
gdk_display_get_default_seat()
- gdk_device_manager_get_client_pointer() replaced by
gdk_seat_get_pointer()
Colin Clark [Wed, 7 Sep 2022 10:53:10 +0000 (11:53 +0100)]
Bug fix: Thumbnail not shown unless filename text shown
Colin Clark [Mon, 5 Sep 2022 18:41:45 +0000 (19:41 +0100)]
Fix #1031: French translations borked since commit
9e019ed7e
https://github.com/BestImageViewer/geeqie/issues/1031
- POTFILES was mistakenly deleted
- .gitignore ignored POTFILES
- gettext requires extra parameter to see all strings
Dmitry Marakasov [Wed, 31 Aug 2022 16:17:22 +0000 (19:17 +0300)]
Detect libtiff properly through pkgconfig
Dmitry Marakasov [Wed, 31 Aug 2022 16:20:16 +0000 (19:20 +0300)]
Fix index.html symlink
Create relative symlink, as absolute one will point to temporary build directory
Dmitry Marakasov [Wed, 31 Aug 2022 16:14:36 +0000 (19:14 +0300)]
Detect strverscmp support properly
Colin Clark [Mon, 29 Aug 2022 15:21:24 +0000 (16:21 +0100)]
Bug fix: meson executable dependencies
The order of the dependencies is significant for the requested GTK
version to be picked up
Colin Clark [Thu, 18 Aug 2022 14:12:57 +0000 (15:12 +0100)]
Fix #1023: Unresponsive UI when Show Marks is enabled
https://github.com/BestImageViewer/geeqie/issues/1023
- Remove and unref the css_provider each iteration
- Two other small speed improvements
Julian Hofer [Sat, 13 Aug 2022 18:56:58 +0000 (20:56 +0200)]
Fix appdata and icon installation
- Appdata used invalid tags
- Icon was not installed
Colin Clark [Fri, 12 Aug 2022 15:20:22 +0000 (16:20 +0100)]
Fix #999: Adding a widget to the info sidebar resizes the sidebar to something around 70% of window width
https://github.com/BestImageViewer/geeqie/issues/999
Colin Clark [Fri, 12 Aug 2022 09:34:00 +0000 (10:34 +0100)]
Exclude build directories from release tar
(cherry picked from commit
71210120367eeb6ba5e5079c13952aa77bb91a40)
Colin Clark [Fri, 12 Aug 2022 09:36:53 +0000 (10:36 +0100)]
Release v2.0.1 files
Colin Clark [Thu, 11 Aug 2022 17:42:44 +0000 (18:42 +0100)]
Exclude build directory from doxygen output
Omari Stephens [Mon, 8 Aug 2022 01:43:58 +0000 (01:43 +0000)]
Fixes some whitespace issues
Omari Stephens [Mon, 8 Aug 2022 00:50:56 +0000 (00:50 +0000)]
Fixes compile warnings in files touched by the "C++ keywords" change
Note that the -Wpedantic function pointer warnings aren't fixable, given the GLIB/GTK API design:
https://stackoverflow.com/a/
14134283
Omari Stephens [Mon, 30 May 2022 06:39:12 +0000 (06:39 +0000)]
Renames variables to avoid conflicting with C++ keywords.
Colin Clark [Mon, 8 Aug 2022 14:22:47 +0000 (15:22 +0100)]
Release v2.0 files
Colin Clark [Mon, 8 Aug 2022 12:04:00 +0000 (13:04 +0100)]
Fix gettext use with Meson
- Also update translations
Omari Stephens [Mon, 1 Aug 2022 09:01:29 +0000 (09:01 +0000)]
*sigh* fixes multiple compile errors and warnings
Omari Stephens [Sun, 31 Jul 2022 21:35:32 +0000 (21:35 +0000)]
Whoops; make sure we check the return value of read_bool_option.
Omari Stephens [Sun, 31 Jul 2022 21:22:31 +0000 (21:22 +0000)]
Fixes a possible uninitialized value usage by modifying how we parse <filter_type> configuration elements
Omari Stephens [Mon, 30 May 2022 08:15:58 +0000 (08:15 +0000)]
Creates a more-explicitly-type-unsafe value reader for enums.
This code relies on our ability to read a guint into an enum address. C++ forbids this being done implicitly, so we do it explicitly.
Colin Clark [Sat, 6 Aug 2022 15:56:59 +0000 (16:56 +0100)]
Fix #1017: Use source root and not build root to install Changelogs and readme from
https://github.com/BestImageViewer/geeqie/pull/1017
Check for non-availability of git.
Carles Pina i Estany [Mon, 1 Aug 2022 19:02:23 +0000 (20:02 +0100)]
Update authors and emails of Catalan translators
Carles Pina i Estany [Mon, 1 Aug 2022 19:02:04 +0000 (20:02 +0100)]
Catalan translation: align text in the output of geeqie --help
Carles Pina i Estany [Mon, 1 Aug 2022 18:52:03 +0000 (19:52 +0100)]
Fix "geeqie --help" remote commands section translation
The strings were marked to be translated in the:
"static RemoteCommandEntry remote_commands" as N_("some string")
Now it translates the strings at printing time.
Carles Pina i Estany [Sun, 31 Jul 2022 20:46:13 +0000 (21:46 +0100)]
Use Catalan "str" («str»)
Carles Pina i Estany [Sun, 31 Jul 2022 20:42:52 +0000 (21:42 +0100)]
Translate fuzzy and untranslated messages
Carles Pina i Estany [Sun, 31 Jul 2022 19:43:17 +0000 (20:43 +0100)]
Add comment on the style used by the Catalan translation
Carles Pina i Estany [Sun, 31 Jul 2022 19:38:48 +0000 (20:38 +0100)]
Consolidate all the "Delete" to "Suprimir"
There was a mixture of other translations
Omari Stephens [Sun, 31 Jul 2022 17:23:17 +0000 (17:23 +0000)]
Fixes `-Wsign-compare` errors when comparing int versus sizeof
Omari Stephens [Mon, 30 May 2022 09:11:15 +0000 (09:11 +0000)]
Fixes jumps across variable declarations in same scope
Those jumps are not legal in C++. zonedetect.h is an imported library, so this is a minimal change that allows compilation as C++.
Omari Stephens [Sun, 31 Jul 2022 16:54:08 +0000 (16:54 +0000)]
Fixes one last int->uint
Omari Stephens [Wed, 27 Jul 2022 18:34:42 +0000 (18:34 +0000)]
Replaces inappropriate usage of (int) with (uint) throughout image_load_dds, which only ever deals with at-most-32-bit unsigned values.
Also adds return value checking for g_try_malloc() to avoid NULL dereference on failure.
Omari Stephens [Mon, 30 May 2022 08:23:15 +0000 (08:23 +0000)]
Avoids narrowing conversion by properly declaring 32-bit masks as uint instead of int.
Colin Clark [Sat, 30 Jul 2022 14:24:31 +0000 (15:24 +0100)]
Set mimimum requirement for lua to 5.3
Omari Stephens [Wed, 27 Jul 2022 17:49:47 +0000 (17:49 +0000)]
No longer attempts to run yelp-build from the docs build if it wasn't found previously.
Colin Clark [Thu, 28 Jul 2022 12:37:06 +0000 (13:37 +0100)]
Clean up generate new release scripts
Andreas Rönnquist [Wed, 27 Jul 2022 13:09:22 +0000 (15:09 +0200)]
Fix HAVE_FFMPEGTHUMBNAILER_METADATA to use mesondefine instead of standard define
Omari Stephens [Mon, 30 May 2022 06:58:32 +0000 (06:58 +0000)]
Stop relying on implicit conversion from TRUE to COLLECTION_LOAD_APPEND.