Matthew Miller [Fri, 9 Apr 2021 00:21:39 +0000 (20:21 -0400)]
Fix doc building with newer yelp
This adds `-i`, because otherwise it will complain about missing files (which
we copy into place later), and adds a trailing slash to the output directory,
because `yelp-build` now puts the files into the wrong place otherwise.
Colin Clark [Sun, 4 Apr 2021 12:12:11 +0000 (13:12 +0100)]
Bug fix #880: Optimize file loading when looking for duplicates
Reversed logic, resulting in items being processed twice
Colin Clark [Fri, 2 Apr 2021 09:44:17 +0000 (10:44 +0100)]
Log window - search text
Include facility to search text in the log window
Colin Clark [Thu, 1 Apr 2021 10:00:53 +0000 (11:00 +0100)]
Ouput exit status from doxygen-help
Exit status 0 if a match found in the .tag file, otherwise exit status
1.
Frej Drejhammar [Sun, 28 Mar 2021 11:05:15 +0000 (12:05 +0100)]
Fix #880: Optimize file loading when looking for duplicates
https://github.com/BestImageViewer/geeqie/pull/880
Frej Drejhammar [Fri, 12 Mar 2021 20:02:16 +0000 (21:02 +0100)]
dupe: Eliminate O(n^2) code in dupe_files_add_queue_cb()
Geeqie is, compared to its ancestor Gqview, embarrassingly slow while
loading a set of files to look for duplicates (most noticeable when
looking for duplicate names). Profiling shows that a lot of time is
spent in dupe_files_add_queue_cb(). The culprit turns out to be two
loops, which for each newly loaded file, traverses the list of already
loaded images. As this gives a time complexity of O(n^2) where n is
the number of images, loading times become very large when the number
of files increases.
This patch adds a GHashTable-based cache which is created when a
loading operation starts and destroyed when it completes. The cache is
initialized with the loaded images on creation (an O(n)
operation). Using the cache, checking for duplicates in the lists can
be done in constant time, thus making the loading time linear in the
number of images loaded. With this change Geeqie now matches the
performance of Gqview.
As a side effect, this patch also fixes a memory leak when an attempt
is made to re-add an already added file, as the unmodified version
never freed the DupeItem allocated for the twice added file.
Frej Drejhammar [Sat, 13 Feb 2021 15:55:05 +0000 (16:55 +0100)]
dupe: Optimize memory handling in dupe_files_add_queue_cb()
Do not traverse the lists returned by filelist_filter() while
allocating new list links with g_list_prepend(). Instead prepend the
lists to dw->add_files_queue using g_list_concat(). Although
g_list_concat() has to traverse the lists containing the new items to
find their ends, it avoids redundant memory allocation and
deallocation.
Frej Drejhammar [Sat, 13 Feb 2021 15:54:24 +0000 (16:54 +0100)]
dupe: Avoid O(n) operations in dupe_files_add_queue_cb()
Replace tests that use g_list_length(), which traverses the list with
simple constant-time NULL checks. That an empty list is NULL is
documented in the GList documentation.
Colin Clark [Wed, 24 Mar 2021 12:49:48 +0000 (12:49 +0000)]
Doxygen helper script
The script may be used to integrate the Doxygen html files into a code
editor.
Set a code editor hot key to pass a variable or function name to the
script. The relevant Doxygen file will be displayed in a browser window.
Colin Clark [Wed, 17 Mar 2021 09:34:09 +0000 (09:34 +0000)]
Fix #845: Control image rotation in pan view
https://github.com/BestImageViewer/geeqie/issues/845
If Pan View "Show Image" is selected and status bar "Exif Rotate" is
set, rotate the displayed image.
Marcel Pol [Thu, 11 Mar 2021 10:09:25 +0000 (10:09 +0000)]
Fix #878: Use binary units for sizes, not decimal values
https://github.com/BestImageViewer/geeqie/pull/878
Marcel Pol [Wed, 10 Mar 2021 12:47:33 +0000 (13:47 +0100)]
Use binary units for sizes, not decimal values.
KiB = 1024 bytes
MiB = 1024 * 1024 bytes
GiB = 1024 * 1024 * 1024 bytes
Please be aware, I am no C programmer. I also saw some use of Mb and mb,
which might indicate Megabit.
Please double check if my assumptions are correct.
Reference:
https://en.wikipedia.org/wiki/Byte#Multiple-byte_units
If the desire is to use decimal units like KB, MB and GB,
the code would need to be changed to use 1000 for kilo.
That is way over my head and not a good task for me.
Adrian Siemieniak [Tue, 9 Mar 2021 10:55:26 +0000 (10:55 +0000)]
Fix #877: Add image/webp mime type
https://github.com/BestImageViewer/geeqie/pull/877
Adrian Siemieniak [Tue, 9 Mar 2021 10:37:08 +0000 (11:37 +0100)]
Add image/webp mime type
Colin Clark [Mon, 8 Mar 2021 12:38:42 +0000 (12:38 +0000)]
Fix #786: Image in fixed size window smaller than X11 desktop sometimes gets wrong zoom, reproducible.
https://github.com/BestImageViewer/geeqie/issues/786
Undo Temporary Fix #133: switching between images causes window to keep
shrinking
Colin Clark [Sat, 6 Mar 2021 16:35:30 +0000 (16:35 +0000)]
Fix #863: Geeqie handles non-existing files in a user-unfriendly way
https://github.com/BestImageViewer/geeqie/issues/863
Any command line error results in a modal dialogue followed by exit.
Colin Clark [Sat, 6 Mar 2021 13:23:46 +0000 (13:23 +0000)]
Fix #644: Images fail to render on MacOS
https://github.com/BestImageViewer/geeqie/issues/644
Change the way the "draw" signal is handled.
Overlay guidelines are disabled.
Marcel Pol [Fri, 5 Mar 2021 16:03:25 +0000 (16:03 +0000)]
Fix #876:Update Dutch translation (nl_nl)
https://github.com/BestImageViewer/geeqie/pull/876
Marcel Pol [Fri, 5 Mar 2021 13:43:20 +0000 (14:43 +0100)]
Update Dutch translation (nl_nl)
Marcel Pol [Thu, 4 Mar 2021 09:58:28 +0000 (09:58 +0000)]
Fix #875: Fix spelling mistake
https://github.com/BestImageViewer/geeqie/pull/875
Marcel Pol [Wed, 3 Mar 2021 18:07:45 +0000 (19:07 +0100)]
Fix spelling mistake
emdedded -> embedded
Colin Clark [Sat, 27 Feb 2021 09:12:40 +0000 (09:12 +0000)]
Fix #860, #871: --remote and --slideshow on startup
https://github.com/BestImageViewer/geeqie/issues/860
https://github.com/BestImageViewer/geeqie/issues/871
Remote slideshow delay is ignored
--remote --File=IMAGE fails: not displaying image, not using running
instance, not forking
equal-l2 [Mon, 8 Feb 2021 10:39:59 +0000 (10:39 +0000)]
Fix #866: Fix build on macOS
https://github.com/BestImageViewer/geeqie/pull/866
Use POSIX options for tail and tr
Cast properly
equal-l2 [Mon, 8 Feb 2021 00:29:39 +0000 (09:29 +0900)]
Cast `struct sockaddr_un*` properly
Because of `-Werror`, the difference in pointer types makes the whole
build fail.
equal-l2 [Mon, 8 Feb 2021 00:27:11 +0000 (09:27 +0900)]
Use POSIX options for tail and tr
Long options like `--delete` and `--lines` are GNU extension, which
cause trouble on non-GNU toolchains.
Colin Clark [Wed, 3 Feb 2021 15:23:53 +0000 (15:23 +0000)]
Bug fix: Include tilde expansion in slideshow recurse
Tilde expansion was missing in call to --remote
--slideshow-recurse:<folder>
Colin Clark [Sat, 30 Jan 2021 14:39:01 +0000 (14:39 +0000)]
Find duplicates speed-up for simple comparisons
Speed increase for simple comparisons (i.e. all those except similarity
checks)
This is achieved by using quicksorts and binary searches.
Colin Clark [Fri, 29 Jan 2021 10:26:50 +0000 (10:26 +0000)]
Include GTK version in output
Include GTK major version in --version output
Colin Clark [Fri, 29 Jan 2021 10:21:30 +0000 (10:21 +0000)]
Fix #857: Mouse locked in column adjusting mode in Exif window
https://github.com/BestImageViewer/geeqie/issues/857
The problem occurs only when compiled with GTK2. The reason is unknown.
Because the problem can cause Xorg to crash, it is best just to inhibit
the column adjust function in GTK2.
Carles Pina Estany [Sun, 24 Jan 2021 15:45:02 +0000 (15:45 +0000)]
Fix #856: Catalan translation updated
https://github.com/BestImageViewer/geeqie/pull/856
freddii [Sun, 24 Jan 2021 15:35:47 +0000 (15:35 +0000)]
Fix #854: updated german translation
https://github.com/BestImageViewer/geeqie/pull/854/
Carles Pina i Estany [Sun, 17 Jan 2021 21:33:51 +0000 (21:33 +0000)]
Updated Catalan translation
freddii [Fri, 22 Jan 2021 14:50:54 +0000 (15:50 +0100)]
updated german translation
freddii [Fri, 22 Jan 2021 14:34:32 +0000 (15:34 +0100)]
updated german translation
Colin Clark [Fri, 15 Jan 2021 12:43:54 +0000 (12:43 +0000)]
Fix #822: The image rotation keys ([ and ]) affect the wrong image
https://github.com/BestImageViewer/geeqie/issues/822
If a call is of the format:
geeqie /<folder1>/*jpg
Geeqie opens folder1 with the listed files selected.
If a call is of the format:
geeqie /<folder1>/*jpg /<folder2>/*jpg
Geeqie opens folder1 and the listed files are displayed in an unnamed
collection.
The hidden command line collection feature of previous versions is
deleted.
freddii [Thu, 14 Jan 2021 11:38:32 +0000 (11:38 +0000)]
Fix #852: fixed wrong spelled words
https://github.com/BestImageViewer/geeqie/pull/852
freddii [Thu, 14 Jan 2021 11:00:00 +0000 (12:00 +0100)]
fixed wrong spelled words
freddii [Thu, 14 Jan 2021 10:17:32 +0000 (10:17 +0000)]
Fix #851: fixed spelling mistakes
https://github.com/BestImageViewer/geeqie/pull/851
freddii [Thu, 14 Jan 2021 08:20:26 +0000 (09:20 +0100)]
fixed spelling mistakes
Colin Clark [Sat, 9 Jan 2021 11:35:41 +0000 (11:35 +0000)]
Fix #829: segfault with clutter-gtk
https://github.com/BestImageViewer/geeqie/issues/829
This fix might cause other problems which might be cured by calling:
LIBGL_ALWAYS_INDIRECT=1 geeqie
or, worst case:
geeqie --disable-clutter
Hrvoje Nikšić [Tue, 29 Dec 2020 10:56:27 +0000 (10:56 +0000)]
Fix #840: Copy image to clipboard menu action
https://github.com/BestImageViewer/geeqie/pull/840
Hrvoje Niksic [Mon, 28 Dec 2020 22:37:58 +0000 (23:37 +0100)]
New pop-up menu action "Copy image to clipboard"
Colin Clark [Sun, 20 Dec 2020 15:39:10 +0000 (15:39 +0000)]
No post-processing for animated gifs (2)
Check for no layout window.
Colin Clark [Sun, 20 Dec 2020 15:04:17 +0000 (15:04 +0000)]
No post-processing for animated gifs
Post-processing takes so much time animated gifs lose frames.
Inhibit post-processing for animated gifs.
Andreas Rönnquist [Thu, 17 Dec 2020 16:11:38 +0000 (16:11 +0000)]
Fix #836: Fix building on GTK2 again, adding #ifdefs for gtk_label_set_[x,y]align
https://github.com/BestImageViewer/geeqie/pull/836
Andreas Rönnquist [Wed, 16 Dec 2020 14:32:03 +0000 (15:32 +0100)]
Fix building on GTK2 again, adding #ifdefs for gtk_label_set_[x,y]align
gtk_label_set_[x,y]align is only available on gtk3, so to still
build on gtk2 we need the old functions used back.
Andreas Rönnquist [Tue, 15 Dec 2020 11:43:50 +0000 (11:43 +0000)]
Fix #834: Use gtk_label_set_[x,y]align instead of gtk_misc_set_alignment
https://github.com/BestImageViewer/geeqie/pull/834
Andreas Rönnquist [Mon, 14 Dec 2020 17:19:17 +0000 (18:19 +0100)]
Use gtk_label_set_[x,y]align instead of gtk_misc_set_alignment
Colin Clark [Sun, 13 Dec 2020 10:54:33 +0000 (10:54 +0000)]
Fix #832: Geeqie remembers desktop
https://github.com/BestImageViewer/geeqie/issues/832
An additional option to remember window workspaces in
Edit/Preferences/Windows.
The default is "off".
Colin Clark [Thu, 10 Dec 2020 16:43:33 +0000 (16:43 +0000)]
Ref #539: Run time check on GDK display backend (2)
https://github.com/BestImageViewer/geeqie/issues/829
Include a run time check to determine which backend is being used.
There was a seg. fault when Wayland was being used.
Colin Clark [Thu, 10 Dec 2020 16:08:01 +0000 (16:08 +0000)]
Ref #539: Run time check on GDK display backend
https://github.com/BestImageViewer/geeqie/issues/539
Include a run time check to determine which backend is being used.
There was a seg. fault when Wayland was being used.
Klaus Ethgen [Wed, 2 Dec 2020 21:02:18 +0000 (22:02 +0100)]
That doesn't wort currently, so removing it again
Klaus Ethgen [Wed, 2 Dec 2020 20:52:53 +0000 (21:52 +0100)]
Own compile
Klaus Ethgen [Wed, 2 Dec 2020 20:01:27 +0000 (21:01 +0100)]
Try to setup security scan
Colin Clark [Sat, 28 Nov 2020 11:18:13 +0000 (11:18 +0000)]
Ref #137: Copy to both clipboards
https://github.com/BestImageViewer/geeqie/issues/137
A third option to copy to both clipboards. Default is to copy to both.
Colin Clark [Sun, 15 Nov 2020 14:25:39 +0000 (14:25 +0000)]
Fix #825: Add keymap_template.h to geeqie_SOURCES
https://github.com/BestImageViewer/geeqie/pull/825
Andreas Rönnquist [Sun, 15 Nov 2020 12:47:58 +0000 (13:47 +0100)]
Add keymap_template.h to geeqie_SOURCES too
Colin Clark [Thu, 12 Nov 2020 12:37:47 +0000 (12:37 +0000)]
Ref #781: Display version numbers
https://github.com/BestImageViewer/geeqie/issues/781
If the tag is at HEAD show the version number only, otherwise show
version-date-commit
Colin Clark [Sun, 8 Nov 2020 13:45:16 +0000 (13:45 +0000)]
Ref #820: Problem with window in the current build
https://github.com/BestImageViewer/geeqie/issues/820
Place automatic scrollbar under menus
Colin Clark [Sat, 7 Nov 2020 14:40:47 +0000 (14:40 +0000)]
Ref #820: Problem with window in the current build
https://github.com/BestImageViewer/geeqie/issues/820
Remove the requirement for a "main" window.
Colin Clark [Sat, 7 Nov 2020 10:18:17 +0000 (10:18 +0000)]
Bug fix: --disable-clutter can cause crash
If --disable-clutter has been issued, trying to load the map will cause
a crash.
Colin Clark [Wed, 4 Nov 2020 15:38:49 +0000 (15:38 +0000)]
Geeqie as a flatpak
Include a reference to the flatpak version of Geeqie in the README and
web page.
Colin Clark [Mon, 2 Nov 2020 17:06:09 +0000 (17:06 +0000)]
Ref #820: Problem with window in the current build
https://github.com/BestImageViewer/geeqie/issues/820
Allow the desktop workspace layout to be saved in the configuration
files.
This is X11 and GTK3 only.
Colin Clark [Thu, 29 Oct 2020 15:31:09 +0000 (15:31 +0000)]
Ref #820: Problem with window in the current build
https://github.com/BestImageViewer/geeqie/issues/820
This fixes a problem with the command line geometry parameters being
ignored.
Colin Clark [Thu, 29 Oct 2020 10:25:42 +0000 (10:25 +0000)]
Fix #821: Un-full-screen doesn't work. Regression
https://github.com/BestImageViewer/geeqie/issues/821
Implement a user-definable option for "Hide window in fullscreen",
instead of a define.
Andreas Rönnquist [Wed, 14 Oct 2020 14:23:55 +0000 (15:23 +0100)]
Fix #816: Fix building with --enable-debug-flags
https://github.com/BestImageViewer/geeqie/pull/816
Colin Clark [Sun, 11 Oct 2020 13:14:43 +0000 (14:14 +0100)]
Ref #761: Severe stall/hang at start-up
https://github.com/BestImageViewer/geeqie/issues/761
Read star rating in the idle loop.
Colin Clark [Fri, 9 Oct 2020 15:50:32 +0000 (16:50 +0100)]
Fix #819: Turning off mouseover info
https://github.com/BestImageViewer/geeqie/issues/819
Showing file data as a tooltip in list view seems redundant, as that
data is visible anyway.
So the tooltip is removed.
Andreas Rönnquist [Sat, 3 Oct 2020 15:03:35 +0000 (17:03 +0200)]
Fix building with --enable-debug-flags
This adds wrappers for callback functions which now takes two inputs
to fix building with incompatible function types warnings. See
https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/63
for a similar issue in Xfce-power-manager.
It also adds a header keymap_template.h and makes the char *
keymap_template non-static, and removes some un-used functions
and variables.
Colin Clark [Thu, 1 Oct 2020 11:47:04 +0000 (12:47 +0100)]
Fix #814: Geeqie slow at startup, even when looking at just a single image
https://github.com/BestImageViewer/geeqie/issues/814
Wrong filedata function call.
Colin Clark [Sat, 26 Sep 2020 12:11:11 +0000 (13:11 +0100)]
GDK_INTERP_HYPER is deprecated
GDK_INTERP_HYPER is deprecated as GDK_INTERP_BILINEAR has a better
quality
Jose Riha [Mon, 21 Sep 2020 10:02:50 +0000 (11:02 +0100)]
Fix #809: Extra underscore in toolbar.c
https://github.com/BestImageViewer/geeqie/issues/809
Jose Riha [Mon, 21 Sep 2020 09:56:57 +0000 (10:56 +0100)]
Fix #810: Fix mistakes in Czech translation
https://github.com/BestImageViewer/geeqie/pull/810
Jose Riha [Mon, 21 Sep 2020 09:47:27 +0000 (10:47 +0100)]
Fix #808: Update Slovak translation
Jose Riha [Sun, 20 Sep 2020 05:14:23 +0000 (07:14 +0200)]
Fix mistakes in Czech translation
Jose Riha [Sat, 19 Sep 2020 21:17:03 +0000 (23:17 +0200)]
Update Slovak translation
Jose Riha [Fri, 11 Sep 2020 11:22:37 +0000 (12:22 +0100)]
Fix #806: Slightly improve plugin template
https://github.com/BestImageViewer/geeqie/pull/806
Jose Riha [Fri, 11 Sep 2020 09:29:00 +0000 (11:29 +0200)]
Slightly improve plugin template
Colin Clark [Sat, 5 Sep 2020 15:10:28 +0000 (16:10 +0100)]
Update gitignore for appdata file
Include org.geeqie.Geeqie.appdata.xml in .gitignore
Colin Clark [Sat, 5 Sep 2020 12:58:49 +0000 (13:58 +0100)]
Plugins sort order
Use caseless and natural sort order when displaying the plugins menu.
Colin Clark [Fri, 4 Sep 2020 11:45:21 +0000 (12:45 +0100)]
Ref #761: Severe stall/hang at start-up
https://github.com/BestImageViewer/geeqie/issues/761
When file marks have been saved, on next start the entire folder of each
marked file is reffed, causing a slow startup.
Wrong filedata function used.
Colin Clark [Mon, 24 Aug 2020 14:43:07 +0000 (15:43 +0100)]
Find duplicates - blocking when loading file list
Geeqie blocks when loading a list of files for find duplicates.
Using recurse can result in thousands of files being loaded, which
creates a problem.
This patch loads the file list in the idle loop.
Colin Clark [Mon, 17 Aug 2020 14:33:33 +0000 (15:33 +0100)]
Part fix #796: Restored windows all show the same location
https://github.com/BestImageViewer/geeqie/issues/796
If multiple windows are defined in the config. file, command line
options are used only in the main window.
Andreas Rönnquist [Sat, 8 Aug 2020 15:26:38 +0000 (16:26 +0100)]
Fix #794: make dist errors out due to a tar filename limit of 99 characters
https://github.com/BestImageViewer/geeqie/issues/794
Colin Clark [Sat, 8 Aug 2020 13:23:18 +0000 (14:23 +0100)]
Fix #781: Running 'make check' in po folder errors out
https://github.com/BestImageViewer/geeqie/issues/781
Spurious newline removed, and version now also includes last release tag
and date.
Colin Clark [Wed, 5 Aug 2020 13:17:22 +0000 (14:17 +0100)]
Addl fix #599: Geeqie won't start if clutter fails to init
https://github.com/BestImageViewer/geeqie/issues/559
Missing source file.
Colin Clark [Wed, 5 Aug 2020 11:13:42 +0000 (12:13 +0100)]
Fix #559: Geeqie won't start if clutter fails to init
https://github.com/BestImageViewer/geeqie/issues/559
New command line option:
geeqie --disable-clutter
Colin Clark [Mon, 27 Jul 2020 14:10:55 +0000 (15:10 +0100)]
Update help and man files
Colin Clark [Mon, 27 Jul 2020 10:02:05 +0000 (11:02 +0100)]
Include Find icon in SaR entry field
Colin Clark [Fri, 24 Jul 2020 09:03:17 +0000 (10:03 +0100)]
Fix #782: dangerous duplicate finder deletes original, leaves dangling symlink
https://github.com/BestImageViewer/geeqie/issues/782
Ignore symlinks to files
Colin Clark [Thu, 23 Jul 2020 12:57:22 +0000 (13:57 +0100)]
Fix clang compile errors
Fix errors revealed by -Wlogical-op-parentheses
Colin Clark [Wed, 8 Jul 2020 15:54:03 +0000 (16:54 +0100)]
Update dupes documentation
Colin Clark [Wed, 8 Jul 2020 10:51:53 +0000 (11:51 +0100)]
Addl fix #397: GPU acceleration
https://github.com/BestImageViewer/geeqie/issues/397
Pan view does not display correctly when renderer-clutter is used.
This patch forces renderer-tiles to be used from pan-view.
This is a work-around - a correct solution is still required.
Colin Clark [Tue, 7 Jul 2020 11:04:27 +0000 (12:04 +0100)]
Fix minor coding errors
Colin Clark [Tue, 7 Jul 2020 10:46:52 +0000 (11:46 +0100)]
Addl fix #397: GPU acceleration
https://github.com/BestImageViewer/geeqie/issues/397
If two windows are open, switching between the two windows may cause a
crash with the message:
The error was 'GLXBadDrawable'
The bug happens with Nouveau drivers and Radeon drivers, but not with
Nvidia drivers.
This patch disables Clutter if the system is liable to this bug. The
user is given the possibility to override this with an option in
Preferences/Behavior.
gusr [Tue, 23 Jun 2020 09:32:15 +0000 (10:32 +0100)]
Fix #779: Add search by path
https://github.com/BestImageViewer/geeqie/pull/779
Colin Clark [Sat, 20 Jun 2020 09:53:15 +0000 (10:53 +0100)]
Fix coding errors detected by clang
Colin Clark [Sat, 20 Jun 2020 08:26:22 +0000 (09:26 +0100)]
Fix #775: GTK3 and the readme.md
https://github.com/BestImageViewer/geeqie/issues/775
Change status of both GTK2 and GTK3 versions to "stable".
Colin Clark [Fri, 19 Jun 2020 13:47:34 +0000 (14:47 +0100)]
Part fix #396: GTK3 collections
https://github.com/BestImageViewer/geeqie/issues/396
The helper icon marker.xpm was not shown when making drag-and-drop on a
collection window.
The patch includes a FIXME, but works well enough.
Colin Clark [Thu, 18 Jun 2020 09:06:07 +0000 (10:06 +0100)]
Fix #770: What's this repo is about
https://github.com/BestImageViewer/geeqie/issues/770
Warning paragraph included at top of README